GitLab

Child frames have some degree of continuity across navigations: the
contents are still embedded in the same document. Let them continue to
propagate user gesture state across navigations. However, main frames
don't have that continuity and should reset their user gesture state
on navigation.

TEST=DocumentUserGestureTokenTest.Navigate
BUG=chromedriver:922

Review-Url: https://codereview.chromium.org/2721423003
Cr-Commit-Position: refs/heads/master@{#456134}

TEST=manual; verify Docs, Sheets, and Slides work with regard to whitespace, key echo, etc when braille mode is off.
BUG=690635,690636,618099
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2740793002
Cr-Commit-Position: refs/heads/master@{#456133}

This CL changes the name of a CSS variable. The checkbox spacing was/is
being used for spacing between a control label and something graphical
such as the checkbox or a policy indicator. The intent is to convey
that it's used for more than checkbox spacing.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2744763003
Cr-Commit-Position: refs/heads/master@{#456132}

Just like with touch event handlers, at present a sub-frame's
compositor does not receive regions rects for non-fast scrollable
regions that accompany MouseWheel handlers. Until ScrollingCoordinator
is made per-frame, we should mark the entire root layer rect as
non-fast scrollable in the presence of blocking wheel handlers.

The primary changes are all in render_widget_compositor.cc; other
files are touched only to give the function a more inclusive name.

BUG=698195

Review-Url: https://codereview.chromium.org/2740133002
Cr-Commit-Position: refs/heads/master@{#456131}

Implement compositor bypass for WebVR via mailbox copy:

- Create a GPU command buffer GL context in the VrShellGl thread that's
  backed by a native Surface. This is encapsulated inside the new
  MailboxToSurfaceBridge class.

- WebKit's VRDisplay sends a MailboxHolder for each frame (as drawn
  via WebGL on the GPU process) as argument to the SubmitFrame mojo
  call.

- MailboxToSurfaceLayerBridge uses its GPU command buffer GL context
  to draw the mailbox content to a Surface.

- VrShellGl picks up the frame from the corresponding SurfaceTexture
  and  proceeds with rendering as usual with its native GL context
  as needed for the low-level GVR API.

Also implements on-the-fly canvas resizing, the transfer surface and
GVR renderbuffer are resized as needed to match the source canvas.

Added frame number as an argument to various TRACE_EVENTs for timing
analysis.

It includes two separate modes for frame scheduling, the more
aggressive one is conditional on
chrome:://flags#enable-webvr-experimental-rendering since the
framerate seems a bit less stable.

BUG=698643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2729523002
Cr-Original-Commit-Position: refs/heads/master@{#455592}
Committed: https://chromium.googlesource.com/chromium/src/+/6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74
Review-Url: https://codereview.chromium.org/2729523002
Cr-Commit-Position: refs/heads/master@{#456130}

In ReloadType, NONE means that the navigation is not a reload, so it
makes no sense to call Reload function with ReloadType::NONE as
parameter.

This CL clarifies it by mentioning it in public API comment and add a
DCHECK in the implementation.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2740843004
Cr-Commit-Position: refs/heads/master@{#456129}

This adds the targetsAtLeastO() helper function to BuildInfo. I also
updated the check we were using for HTTPS clear text to use this
instead of manually checking targetSdkVersion.

This helper should be updated once the SDK level for O has been
finalized.

BUG=688556

Review-Url: https://codereview.chromium.org/2745663002
Cr-Commit-Position: refs/heads/master@{#456128}

While running LayoutTests, this test timed out. I was curious, looked into it, and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert function being garbage. This caused 1000s of failures which caused test to run slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated new test expectations.

BUG=697646

Review-Url: https://codereview.chromium.org/2721243004
Cr-Commit-Position: refs/heads/master@{#456127}

Once browser initiated nagivations are enabled, we need a secondary map to map framenodeid's to IO thread clients.

BUG=645983

Review-Url: https://codereview.chromium.org/2737663004
Cr-Commit-Position: refs/heads/master@{#456126}

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907

Review-Url: https://codereview.chromium.org/2745783002
Cr-Commit-Position: refs/heads/master@{#456125}

Checking hasGetAccountsPermission before calling android.AccountManager.updateCredentials
is irrelevant, because this call never required GET_ACCOUNTS permission.
Added check for MANAGE_ACCOUNTS permission that was required before
Android M. On M+ it doesn't require any special permission.

BUG=699050

Review-Url: https://codereview.chromium.org/2745533002
Cr-Commit-Position: refs/heads/master@{#456124}

In this CL, I just tried to remove the flaky expectations
and rebaseline using `webkit-patch rebaseline-cl` to see
if that works.

BUG=685851

Review-Url: https://codereview.chromium.org/2733453002
Cr-Commit-Position: refs/heads/master@{#456123}

Activate the keychain reauthorization. Reauthorization will be performed
if the users preferences (cfprefs) indicate that the operation has been
attempted less than 2 times previously, and that the operation has not
previously succeeded. The number of attempts is set before the
operation, so that a crashy operation stops running after a finite
number of attempts. After successful completion, the preferences are
updated so that the operation is never run again. This CL also updates
the designated requirement with a new hash.

BUG=629906

Review-Url: https://codereview.chromium.org/2738053007
Cr-Commit-Position: refs/heads/master@{#456122}

There may be existing pointers to the memory block that are being actively
accessed while the zeroing of memory is taking place. While this change
doesn't fix that, it does make it possible for those other threads to recognize
that memory is changing under it and be able to react appropriately.

Also, restore missing kTypeIdAny that was somehow lost.

BUG=620813

Review-Url: https://codereview.chromium.org/2709113003
Cr-Commit-Position: refs/heads/master@{#456121}

Added myself to a new blink_image_capture and
removed/renamed myself from a few categories

Review-Url: https://codereview.chromium.org/2741853004
Cr-Commit-Position: refs/heads/master@{#456120}

This is so that mojo/binding.html can find the generated bindings for
math_calculator.mojom. This layout test was added in r455925, but failed
to add this data dependency.

BUG=700281
TEST=gn desc blink_tests runtime_deps

Review-Url: https://codereview.chromium.org/2742793003
Cr-Commit-Position: refs/heads/master@{#456119}

In general View::RequestFocus() and FocusManager::SetFocusedView() do
the same thing. The only exception to that is the SetFocusedView()
does not check if the view wants focus, where as View::RequestFocus()
does. For the cases I'm changing here RequestFocus() is fine.

BUG=none
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2738063007
Cr-Commit-Position: refs/heads/master@{#456118}

- Fixed the layout issues with the fullscreen toolbar
- Fixed the hiding animation

BUG=689115

Review-Url: https://codereview.chromium.org/2738043002
Cr-Commit-Position: refs/heads/master@{#456117}

In crrev.com/2354793003, we changed state updates to go through
TextInputManager, but TextInputManager does not propagate state update
when the current and last state was NONE. This can cause IME thread to
hang because it waits for the request to be replied.

BUG=699699

Review-Url: https://codereview.chromium.org/2743933003
Cr-Commit-Position: refs/heads/master@{#456116}

To resolve code review comments from https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/router/mojo/media_router.mojom

Create an ip_address.mojom to be used by media_router.mojom

BUG=698423

Review-Url: https://codereview.chromium.org/2745643002
Cr-Commit-Position: refs/heads/master@{#456115}

BUG=

Review-Url: https://codereview.chromium.org/2743983002
Cr-Commit-Position: refs/heads/master@{#456114}

UrlRequestContextFactory needs to be initialized before GetSystemGetter
is called.

Net log should be set before network activity starts.

BUG= internal b/35963633
TEST= Manual attempt to reproduce the crash

Review-Url: https://codereview.chromium.org/2738583003
Cr-Commit-Position: refs/heads/master@{#456113}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1ebe368476a6..faa1c3e0aeca

$ git log 1ebe36847..faa1c3e0a --date=short --no-merges --format='%ad %ae %s'
2017-03-10 benjhayden Clarify jsdoc for Histogram.customizeSummaryOptions().

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2742023002
Cr-Commit-Position: refs/heads/master@{#456112}

This CL is a follow-up for:
https://codereview.chromium.org/2627483003

After discussion with UI team, the text message on the chooser should
stay on the top-left as it was before the above CL. So this CL changes
it back.

BUG=664240

Review-Url: https://codereview.chromium.org/2744713003
Cr-Commit-Position: refs/heads/master@{#456111}

This will allow the testers to symbolize microdump crash logs.

BUG=593106

Review-Url: https://codereview.chromium.org/2740843002
Cr-Commit-Position: refs/heads/master@{#456110}

Previously, component is copied to /var/lib/imageloader/xxx folder upon
installation and next reboot mount the extracted image.
This patch mount the extracted image in place folder copy and no reboot
is required.

BUG=690521
TEST=test OnCustumInstall on a chromebook, escpr component is downloaded and mounted seamlessly.

Review-Url: https://codereview.chromium.org/2744453003
Cr-Commit-Position: refs/heads/master@{#456109}

As discussed in CL https://codereview.chromium.org/2681933002.

Review-Url: https://codereview.chromium.org/2740843003
Cr-Commit-Position: refs/heads/master@{#456108}

This is an alternative to trying to rebaseline everything right away (https://chromium-review.googlesource.com/c/452797/).

BUG=697971

Change-Id: I573e62eda15b7174e744696e75d45c3f92b9adcf
Reviewed-on: https://chromium-review.googlesource.com/452644
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456107}

Resident size is approximated pretty well by stats.max_size_in_use. However, on
macOS, freed blocks are both resident and reusable, which is semantically
equivalent to deallocated. The implementation of libmalloc will also only hold
a fixed number of freed regions before actually starting to deallocate them, so
stats.max_size_in_use is also not representative of the peak size. As a result,
stats.max_size_in_use is typically somewhere between actually resident
[non-reusable] pages, and peak size. This is not very useful, so we just use
stats.size_in_use for resident_size, even though it's an underestimate and
fails to account for fragmentation.

BUG=695263

Review-Url: https://codereview.chromium.org/2743563004
Cr-Commit-Position: refs/heads/master@{#456106}

This is the first step towards fixing the whitespace attachment bugs we have. My
plan is to use this from recalcDescendantStyles, and reattachWhitespaceSiblings
instead of the light tree.

BUG=657748

Review-Url: https://codereview.chromium.org/2725953002
Cr-Commit-Position: refs/heads/master@{#456105}

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I added a DCHECK to ensure all views are being cleaned up and filed a bug
to refactor this code so we don't have to clean up the views manually.

Fixed FocusCycleTest so it doesn't add duplicate child views to the status
area, which was tripping my DCHECK.

BUG=700122

Review-Url: https://codereview.chromium.org/2745723002
Cr-Commit-Position: refs/heads/master@{#456104}

These are:
components_browsertests
components_unittests
content_browsertests
content_unittests
unit_tests

Marshmallow 64 bit bot is used since it's not on the CQ, as we don't have capacity yet to enable this on the main waterfall. Also OS specific breakages should be rare.

In a followup we'll add some instrumentation test suites when support for passing command lines is available.

BUG=699242

Review-Url: https://codereview.chromium.org/2745683002
Cr-Commit-Position: refs/heads/master@{#456103}

This CL introduces the BackgroundFetchManager object and exposes it on
the ServiceWorkerRegistration, as part of a new Background Fetch module.

More functionality and tests will be added iteratively.

Intent to Implement:
  https://groups.google.com/a/chromium.org/d/topic/blink-dev/Ia9_-CVrl1U/discussion

WPT directory addition + IDL harness tests:
  https://github.com/w3c/web-platform-tests/pull/5094

Based on the following CL by awdf@:
  https://codereview.chromium.org/2739653002/

BUG=692534

Review-Url: https://codereview.chromium.org/2736143003
Cr-Commit-Position: refs/heads/master@{#456102}

This isn't running on the main waterfall as well; we should make it run there before adding it to the CQ so that sheriffs can see failures on the main waterfall instead of just silently blocking the CQ.

BUG=693672,700426
NOTRY=true

Review-Url: https://codereview.chromium.org/2736403006
Cr-Commit-Position: refs/heads/master@{#456101}

BUG=700390
TBR=rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2739423002
Cr-Commit-Position: refs/heads/master@{#456100}

BUG=None

Review-Url: https://codereview.chromium.org/2741133003
Cr-Commit-Position: refs/heads/master@{#456099}

For most window managers, calling XMapWindow causes a corresponding
MapNotify event to fire, indicating it is ready for drawing. Since this
usually happens immediately, but asynchronously, chromium previously
blocked the UI thread until it got this event, to avoid calling any
further X11 commands on the window until it was ready.

Unfortunately, not all window managers immediately map the window
after a MapRequest.  For example, the i3 window manager will not map
the created window while you're in fullscreen mode (i.e. youtube
video). This means chromium blocks indefinitely until the user
manually exits out of fullscreen mode.

The fix here is to avoid blocking, since we cannot make the assumption
that we'll get a MapNotify event quickly. By simply not blocking on
window map, we create two issues.

The first issue occurs when dragging tabs outside a window to create a
new one. The newly created window would fail to size itself properly
according to the space given to it by the window manager. This was
because the delayed_resize_task_ would get cancelled by SetBounds during
the time the thread would have otherwise been blocked.

This issue was fixed by only cancelling the task when the bounds changed
in that function, since that's the only time it will call OnHostResized
itself.

The second issue occurs during TooltipControllerTests, where a tooltip
is shown/hidden, and then immediately calls IsVisible() on the
widget (which eventually calls it on the underlying native
window). Since the mapping is now async, IsVisible() was false until
MapNotify was called.

The fix for this was to keep track of an additional variable for when we
are waiting for a MapNotify event, and using that to make IsVisible()
true during this time (after calling MapWindow, and before getting
MapNotify).

BUG=505669,670959

patch from issue 2329323002 at patchset 120001 (http://crrev.com/2329323002#ps120001)

Review-Url: https://codereview.chromium.org/2630773002
Cr-Commit-Position: refs/heads/master@{#456098}

TabObserver.onPageLoadStarted is a better indicator of navigation start
event which is actually also used in ChromeTabUtils.

This fixes the tests that are failing when PlzNavigate mode enabled.
WebappModeTest#testWebappHandlesWindowOpenInTabbedMode
WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode

BUG=699383

Review-Url: https://codereview.chromium.org/2742963002
Cr-Commit-Position: refs/heads/master@{#456097}

* Adds utilities to OmniboxSuggestion for caching and retrieving a list of
suggestion with enough info to be visually and functionally the same.
* Uses the utilities to add a new mode in AutocompleteController where
it caches each zero suggest update and sends them to its listener when
set.
* Uses this new mode in LocationBarLayout to show zero suggest results
before native initialization. If the user selects these results without
native, the selection action is delayed until the suggestion list is
updated. This gives the native AutocompleteController to create the
necessary components that will handle the logs correctly. Also adds logc
to check whether the suggestion to be logged matched with the suggestion
selected.

Review-Url: https://codereview.chromium.org/2738583002
Cr-Commit-Position: refs/heads/master@{#456096}

When we're generating fields in ComputedStyleBase, there are cases
where the generated code depends on the field template. For example,
keyword fields may have different getters than platform type fields.
Instead of doing if-else statements inside the template which makes
it quite ugly, this patch moves that logic out into their own files
as Jinja macros. Each file defines Jinja macros that specify how a
field should be generated.

This patch adds a 'keyword' template for enums, 'flag' template for
bools, and 'monotonic_flag' for nonproperty flags that can't be set
to false.

Link to generated code:
https://gist.github.com/anonymous/93f5d3907e3515d0b50adf0107f3000e

Link to diff (see differences in 'initialUnique' and 'resetUnique'):
https://www.diffchecker.com/mikllVbf

BUG=628043

Review-Url: https://codereview.chromium.org/2693933003
Cr-Commit-Position: refs/heads/master@{#456095}