- 29 Oct, 2019 40 commits
-
-
Gyuyoung Kim authored
Clean up old Mojo types in MediaServiceTest. - Convert mojo::AssociatedBinding to mojo::AssociatedReceiver - Convert mojo::FooClientAssociatedPtrInfo to mojo::PendingAssociatedRemote<> Bug: 955171 Change-Id: Iff82fd44b8faa4775115e360889ada3b49facf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883467 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#710160}
-
Toni Barzic authored
Updates home screen animation for transitions between overview and home screen when the overview uses FadeInFromHome and FadeOutToHome transitions (which are going to replace existing sliding animations). The new transitions are currently guarded by kHomerviewGesture feature flag. Bug: 1005366 Change-Id: Icb12e7e02dbd1194a7b0b605072597f50124e264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872226 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710159}
-
Takumi Fujimoto authored
This CL makes the GMC toolbar button appear when there is an active Cast session. GMC dialog contents for Cast will be added in a future CL. The functionality is put behind a kGlobalMediaControlsForCast feature flag. Bug: 987479 Change-Id: Ie97f8d1e9ca6cd94fc982d2d60c490aa777499d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873200 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#710158}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91d0d0f8. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I924783b4a87288bbb96bf214cb61a05ae9abee96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885300Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710157}
-
Ce Chen authored
config. Bug: 925072 Change-Id: I98478cdc4db2cc7c21155bbd1333656f11e1748a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885391Reviewed-by:
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Ia29d4fca693a2f718f1a09ae8de5c50624103c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884459Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ba192e7a9c8..fea4a2548205 git log 4ba192e7a9c8..fea4a2548205 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 erikchen@chromium.org Roll depot_tools git to v2.23.0 [bleeding edge/canary] Created with: gclient setdep -r src/third_party/depot_tools@fea4a2548205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1018953 Change-Id: I01b4fbf85a40bde7506f6a0e7814e45da53e330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710154}
-
Min Qin authored
This CL addresses some comments left in: https://chromium-review.googlesource.com/c/chromium/src/+/1832723. It now reads the remote blob interface directly rather than converting it to a BlobDataHandle first. BUG=947395 Change-Id: Ie9ecdaab3fa392f0c99f51eb73d5b0f8590cfbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869751 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#710153}
-
Tom Anderson authored
The Glib documentation [1] states that "It is a programmer error to give a key that isn't specified as having a string type in the schema for settings." Therefore, we must check if the settings schema has the key before actually getting any settings. If we do not do this, glib will terminate chrome with this error message: GLib-GIO-ERROR **: Settings schema 'org.cinnamon.muffin' does not contain a key named 'button-layout' Also increase the glib requirement to 2.40 since that's the minimum version that provides g_settings_schema_has_key. This version is available on all supported distros all the way back to Ubuntu Trusty. [1] https://developer.gnome.org/gio/stable/GSettings.html#g-settings-get-string BUG=1017974 R=thestig Change-Id: I46f95bd7a242e48e1d9dc910f6b1f3ed114e7d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880567 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#710152}
-
dpapad authored
This is in preparation of migrating to Polymer3. Bug: 1012533 Change-Id: Iab0d6d25a5c5df4ba5c19deccb98ad3ee968a982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881842 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710151}
-
Dominic Mazzoni authored
This is a new attempt at fixing bug 657157, previous attempts were reverted due to regressions. When setting accessibility focus to a node, auto-focus it if it's a link. This is needed for some sites that have skip links that are only visible when focused. In addition, when following a same-page link, move accessibility focus to the new target location on the page only after a short delay. This avoids a race condition due to focus also changing at the same time. Tested manually on three pages mentioned in bug 657157: 1. getbootstrap.com, which has a same-page link that's only visible when focused 2. http://jsfiddle.net/mev0c4dt/show/ - a test page for a regression that happened with a previous attempt to fix this bug 3. https://codepen.io/artesea/pen/jVdLXP - a test page for a regression that happened with a previous attempt to fix this bug Bug: 657157 Change-Id: I791544af3074f5aac5116c6695332d8178da21d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873964Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710150}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ibef33353dda58d8ffe31e4c252f6560e815d9a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884511Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#710149}
-
Will Harris authored
This is to allow time for third party vendors who currently inject into Chrome renderer processes to update their software. This will be re-enabled in a future release of Chrome. BUG=750886 Change-Id: I081a44a39ff499b86d02a637cb56ce4b6ff2c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885226Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710148}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1018887 Change-Id: Ifb7b963111c36b594c482314ca294e5f2fdf970a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884519 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710147}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/77b752951550..01a21f71f427 git log 77b752951550..01a21f71f427 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9109135d..7ce02641 (709913:710014) Created with: gclient setdep -r src/third_party/webrtc@01a21f71f427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I51584eb08372962899ab91db00f1abb092a931dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885018Reviewed-by:
-
Brian Sheedy authored
Disables the XR browser tests on the RX 550 tester, as the tests randomly hang indefinitely on this hardware configuration. TBR=ynovikov@chromium.org Bug: 1018896 Change-Id: Ie874c7df846d5133cd91fcf03eb7592e4c2b1347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884278Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#710145}
-
Peter Wen authored
Rather than depending on system provided rt.jar, check one into cipd and use that one instead for hermetic builds. The one used is from openjdk-8-jdk. Add myself to OWNERS under //third_party/jdk and update README.chromium with instructions for updating the extras subdirectory. Bug: 693079 Change-Id: I65361bd11aa0edd60dceb102b45082848dac6244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884367 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#710144}
-
shrekshao authored
Remove import from upload module. Upload doesn't seem to be actually used. Simply removing it will make the script work again. Bug: 1018475 Change-Id: Ib30850f1c7b4a0ad2cb1596b1051662651514be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885096 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710143}
-
Joel Hockey authored
Refactor ReturnEarlyIfAborted function to only call abort_callback_ if it is not already called since it is possible that OnVmShutdown could call it, and then another delayed callback could also call it. Bug: 1013059 Change-Id: I33108b158ccc60e405c5ecf09d4cec3d65b3edec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880242Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#710142}
-
Mitsuru Oshima authored
Apply layer blur on the layer that has wallpaper, but not the widget because the solid color is a part of widget's layer. Bug: 1015886 Test: covered by unittest. Also tested manually with blur change reverted. Change-Id: Iaf0f2faaa1e92285a3f8b45083027a7fccf0bc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885219Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710141}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=khushalsagar@chromium.org Bug: 1018887 Change-Id: I0ff68808f1b026c7f705926367281a2c152e8f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884517Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710140}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/054ab2be..a0b89dfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf7aaa1a6fe22b0703f5eb3b2ba833f0532f6bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885290Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710139}
-
siyua authored
messaging experiment code Bug: 961082 Change-Id: I45ea1a98d66921217045bda865bc833b48d35b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881714Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#710138}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Iec40ef6edd087f2ae5277b2e0996bddd92675570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884598Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710137}
-
Jan Wilken Dörrie authored
This change implements showing the soft keyboard if the Touch To Fill sheet gets explicitly dismissed by the user. This required making RenderWidget::ShowVirtualKeyboard() available from PasswordAutofillAgent, which is done by exposing a corresponding API on RenderFrame and implementing it in RenderFrameImpl. Bug: 1014043 Change-Id: I46d0c6a8c4abcde47c905797d2c7d39242dd8ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879928 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710136}
-
Matt Simmons authored
Bug: 1017977 Change-Id: I73b6f34d05f85a0ecce22b3d74e2ea8177533b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879763Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#710135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f71802b4404..6f23b4b7038e git log 2f71802b4404..6f23b4b7038e --date=short --no-merges --format='%ad %ae %s' 2019-10-28 mmynttinen@mozilla.com Fix MinGW include: s/VersionHelpers.h/versionhelpers.h/ 2019-10-28 jmadill@chromium.org Plumb more logic for ANGLE_get_image. Created with: gclient setdep -r src/third_party/angle@6f23b4b7038e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I0b9f56f367af32ecfc33c760647258f8e15570ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884527Reviewed-by:
-
Miyoung Shin authored
This CL converts KeySystemSupport{Ptr, Request} in content to the new Mojo type. Bug: 955171 Change-Id: I84b54952523842d408f13515eeae0649c73895e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882200Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 1018887 Change-Id: Idb34b1c7731f9494d8ebc6aa471bc26f16f72619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884995 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710132}
-
Miyoung Shin authored
This CL cleans up unused using aliases of MirrorServiceRemoter{Ptr, Request} and MirrorServiceRemotingSource{Ptr, Request} in cast_remoting_connector_unittest.cc since old Mojo types of them was already converted. Bug: 955171 Change-Id: I0f7fc2717418b9f752728435541d8f466593e625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882261Reviewed-by: -
Gauthier Ambard authored
The idea is to log when the user is opening a URL (from another app) which is already opened in the app. Having this metrics will allow us to know if it is impactful to handle this special case. Bug: 1014964 Change-Id: I94c7b7810eb66c81ec310057d1b4b991dad55ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869412Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#710130}
-
Karan Bhatia authored
Simply moves RequestParams to its own file. This is a pure refactoring change. BUG=974391 Change-Id: Id02ae3f33847617ea65ad2e5d757094015d22bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881494 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710129}
-
Miyoung Shin authored
This CL converts OutputProtection{Ptr, Request} in media and chrome to the new Mojo type. Bug: 955171 Change-Id: Ie7dfdb8fe46b2aec18a576eb6435122b662c1fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882263Reviewed-by: -
Ce Chen authored
1. Allows to enable on device head suggest in incognito w/o enabling it in non incognito first. 2. Removes request delay in incognito since there is no server suggestion which we need to cope with. Bug: 925072 Change-Id: I344ecc2c620cb95c3b5f7c929cac0d9287b3c05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881978Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#710127}
-
Livvie Lin authored
Matches the about_flags.cc implementation. Bug: 1008219 Change-Id: I3755cf4f7b968fc347acc0ae5ab6ef31c70223bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884755Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710126}
-
Ali Juma authored
WKWebView and iOS do not permit navigation to arbitrary files on a device's file system. Attempting to load such inaccessible files in WKWebView can later trigger broken behavior (see crbug.com/1010526 for more details). To prevent this brokenness, disallow these navigations right away, rather than waiting for WKWebView to disallow them. Bug: 1010526 Change-Id: Ieefb5befad659669a38efad127dfdb6e0179a165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881667 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
-
Qingsi Wang authored
disabled in WebRTC. This policy gates the effectiveness of chrome://flags/#enable-webrtc-hide-local-ips-with-mdns. Only when a URL is not whitelisted by the policy and the feature flag has the value 'Enabled', local IP addresses are concealed with mDNS hostnames in WebRTC ICE candidates. Bug: 1012945 Change-Id: I7782db6f1196921361c12738e00e471282e64058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857184Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710124}
-
Tricia Crichton authored
Several tests that require features not supported on Android were added to the ANDROID_NEGATIVE_FILTER. Fixed: chromedriver:3191 Change-Id: I3c30057df11a008b59100e4e1aae91a1f90d754d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884284Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#710123}
-
rbpotter authored
Also fixing some tests that fail due to the addition of the assert. cr.js is included by default in the extraLibraries of the PolymerTest base class, so test classes that do not override extraLibraries and import cr.m.js cause the webUIResponse/webUIListenerCallback to be set twice. Bug: 1004967 Change-Id: I7c31cc4df5119556f62e1afe7ebf1b85cb0c6722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885230Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710122}
-
Jarryd authored
The only place where this event was fired has been removed. https://crrev.com/c/1369551/ shows in site_entry.js that the event was removed, and a search of cs for the event turns up no results. Change-Id: Id1b198382cfbd004c7fbd6035e2ec7cbc656e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869017Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710121}
-
