- 10 May, 2018 40 commits
-
-
Christian Biesinger authored
When we get a child's intrinsic size we need to make sure to use the correct writing mode. This patch only fixes the case where the child has a size specified. Makes a few more tests pass (see the test expectations change). Makes one test fail, but that one passed more by coincidence than anything else. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia14edd6c85970ccb17c8735dbb3a307e657015a6 Reviewed-on: https://chromium-review.googlesource.com/1053885 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557715}
-
Antonio Gomes authored
Driven by follow up of https://crrev.com/c/1042825. BUG=773295 Change-Id: I8778d225f411c84f431867b2845301f3da770d6d Reviewed-on: https://chromium-review.googlesource.com/1050705 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557714}
-
Xiyuan Xia authored
Bug: 841966 Change-Id: I7e14a67b0f89d1ba713c582d07ba2229c7ecf25d Reviewed-on: https://chromium-review.googlesource.com/1054226Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557713}
-
Artur Khachatryan authored
Change-Id: I0b716112f233b2790ec0ee5af33760438aea9218 Reviewed-on: https://chromium-review.googlesource.com/1054422Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557712}
-
Sergey Ulanov authored
Layout tests were disabled on Fuchsia, so they bitrotted in the last couple of month. This CL includes the following changes to make layout tests runnable on Fuchsia again: 1. Content shell package is installed with "pm install" command. 2. Fonts no longer need to be copied - they are part of the content_shell package as data deps. 3. Now SSH can used to forward TCP connections instead of layout_test_proxy. 4. libosmesa.so can be loaded from the package, so it no longer needs to be copied to /system/lib . Bug: 778467 Change-Id: Ie16f7ad6b9088153450194b280a6f69e9cb25328 Reviewed-on: https://chromium-review.googlesource.com/1054332Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557711}
-
David Black authored
There is a follow up CL to add an ActionView class which is a child of DialogPlate that I want to keep grouped in the same directory. Doing the DialogPlate move here in a separate CL because adding the ActionView in the same CL introduced enough changes where git didn't track the DIFF but instead treated the changes as a file delete and new file add. Follow up CL is: https://chromium-review.googlesource.com/c/chromium/src/+/1053160 Screenshot in bug. Bug: b:79473532 Change-Id: Ifcd7a0db2c67c2c7b4f61244b5107ff3bc4fb42b Reviewed-on: https://chromium-review.googlesource.com/1054149 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557710}
-
Ryan Tseng authored
This was generated by luci_check. This: * Adds new buildbot builders * Remove migrated buildbot builders * Adds luci equivalent builders Known issue: Main console is not updated. That will come later. Change-Id: Ic6bb08ce57e0a42933181f1ad9a12a95f0739b5e Reviewed-on: https://chromium-review.googlesource.com/1054004Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557709}
-
Ryan Sleevi authored
Presently, the NetworkContext has three public constructors, one private constructor, and a public static method, all which, in some way, configure a URLRequestContext based on NetworkContextParams. However, one of these constructors in unused except for in an (uncalled) CreateForTesting() method, two are 'transitional' constructors that only exist as part of the Network S13N effort to keep things running, and the static method has implicit and explicit circular dependencies with the URLRequestContextMojo. This adds documentation to that effect, removes the unused code, updates the existing code to follow the 'best practice' for new code, and tries to hide the footguns from plain sight. BUG=none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If5710d84cbb8e144798da9ac3a5235f92b65105e Reviewed-on: https://chromium-review.googlesource.com/1053962 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557708}
-
Nate Chapin authored
Bug: 680046 Change-Id: I46ffe62d8bb9982a717b49b31ed6be7ae62e4baf TBR=kinuko@chromium.org Change-Id: I46ffe62d8bb9982a717b49b31ed6be7ae62e4baf Reviewed-on: https://chromium-review.googlesource.com/1035618 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557707}
-
Troy Hildebrandt authored
This reverts commit c4c35ff0. Makes sure to initialize path_wildcard_present_ in TemplateURLRef::InvalidateCacheValues to fix use of uninitialized value errors. Bug: 834876 Change-Id: Iaf1687045ae037a9d2dd2a2accdc1856ef0055ae Reviewed-on: https://chromium-review.googlesource.com/1050737 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
-
Eric Karl authored
This reverts commit 88aa3d56. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable several flaky WebVrTransitionTests. > > TBR=bsheedy@chromium.org > > Bug: 840638 > Change-Id: I3acc6d00d75f6c6dce370961d7459dc3a50faef4 > Reviewed-on: https://chromium-review.googlesource.com/1049274 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556686} TBR=bsheedy@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840638 Change-Id: I46f8ffa148d1944ff4f05241fd93e2220fbd93ae Reviewed-on: https://chromium-review.googlesource.com/1054119 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557705}
-
Sam McNally authored
The existing Google Drive integration waits until the mount is complete before adding it to the file manager. Add OnMounted() to the DriveFsHost delegate to provide this signal when using DriveFS. Also switch to AccountId::GetAccountIdKey() Bug: 823607 Change-Id: I5f5b7027f7f899ed91759a9c6e7dd913eb9d5903 Reviewed-on: https://chromium-review.googlesource.com/1053043 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557704}
-
Chris Harrelson authored
Bug: 831762 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic7ddaf8b86fb8d0f1d7bb3a83b62c5cc2ee2b78c Reviewed-on: https://chromium-review.googlesource.com/1053487Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557703}
-
Scott Chen authored
Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I27a757241ae2b8b44453b9acb1000fe8d9ddb69d Reviewed-on: https://chromium-review.googlesource.com/1054217Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557702}
-
Marina Ciocea authored
Use audio service IPC instead of AudioInputController for creating input stream. This change is part of the effort of moving audio out of browser process [1]. By moving audio into a separate process, speech recognition can no longer use AudioInputController directly, and needs to use IPC to create and use input streams provided by audio service. [1] Chrome audio process design doc: http://doc/12vz7UZBQIp1195V-xAYvHIoQ1r536BCmMKcPN7Si-OI Bug: 834706 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1dc98ad670e1e9880320ae4bf054ae0d94f5b48f Reviewed-on: https://chromium-review.googlesource.com/1049685 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557701}
-
Daniele Castagna authored
Modesetting with an x-tiled buffer and then pageflipping to y-tiled buffers on 3 different crtcs is allowed to fail and indeed does on APL devices. This CL makes sure the modeset buffers are allocated with the same modifiers we allocate buffers for the buffer queue. Bug: 819692 Test: pyro with 2 external monitors Change-Id: I392cfecbf598b096947af55c793148933ee83025 Reviewed-on: https://chromium-review.googlesource.com/1054447 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557700}
-
Jian Li authored
This allows the embedder to create a URLLoader and ntercept a navigation request. Bug: 841617 Change-Id: Id6d8c795805413962151be5fbdce91e52322af5d Reviewed-on: https://chromium-review.googlesource.com/1053352Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557699}
-
George Burgess IV authored
In order to use AFDO on Linux, we need to be able to locally unpack the profiles we fetch (which is likely preferable to storing a second, unpacked version in gs://). It used to be that we only needed these for Android, since these profiles were previously only used by Android. This was split out from https://chromium-review.googlesource.com/c/chromium/src/+/1025132 Bug: 805098 Test: Ran install-build-deps.sh Change-Id: I1374b2b84c26f6ef808c00217bfbb51e8fbf980d Reviewed-on: https://chromium-review.googlesource.com/1054613Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#557698}
-
Eric Karl authored
This reverts commit e079f156. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky testWindowRafStopsFiringWhilePresenting_WebXr. > > Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest > testWindowRafStopsFiringWhilePresenting_WebXr because flaky. > > TBR=bsheedy@chromium.org > > Bug: 840883 > Change-Id: I2300a6be8d79d1d6f47d33d5fd06edc9fee5ca41 > Reviewed-on: https://chromium-review.googlesource.com/1051788 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557189} TBR=bsheedy@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840883 Change-Id: I7638d3489db017dc040683e8a6cc6ce47c2df94d Reviewed-on: https://chromium-review.googlesource.com/1054352Reviewed-by:
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I0951d87c1baee0f172e6e446f2cc6c5a1ae6cf2a Reviewed-on: https://chromium-review.googlesource.com/1054631Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557696}
-
Christopher Grant authored
- Revert to "new incognito tab" above "close all incognito tabs" - Don't duplicate the UI model logic in each button handler BUG=841501 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I87e625ec75270114567810c595ca3767e7e93b0f Reviewed-on: https://chromium-review.googlesource.com/1054503Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557695}
-
Eugene Ostroukhov authored
Bug: 828601 Change-Id: Ia90474edd65f80e432533974ff12d08c4a149ba8 Reviewed-on: https://chromium-review.googlesource.com/1053060Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557694}
-
Bret Sepulveda authored
GlassBrowserFrameView had a GetTitlebarColor method that was redundant with BrowserNonClientFrameView::GetFrameColor, so this patch deduplicates them. Bug: 841643 Change-Id: If1f0b3724fac814b8b445c1792213753b49e2eda Reviewed-on: https://chromium-review.googlesource.com/1053490 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557693}
-
Ahmed Fakhry authored
The ink drop highlight lingers behind when the window and the caption buttons are growing as a result of maximizing the window. Sometimes it even sticks in the wrong place forever until the mouse is moved. This CL fixes the issue by painting the hover highlight in such a way that simulates the AutoHighlightMode::SHOW_ON_RIPPLE mode. This guarantees the highlight is always painted at the center of button. BUG=840901 Change-Id: I6096fef6605c262ca81c8526fea029e7dc459179 Reviewed-on: https://chromium-review.googlesource.com/1053805Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#557692}
-
James Cook authored
More support for WindowService as a library. Expose a method to set the frame decoration metrics (e.g. client area insets). Bug: 839592 Test: added to services_unittests Change-Id: I44ead634ad2c5ceb35020efcf5a301aced6ec603 Reviewed-on: https://chromium-review.googlesource.com/1053557Reviewed-by:
-
Manu Cornet authored
Change-Id: I541a6cd9b41b8ce505ce2e6598a5f35e0c548993 Reviewed-on: https://chromium-review.googlesource.com/1015967 Commit-Queue: Manu Cornet <manucornet@google.com> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557690}
-
Jonathan Backer authored
Saves 0.4 ms out of 9.4 ms on thread_GPU_cpu_time_per_frame on thread_times.key_silk_cases running on N5 with OOP-R enabled. This CL does a couple of things. (1) dirties GrContext when we make GL calls directly (via api() in RasterDecoderImpl or in helpers like TextureManager) (2) does a hard RestoreState(nullptr) just before we service another decoder using virtual contexts. The correctness/performance of this CL relies on two facts: - RasterDecoder functions don't rely on ContextState persistence between calls (it uses Scoped*Binder and helpers call Restore* on exit). This means we can ignore how GrContext changes state during RasterDecoder execution. - GetContextState is called if and only if we switch virtual contexts (https://cs.chromium.org/chromium/src/ui/gl/gl_context.cc?rcl=7665435ec16705f26cf15259d28b89d24ec80699&l=328) This CL avoids most state resetting in the common case where we OOP-R a bunch of tiles all at once (e.g. page load). Note our resetting is still pessimistic. In particular, I would expect scenarios like this where we still unnecessarily reset/restore state. - client A receives GetContextState - client B made current, but immediately descheduled to wait on a SyncToken provided by A - client A made current again Bug: 836916 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9eecef94a5429861ae4b70acdd3aba0450bded4b Reviewed-on: https://chromium-review.googlesource.com/1047445Reviewed-by:Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557689}
-
Christopher Grant authored
This change reduces the amount of custom code in LinearLayout to the minimum, reducing duplication and keeping things more consistent. BUG= R=acondor Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I11a9c0a766845f9b5b7a86378a12b5e0b6202115 Reviewed-on: https://chromium-review.googlesource.com/1053754Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557688}
-
rodmartin authored
Change-Id: I1096ccdc251b41a91c17d0b4ce6dc778ef33d7dd Reviewed-on: https://chromium-review.googlesource.com/1050970Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#557687}
-
David Jacobo authored
Somehow using Close() to get rid of a WebContents causes a error, while still investigating we can avoid this by: -replacing with ClosePage (which apparently is used more broadly thru the codebase). -Stop directly closing the tab and instead ask PostTask() to do it. Bug: b/79167225 Test: Manual test. Change-Id: I752073c8577bf45a387ed1e7f5d908feea05f8b5 Reviewed-on: https://chromium-review.googlesource.com/1043266 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#557686}
-
https://pdfium.googlesource.com/pdfium.git/+log/80302c77a854..5ad45e2f68bb $ git log 80302c77a..5ad45e2f6 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 dsinclair Cleanup formcalc method generation 2018-05-10 rharrison Clean up post review comments Created with: roll-dep src/third_party/pdfium BUG=chromium:814848 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1d0e111ec94d82eee04e9e8a283f97838d7e5d19 Reviewed-on: https://chromium-review.googlesource.com/1054492Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557685}
-
Eric Orth authored
Bug: 841278 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibc169428f34de3f291756f360a09ee22d4aa2308 Reviewed-on: https://chromium-review.googlesource.com/1053835 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
-
Troy Hildebrandt authored
Adds recording of voice search initialization failures, recorded if we fail to show the speech recognition intent, and a voice search dismissal metric when the voice search is dismissed by the user. Also moves the recording of the voice recognition finished event to capture more of the completions and provide a more realistic ratio of start/finish events. Bug: 840483 Change-Id: I857ef4115482fa4695bd0dd9e7fe3794dac55769 Reviewed-on: https://chromium-review.googlesource.com/1048311Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557683}
-
Sergey Ulanov authored
CollectContextGraphicsInfo() now calls CollectGraphicsInfoGL(), same as on Linux and Mac. Layout tests were failing to start due to CollectContextGraphicsInfo() returning false. Bug: 778467 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If089e57b167fb74f95da4462cbe2b1756a76c2be Reviewed-on: https://chromium-review.googlesource.com/1054265Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557682}
-
Jian Li authored
These new files are simply copies of OfflinePageRequestJob files with name changes. They're not added to compile targets. This will allow easier reviewing for next patch that refactor OfflinePageRequestHandler to support both with network service enabled and without network service enabled. Bug: 841617 Change-Id: I295479cfe2240eddd77a7f9580af4c0346997282 Reviewed-on: https://chromium-review.googlesource.com/1053364Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557681}
-
Xi Han authored
ServiceManager. We need a thread to post/execute tasks when starting the ServiceManager. This thread needs to be created before the browser main loop is initialized, and will be registered as the BrowserThread::IO thread which is currently used by ServiceManager connections. The creation of such a thread is moved to service_manager::main via MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no thread created before calling fork() on posix, we also move the setup of sandbox before creating the IO thread. Bug: 740677, 729596 Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 Reviewed-on: https://chromium-review.googlesource.com/969098 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557680}
-
Evan Stade authored
This is a reland of f57e1c35 which was reverted due to being blamed for the msan failures which were fixed by d8f72fd2 Original change's description: > cros - Update appearance of resolution change notification. > > This removes the last raster asset in ash_resources.grd, so remove that > file and the associated build target. > > Bug: 840509,505953 > Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c > Reviewed-on: https://chromium-review.googlesource.com/1050523 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557292} TBR=jamescook@chromium.org,sky@chromium.org Bug: 840509, 505953 Change-Id: Iae0b07cbf2e14e307b74e11d07d21290ee72291b Reviewed-on: https://chromium-review.googlesource.com/1054222 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557679}
-
Stefan Zager authored
TBR=evanm@chromium.org NOTRY=true Change-Id: I14319a25baa26ed7361e796839ed6b4c689529e5 Reviewed-on: https://chromium-review.googlesource.com/1054491Reviewed-by:
-
Ehsan Chiniforooshan authored
If the reader of the stream stops reading from it for some reason, a deadlock is possible: - WriteToStream() obtains stream_lock_ but does not release it because it is blocked on writing to the stream that is not read from. - CloseStream() does not close the stream because it waits on the lock that WriteToStream() is not releasing. I will remove the lock alltogether. So, CloseStream() does not wait and just closes the stream. Then, if the BlockingCopyFromString() statement of WriteToStream() is blocked, it will be signaled that the stream is closed. It is not a perfect solution because if CloseStream() closes the stream after the "if (stream_.is_valid())" check of WriteToStream() but before BlockingCopyFromString() reaches the wait statement, the stream handle becomes invalid and a DCHECK will fail. I cannot think of a simple solution right now, but the above-mentioned scenario is very unlikely to happen. For sure, this CL improves the current flakiness. Bug: 837215 Change-Id: I5d064b93dfb6af444c778bb60f156b29b43f1617 Reviewed-on: https://chromium-review.googlesource.com/1054092 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#557677}
-
Leonard Grey authored
Currently, all clicks on a bookmark folder button trigger their action on mouse down, so that the folder menu can open on mouse down as expected. This also includes command click, which, rather than opening the folder menu, opens all the bookmarks in the folder as new tabs. This isn't desirable since: - The expected behavior is that button clicks trigger on mouse up. - Triggering this on mouse down interacts poorly with the nested run loop created by the confirmation dialog we display when the folder has many links. This change causes the action to no longer fire on mouse down if the user is command-clicking the folder button. Bug: 840387 Change-Id: Ic1364160cf26f2f3ea6e67d7dd0d6cf5079082eb Reviewed-on: https://chromium-review.googlesource.com/1053947Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557676}
-
