GitLab

BUG=407858

Review URL: https://codereview.chromium.org/504413004

Cr-Commit-Position: refs/heads/master@{#292456}

Tabbing should navigate through all the visible controls.

I've changed the EditablePhotoButton to actually be a button and
not just an image, so that tabbing and pressing enter actually
works.

BUG=405056

Review URL: https://codereview.chromium.org/489143002

Cr-Commit-Position: refs/heads/master@{#292455}

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180973%3A181040&mode=html

TBR=hclam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/512283002

Cr-Commit-Position: refs/heads/master@{#292454}

Simple rename patch, in preparation for making the DataTypeStatusTable
copy-able and having it track more than just errors.

BUG=368834

Review URL: https://codereview.chromium.org/513543004

Cr-Commit-Position: refs/heads/master@{#292453}

BUG=110610

Review URL: https://codereview.chromium.org/514233002

Cr-Commit-Position: refs/heads/master@{#292452}

BUG=none

Review URL: https://codereview.chromium.org/511253002

Cr-Commit-Position: refs/heads/master@{#292451}

BUG=
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/514143003

Cr-Commit-Position: refs/heads/master@{#292450}

Adding droppedframecount UMA to monitor videoplayback quality. Metric gets logged only if the pipeline has video & has decoded atleast one video frame.

BUG=
R=dalecurtis

Review URL: https://codereview.chromium.org/497913002

Cr-Commit-Position: refs/heads/master@{#292449}

Review URL: https://codereview.chromium.org/512663002

Cr-Commit-Position: refs/heads/master@{#292448}

The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.

This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/505403002

Cr-Commit-Position: refs/heads/master@{#292447}

Our designers generated assets that do not use sRGB color profile
and this makes libpng unhappy. According to jreck@ Android does not use
these profiles. This CL removes all these color profiles using this command:
find . -type f -name "*.png" -exec convert {} -strip {} \;

BUG=394138
R=dtrainor@chromium.org, newt@chromium.org
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/510423002

Cr-Commit-Position: refs/heads/master@{#292446}

Some errors remain but these are circular includes that can't be fixed in the build files only.

Enable views_unittests and wm_unittests now that they compile

BUG=
R=sky@chromium.org, tfarina@chromium.org

Review URL: https://codereview.chromium.org/513313002

Cr-Commit-Position: refs/heads/master@{#292445}

BUG=408429
TEST=none
TBR=miket

Review URL: https://codereview.chromium.org/515313002

Cr-Commit-Position: refs/heads/master@{#292444}

Mac does not use Skia image natively even if TOOLKIT_VIEWS=1.

BUG=378134

Review URL: https://codereview.chromium.org/517723002

Cr-Commit-Position: refs/heads/master@{#292443}

BUG=110610

Review URL: https://codereview.chromium.org/515303002

Cr-Commit-Position: refs/heads/master@{#292442}

Testing clock needs an owner. Put a scoped_ptr<> to where it was first
created.

BUG=400728

Review URL: https://codereview.chromium.org/488133005

Cr-Commit-Position: refs/heads/master@{#292441}

If a CDM calls the wrong Resolved() method to resolve a promise, the
promise is cast to the wrong type and causes a crash. This fixes the
problem by verifying that the promise is the correct type before
casting it.

BUG=408319
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/515753002

Cr-Commit-Position: refs/heads/master@{#292440}

This broke fling.

This reverts commit f1e78836.

TBR=sadrul,alexst
NOTRY=true

Review URL: https://codereview.chromium.org/514303002

Cr-Commit-Position: refs/heads/master@{#292439}

Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/)

Reason for revert:
Speculatively reverting to see if this helps the mac perf bots:
https://code.google.com/p/chromium/issues/detail?id=408673

Original issue's description:
> Fix assorted issues with remote CoreAnimation
>
> These issues came up while running for a few days with the
> flag --enable-remote-core-animation.
>
> Fix flashes of old frames by hooking up the DiscardBackbuffer (which
> happens when being made non-visible) to re-set the CAContext and
> CALayer (so the browser gets a new one with new content for the next
> frame).
>
> Add support for disabling vsync by using setNeedsDisplay to draw.
>
> Change the backpressure mechanism to rely on the browser to apply
> backpressure in its compositor via the cc:: output surface.
>
> Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
> to the real GL API while in the CoreAnimation callback.
>
> BUG=312462
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8

TBR=piman@chromium.org,ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=312462

Review URL: https://codereview.chromium.org/517733002

Cr-Commit-Position: refs/heads/master@{#292438}

It's timing out on some android bots and from a local run, it seems
to just be legitimately slower than the default 60s timeout.

BUG=405381

Review URL: https://codereview.chromium.org/510413002

Cr-Commit-Position: refs/heads/master@{#292437}

BUG=110610

Review URL: https://codereview.chromium.org/513283002

Cr-Commit-Position: refs/heads/master@{#292436}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/512253002

Cr-Commit-Position: refs/heads/master@{#292435}

If this is submitted, then cl/74264031 should also be submitted so that the perf dashboard correctly makes patches.

Any thoughts?

BUG=

Review URL: https://codereview.chromium.org/511043002

Cr-Commit-Position: refs/heads/master@{#292434}

When the browser takes the navigation, the current page doesn’t change, so it makes no sense to change the page id.

This reverts a58db8b0.

BUG=407376
TEST=stuff is green

Review URL: https://codereview.chromium.org/511263002

Cr-Commit-Position: refs/heads/master@{#292433}

BUG=110610

Review URL: https://codereview.chromium.org/514123002

Cr-Commit-Position: refs/heads/master@{#292432}

PRESUBMIT checks for usage of FIXME, so added that to error message.

Review URL: https://codereview.chromium.org/515063004

Cr-Commit-Position: refs/heads/master@{#292431}

BUG=403813
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/516643005

Cr-Commit-Position: refs/heads/master@{#292430}

BUG=110610

Review URL: https://codereview.chromium.org/511153002

Cr-Commit-Position: refs/heads/master@{#292429}

This will make the WebRTC connection work under NTLM/Kerberos using the default credential without prompting the user.

BUG=395614

Review URL: https://codereview.chromium.org/414523005

Cr-Commit-Position: refs/heads/master@{#292428}

compositor-perf team is using these benchmarks for tracking compositor
performance primarily in software raster path, so forcing software raster.

BUG=407927

Review URL: https://codereview.chromium.org/516623002

Cr-Commit-Position: refs/heads/master@{#292427}

The GestireNav screenshot dimensions are density-independent, because when we capture the screenshot we scale it to RVH's bounds: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/navigation_entry_screenshot_manager.cc&q=navigation_entry_sc&sq=package:chromium&type=cs&l=136

Thus we don't need to scale it again when we paint during the overscroll gesture.

BUG=402280

Review URL: https://codereview.chromium.org/507083002

Cr-Commit-Position: refs/heads/master@{#292426}

This fixes an issue with invalid JSON being generated as example values
for policies on Windows, and points to the documentation for complex
policies on Windows.

BUG=381627

Review URL: https://codereview.chromium.org/511993003

Cr-Commit-Position: refs/heads/master@{#292425}

And it doesn't have its body :)

R=brianderson@chromium.org
BUG=NONE
TEST=NONE(non functional change)

Review URL: https://codereview.chromium.org/515573005

Cr-Commit-Position: refs/heads/master@{#292424}

IME Visibility status check test case is missing when we do long
press on different kind of empty and non-empty input fields. This patch
takes care of adding missing test cases for the same.

BUG=

Review URL: https://codereview.chromium.org/516843005

Cr-Commit-Position: refs/heads/master@{#292423}

Telemetry does not account for process death when computing deltas of various process statistics over a browser run.

CPU stats are currently stored in a dictionary of POD types aggregated by process type which gives no room for separating dead processes over a run.

Ultimately the goal is to report CPU stats in the timeline on a per-process basis.

Towards this goal and to fix counting of dead processes, this CL adds an IdleStatsData object which inherits from TimelineData. IdleStatsData keeps
track of idle wake ups by PID and is able to omit processes which have died during a run from the final reported result.

BUG=343373

Review URL: https://codereview.chromium.org/501813002

Cr-Commit-Position: refs/heads/master@{#292422}

In r272421, I changed sheet repositioning on window resize to be based on
NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification
because it tracks window resizing much more smoothly.

That caused this problem where if the browser window is vertically maximized
(or is in fullscreen), the window size does not change when the bookmark bar
is shown or hidden.

The old code has a different bug however. If the browser window is not
vertically maximized, showing or hiding the bookmark bar does not change the
browser content view's frame. It moves up or down to follow the window resize
but its frame relative to its superview remains the same.

I settled for adding code to explicitly update the sheet's position when the
bookmark bar is shown or hidden.

BUG=407509

Review URL: https://codereview.chromium.org/502413004

Cr-Commit-Position: refs/heads/master@{#292421}

BUG=110610
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/510313002

Cr-Commit-Position: refs/heads/master@{#292420}

The bug in JavaScript encoder that prevented us from doing so has been fixed.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/509173003

Cr-Commit-Position: refs/heads/master@{#292419}

The android webview build now uses clang when building for host; update
the gyp variables appropriately to make sure we use reasonable compiler
flags.

BUG=377684

Review URL: https://codereview.chromium.org/516723004

Cr-Commit-Position: refs/heads/master@{#292418}

When removing tiles, we need to remove everything outside the live
tiles rect even if it has borders inside the live tiles rect. The
DifferenceIterator includes borders when deciding if a tile is in the
included rect, so tiles that are only in the included rect with a border
were not being removed from the tiling. This lead to us having tiles
outside the rect, and to creating a tile that already existed.

When adding tiles, the same problem existed. The DifferenceIterator
includes borders when deciding which tiles are to be excluded, so a
tile that was inside the old live tiles rect with borders only would
not have existed, but it would be excluded by the DifferenceIterator.
This prevented us from making tiles that were inside the live tiles
rect.

Depends on: https://codereview.chromium.org/513903002/

R=enne@chromium.org, vmpstr@chromium.org, enne, vmpstr
BUG=405427

Review URL: https://codereview.chromium.org/505913003

Cr-Commit-Position: refs/heads/master@{#292417}