- 15 Feb, 2020 32 commits
-
-
Alex Cooper authored
This is a reland of 96d43c20 Changes for reland: * SERVER_PORT variable moved from individual tests to XrTestFramework * XrTestFramework configures embedded test server to use HTTPS * RenderTests set their port explicitly. * Tests that were setting server port/not expecting HTTPS were updated * Re-add GetFileUrlForHtmlTestFile for use by testFileUrlEmphasis * Update Goldens as a result of URLs changing from file to server, and from the default http to https. (Goldens pulled from Patchset 3 of this CL). Original change's description: > Switch Android VR tests to use embedded test server > > As part of the work to use the permissions prompt by default, instead of > the custom consent dialogs, tests will need to be updated to use the > embedded test server rather than directly navigating to a file. This is > due to the fact that the Permissions code will DCHECK if saving the > permission for a file-type URL. > > Bug: 1043241 > Change-Id: Iaa820812fac0bc389af47c22f8e069e81929b05a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047987 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740399} Bug: 1043241 Change-Id: I208c6f0517bfc2f382466631f3844fc11cec5375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049839 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741694}
-
Jazz Xu authored
This CL fix the issue by updating pip availability when media loading is complete. Bug: 1051142 Change-Id: Iea84f73aca6af85d951f4e7ca20240b597ef0ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044657 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741693}
-
Vikas Soni authored
Use ExternalVkImageFactory as an interop factory instead of SharedImageBackingFactoryAHB for software decode video path on android. This is because AHB backing do not support single channel formats used by video frames in this path. Bug: 985387 Change-Id: I31243c34a8b72beb0a7af0bec7e54bd326e9a203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045130 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741692}
-
Kurt Horimoto authored
This DCHECK assumes that every |-scrollViewDidEndDraggingWithGesture: targetContentOffset:| callback is received following a corresponding |-scrollViewWillBeginDraggingWithGesture:|. This is not always the case though, since sometimes the begin dragging signals is not sent if the drag begins at the same time as WKWebView events like page loads or navigations. This CL removes the DCHECK and updates FullscreenModel to send the FullscreenModelObserver::FullscreenModelScrollEventStarted() callback when |scrolling_| is set to true, which occurs when the scroll view is either dragging or decelerating. This allows for this callback to be handled even if the drag begin callback was skipped. Bug: 1001872, 1048010 Change-Id: I6dec6280ba738ecdd4eb035e1133bae7fe7868ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057809 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#741691}
-
Toni Barzic authored
For test that test home button specifically, for the button to be shown by setting an accessibility feature that overrides shelf navigation buttons hiding in tablet mode. For others, use GoHome instead of tapping home button to trigger logic if the feature to hide the buttons is enabled. BUG=1051714 Change-Id: I843d3c537df05835682b67aa71a54fa39ef6f99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057594Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741690}
-
Chris Lu authored
FullscreenWebViewResizer's |-updateForCurrentState| is only called in response to webview's frame KVO, but it also needs to be called when the toolbar heights are changed since it changes the visible viewport. Fixed: 1039658 Change-Id: Ib1afae58facfa85c358df0fc20f1aac7a2337acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052247 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#741689}
-
Hiroki Sato authored
This CL adds a new accessibility private API where extensions will be able to listen a ChromeEvent which is dispatched when TalkBack state in ARC accessibility gets changed. Android side change is http://ag/10260750. Bug: 981964 Test: unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Change-Id: I9012e9761d3995bd686c2651ecc9921ed8fc15e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037187Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#741688}
-
Sylvain Defresne authored
As a first step towards using Firebase via the internal framework, and thus removing the dependency upstream on Firebase, add a method to AppDistributionProvider to initialize Firebase. Bug: 1049042 Change-Id: Ifbbb211b844eeb564462586755f66913a01d5bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057750 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#741687}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f4ab98d1264..bb7534ee99ce git log 9f4ab98d1264..bb7534ee99ce --date=short --first-parent --format='%ad %ae %s' 2020-02-14 ynovikov@chromium.org Use ASSERT() instead of assert() when possible. Created with: gclient setdep -r src/third_party/angle@bb7534ee99ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I1fbf495549351ec9fd513c3b5fc2d759af1ee9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741686}
-
Yuichiro Hanada authored
This CL rewrites RewriteMouseWheelEvent to use new API. Bug: 1049489 Test: unit_tests Change-Id: I97aa14f7b51cd7c5d07125abe74848fa1b445e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055948 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#741685}
-
Scott Violet authored
Chromedriver is responsible for writing the flags file, so there is no need for run_android_wpt to do it. BUG=1049426 TEST=none Change-Id: Ib77b06756a9e6ea6c35995e4ea86a0476f9630bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056754 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741684}
-
Daniel Clark authored
Prior to this change the picker indicator element (the element inside the control's text box that can be clicked on to open the popup) for date, time, datetime-local, week, and month input controls all had an aria-label of "show date picker". This change updates the picker indicator's aria-label for each of these control types so that it actually corresponds to the control type ("show time picker", etc). Bug: 1026537 Change-Id: Id93ea60e6481d3996b5c663ff8b1a3baf703a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052608Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741683}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/149341bb048d..38e9e47300ac Created with: gclient setdep -r src-internal@38e9e47300ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifa2dafb594a4ced4daf266bff20549e5431c5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741682}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ieda03af232a15869edd2e252ea2d38475b36881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058029Reviewed-by:
-
Jarryd authored
Match origin string representations on the SiteDetails pages with how they are represented on the AllSites page by displaying host only, except in cases where a non-default scheme or port is used. Bug: 997258 Change-Id: I17fda8124f9d4ac3dade15889f65e0a32f111b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043862 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741680}
-
Caleb Rouleau authored
Per https://groups.google.com/a/google.com/g/chrome-speed/c/J1O_3GXF00Q and https://docs.google.com/document/d/1ntZVHyapCVuNMDjbEblI7za7GX_T96oV-FSmKtrEefA/edit#heading=h.a0tfb17lbj4z Turn off benchmarks that do not explicitly opt in to run on Win 7 Perf, Win 7 Nvidia GPU Perf, and Nexus 5. Also I fixed a bug in bot_platforms.py to make it more usable for this and fixed the sharding script deschedule command to additionally work for executables (gtests), not just benchmarks. I ran the following two commands after making the code changes to generate the autogenerated files: ./generate_perf_sharding.py deschedule ./generate_perf_sharding.py update-timing --filter-only Note that after this change these platforms will become extremely unbalanced. I will reshard them this weekend to reduce the potential culprit list if there is a silicon-lottery related regression as low as possible. Note that it turns out that passthrough_command_buffer_perftests and validating_command_buffer_perftests were only scheduled on the Win 7 Nvidia GPU Perf bot. Since they were not opted in, they became removed from all bots. I sent an email directly to the owners of those executables to ask them if they wanted those executables scheduled on the win 10 perf bots. Bug: 1030840 Change-Id: I66b282ec9a312f58c822c3f06a9f845226b6ce20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056564 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741679}
-
Alex Cooper authored
When run in parallel, the test can sometimes fail complaining that "device.mojom.Gamepad" is not a constructor; however, this does not seem to repro when run indepdently. Changing this to use a map with the appropriate default properties set seems to fix this issue when run in parallel. Fixed: 1052539 Change-Id: I24877e8bad709abda69e13b94455a174a100c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058005 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741678}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b444ec4d1fa9..05676f7bc238 git log b444ec4d1fa9..05676f7bc238 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 iapres@microsoft.com Reland: Ensure arcTo (SVG) ends at the targeted point 2020-02-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-14 khushalsagar@chromium.org images: Fix fuzzer crash for creating raster SkImage with invalid data. 2020-02-14 reed@google.com Defensively reset aa[] value when we call a blitter repeatedly Created with: gclient setdep -r src/third_party/skia@05676f7bc238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1001768,chromium:1050445 Tbr: stani@google.com Change-Id: Ia095d229a95165fda0549f9c40c02a7c40febb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058023Reviewed-by:
-
Yuichiro Hanada authored
This CL changes RewriteMouseButtonEvent to use the new API. Bug: 1049489 Test: unit_tests Change-Id: Id06008eae4073bb072a3d07b0ce1c7b825c53eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043614 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741676}
-
Oksana Zhuravlova authored
This change replaces InterfaceProvider references with BrowserInterfaceBroker in the context of interfaces exposed by the browser. Change-Id: I6ee3e4b97cfd84a4c0fdc9fd968ea9184b15a306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057943Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741675}
-
Jarryd authored
Adds calls to QuotaManagerProxy::NotifyWriteFailed() where write errors might occur in IndexedDB code. With this information, the quota system can reasonably guess if the disk storing the user's profile is out of space, and decide if any actions should be taken from there. Bug: 997258 Change-Id: Ifd7ea5c129a8467e47676a5d9ab157ef2015daea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029308Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#741674}
-
Reilly Grant authored
The BarcodeDetector, FaceDetector and TextDetector APIs will be released individually. This change creates separate runtime enabled feature flags for each to allow this staggered release. BarcodeDetector is marked stable for launch. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/j-PLtssE5fo/budv_U6fCwAJ Bug: 659138 Change-Id: I880ac0d4a619e907b7e310b514f082b470bfad14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717915 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#741673}
-
Avery Musbach authored
The present CL revises a comment about why after the split view drag indicators are updated, the bounds of the virtual desks bar may need to also be updated. It involves "the top splitview guidance indicator," which exists only in tablet mode, because clamshell split view is always horizontal. It is important to understand that the code only matters in tablet mode. That is why the code calls MaybeUpdateDesksWidgetBounds only on the overview grid with the dragged item. Bug: None Change-Id: I3f0db698c631021e37a740f4927768d253d55ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056567Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741672}
-
Alex Cooper authored
Currently the test code only sends the stage parameters as Display Info updates. Now that WebVr has been removed, this code path is one that is being considered for removal. The real runtimes utilize both this VRDisplayInfo update path as well as updating the stage parameters with frame data. This changes the test runtime to do the same (i.e. send up stage parameters via both DisplayInfo and FrameData). Fixed: 983363 Change-Id: I3c0a3f59b97163c3ac3b8f4b6529183142688d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056501 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Eugene But authored
Notable changes: - Log SecurityChange #mixed if page has mixed content - Log SecurityChange #broken if response has bad SSL cert - Do not log anything for other cases as it's not useful for finding steps Bug: 2056565 Change-Id: Ieb7ce2f597eb0fb04680495b152d667fa3570a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057756 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741670}
-
Xing Liu authored
Since Android Q sdk is the default sdk now, we don't need to put this function in downstream. This CL deletes the function in AppHooks. This CL needs to land after the downstream deletion is landed. Bug: 1051183 Change-Id: I7add5c31e576b476b48b58e99b143f819eafbdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050095Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741669}
-
Alex Cooper authored
Fixed: 1041009 Change-Id: I835439aac1c06ab0c5a96cd01dffcac819a49f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056762Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741668}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8efb37a5fa93df767c7a4d1734e45181149b4b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057742Reviewed-by:
-
Min Qin authored
This has already been enabled at 100% through finch. So defaulting it to enabled. BUG=988562 Change-Id: I7f27b919df38a0ce50e13851cac73830493ce905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055760Reviewed-by:
-
Daniel Rubery authored
This CL adds the filename to deep scans. This is useful for the server to get a suggested file type. Bug: 1052534 Change-Id: I061add07d4031c1e11c141c6ad9550c691bb0223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057086Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#741665}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4243361bbb6..851532894fe9 git log c4243361bbb6..851532894fe9 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 ehmaldonado@google.com git-cl: Use scm.GIT.{Get,Set}BranchConfig and {Get,Set}BranchRef instead of git calls. Created with: gclient setdep -r src/third_party/depot_tools@851532894fe9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051631 Tbr: agable@chromium.org Change-Id: I98eb0e725aec9e733a7ad38bed73bb2e4d6fb55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057731Reviewed-by:
-
David Black authored
This CL also adds the logic to send the corresponding server-side experiment ID when the client flag is enabled as response processing v2 relies upon synced client and server changes. Rough design linked in bug. Bug: b:129411551 Change-Id: I106d319218a8f051651e6bdc4d0e796ab8df4897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057637Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#741663}
-
- 14 Feb, 2020 8 commits
-
-
Scott Violet authored
This matches what content_shell does. BUG=1052488 TEST=covered by wpt Change-Id: I984e96fe68929999a8ce09c37cfaaa8b0cb06dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056761Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741662}
-
Tom Anderson authored
The machines are on chromium.linux, not chromium.fyi, so the "read test spec" step on the bots read the wrong chromium.*.json file and do not run any tests. After this change, tests should hopefully start running. Change-Id: Idbdeccb297ad9b68fd2293b11864b891c7cfa57b Bug: 1043896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057626 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#741661}
-
Oksana Zhuravlova authored
This change moves the initialization of BackgroundSyncNetworkObserverAndroid to a later stage in the BackgroundSyncManager startup. This avoids creating the BackgroundSyncNetworkObserverAndroid::Observer instance unnecessarily for WebView which does not support BackgroundSync. Change-Id: I181ac886a336a4b32301a0b5790f1ed2963c4f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052265Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741660}
-
Manu Cornet authored
Bug: 1050788 Change-Id: If84dbdcc893385d77bd68f09fcaf9a94d7f6aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057641 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Bug: 537081 Change-Id: Id3f07a52fd4aa87a57b29b9ee8119568bd4e6844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057113Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741658}
-
Yuichiro Hanada authored
This CL should not cause any behavioral change. Bug: 1049489 Change-Id: I5cdddae9581215840195cf49906f4c76a340a381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056503Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#741657}
-
Jinsuk Kim authored
App menu should be accessible if preview tab is in peek (open) state. This CL fixes that. Also takes care of find toolbar in consequence of the fix so that the preview tab can get closed if the toolbar appears. Bug: 1050441 Change-Id: I5ccc3a53c89630eadf5db784105e65c2397862b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048603Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3b3069e9b4a3..657c0f420df0 git log 3b3069e9b4a3..657c0f420df0 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 dproy@chromium.org [trace viewer] Fix test runner under polyfill 2020-02-14 dproy@chromium.org [results.html] Add webcomponents v0 polyfill to results.html Created with: gclient setdep -r src/third_party/catapult@657c0f420df0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: skyostil@google.com Change-Id: I368059cd4833730cce08dba62575e9a8143e2b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057734Reviewed-by:
-
