- 27 Oct, 2014 40 commits
-
-
sclittle authored
This fixes the failing CORS bypass telemetry test for the data reduction proxy. The CORS bypass test doesn't need to care what kind of bypass was caused, just that the CORS request was bypassed. Also made VerifyProxyInfo resilient to the actual and expected proxy lists being ordered differently. BUG=423916 Review URL: https://codereview.chromium.org/663333004 Cr-Commit-Position: refs/heads/master@{#301472}
-
mikecase authored
The ChromeShellSyncTest tests have been running on some of the chromium-fyi android bots. The tests have passed consistently for several days and I am now moving them to run with the rest of the instrumentation tests. BUG=406538 Review URL: https://codereview.chromium.org/680573004 Cr-Commit-Position: refs/heads/master@{#301471}
-
sclittle authored
Currently, if there are no bad proxies, IsProxyBypassed will cause a runtime error. This change makes it return (False, []) as expected. BUG=427666 Review URL: https://codereview.chromium.org/664483004 Cr-Commit-Position: refs/heads/master@{#301470}
-
mariakhomenko authored
BUG=324043 Review URL: https://codereview.chromium.org/676053002 Cr-Commit-Position: refs/heads/master@{#301469}
-
oshima authored
Add mojo_system_unittest back to valgrind bots, which was removed by accident in https://codereview.chromium.org/681493003 R=jamesr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/683493004 Cr-Commit-Position: refs/heads/master@{#301468}
-
avi authored
BUG=407376 TEST=none Review URL: https://codereview.chromium.org/683563003 Cr-Commit-Position: refs/heads/master@{#301467}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=pkasting@chromium.org Review URL: https://codereview.chromium.org/680053003 Cr-Commit-Position: refs/heads/master@{#301466}
-
tiago.vignatti authored
This CL renames KeyEventConverterEvdev to EventConverterEvdevImpl, adding mouse support there. It adds converter for mouse events that handles move and button events. This is useful for simple mouse testing and also systems that don't want the complexity of gestures library. I don't have a multipurpose input device just like described in crbug.com/412996, but I believe this benefits the needed changes towards that goal as well. BUG=412996 TEST=Run chrome target on DRI platform on non-CrOS. Review URL: https://codereview.chromium.org/677113002 Cr-Commit-Position: refs/heads/master@{#301465}
-
Antoine Labour authored
This reverts commit b1dfa83e. Broke Linux ChromiumOS Ozone Tests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/5338/steps/interactive_ui_tests/logs/stdio TBR=gusfernandez@chromium.org BUG= Review URL: https://codereview.chromium.org/682853002 Cr-Commit-Position: refs/heads/master@{#301464}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 R=jianli@chromium.org Review URL: https://codereview.chromium.org/684543002 Cr-Commit-Position: refs/heads/master@{#301463}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=wolenetz@chromium.org Review URL: https://codereview.chromium.org/661163004 Cr-Commit-Position: refs/heads/master@{#301462}
-
scheib authored
ContentSettingsHandler is now made aware of Off The Record profiles and will observe them as well, correcting bugs where changes from the settings webUI would function incorrectly. This is a rework of a previously landed fix [fix] which was reverted due to a crash bug [crash] when OTR profiles already existed before settings were opened. [fix] https://codereview.chromium.org/585953003 [crash] https://code.google.com/p/chromium/issues/detail?id=417597 BUG=425079, 418931 Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c Cr-Commit-Position: refs/heads/master@{#301273} Review URL: https://codereview.chromium.org/676083003 Cr-Commit-Position: refs/heads/master@{#301461}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/dbee270..bdffb34 TBR=leviw@chromium.org,yurys@chromium.org Review URL: https://codereview.chromium.org/678083002 Cr-Commit-Position: refs/heads/master@{#301460}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Review URL: https://codereview.chromium.org/661033006 Cr-Commit-Position: refs/heads/master@{#301459}
-
gunsch authored
R=lcwu@chromium.org BUG=None Review URL: https://codereview.chromium.org/673883004 Cr-Commit-Position: refs/heads/master@{#301458}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=rch@chromium.org Review URL: https://codereview.chromium.org/678073004 Cr-Commit-Position: refs/heads/master@{#301457}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=msw@chromium.org Review URL: https://codereview.chromium.org/680023003 Cr-Commit-Position: refs/heads/master@{#301456}
-
danakj authored
Revert of Optimize QuadF's PointIsInTriangle function (patchset #3 id:40001 of https://codereview.chromium.org/458173002/) Reason for revert: Caused perf regressions: https://code.google.com/p/chromium/issues/detail?id=404968 Original issue's description: > Optimize QuadF's PointIsInTriangle function > > PointIsInTriangle() is still the hotspot of many CSS animation cases.Take Nexus10 with latest chromium build for example: > 4.0% case: poster-circle.html > 1.5% case: morphing-cubes.html > > This patch changes the algorithm of testing "Point In Triangle". > 1. Using double-precision float point. > 2. A much readable algorithm. > 3. Better performance due to remove 2 div operation > > R=danakj@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290290 TBR=kui.zheng@arm.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/682793003 Cr-Commit-Position: refs/heads/master@{#301455}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=sievers@chromium.org Review URL: https://codereview.chromium.org/682743002 Cr-Commit-Position: refs/heads/master@{#301454}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=yoz@chromium.org Review URL: https://codereview.chromium.org/667153007 Cr-Commit-Position: refs/heads/master@{#301453}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=pauljensen@chromium.org Review URL: https://codereview.chromium.org/663043004 Cr-Commit-Position: refs/heads/master@{#301452}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thestig@chromium.org Review URL: https://codereview.chromium.org/672413003 Cr-Commit-Position: refs/heads/master@{#301451}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=jyasskin@chromium.org Review URL: https://codereview.chromium.org/685503002 Cr-Commit-Position: refs/heads/master@{#301450}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=sky@chromium.org Review URL: https://codereview.chromium.org/679233002 Cr-Commit-Position: refs/heads/master@{#301449}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=avi@chromium.org Review URL: https://codereview.chromium.org/678073003 Cr-Commit-Position: refs/heads/master@{#301448}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=avi@chromium.org Review URL: https://codereview.chromium.org/681873003 Cr-Commit-Position: refs/heads/master@{#301447}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Review URL: https://codereview.chromium.org/686493002 Cr-Commit-Position: refs/heads/master@{#301446}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=ben@chromium.org Review URL: https://codereview.chromium.org/677563004 Cr-Commit-Position: refs/heads/master@{#301445}
-
prasadv authored
BUG=419297 NOTRY=true Review URL: https://codereview.chromium.org/676403005 Cr-Commit-Position: refs/heads/master@{#301444}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/13f701a..5f6094a CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=hcm@google.com Review URL: https://codereview.chromium.org/679973004 Cr-Commit-Position: refs/heads/master@{#301443}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=avi@chromium.org Review URL: https://codereview.chromium.org/677413004 Cr-Commit-Position: refs/heads/master@{#301442}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Review URL: https://codereview.chromium.org/681753004 Cr-Commit-Position: refs/heads/master@{#301441}
-
dcheng authored
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Review URL: https://codereview.chromium.org/684483002 Cr-Commit-Position: refs/heads/master@{#301440}
-
ananta authored
Ensure that the main window does not render as deactivated when the link disambiguation bubble is displayed. This uses the existing framework in the BubbleDelegate to disable inactive rendering in the active widget when the bubble is displayed, etc. Inactive rendering is enabled when the bubble is dismissed. Changes in this patch are to pass the active widget to the LinkDisambiguationPopup class when it is created to display the bubble. This class then passes the contents view to the actual bubble. BUG=421020 Review URL: https://codereview.chromium.org/680643002 Cr-Commit-Position: refs/heads/master@{#301439}
-
afakhry authored
Selecting an app window from the overview mode maximizes the window only if it's maximizable. A change proposal to fix the below 2 bugs: - crbug.com/424710 - crbug.com/424708 R=oshima@chromium.org BUG=424710,424708 TEST=Manual & athena_unittests @ OnSelectWindow Review URL: https://codereview.chromium.org/668513003 Cr-Commit-Position: refs/heads/master@{#301438}
-
xiyuan authored
- Bring back kiosk update url in device local account policy; - Use the update url from policy to initialize kiosk cache; BUG=345123 TEST=KioskEnterpriseTest.PrivateStore Review URL: https://codereview.chromium.org/676913002 Cr-Commit-Position: refs/heads/master@{#301437}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/433f657..dbee270 TBR=leviw@chromium.org,yurys@chromium.org Review URL: https://codereview.chromium.org/682723002 Cr-Commit-Position: refs/heads/master@{#301436}
-
egdaniel authored
BUG= Review URL: https://codereview.chromium.org/680903002 Cr-Commit-Position: refs/heads/master@{#301435}
-
vmpstr authored
This patch ensures that picture pile base is thread safe, since it is not guaranteed that the ref is always adjusted on the same thread. In particular, the worker thread (which refs picture pile on the cc thread) might deref it (and delete it) on the worker thread. R=reveman Review URL: https://codereview.chromium.org/683543002 Cr-Commit-Position: refs/heads/master@{#301434}
-
reveman authored
Allocation of GpuMemoryBuffers requires a round-trip to the browser process and by moving this to worker threads it is no longer on the critical path on the compositor. The LockForWrite mechanism in the ResourceProvider has been adjusted to properly support worker thread allocation of resources. BUG=418553 Review URL: https://codereview.chromium.org/645943002 Cr-Commit-Position: refs/heads/master@{#301433}
-