GitLab

This is to roll crrev.com/c/2096056

Bug: 1059167
Change-Id: I9f73acad1b1109406144a347d7e5e94da54285ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094923Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748670}

Since UpdateClient::Install now takes a repeating callback to
convey state changes, the updater can use this callback mechanism
instead of observer events.

Also, fixed the second parameter for the ctor, which imo, it was
confusing. A ctor decl like Ctor(param, callback) may indicate to
the reader that the ctor is handled in a non-blocking manner.
In this case we are talking about, it is the InstallApp call
which is non-blocking:

void InstallApp(const std::string& app_id,
                base::OnceCallback<void(int)> callback);

I made the InstallAppController ref counted thread safe, since the
class is shared among different threads of execution, and it is
more correct to be declared this way.

There is no corresponding component state for the COMPONENT_WAIT
event, so at one point we may do something about the state machine,
or come up with a different way to receive this, or just ignore.

Bug: 1059938
Change-Id: Ib27f7fed50e5513a974bef1c74c6eac6827935fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095866Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748669}

https://chromium.googlesource.com/angle/angle.git/+log/e18f749d97e8..4f10b113a191

git log e18f749d97e8..4f10b113a191 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 6861ea4e10a1..343d4f6f1870 (3 commits)
2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 97484d689869..014968c3b6b3 (11 commits)

Created with:
  gclient setdep -r src/third_party/angle@4f10b113a191

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: Idc21565c35b6bcff4bda278f889803a3e03f4b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096081Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748668}

This reverts commit b0fc3d10.

Reason for revert: Pixel_Video_Context_Loss_VP9 has begun failing on all Android platforms

Original change's description:
> Remove expected leftover minidumps
> 
> Removes expected leftover minidumps from several tests that
> intentionally crash a Chrome process. This is so that these
> intentional crashes are not caught as failures once pre/post test
> minidump checking is enabled with crrev.com/c/2090590.
> 
> Bug: 1056235
> Change-Id: Iad026563b3a7acfc6e2078ffec36a000ed4b2dec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080863
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748433}

TBR=kbr@chromium.org,bsheedy@chromium.org

Change-Id: Ie3903e7c61b4731ffa6ede93866d4105e1c0aec9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1056235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096775Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748667}

This reverts commit a3520fb4.

Reason for revert:
multiple build bots are failing to compile, see crbug.com/1060155.

Original change's description:
> Move //chrome/lib/lifecycle/ to //chrome/browser/android/
> 
> Patchset 1 of 3 to introduce new target and switch upstream dependencies.
> Patchset 2 will update downstream build targets.
> Patchset 3 will remove the old //chrome/lib/ directory.
> 
> BUG=1052382
> 
> Change-Id: Ia17859f630003eded43ee1b928e8ddc2ab22814e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095444
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748553}

TBR=yfriedman@chromium.org,dtrainor@chromium.org,twellington@chromium.org

Change-Id: Ia87cdc63156402445b313a1a80bb2bd79af9eef1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096755Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748666}

Before this patch, payment_app_provider_impl.cc wrote out
payments::mojom:: prefix for every type it used from that namespace.
This made reading and writing code in this file cumbersome.

This patch places several "using payments::mojom::XYZ" statements at the
top of the anonymous namespace in payment_app_provider_impl.cc and
removes payments::mojom:: prefixes throughout the rest of the file.

After this patch, the majority of payment_app_provider_impl.cc omits the
payments::mojom:: prefix, which makes reading and writing code in this
file easier.

Bug: 1005076
Change-Id: If44010e2bb0f3aea364742a4b28395a650e1a25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089963Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748665}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ca9e417e03e..aafa9b5c733c

git log 3ca9e417e03e..aafa9b5c733c --date=short --first-parent --format='%ad %ae %s'
2020-03-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-03-10 szuend@chromium.org [utilities] Inline Promise#catchException at all use-sites
2020-03-10 jacktfranklin@chromium.org Extend GRDP tooling with TypeScript support
2020-03-10 tvanderlippe@chromium.org Fix input for build_release_applications
2020-03-10 szuend@chromium.org [utilities] Move loadXHR to its only use-site in ResourceLoader.js
2020-03-10 szuend@chromium.org [utilities] Use Set instead of Array in ResourceTreeModel
2020-03-10 szuend@chromium.org [utilities] Replace Array#remove with helper in WatchExpressionsSidebar
2020-03-10 szuend@chromium.org [utilities] Replace Array#remove with helper in ApplicationPanelSidebar
2020-03-10 jacktfranklin@chromium.org Exclude `front_end/third_party` from GRDP file checks
2020-03-10 tvanderlippe@chromium.org Add e2etest for forcing pseudo states

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@aafa9b5c733c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1046596,chromium:1050549,chromium:1060003,chromium:1060009
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5e67c1e7fc5b59d89c71c873cdb5cdf9692dc013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748664}

Adds a test to prevent regression of crbug.com/1039228

Bug: 1039228
Change-Id: Ia8735b233288c22d5b96f7022fa272f710b07cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082915Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748663}

Chrome now successfully builds with ToT Clang after
crrev/9243da16.

Bug: 1059231
Change-Id: I5208e0c6d5990146e28ef57617038430a4b3a310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095705
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748662}

This changes the |type| field of the result to |userAgentSpecificType|
that contains a list of memory types instead of a string.

Bug: 1049093
Change-Id: I313135f8c23f6a7cd00d0861bdd9ef9017846d40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096444Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748661}

Change-Id: I378d8444ed8d0526ce1b34983167579e7441aceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094313
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748660}

This CL removes the animation of the content offset of the TabGrid which
allows the selected tab to be at the top of the collection.
When BVC is presented the animation isn't seen. When it is contained,
the animation was creating a visible glitch.

Fixed: 1056611
Change-Id: I8b32e8191c413e368f75c88dce1fee0665f6d075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095722Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748659}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2572b81df7cb..391bb28f91a4


Created with:
  gclient setdep -r src-internal@391bb28f91a4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ibd66ec87f5236cba1979ce2fbd4547d60e7219aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096080Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748658}

<span> elements with no text context don't need aria-hidden attribute.
ChromeVox ignores them (they're empty), and skips to the next <button>
on Tab key advance as expected.

Tbr: Luciano
Bug: 1035691
Change-Id: If561ae6a0a5733c8c6b6a91e22ec0f9fd095fbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094867Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748657}

This removes the relationship between the opener and opened window
during a Cross-Origin-Opener-Policy(COOP) triggered browsing instance
swap, as described in [1].
Which is done by:
- Keeping the |require_coop_browsing_instance_swap| boolean beyond the
navigation request scope as it is needed after its destruction.
- Removing render frame proxies to unrelated site instances within
CommitPending, after the creation of the swap out proxy.
- Deleting the |FrameTreeNode::opener_| (setting it to nullptr).

Most of the WPTs expectations were removed, except for the
CrossOriginIsolated bit which is not implemented yet. This required a
few changes to the tests (mainly common.js) as the change of the window
proxy may be delayed until the previous render frame is unloaded. Which
might take some time since several tests are run in parallel.
This can become immediate by addressing the TODO in [2], but this has
side effects that are not well understood yet.

Some tests are also crashing due to specificities of the test code,
which is being addressed in https://crrev.com/c/2074482.

[1] https://docs.google.com/document/d/1M9dYuKpUMVxWfufhJFPpdAR0rbDVQIYe-YFZWsfs9VQ/edit#heading=h.8uxfgpakgc0
[2] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/render_frame_proxy_host.cc;drc=70a2e4eb2bce58d4817b538f0249afb366245dda;l=121?originalUrl=https:%2F%2Fcs.chromium.org%2F

Change-Id: I2b69af8b20035a4b5d6f99795b4a05c4548da728
Bug: 922191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062335
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748656}

Migrate immediate task antistarvation logic from
|chose_delayed_over_immediate| to explicit chose_delayed &&
has_immediate.

This reduces the confusion as we actually never select
delayed tasks over immediate, only immediate tasks over delayed.

R=shaseley@chromium.org
CC=skyostil@chromium.org

Change-Id: I2aad35f9e511293864a24849e74e1eae9bed7cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093602Reviewed-by: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748655}

Reason for reland: Fixed MSAN test failures caused by an unitialized
member variable

Original change's description:
> Block execution in ~HangWatchScope() when a hang is in progress
>reland
> This gives morelandre actionable hang reports as it allows to keep the
> execution from advancing to unrelated parts of the code when we
> are in the progress of capturing a hang.
>
> Bug: 1034046
> Change-Id: Ie4d5f31515fec829c527cf92ee9f723e5f940f5f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068450
> Commit-Queue: Oliver Li <olivierli@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745775}

Bug: 1034046
Change-Id: Ib8f459754dfac9455cbdb03eefc42a5769395d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095217
Commit-Queue: Oliver Li <olivierli@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748654}

This reverts commit fbc23470.

Reason for revert: This CL was not the cause for a test failure. crbug.com/1060068

Original change's description:
> Revert "Changed infinite iterations's representation from -1 to infinity()."
> 
> This reverts commit b5046a36.
> 
> Reason for revert: system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:tech:discourse_infinite_scroll:2018
> is failing.
> 
> Original change's description:
> > Changed infinite iterations's representation from -1 to infinity().
> > 
> > In blink we use -1 to represent infinite iterations for historical
> > reasons. Rather, we should use std::numeric_limits<double>::infinity()
> > to be more specification-complaint.
> > 
> > CL based on crrev.com/c/1373409.
> > 
> > Bug: 913662
> > Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100
> > Reviewed-by: Ian Vollick <vollick@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Yi Gu <yigu@chromium.org>
> > Reviewed-by: Daniel Libby <dlibby@microsoft.com>
> > Commit-Queue: Annie Liu <t-hunliu@microsoft.com>
> > Cr-Commit-Position: refs/heads/master@{#748383}
> 
> TBR=vollick@chromium.org,majidvp@chromium.org,yigu@chromium.org,dlibby@microsoft.com,t-hunliu@microsoft.com
> 
> Change-Id: Ic85093b6bb9f0d15a45cf65dbefa410e66b43346
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 913662
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094489
> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748545}

TBR=vollick@chromium.org,majidvp@chromium.org,yigu@chromium.org,dlibby@microsoft.com,jshikaram@chromium.org,t-hunliu@microsoft.com

Change-Id: I210fef12f134e195d5538e89e74b01c1ca8d690f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 913662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094869Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748653}

https://android.googlesource.com/platform/external/perfetto.git/+log/da7205379701..2663ead23f9a

git log da7205379701..2663ead23f9a --date=short --first-parent --format='%ad %ae %s'
2020-03-09 primiano@google.com probes: cleanup handling of ProbesDataSource

Created with:
  gclient setdep -r src/third_party/perfetto@2663ead23f9a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:141917389,chromium:150960749
Tbr: perfetto-bugs@google.com
Change-Id: Ie57f92fb52e6ac13dbdbe6c638cd1b4318ffdbde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096079Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748652}

Bug: 1060129
Change-Id: Ic04b6aa906d939a924bb8488481c4f669b849a21

TBR=sky@chromium.org,jameshollyer@chromium.org

Change-Id: Ic04b6aa906d939a924bb8488481c4f669b849a21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095594
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748651}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c027048d88b..dd3d91691f1e

git log 4c027048d88b..dd3d91691f1e --date=short --first-parent --format='%ad %ae %s'
2020-03-09 jbolz@nvidia.com Allow sampledimage types as operand of OpCopyObject (#3222)
2020-03-09 vasniktel@gmail.com spirv-fuzz: Remove duplicated functionality (#3220)
2020-03-09 andreperezmaselco.developer@gmail.com spirv-fuzz: Allow OpPhi operand to be replaced with a composite synonym (#3221)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@dd3d91691f1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com
Change-Id: Ib9582220d2add51427dda2fc60d627a49692388d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096208Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748650}

This changes the callback from RepeatingCallback to OnceCallback,
and removes the nested callback which was unnecessary and made the code
hard to understand.

Bug: 1041472
Change-Id: If93482c0cfa9e676a0b35712bf545d33b60ada89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094987Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748649}

https://skia.googlesource.com/skia.git/+log/80f8325046b9..fae71fb596d0

git log 80f8325046b9..fae71fb596d0 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 borenet@google.com [infra] gen_tasks: fix TODOs in usesDocker()

Created with:
  gclient setdep -r src/third_party/skia@fae71fb596d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: brianosman@google.com
Change-Id: I64fc5d1979eaa83ef14ea799dd319dc99b23a139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096078Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748648}

WebStateListObserver::ChangeReason was sometime used as an enum and
sometime used as a list of flags (as reflected by the definition of
the value that are power of two).

As there is no reason to use it as flags (since the values are not
compatible), convert it to a proper enum (without specifying the
individual value of the enumerators). Also convert it to an "enum
class" so that it is not convertible to int types implicitly.

Remove CHANGE_REASON_NONE value since it can never been passed in
a meaningful way (it made some sense when used as a flag since it
could be combined with other) and convert the uses of the constant
to the proper value.

Bug: none
Change-Id: I1a955fd558208cc3d6e108781b407d1a23fa8676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089891Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748647}

Bug: 1015841
Change-Id: I2b9db68ada58615108c459f33bcca258fb5a88d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089868
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748646}

adds a web platform test which asserts that not negotiating
  https://tools.ietf.org/html/draft-ietf-mmusic-sdp-bundle-negotiation
results in different ICE transports.

BUG=1058826

Change-Id: I0c83c1092808d84c8ad876a97b9ba4661b340ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095537
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748645}

Updating the expiration date for the following and related histograms:
Signin.LoadedIdentities.Count
Signin.LoadedIdentities.Duration
Signin.LoadedIdentities.DurationPerIdentity
Signin.SSOAuth.GetIdentities.ErrorCode
Signin.SSOWKWebView.GetAllCookies.CookieCount
Signin.SSOWKWebView.GetAllCookies.Duration
Signin.SSOWKWebView.GetAllCookies.Request

Fixed: 1059821
Change-Id: I1a2c00c62aa21659b6a417882182977346967c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095073
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748644}

Use MediumThick style for permissions and cookie controls.
Use tinted icon to align the cookie controls UI with the permission
UI above.

Screenshot: https://crbug.com/1040091#c22
Bug: 1040091
Change-Id: Ie0d2abced7dc63e8c73de9240444cd4215c81044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091347Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748643}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed60bec01fc7..3ca9e417e03e

git log ed60bec01fc7..3ca9e417e03e --date=short --first-parent --format='%ad %ae %s'
2020-03-10 szuend@chromium.org Add missing SDK import to CSSOverviewPanel.js

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@3ca9e417e03e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7c223a70f4ad0f3aa30a1ff4610cd1ea095b8bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096518Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748642}

This CL adds to chrome://settings/passwords the password check banner
and button when no password check has been done yet.

The CL also adds the banner SVGs in both light and dark mode, ~5k each.
Compressed using avocado (~60% smaller than original files)
(by fhorschig@).

Bug: 1047726
Change-Id: Ic696c5757d09d1ce7ebfa93e62273a67acc90e88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087345
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748641}

Currently, overscroll is disabled when Find In Page + keyboard is active
because it listens to the keyboard notifications. When the keyboard is
inactive or when Text Zoom is active, there is a weird state where the
Find In Page bar is over the toolbar, but after scrolling, the
overscroll view appears under Find In Page.

This CL disables overscroll altogether when something (Find In Page or
Text Zoom) is presented over the toolbar.

Fixed: 1056912
Change-Id: I8eba45621d3f59fd65fd17aa4c810adb397ba14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087755
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748640}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3310ddd30e3b..2572b81df7cb


Created with:
  gclient setdep -r src-internal@2572b81df7cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I23071baa1e95171a60d13ca4d24c49bb864fcf8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096213Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748639}

Bug: 1051856
Change-Id: Iea7cb5bb26d887d48285058676a55b1ab1b47d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085051Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#748638}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/343d4f6f1870..dbb56a1d4859

git log 343d4f6f1870..dbb56a1d4859 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 johnkslang@users.noreply.github.com Merge pull request #2105 from jeffbolznv/nonunif

Created with:
  gclient setdep -r src/third_party/glslang/src@dbb56a1d4859

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com
Change-Id: I98a38f8ea39f2cad4a04c8de60aef28ed0e9d479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748637}

Using wpt-import in Chromium 0b38974f.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"
f21f4b76 "Reland "Origin policy: implement window.originPolicyIds""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I3bf1417972fc944b632a95189ef5990c15f5b359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096377Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748636}

This is a reland of 00861a81

Original change's description:
> VulkanSwapChain: Use VK_KHR_incremental_present for better performance.
>
> Bug: 1059598
> Change-Id: I4ec9ae96b97606d4e64d6ce8874471b00586def8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094235
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748280}

TBR=vasilyt@chromium.org

Bug: 1059598
Change-Id: I4f5154125f5c1a23bd9f696c2ec7223aa8405999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095147Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748635}

https://webrtc.googlesource.com/src.git/+log/137991396d03..a2cb93d8b965

git log 137991396d03..a2cb93d8b965 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 srte@webrtc.org Revert "Wire up internal libvpx VP9 scaler to statistics proxy"

Created with:
  gclient setdep -r src/third_party/webrtc@a2cb93d8b965

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ibd370f0d237e7f64be0cd53b3cf9737a8b00e4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748634}

not supported types.

ParameterSet should throw IllegalArgumentException when we add a
parameter of a type which is not supported in the getAcceptableTypes
method.

However, it throws an ArrayStoreException because the type definition
of ACCEPTABLE_TYPES is of type Set<Class<?>> and when we invoke the
toArray method of the Set class we define the type as String.

This CL fixes that and specifies the correct type which is Class in
the toArray method. It also adds unit tests.

Bug: 1059752
Change-Id: Ia54b0d3acd2e2813a618ad87b97f10a443e64fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093595Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748633}

With https://chromium-review.googlesource.com/c/chromium/src/+/2088343,

SkiaOutputSurfaceImpl::Reshape() can create SkSurfaceCharacterization
on viz thread without waiting on GPU thread Reshape(), so we don't need
the forced Resahpe().

Bug: 1041949
Change-Id: I93030d2c7dca9f66183f661b95868fad957af6e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094252
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748632}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/0ac28472d073..cc958279ffd6

$ git log 0ac28472d..cc958279f --date=short --no-merges --format='%ad %ae %s'
2020-03-10 tikuta client: remove --extra-variable flag from isolate.py
2020-03-03 tikuta client: update isolated
2020-03-02 jbudorick run_isolated: expand list of caches to touch.
2020-02-26 jbudorick run_isolated: touch requested named caches.
2020-02-25 tikuta client: use print to write to stdout
2020-02-19 tikuta client: check retcode of isolated execution
2020-02-18 jwata [swarming] fix tools.clear_cache_all
2020-02-18 tikuta client: increase verbosity during isolated download
2020-02-06 tikuta client: use go isolated in win10 or non-windows
2020-02-04 tikuta client: update isolated
2020-02-03 tikuta client: update oauth2client from 1.5.2 to 2.0.0-post1
2020-01-31 tikuta client: use request_uuid
2020-01-31 tikuta client: apply yapf to client/tests/swarming_test.py

Created with:
  roll-dep src/tools/swarming_client

Change-Id: I97a72e906fd998681f883ee94126148645502bc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096164
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748631}