- 04 Jun, 2020 40 commits
-
-
Yi Gu authored
The test is also flaky on other platforms: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3BvaW50ZXJldmVudHMvcG9pbnRlcmV2ZW50X2NvYWxlc2NlZF9ldmVudHNfYXR0cmlidXRlcy5odG1sDA TBR=lanwei@chromium.org Bug: 1059645 Change-Id: I8563223533cd6445166be5d073f96b3ae013ee56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230321Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775111}
-
Alexander Surkov authored
Bug: 1087929 Change-Id: Icc494291dc1bb611c6522dc725e3267efe4fdaa2 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219283 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#775110}
-
Charlie Hu authored
PolicyParserMessageBuffer has been used in parsing of document policy. It is planned to use it to replace |Vector<String>* messages| to gather messages in feature policy parser as well. Change-Id: Ia0a12305059acd524fe47afba733ee6537b7eb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209816Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#775109}
-
Dominique Fauteux-Chapleau authored
This validates that the service provider set in a Connector policy is recognized and includes the corresponding URL into settings. Bug: 1069049, 1069048 Change-Id: I0486261ae2d329e6f743147eaea88906ff1a64ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220471Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#775108}
-
Geoff Lang authored
NOTRY=true TBR=kbr@chromium.org BUG=angleproject:4684,angleproject:3930 Change-Id: I6582e6c495626e586d6eeb2ad2912e50320933e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230762Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775107}
-
Peter Marshall authored
We are planning to use ephemeral profiles to implement this method in the future, but their creation is async. OTR profiles which are currently used have synchronous creation, which is why this method was synchronous so far. This CL updates the implementation to be async, but does not yet make any other changes. In later CLs we will plumb through the callback to the async ephemeral profile creation. Doc for context: https://docs.google.com/document/d/1fnTD_smbp5vzWTLAuXagVsqm_C5607DPbKcfx6KbCTY Bug: 1086935 Change-Id: I19c72bd002574ba8e6c810f3fff25d974e1f852e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230461Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#775106}
-
Peter Wen authored
Add _java_resource_types, _java_library_types, and _java_leaf_types. These types, together with "group", define all existing invoker.type values for all java targets. Since leaf types like android_apk are not used as dependencies for other java targets, all java targets in deps trees can be defined as either resources, libraries, or groups. Naming conventions have also been improved. Now java targets must match _java_resource_patterns if the target is a resource target. Otherwise, it must match _java_library_patterns if the target is a library target. Group targets can match either of those, but should prefer matching _java_library_patterns since they are treated as library targets in the java_group template. Thus, target filtering is now simplified. To filter for resource targets , simply use _java_resource_patterns. To filter for library targets, use _java_library_patterns and ignore the ones that also match _java_resource_patterns. To filter for any java target, use _java_target_patterns, which is a simple concatenation of the other two lists of patterns. The assert in write_build_config has been updated to enforce naming schemes accordingly. This enables assumptions about library and resource targets such as __header, __impl, and the newly added __assetres, which is defined on library targets to be its transitive list of all resource target deps. Now compile_resources targets can filter their deps so that they only depend on transitive resource deps. This allows compile_resources to not depend on java library targets, and unblocks header generation for apk targets. Previously an apk's __header target would depend on compile_resources to finish, while the compile_resources target would depend on the rest of the java library dependencies (not headers), completely removing any benefit of header compilation for apk targets. Original CL: https://crrev.com/c/2220585 Fixed: - Turns out compile_resources depends on the android sdk, and that was either supplied directly (in the case of android_apk_or_module) or it was supplied by its java dependencies (in the case of junit_binary). - This dependency was broken by replacing java library deps with their corresponding __assetres deps. - Fixed by explicitly specifying android_sdk_dep just like build_config_dep. - Added comments for both of these explicit *_dep variables. Bug: 1090812 Change-Id: I57c63ff805c4e27ff6b47bc69c0a6954b0b681c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231178 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#775105}
-
Gavin Williams authored
These colors are for the CrOS Print Preview printer status icons to indicate the printer's current status. Bug: 1059607 Change-Id: I8c5ebd95aba2154b30b9435ceb1c3ec974c4dec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227904 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#775104}
-
Adam Rice authored
The WebSocketStream origin trial has ended, and we are not planning to run another origin trial. Remove the client-side configuration. BUG=983030 Change-Id: I41fcc1ea793467407429d7afa1a73fba1fcc9910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228376Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#775103}
-
Roman Sorokin authored
* Extend to 2021-01-01 * Transfer (or extend) ownership to raleksandrov@ Fixed: 1088741, 1088740 Change-Id: Ib304c5c6c908f8cd1dbee9e904b840b1d58af86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225900 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#775102}
-
Martin Šrámek authored
...on all platforms. Bug: 1090343 Change-Id: Ie724ebb1235a89e80a3510bed5e0df0b7d78d062 TBR: koerber@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231105Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#775101}
-
Yi Gu authored
The test has been flaky recently. Please see bug for details. TBR=andypaicu@chromium.org Bug: 1090274 Change-Id: If92d3983d0bfb2402bfdfdc27fe5d92e30041d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230759Reviewed-by:
-
Justin Donnelly authored
Change-Id: I743f0fd55842f9f3aa9f3732667cfc950333fab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229464Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#775099}
-
ckitagawa authored
Scroll position isn't accounted for in the clip rect for subframes. It needs to be manually corrected via the tracker when serializing. Bug: 1090920 Change-Id: I93e316016832132cbfdfec833249ed454c060b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228577Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#775098}
-
Pawel Baran authored
Bug: 1084529 Change-Id: I4ce8adcfef38633210de514ff63726abe96ded94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207151Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Paweł Barań <pbaran@opera.com> Cr-Commit-Position: refs/heads/master@{#775097}
-
Boris Sazonov authored
Fixes a crash when supervised_user_google_auth_navigation_throttle would attempt to start reauth without actually checking whether there's a primary account. Bug: 1070576 Change-Id: Ia825e9cc0cc192cbb5ceedbd9e9f9fbd5a0b8438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228161Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#775096}
-
Hitoshi Yoshida authored
Bindings is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in Performance.measure(). Bug: 839389 Change-Id: I248bfe06c143dbfab003b9ba863dc00bb1a033bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224420Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#775095}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2c704cdc7272..8436fb411921 2020-06-04 jacktfranklin@chromium.org Add DOM helpers for testing components 2020-06-04 changhaohan@chromium.org Ungroup same console messages when "Group similar" setting is off If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082963 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51e97b6c15634ec134d0a5bc688571eaa19d957f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775094}
-
Yi Gu authored
TBR=sky@chromium.org Bug: 1091129 Change-Id: I796f65786ebdcf11814e8e028f678fcbf58b59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230279Reviewed-by:
-
Andrew Grieve authored
Bug: None Change-Id: I7f3289980e7fbebf1719098b9e6edd2d47b11c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229998 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775092}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e19a3cec9a49..23708cd50e93 2020-06-04 mtklein@google.com SkRecord cleanup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: Ie4609019432ec773ce0f5fd91ca96f4da58e82c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230885Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebabe5a1eb1e..a437e061d367 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: Ie8b6745b4a22e1851cb01f52642dbe684f90fc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230883Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775090}
-
Xianzhu Wang authored
The CAP compositing algorithm may mark many layers with direct compositing reasons as kOverlap, but we should try to get the actual reason. This is just for testing and debugging. Change-Id: I9a6b707215ed02232ac001a0485987efbca7e2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227261 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775089}
-
Anatoliy Potapchuk authored
This cl will make extensions react correctly in case of arc and web kiosks. Bug: 1086382 Change-Id: I9ceb6ee6170068bd0f43d7b36ba08636a8da6593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215805Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#775088}
-
Roman Sorokin authored
Looks good local Flakes are most likely related to CL:2097795 TBR=antrim@chromium.org Fixed: 1083235 Change-Id: Ic0d3be25a1fe623681a42f45b517a596f51b8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230468Reviewed-by:
-
sandromaggi authored
If we enter STOPPED state, the |ui_delegate_| member is set to nullptr. The UI is not removed at this point, clicking the back button will end here, leading to a hard crash. Bug: b/152954282 Change-Id: I3333f6d6de16f701052fa3d4a494fc07dcd74da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230465 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#775086}
-
Anastasiia Nikolaienko authored
Fix flakiness of OSSettingsPeoplePageAccountManagerTest.AllJsTests. In some tests we override isChild property in JS from false to true, but in C++ we set accountManagerPrimaryAccountChildManagedTooltip string only if is it was initially true. Fix this by adding string to loadTimeData for all users (is user is not child - it's going to be empty). Fixed: 1087207 Change-Id: I20ae9f89bfe6646e74073632f8eafa02950f514d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224262 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#775085}
-
Peter Wen authored
This reverts commit c8827ca3. Reason for revert: compiling android_webview/support_library/boundary_interfaces:boundary_interface_example_apk__compile_resources fails Original change's description: > Android: Improve type filtering, add __assetres > > Add _java_resource_types, _java_library_types, and _java_leaf_types. > These types, together with "group", define all existing invoker.type > values for all java targets. Since leaf types like android_apk are not > used as dependencies for other java targets, all java targets in deps > trees can be defined as either resources, libraries, or groups. > > Naming conventions have also been improved. Now java targets must match > _java_resource_patterns if the target is a resource target. Otherwise, > it must match _java_library_patterns if the target is a library target. > Group targets can match either of those, but should prefer matching > _java_library_patterns since they are treated as library targets in the > java_group template. > > Thus, target filtering is now simplified. To filter for resource targets > , simply use _java_resource_patterns. To filter for library targets, use > _java_library_patterns and ignore the ones that also match > _java_resource_patterns. To filter for any java target, use > _java_target_patterns, which is a simple concatenation of the other two > lists of patterns. > > The assert in write_build_config has been updated to enforce naming > schemes accordingly. This enables assumptions about library and resource > targets such as __header, __impl, and the newly added __assetres, which > is defined on library targets to be its transitive list of all resource > target deps. > > Now compile_resources targets can filter their deps so that they only > depend on transitive resource deps. This allows compile_resources to > not depend on java library targets, and unblocks header generation for > apk targets. Previously an apk's __header target would depend on > compile_resources to finish, while the compile_resources target would > depend on the rest of the java library dependencies (not headers), > completely removing any benefit of header compilation for apk targets. > > Bug: 1090812 > Change-Id: Ic3c254db9f4d1af2182059119718f15b40957ce9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220585 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775081} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: If0ad501bf606e302d49b1573f168417efd182931 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231158Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775084}
-
Saurabh Nijhara authored
Bug: 1048607 Change-Id: I0f2690063077091616de9943177d01eea3f79420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224253 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f7fb830ba42..8b7cfa16aa2f 2020-06-04 mbonadei@webrtc.org Introduce absl_deps in rtc_* C++ templates. 2020-06-04 tommi@webrtc.org Remove dependency from RtpRtcp on the Module interface. 2020-06-04 eshr@google.com Clean resource_adaptation_processor_unittest use of TaskQueueForTest 2020-06-04 danilchap@webrtc.org Add Scalability structure tests for individual frame configurations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1046390 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3013eec78a38942d18c4794aeb807502279ace16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230882Reviewed-by:
-
Peter Wen authored
Add _java_resource_types, _java_library_types, and _java_leaf_types. These types, together with "group", define all existing invoker.type values for all java targets. Since leaf types like android_apk are not used as dependencies for other java targets, all java targets in deps trees can be defined as either resources, libraries, or groups. Naming conventions have also been improved. Now java targets must match _java_resource_patterns if the target is a resource target. Otherwise, it must match _java_library_patterns if the target is a library target. Group targets can match either of those, but should prefer matching _java_library_patterns since they are treated as library targets in the java_group template. Thus, target filtering is now simplified. To filter for resource targets , simply use _java_resource_patterns. To filter for library targets, use _java_library_patterns and ignore the ones that also match _java_resource_patterns. To filter for any java target, use _java_target_patterns, which is a simple concatenation of the other two lists of patterns. The assert in write_build_config has been updated to enforce naming schemes accordingly. This enables assumptions about library and resource targets such as __header, __impl, and the newly added __assetres, which is defined on library targets to be its transitive list of all resource target deps. Now compile_resources targets can filter their deps so that they only depend on transitive resource deps. This allows compile_resources to not depend on java library targets, and unblocks header generation for apk targets. Previously an apk's __header target would depend on compile_resources to finish, while the compile_resources target would depend on the rest of the java library dependencies (not headers), completely removing any benefit of header compilation for apk targets. Bug: 1090812 Change-Id: Ic3c254db9f4d1af2182059119718f15b40957ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220585 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Asami Doi authored
Offline capability check was integrated into the installable manager in https://chromium-review.googlesource.com/c/chromium/src/+/2203571/. This CL adds new browser tests for a website that works well offline. Bug: 965802 Change-Id: I377c736bafd6c9e42308687e5c6c04cc773ab641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223701 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#775080}
-
Friedrich Horschig authored
This CL changes strings according to a recent review. Screenshot for IDS_PASSWORD_MANAGER_RE_SIGNIN_ACCOUNT_STORE: https://storage.cloud.google.com/chromium-translation-screenshots/02eb76ea47b2714778afd441656eac5a8aae3abd Screenshot for both IDS_PASSWORD_MANAGER_OPT_INTO_ACCOUNT_STORE*: https://storage.cloud.google.com/chromium-translation-screenshots/ae2abb47abb0f75ffcbe87ebf59af6841c3ee2d3 Bug: None Change-Id: Ic3f83618741166cae8b8eb96f6eeb4356a212c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230619 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#775079}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/722db7ecd0fb..2c704cdc7272 2020-06-04 szuend@chromium.org [cleanup] Move Date#toISO8601Compact to DateUtilities 2020-06-04 tvanderlippe@chromium.org Revert "Typecheck sdk/SourceMap.js with TypeScript" 2020-06-04 sigurds@chromium.org Export coverage event if the original resource is not available 2020-06-04 bmeurer@chromium.org [wasm] Wasm disassembly cannot be edited. 2020-06-04 tvanderlippe@chromium.org Revert "DevTools: E2E test covering going from perf to sources" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1064206,chromium:1071432,chromium:1079076,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I93f1d052631c5cfbc36ef0612b844c0949be384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231019Reviewed-by:
-
Benoit Lize authored
File creation can fail, and does in fact (see linked bug). Since the file is not needed to continue, remove a CHECK() and continue without it. Bug: 1029320, 1091181 Change-Id: I8fc14299dd6b2a9694b7fdfef12db7e542ece781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230624Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64aa5138c75f..e19a3cec9a49 2020-06-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3ad285a60d82 to 0711869b5f20 (1 revision) 2020-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 295a4177aebc to 783cd5a79c8a (24 revisions) 2020-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 065b0a7f to 2f744540 (474 revisions) 2020-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c1581646c46 to 989c790d4b8b (14 revisions) 2020-06-04 ethannicholas@google.com add missing import for std::atomic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1078378,chromium:1084458,chromium:951458 Tbr: tdenniston@google.com Test: Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_shaders_derivateTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest.OrientedWindow Change-Id: I7c099f58b718adc84e0a31a40df6786607decf4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229546Reviewed-by:
-
Jan Wilken Dörrie authored
This change moves the Windows only code in base/strings/{strcat, string_util, string_split}.h to their own _win.h headers, and introduces appropriate _internal.h headers to be able to share the templated code between Windows and cross-platform code. This change is purely organizational, and there is no functionality added or removed. Bug: 911896 Change-Id: I3d2eae1e665cfcf48e727d6d71ca1975c441a370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228622 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: -
Tanmoy Mollik authored
Enable SyncErrorInfoBar in preparation for release to Stable. Bug: 1046765 Change-Id: Iacf88d41dba2eb7aff6d660cc5354407cc5353d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224266 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Alex Ilin authored
The test checks that the links that suppose to open a new tab work as expected in the reauth dialog. Bug: 1045515 Change-Id: I4abddb7506b0bae209c6865d59cc8b3be4526ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226754 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43a94a305b95..ebabe5a1eb1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I5a63260bee98601d5a229e5ee82846ce10abdacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230881Reviewed-by:
-
