GitLab

Make GetChannelSuffixForDataDir() exist always on linux, to make
it independent of GOOGLE_CHROME_BRANDING. On Linux, disentangle
the logic in that function from GetChannelImpl() and instead
make it call GetChannel(). This makes it automatically do the
right thing in unbranded builds (returning an empty suffix).

This should be behavior-preserving, but if we ever wanted to do
release channels for unbranded builds, this is a tad easier
to do now -- and we have less mode-dependent code.

Bug: 961769
Change-Id: Id9aec641c3468033f8d676c14874a68016493fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887152
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710403}

Many of the portal browser tests have the same steps to run at the
beginning of the test: inject script to create a portal and to navigate
it to a given URL, and then wait for the navigation to finish. We factor
this out into a common function.

We also perform a few small cleanups. We rename the test
ReactivatePredecessor to AdoptPredecessor, since it doesn't actually
reactivate. We increase usage of JsReplace instead of StringPrintf.

Bug: None
Change-Id: Ia1ef41b8138df0189ad3291b76c34be53c291403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885171Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710402}

This reverts commit 667d336e.

Reason for revert: Breaks downstream Android builds.
https://ci.chromium.org/p/chrome/g/internal.client.clank/console

Original change's description:
> Rename gl_test to gpu_tests
> 
> This is to make the name reflect that there aren't just OpenGL tests in
> this executable now, there are WebGPU / Dawn tests too.
> 
> Bug: 1017035
> Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710382}

TBR=zmo@chromium.org,cwallez@chromium.org,jbudorick@chromium.org

Change-Id: I7e1ae7d108568a704f4900261b1f4b318d58b26c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1017035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887665Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710401}

These are not needed on the client and depend on extra chromium generated
classes. This causes an error when trying to build when using the AAR
with blaze.

Change-Id: I36e081039b05023113cfd4f576ede8c8963042d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887233
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710400}

This bug only occurs on iOS 12. The root cause is that, on iOS 13 we
use the dark mode apis to color things in incognito. This means all
colors can be set once and incognito can be changed afterwards and the
colors will update. For iOS 12, the colors are static, so they must be
set after the incognito status is known.

Bug: 1017138
Change-Id: I8084646b07d2bcbf8b48d91b0d7d341a8fb9bece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886684Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#710399}

R=ericrk@chromium.org

Bug: 757605
Change-Id: I8ab28e93a6f7457a66e35399d5ab487f3af22178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885095
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710398}

Since https://crrev.com/701411, restoring a window that was "last active"
and "minimized" when it was closed opens a window that is completely
white. This is because the window is activated but never shown.

This CL ensures that the window that gets activated when restoring a
session is also shown.

Bug: 1018885
Change-Id: I9d01bfb2cafa83df9744bf5c598570ff55252de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884952Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710397}

This patch adds UMA metric with a final number of print servers to
query.

BUG=chromium:1018591
TEST=none

Change-Id: I19f1608b9b60e869c461c1c8a1ffde59c9446ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882811
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710396}

Also fixed test that was exiting early because of no expiration date
instead of getting to the part that crashed.

Bug: 1018744
Change-Id: Id9df8a144f0274e83589bacdb42cb08dc4dbcea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884650Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710395}

Convert the remaining bits in both the browser process and the video_capture
service for the SharedMemoryVirtualDevice and TextureVirtualDevice mojo
interfaces to the new mojo types.

Bug: 955171
Change-Id: Ifdc0071fd9759bad87582aa744aa2b629f61fdf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883512Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710394}

Adding hnakashima@ and myself to OWNERS as we've worked with and
reviewed a lot of util code.

Bug: 995916
Change-Id: Ie6a68d4a883ccea46016617a61ae4de791087dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884518
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710393}

Bug: 914501
Change-Id: Iab146b0f40918ca7f91c9927c9922695050c53f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859678Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710392}

Update policy names from DomainsTo* to URLsTo* to better describe their current functionnality.

Bug: 1017153
Change-Id: Iad038ce5a3c5dc5943a9c5094420e957847662ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884659Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710391}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 1018887
Change-Id: I76a50bc2619e1a76b8d0901efa1ccc24bf204c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885014
Auto-Submit: kylechar <kylechar@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710390}

Bug: 995916
Change-Id: I131f26a52f4cbb7e598e56ba356e847456ae8be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884355Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710389}

Bug: 792504
Change-Id: I05922e5d4eee25da7273bd329cd0c88a729c4a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878068
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710388}

https://boringssl.googlesource.com/boringssl/+log/76918d016414bf1d71a86d28239566fbcf8aacf0..fe37af11a69c88ae5c63c5eb846552237a4fc8e9

Bug: none
Change-Id: I21392e0adddab21b0afa5ea9b278fe4f39205b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876761
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710387}

https://skia.googlesource.com/skia.git/+log/ee08d523f60a..15b40236bd8b

git log ee08d523f60a..15b40236bd8b --date=short --no-merges --format='%ad %ae %s'
2019-10-29 kjlubick@google.com [canvaskit] Add various ImageFilters
2019-10-29 egdaniel@google.com Some cleanup of unneeded code/objects in GrVkPipelineState.
2019-10-29 bsalomon@google.com Reland "Make GrFillInData use SkRasterPipeline"

Created with:
  gclient setdep -r src/third_party/skia@15b40236bd8b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Ia1eda585e3071cdedeb9d30d4372ef4f230f275c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887491Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710386}

Bug: 1017685, 1016367
Change-Id: I355cc71be2fcacd3f2a08124d2ba7ba1af5c61ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886336Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710385}

In case no window is provided

Bug: 1017659
Change-Id: I8184f0c86a6e31711b09e53867d8f015e308117d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883650
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710384}

It was added several years ago but hasn't been used after its first use.
Remove to simplify code.

Change-Id: I9d7a18758b720ebad90624353da83659e68f0112
Bug: 1014162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881983
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710383}

This is to make the name reflect that there aren't just OpenGL tests in
this executable now, there are WebGPU / Dawn tests too.

Bug: 1017035
Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710382}

In r686771, we converted a base::Callback used by printing::PrintManager
for Android printing to a base::OnceCallback. This was incorrect, as
the PrintManager's lifetime is tied to the tab's lifetime. Now printing
for a given PrintManager works the first time, but never again after the
OnceCallback has been called. The callback needs to remain valid for the
duration of the PrintManager's lifetime, so make it a RepeatingCallback.

TBR=vkuzkokov@chromium.org

Bug: 1018377
Change-Id: I367ea2e1850ee67a30ef024da2b93d4cef701f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885001
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710381}

https://chromium.googlesource.com/angle/angle.git/+log/dc883a948e71..287b0a670fbf

git log dc883a948e71..287b0a670fbf --date=short --no-merges --format='%ad %ae %s'
2019-10-29 timvp@google.com Vulkan: Enable forceOldRewriteStructSamplers for all Android ICDs

Created with:
  gclient setdep -r src/third_party/angle@287b0a670fbf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I02df77e279f19891fcef0ccfee2b6710e2bd8cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710380}

This rolls chromite to crrev.com/c/1863321. That picks up a change to how
artifacts in the Simple Chrome SDK cache are stored. Since we add some of
those artifacts to a test target's data deps, we also need to tweak them
a little to conform to the new cache layout.

Bug: 1012981
Change-Id: I5510be69ec38de31b6cedec2b45a182b91275589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884279Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710379}

After crrev.com/c/1866513, sync_startup_tracker_ was never actually set.
Removing it also lets us remove some more dead code.

Bug: 1015805
Change-Id: I4fb4d6b696ba3241d66ca6fd16cfd6d5abfc68e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886892Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710378}

There may be a one-pixel gap between the gradient zone and the arrow
button (not always). It is caused by the rounding error during painting.
The easiest way to fix this is to enlarge the gradient zone by one
pixel. It does not introduce other visual side effects.

Bug: 1018965
Change-Id: Ifceb1310adee0e907ec3fc1ed7e88ea50af2b7fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885092
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710377}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I13101a52bff081033dde355763396152208d0a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887833Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710376}

In
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1883707
the namespace will be changed. Update the test to make sure we don't
break it.

Bug: 1006759
Change-Id: I0c186eb7d2d32d812c646d90b98623bbb54eb1f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881235
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710375}

Remove redundant call to TriggerSyncForModelTypes() after FakeServer has
been extended to issue invalidations, just like the real server does.

Bug: None
Change-Id: Iab3fd66c81c3967fadc5db1209953916c043da6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886864
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710374}

We need to update interface for webxr because of WPT fail.
Update interfaces/webxr.idl (#18891):
https://github.com/web-platform-tests/wpt/commit/ee40b7bdc5a1e62be5b49b298b8d080b3de816b6
I fixed it.

Bug: 1001507
Change-Id: Ibb8d45276a67f5bfe8f6cd443dc95f5a59f0dae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871530Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#710373}

CL produced with ESLint --fix and clang-format.

This is in preparation for turning on the 'prefer-const' ESLint rule for that
folder.

Bug: 72003
Change-Id: I94a6f0ae63da907e552c659325de600b6b3733c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885553
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710372}

This does not appear to be needed anymore.

Bug: none
Change-Id: I299d9e401ea05ec7c67e90b46c571157a27ee291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885172Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710371}

Now that WebVR is gone, we can remove the mojo interfaces that were only
used for WebVR gamepad integration. WebXR has a different way of sending
gamepad data to blink. This paves the way for further cleanup of the
WebXR mojo interfaces.

Fixed:1017856

Change-Id: Ib5e74531f4b48baf168e2ce271f97aa3ee8804ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885131Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710370}

After adding insecure-broken to the DevTools protocol, the
SecurityStateComparator needed to be updated to handle the additional
value. This cl rebaselines and re-enables the test now that the frontend
changes have been submitted (crrrev.com/c/1880092).

Bug: 1008218
Change-Id: Iae4cfa2dd43142ffea695737320cf3dd52aa9692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884353Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710369}

https://android.googlesource.com/platform/external/perfetto.git/+log/0668f3ddd97f..ca687f6e0c70

git log 0668f3ddd97f..ca687f6e0c70 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 primiano@google.com Merge "tools(tmux): fix script argument"

Created with:
  gclient setdep -r src/third_party/perfetto@ca687f6e0c70

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Id1978b3a232d742b1e9fdfe369ba8738f787fb7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886367Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710368}

Target 13.2 for iOS13 beta coverage and target 12.4 for iOS12.

CIPD packages:
  infra_internal/ios/xcode/mac  11b44
  infra_internal/ios/xcode/ios  11b44

Bug: 1018869b
Change-Id: I6ae9bc093a81a0d72a167a1ad9feddbd05d8de11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884658Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710367}

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
Replace use of base::ProtectedMemory with raw function pointers and add
an attribute to disable CFI-icall checking.

Bug: 1018834
Change-Id: I0bc25d3a803c51a5d1d4c06d21925486393b1808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884456
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710366}

This fixes a bug where docked DevTools in PWAs doesn't work (and would
affect anything that attempts to put two WebContents in a PWA).

This function was never implemented because it involved passing a
map of NSView*s over mojo. Since various refactorings, we now have a
ScopedNSViewIdMapping which helps with this.

Starting at the bottom of the change's stack and working to the top:
* Change NativeWidgetNSWindowBridge::SortSubviews to take a
  std::vector of NSView ids, instead of a std::map ranking NSView*s.
  In the function, create the std::map ranking from the std::vector.
* Change the caller, NativeWidgetMacNSWindowHost::ReorderChildViews.
  to build a std::vector of NSView*s, and then from that create a
  std::vector of NSView ids.
  * If the NSView*s do not have an id (that is, if they are not a
    WebContentsView, which only happens in tests), then create a
    temporary remote_cocoa::ScopedNSViewIdMapping to create an id.
* Rename NativeWidgetMacNSWindowHost's SetAssociationForView,
  ClearAssociationForView, and associated_views_ to reflect that the
  "associated views" are a map from views::NativeViewHosts (a subclass
  of views::View) and NSView*s.

Then there is an iffy part of the change
* Allow looking up an NSView's id (the uint64 that is sent over mojo
  to refer to the NSView) from the NSView.
* Arguably, we should change gfx::NativeView to also carry an id
  with it. But that is a too-large-scope change for now.

Bug: 991598, 1017446
Change-Id: I2371d1716f98c2e6223a5db0272984c98c6fa4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885950
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710365}

This CL is lifting the parameterized unittests originally
wrote for windows to a common file to be available to
other platforms.

Test from KnownExpectedFonts will now also run on Linux.
  * Added the test cases for linux.
Test from Glyphs are now running on every platforms.

Adding a matching_glyphs count to font_fallback_linux.cc.
Previously, a default font was returned for a single character
even if it was not matching the character, it was still the
best match. If no codepoints are found, the font is considered
a no match.

Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569
Fixed: 3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710364}