GitLab

Roll Chrome Win64 PGO profile from chrome-win64-master-1610452567-3155f81fa9ef93aecd596b942169049fc68cadb1.profdata to chrome-win64-master-1610463436-2052566ba20716214eb6d7caa0887c28794c37bd.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia675d3f8c545df30f9247eba95d2926525db0c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622813Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#842627}

Bug: 93619, 1148478
Change-Id: I7a7d46dcaa216731741dc9ab9fc83e0ac0598223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623724
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842626}

Saving canvas image from context menu goes through
RenderFrameHost->LocalFrame->RenderFrameHost. This CL
adds a boolean flag to indicate the download is actually from the
context menu save.

BUG=1113770

Change-Id: I404aaa4e11e19744be3fe4d11ac4413beed4c814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616245Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842625}

The goal of this series of patches is to propagate the keychain reload
flag that comes with the identity list update notification from
GCRSSOService.

This flag will be used by AuthenticationService to have a better signal
when the identity list is updated by another Google app (when the flag
is YES), or if the update comes from Chrome user actions.

* crrev.com/i/3513584: Receive the flag from GCRSSOService notification
=>crrev.com/c/2615421: Add support for the keychain reload flag
* crrev.com/i/3470951: Switching FireIdentityListChanged(bool) method
* crrev.com/c/2615538: FireIdentityListChanged() cleanup

Bug: 1097080
Change-Id: I5763ed1127ba1fe1e8e79953bea321803c06953d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615421
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842624}

This has been stable on canary/dev and showed very good results in the
beta experiment: go/isolated-splits-experiment

The plan is to run beta/stable experiments in M89 with isolated splits
disabled to get final numbers.

Bug: 1126301
Change-Id: Ifc6ecbc893241b84db57545381d606a0adb1e963
Binary-Size: Increase is unavoidable and comes from symbols being
Binary-Size: duplicated between dex files and resources moved into
Binary-Size: base module.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612278
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842623}

This change enables Chrome OS Chrome builds running on non-cros linux to
work with Espeak-ng.

On linux builds, dcheck always triggers an error in mojo.
Consequently, in TtsService, where the service makes mojo calls on a
Remote within the audio thread, a DCHECK was hit:

2021-01-11T22:46:32.666960Z FATAL chrome[2743839:2743847]: [sequence_checker.h(120)] Check failed: checker.CalledOnValidSequence().
#0 0x7f7ee68c681f base::debug::CollectStackTrace()
#1 0x7f7ee665fd8a base::debug::StackTrace::StackTrace()
#2 0x7f7ee665fd45 base::debug::StackTrace::StackTrace()
#3 0x7f7ee66a9057 logging::LogMessage::~LogMessage()
#4 0x7f7ee66a9769 logging::LogMessage::~LogMessage()
#5 0x7f7ee6620c1b logging::CheckError::~CheckError()
#6 0x7f7ee564e09c base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker()
#7 0x7f7ee566c068 mojo::InterfaceEndpointClient::SendMessage()
#8 0x7f7ee566c99f mojo::InterfaceEndpointClient::Accept()
#9 0x565159b53c29 chromeos::tts::mojom::TtsEventObserverProxy::OnStart()
#10 0x56515c4e3a5a chromeos::tts::TtsService::Render()
#11 0x7f7ed8648f02 media::AudioOutputDeviceThreadCallback::Process()
#12 0x7f7ed861fe9d media::AudioDeviceThread::ThreadMain()
#13 0x7f7ee68fb1ab base::(anonymous namespace)::ThreadFunc()
#14 0x7f7ea303fea7 start_thread
#15 0x7f7ea2baad8f clone

Fix this by queueing up already rendered audio buffers and processing
them on the main thread's task runner.

Test: manually on a linux chromeos build. Verify that web speech produces speech through Espeak.

Change-Id: I4b1e5b0a6e72e4e571b5a26fde731acc57936894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621983Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842622}

Bug: 1085129
Change-Id: I16ee23ac320300b2e408aca4b8a4873b1f1594ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624674
Auto-Submit: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842621}

We are seeing regular hangs on bots when running 'wpt manifest' on
Python 3, which is causing them to go red. Initial investigations have
not been able to locate a root cause (other than the upgrade), so to
stop the bleeding lets switch back to Python 2 for now.

This is not a long-term fix, just a bandaid. WPT is going to Python 3
only in ~Feb 2021, and will start introducing breaking code changes. If
we cannot resolve the issue here, we will end up stuck on old WPT
tooling forever (which is very much not desirable!).

Bug: 1161274
Change-Id: I7cef267d7b4f725a2069950852c75fa4fc009fb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623816
Auto-Submit: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842620}

The CrOS side of this isn't yet implemented, but we can just set these
fields already anyway.

Bug: b/165724836
Change-Id: Iee100d6f160bb3a749c913e9df7b0cdd1c4ff524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568683Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#842619}

Instead of using the default arguments of
v8::ConstructorBehavior::kAllow and then immediately calling
FunctionTemplate::RemovePrototype, this patch changes the
FunctionTemplateInfo::New to pass in the correct value for
v8::ConstructorBehavior.

There is no change in observable behavior with this patch.

In the future, this change will allow v8 to correctly cache only the
instantiable templates (crbug.com/v8/11284) improving performance of
this template cache.

Bug: v8:11288
Change-Id: I0392fd83fbeeb5a0363d75742bcae9a5239ac715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616412Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842618}

1. Only emit the receive-message metrics and logs if the callback has
   not already been invoked.
2. Record a fast-path-ready notification as a receive-message success.
3. Clarify receive-message histogram summaries to indicate that the
   metric records the result of opening the receive stream, i.e.,
   starting to receive messages, not a result for every message receipt.
4. Add metrics and logs to track send- and receive-message OAuth token
   fetches.

Manually verified logs and histograms.

Fixed: 1164009
Change-Id: I2a064cae444ec890971db40b15c93c713e32565c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619628
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842617}

ScopedProfileKeepAlive is not meant for use with OTR profiles, so this
caused a failed DCHECK() when a downloading a file in Incognito (with
DestroyProfileOnBrowserClose=true).

Bug: 88586
Change-Id: I1aff2cadf62ab1bd56a0b44e9154d6843f92cc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622873Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842616}

The NEW_PAGE, EXISTING_PAGE, and SAME_PAGE names are confusing because
they refer to NavigationEntries rather than pages. For example, NEW_PAGE
is used for same-document main frame navigations, which create a new
entry but not a new page. This CL mechanically renames them to
NEW_ENTRY, EXISTING_ENTRY, and SAME_ENTRY.

Bug: 1164466
Change-Id: Idb0bfa4de08a69f55088b248a9b05619dd17cca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618392Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842615}

When the first option in the select is hidden, even though the option
won't be shown in the dropdown list, its text still appears as the
selected option in the dropdown. Moving the |noScannersText| option to
after the list of scanners allows the first scanner to replace
|noScannersText| as the selected value when loaded.

Bug: 1059779
Change-Id: Ic06363e55d082fe758a6ae04ddbe4e7206841f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622894
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842614}

Add tab_search:measure_memory:before and tab_search:measure_memory:after
to measure memory before/after open tab search.
Add tab_search:clean_slate to benchmark tab search without any traffic.

Bug: 1099917
Change-Id: I748609a91af8866c9814ff0cf2a17e92dd197d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622951Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842613}

This CL merges multiple details into a single block, with the details
separated by a line. See b/174652960#comment16 for screenshots.

Bug: b/174652960
Change-Id: Ia562ec600b513a120b503c8f7ffa676124089749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611096
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#842612}

Bug: 1139478
Change-Id: I9fd0a87bcc2086e27a5c4b3b6c025c2ff4065dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623672
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842611}

Per the bug filed by our UX designer, update the preview focus ring to
have a solid inner ring, and a dashed outer ring with 4dip dashes and
2dip gaps.

Since Switch Access is the only application of the DASHED focus ring
style currently, I modified that style directly, rather than creating
another new style.

Bug: 1152610
Change-Id: If61810ed594e7f388a8cbf71aaa41a44c2ed3cb6
AX-Relnotes: Dashed focus ring in Switch Access now has a different style.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622757Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#842610}

Bump the expire date to 2022-02-01

Bug: 1165249
Change-Id: Ifb567252ac93f21073d16019adbed1b3c9622bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622993Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842609}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81d005b6696c..767ed2f6b642

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC zmin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: zmin@google.com
Change-Id: I0a20a271d883525e958b9ad30faa6f555a566609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624854Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#842608}

This reverts commit f0314d14.

Reason for revert: Enforcement is not yet ready for M89 (see https://crbug.com/1151438) - need to temporarily disable before the branch point.

Original change's description:
> Reland "Enable |request_initiator_site_lock| enforcement on Android."
>
> This reverts commit 207fb0e1.
>
> Reason for revert: Trying again on M89 (with new crash keys from https://crrev.com/c/2575368)
>
> TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 920634
> Bug: 1151008
> Bug: 1151438
> Change-Id: Iff849597312d7843b1fff809a00743d0785680e8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578100
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#834521}

TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 920634
Bug: 1151438
Change-Id: Ibd1aea1a23c2cc04256724de5b8a8685f866de9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623468Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842607}

Migrating GetWebPageMetadata to the component will necessitate a
browser/renderer split directory structure.

Bug: 1164069
Change-Id: I789a7991d2d98247415b2c6d35108fdf258d1113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621987
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842606}

From the perspective of extensions, Lacros should be functionally
equivalent to ChromeOS rather than Linux.

Bug: 1164523
Change-Id: I020997a4185afb54018f19653f00f7b9d00f4f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623121Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842605}

This fixes bug where if looking at site settings in PageInfo or through SingleWebsiteSettings and view Notification preference on Android O+, the notification icon will be duplicated upon returning to setting pages.

Bug: 1163799
Change-Id: I7705b8c4d3bf55cb09ab171ee40e1b9f6c29ef22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617463
Commit-Queue: Jordan Oroshiba <oroshiba@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842604}

Addressing missed feedback from crrev.com/c/2581027, use right
click instead of adding new API.

Bug: none
Test: compiles
Change-Id: I988c92c87e9339702a5554bd7e5375d467616412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623424Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842603}

Updates the expires_after attribute for 57 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-04-12.

TBR=chromium-metrics-reviews@google.com

Change-Id: I8174bb5839ae52353832435a8b44ba7ee5646254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622341Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#842602}

We assign the priority as FOREGROUND if there is any pending force
installed extension. Then for the enabled/disabled extensions, we set
the priority as FOREGROUND in this case. This causes a  high rate of
"ondemand" updates for certain extensions. This CL fixes this by
assigning FOREGROUND priority only in case of first installs.

Bug: 1133407
Change-Id: I7b6e84e22c240ead798eb6f625ef3c26142c786f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621893Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#842601}

Bug: 1156270
Change-Id: I895cac0847e226374efc27d5a9cfdc6f29b09130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622664Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842600}

Bug: 1133624
Change-Id: I71e50481f0d7942f6ce428e890742828bfe0699e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500422
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842599}

This config is supposed to enable the account indication footers for
*Save Card* bubbles, not for *Password* bubbles.

Bug: 1121258
Change-Id: I09a4cbc636582c3298d837d356f1274c0d5c36c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624787Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842598}

This CL adds a new WebFeature metric for pages that are embedded via
<frame> or <iframe> by default, without explicitly setting an
X-Frame-Options header or frame-ancestors CSP directive.

https://github.com/mikewest/embedding-requires-opt-in

Bug: 1153274
Change-Id: I5bb45df3eb2aec0010f2ddd2dfe457551de9d40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623010
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842597}

Disable org.chromium.chrome.browser.omnibox.voice
.AssistantVoiceSearchServiceRenderTest#testAssistantColorfulMic
on Android due to flaky.

Bug: 1165682
Tbr: fgorski@chromium.org
Change-Id: I036cde50ce6b9c4664eb242e6a2f6b02b3979d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622338Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842596}

This is a reland of 29ff7965

Reordered initialization to fix ASAN/MSAN bug.

Original change's description:
> ime: Handle InsertTextCursorBehavior in InputMethodChromeOS.
>
> TextInputClients now support moving the cursor after committing some
> text. This patch adds support for input engines to call the new API.
>
> There is a slight complication with multiple CommitText calls during
> key event handling. Previously, when handling a key event, any calls
> to CommitText will be coalesced together and executed once the key
> event is handled. However, this coalescing logic doesn't handle
> cursor movement.
>
> Add logic to handle cursor movement when coalescing commits by observing that
> any sequence of CommitTexts with cursor movement can be implemented with two
> separate CommitTexts. Note that this is a no-op change if the IME never uses
> the new cursor movement parameter.
>
> Bug: 1155331
> Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067
> Reviewed-by: Keith Lee <keithlee@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840082}

Bug: 1155331
Change-Id: I373a8195946ec4fb966f932eaf084b2b74f06b6c
Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng,linux_chromium_chromeos_asan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612604Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: John Palmer <jopalmer@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842595}

The test is also flaky on Chromium trybot, disable it.

Bug: 1165749
Change-Id: I992be191e2ab52106239dd13572dc058fde4b448
Tbr: dtseng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624829Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842594}

This is a reland of 07b882d4

The original CL was reverted due to a few layout tests failing in ASAN.
The cause of these failures was that vertical_autoscroll_layout_box_
and horizontal_autoscroll_layout_box were not being cleared in
StopMiddleClickAutocroll. This resulted in heap-use-after-free errors.

In order to fix this issue, the two pointers are cleared in
StopMiddleClickAutoscroll. They are also cleared if necessary in
StopAutoscrollIfNeeded. In the latter, middle click autoscroll would be
stopped if both layout boxes are to be cleared.

Original change's description:
> Change autoscroll latching to top-most delta-consumable scroller
>
> Users will now be able to use middle click autoscroll to scroll a
> parent div if the inner-most scroller is unable to scroll in that
> direction.
>
> If there is no delta-consumable scroller, the top-most autoscrollable
> scroller will be latched.
>
> Bug: 1107648
> Change-Id: Iccd4efec3b1ce5d09c701d3d46052176275dbc32
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488042
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#835318}

Bug: 1107648
Change-Id: Idf3c2253a25d2cfbe12a8ffe30bbf697c636d222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582733Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#842593}

This adds an OWNERS file to ios/chrome/test/wpt, with the initial
author of this code as an owner.

Change-Id: I0d2f22b4ec3c53ae7a3fad9e06c2d64db7695371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624587Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842592}

Roll Chrome Win32 PGO profile from chrome-win32-master-1610441943-347418dd52d747baeeb402622c1d23998512f08e.profdata to chrome-win32-master-1610452567-971e6bfbeacac133e734933b87972f0e8c85e431.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I70ae8f6df2a4604c8cff4ea67d200fd9496eb539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624258Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#842591}

This is a reland of 909901eb

The revert was due to greater pixels error difference between
Mac 10.12 & 10.15 and the baseline.

After checking the error rate on failed Mac bots, the fix is
to increase the error_pixels_percentage_limit from 9f to 10.2f in
form_controls_browsertest::FuzzyPixelComparator.

Original change's description:
> [Controls Refresh Android] Fixes input missing border
>
> Prior to this CL, controls-refresh text input is missing its border.
>
> The fix is to make sure property text_field.has_border is passed to
> native theme. This property is only used by form controls-refresh
> so it has no impact on existing text input.
>
> Bug: 1155397
> Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#841106}

Bug: 1155397, 1164011
Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842590}

Add user action metrics for:
- Clicking to open the reading list
- Adding to the reading list from the Bookmark icon entry point
- Adding to the reading list from the tab context menu

Bug: 1163938
Change-Id: I95d655ce60f5b76c80f4d3b6a8490310befa8fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622315
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842589}

Canada requires a legal footer to be shown on the marketing
opt-in screen. Add the footer and tests for it.

Fixed: 1124956
Change-Id: If9f1dd34dfb9ea9209498521eeee107f8aa132f9
Bug: 1124956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577364
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842588}