- 08 Nov, 2019 40 commits
-
-
John Delaney authored
The heavy ad intervention currently does not trigger when a blocklist is not available. We do not setup the blocklist in incognito mode. This change creates a blocklist for incognito profiles with no backing store, which simply creates an in-memory blocklist. This allows us to have very similar behavior across incognito & non-incognito. Bug: 1022806 Change-Id: I0d1e48adc08eb6dd93fb8a9ac6dd6b848f0ca348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902528 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#713928}
-
Michael Wasserman authored
This reverts commit 1cc1acb5. Reason for revert: caused Mac ASan 64 Tests (1) browser_tests to fail: PasswordChangeAuthenticatorUnitTest.DetectPingSuccess PasswordChangeAuthenticatorUnitTest.DetectAzureSuccess PasswordChangeAuthenticatorUnitTest.DetectAdfsSuccess https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/58281 Reverting as discussed in chat, hopefully this will make the tree a little greener? Original change's description: > Disable new JS test for ASAN properly > > JS tests don't work on ASAN, which is a known bug: > https://crbug.com/1010561 > > Use the existing "include_js_tests" flag to exclude > password_change_authenticator_test as it is intended, > instead of an ad-hoc solution. > > Bug: 1022385 > Change-Id: Ia81d148dd2c38c17813a2b007be27aa932849679 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904197 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713806} TBR=thakis@chromium.org,rsorokin@chromium.org,olsen@chromium.org Change-Id: I68be33e1819fa3c705db82b7e9a49bd5e08e55b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907128Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713927}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e3eacac1ca1..60c88fd3ec68 git log 5e3eacac1ca1..60c88fd3ec68 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 rsavitski@google.com Merge "ui: remove "idle process" process/thread tracks (utid 0)" 2019-11-08 lalitm@google.com trace_processor: fix counter values best index logic Created with: gclient setdep -r src/third_party/perfetto@60c88fd3ec68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8526018d5502b37e34be1b18a5ef0616c056e1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713926}
-
behdad authored
Bug: chromium:1021682 Change-Id: Id35d9656d8c278c5b0eeaccf0efe905c58454b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900248Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713925}
-
Jon Mann authored
When navigating over the network list in the system tray, announce all visible details including: name, connection status, signal strength, managed by administrator, secured, etc. Fixes: 1006390, 1006019 Change-Id: I8b37d4711a329df94c6f16f17e378c3e3de66f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899068Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#713924}
-
Bo Liu authored
Fix ContentViewRenderView's usage of postOnAnimation which can lead to leak after destroy as well. Bug: 1018148 Change-Id: I8d6509eed77355359a285e2ddb67bb80ac1e79de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903688 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713923}
-
danakj authored
On the bots, we see phantom time being lost during startup of the webkit_layout_tests step on each swarming bot. Looking at the logs from https://bugs.chromium.org/p/chromium/issues/detail?id=982208#c0 we see 25-40s of lost time after "Manifest generation completed". I narrowed down the majority of this time to be spent inside _wpt_test_urls_matching_paths(). This method was called 213 times, once for each virtual test suite, and iterates through multiple WPT dirs, and then over 30k test paths from the WPT manifest files. The inner loops of this process was doing far more work than they needed to do. We change _all_virtual_tests() to pass a set of virtual test paths to _wpt_test_urls_matching_paths(), calling it a single time. This allows us to generate and load the WPT manifests a single time instead of hundreds of times, saving about 4 seconds of time on my local machine. We then re-order the nesting of the loops and move work that needs to be done to the outer-most loop based on the inputs it depends on. And we simplify the matching done inside the inner-most loop to a single string.startswith() call. This saves another 9 seconds of time on my local machine. Locally this takes this phantom time from about 14 seconds down to 2 seconds. As the bots have larger phantom time (25-40 seconds) we can expect to see a larger proportional win there: On linux-rel we see the phantom time after generating WPT manifests drop from 19 to 4 seconds (-15 seconds) and on win10_chromium_x64_rel_ng we see the phantom time drop from 23 to 5 seconds (-18 seconds). Overall this is reducing the post-manifest phantom time by about 80% (about 20s -> 4s). It is reducing total time to first test by about 20% (about 90s -> 70s). R=dpranke@chromium.org Bug: 982208 Change-Id: Ibb8d6287e456f0910ee43f80e8072743d21bc2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903725 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#713922}
-
rbpotter authored
Change the bookmarks Web UI build to be more similar to other Web UI pages (e.g. extensions, settings, Print Preview) by adding individual grd files for its resources, and building the optimized page from an unpak folder. This will allow the page to leverage existing logic in unpack_pak to place generated Polymer 3 JS files and non-generated JS module files in the same folder structure for bundling when the page is migrated to Polymer 3. Bug: 1022213 Change-Id: If27d96cefbca79f7b4b238b5123482dab465b4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904450Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#713921}
-
Mia Glaese authored
Bug: 982018 Change-Id: I3feac4d011e96a9e9ece24ff50d20b5958e3f0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895795 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#713920}
-
Elly Fong-Jones authored
These methods are present as of 10.15 and need to be proxied on MTLDeviceProxy. Bug: 973128 Change-Id: Ib4bf6e2f52d0101fb639bd848346c2c00bfeee9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906331Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713919}
-
Clark DuVall authored
Some of our navigation APIs were untested. The tests ended up finding a crash in getRedirectChain(). Change-Id: I2e0837ace604ee1607cebaa745e07c782cfc4be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904753 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713918}
-
Tommy Li authored
No one is looking at this metric currently. Bug: 1016906 Change-Id: Ib77a893871383756a551e6cbe7cd92545d8258de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898507 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#713917}
-
rbpotter authored
In order to migrate pdf_scripting_api.js to be a module script for the Print Preview Polymer 3 migration, we need to stop executing it as a standard script in EnsurePDFHasLoaded and pdf_extension_test.cc. Since the current usage of this script only relies on a few lines of logic contained in the PDF scripting API rather than the entire class, inline these lines in C++ rather than injecting pdf_scripting_api.js. Bug: 1012574 Change-Id: Ib2b43b83819102c19be20a58e163f04b7c0d6e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902257Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ed1c2732ba..c03ce008b9fe git log d9ed1c2732ba..c03ce008b9fe --date=short --no-merges --format='%ad %ae %s' 2019-11-08 bclayton@google.com Kokoro: Allow 'Fixes:' in bug check Created with: gclient setdep -r src/third_party/swiftshader@c03ce008b9fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I14335fc30741957daa56b0cd8b9c096888608a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906651Reviewed-by:
-
Simon Que authored
Bug: 1022686 Change-Id: I925f5f3922ba297349af65a60705cb4970d3cff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906386 Commit-Queue: Simon Que <sque@chromium.org> Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#713914}
-
manuk authored
Previously, the DemoteByTypeRule was only usable if the params were set in the OmniboxBundledExperimentV1 study. With this CL, a group in any study that enables the OmniboxDemoteByType feature will also be able to set the params. Bug: 264066 Change-Id: I7f0695f4cb71e46a7a533d240db2e91f105cda03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903665Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713913}
-
Bruce Dawson authored
The Windows 10 19013 Preview SDK has an extra UCRT file in the debuggers directory and this file (api-ms-win-downlevel-kernel32-l2-1-0.dll) is needed when running cdb.exe on Windows 7. This change allows the copy_cdb_to_output action to run with 18632 and later SDKs. Once we require a later SDK we should add the new file to the list of outputs for this action but this will smooth the otherwise bumpy transition. Bug: 10216507 Change-Id: I2304aea73dfcd25258697c37d05b05dc6adff55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904873Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713912}
-
Jinsuk Kim authored
With https://crrev.com/c/1898161, HistoryNavigationDelegate returns nulled-out BottomSheetController when the activity is already destroyed. All the public methods of NavigationSheetCoordinator should take it into account and early out in any calls to them when it is detected. Bug: 1022285 Change-Id: I605a136f73c4e33ac880142321c3205b12eff940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906846 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713911}
-
Robert Liao authored
These appear unused and some use ATL. BUG=5027 Change-Id: I3b9ffae2134d03afe74e054ac7ce7896294db898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906257 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713910}
-
Rouslan Solomakhin authored
Before this patch, specifying an empty list of modifiers would crash Android PaymentRequest, because it would clear its own list of modifiers before initializing it. This patch checks that the list of modifiers is initialized before clearing it. The new test EmptyParametersTest.NoCrash crashes without the patch and passes with the patch. After this patch, specifying an empty list of modifiers does not crash Android PaymentRequest. The android_browsertests were chosen to make sure both Android and desktop behave correctly. Although WPTs could also find the bug, they currently don't run on the waterfall (neither desktop nor Android). Bug: 1022810 Change-Id: I661aa80889822a73939c5f96662dc3531689a85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906806 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713909}
-
Shivani Sharma authored
Bug: 932236 Change-Id: I4a30d7f9230682b75215f753ddc4e128e1c45be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790062 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#713908}
-
Rob Buis authored
Blink currently does not properly render MathML but allows authors to specify fallback content via an annotation child of the <semantics> element. This is implemented by CSS rules in a dedicated UA sheet. This CL adds a mathml-fallback.css UA sheet with the same CSS rules and uses it when MathMLCore is disabled, in order to preserve existing behavior in that case. When MathMLCore is enabled, the existing mathml.css UA sheet is still used for now but its content will be modified in future CLs when the MathML implementation is refined. Bug: 6606 Change-Id: I4d68f10185d7e25f64bffeee0da5a184fac39932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904186Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#713907}
-
Eric Roman authored
Bug: 1021236 Change-Id: Id03f517e8a5ed285c695d51b54182f99d3c91fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904866 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#713906}
-
John Z Wu authored
- Implement GetURLLoaderFactory() - Implement GetIdentityManager() - Use a real SyncCredentialsFilter - Implement GetPasswordSyncState() Bug: 867297 Change-Id: I1b4fddc1601b7cfd007957ca88ea493d35e55555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904869Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713905}
-
Etienne Pierre-doray authored
Bug: 839091 Change-Id: Ie40872cdd6a7ea1d5d628a8aa49b0df5b9f48a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904269 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713904}
-
Antonio Gomes authored
The replacement is now possible that all users are in Blink. Essentially, the former is a pure interface for the later. As a follow up step the use of WebString will be replace by WTF::String. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I84f540d050e72180a9026f595e586d1319efed1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904669 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#713903}
-
Peter Kotwicz authored
This CL removes the --aggressively-prewarm-renderers command line flag. I am deleting it because there are no plans on turning on the flag behaviour by default. BUG=1022819 Change-Id: I6fcfe9be782ed5a1f20831b89b356b28e1671045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906310Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99b558b594a1..2e30fde04687 git log 99b558b594a1..2e30fde04687 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 jlavrova@google.com Font resolution: all unit tests working 2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage 2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made 2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend. 2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17 2019-11-08 mtklein@google.com remove redundant comparison ops Created with: gclient setdep -r src/third_party/skia@2e30fde04687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Idfcc045a389982ea02602897440dba6aca1787a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906867Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/814c68a9..2a7f3180 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I63eddd17a3834c7fd9be6ae356da51c9dd1a32ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906826Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713900}
-
Mario Sanchez Prada authored
As agreed on crrev.com/c/1879260, we are now renaming this interface to prevent a naming clash now that we have migrated to the new Mojo types, which would lead to confusing situations like having a mojo::Remote<video_capture::mojom::Receiver>. Bug: 955171 Change-Id: I2fdc736643ac652de6db27af1de593ee13ca83f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901468 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713899}
-
Simon Que authored
Bug: 1022800 Change-Id: Ibb932d484610190dbc95814f21b5b7c5bb2aa5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906446Reviewed-by:
-
Mei Liang authored
This CL adds an API to TabSelectionEditorController that shows the TabSelectionEditor with the given tabs, and the first n tabs being selected. There is also a divider shows between the first n selected tabs and the rest of the tabs. Change-Id: I32aa764dc62bbabc89fe54641963b9f64274134e Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896866Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Peter Boström authored
After r713254 there are hopefully no longer performance issues with enabling FocusRings everywhere. Bug: chromium:924232 Change-Id: I99cca2635f3d618d72b2371ce6a07eecea01ffee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903611Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713896}
-
Michael Wasserman authored
This reverts commit efd7d333. Reason for revert: BackForwardCacheBrowserTest.WebMidiNotCached is consistently failing since this landed on at least one bot: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8840 Tracking as part of Bug: 1022876 Original change's description: > BFCache: Add a browser_test for WebMIDI > > Bug: 981740 > Change-Id: I40605b9b6b343a3e0b4a12fe3b0e5e0b6f992390 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903182 > Commit-Queue: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713734} TBR=toyoshim@chromium.org,kouhei@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,fergal@chromium.org Change-Id: Ibb109e18bec2fc12305efc483972acb743c75714 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906874Reviewed-by:
-
Alison Maher authored
When LayoutNGListItem::OrdinalValueChanged() is called on an ":after" list item element, |marker_| is a nullptr. Similar to LayoutNGListItem::ListStyleTypeChanged(), we need to check that |marker_| is not nullptr before invalidation to avoid null-dereferences in this case. Bug: 1020669 Change-Id: I66913cde0420a3612e881dab9e44a006c276ec64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902666 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713894}
-
Xing Liu authored
Range [111000000, 111999999] is reserved for Chime job scheduler. Bug: 1013386 Change-Id: Ia211cf20adc4580bcdbb6fcc3303dc0fd4367c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904947Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713893}
-
Toni Barzic authored
Updates WindowTransformToHomeScreenAnimation to use window_util::HideAndMaybeMinimizeWithoutAnimation(). Change-Id: I3cb191d72a351bf6dd700857b85d2b0775aa4bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905268Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713892}
-
Avi Drissman authored
Work around an Installer.app bug. Bug: 1022413 Change-Id: I4eab147d15bcae44f1d0fc6a4e4da9ac78a34772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904688 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#713891}
-
Bruce Dawson authored
The post_build_ninja_summary.py uses "weighted time" as one of its key measures to summarize build performance but this is only documented in a comment in the script itself. This adds documentation to the page that recommends using this script for build-speed investigations (chiefly through set NINJA_SUMMARIZE_BUILD=1). This also updates the example output to say elapsed time instead of the inaccurate term CPU time. Change-Id: I148df429722a33f70123d9f3076b1b7e5e6cb347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902113Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713890}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1917f7a09940..d5c0b56e84e0 git log 1917f7a09940..d5c0b56e84e0 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danakj@chromium.org Use git fetch --no-tags to fetch commits to apply via cherry-pick. Created with: gclient setdep -r src/third_party/depot_tools@d5c0b56e84e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: I82a2b944fd99329515f04e978c11cd5310ed3335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906868Reviewed-by:
-
