- 03 Oct, 2019 40 commits
-
-
Sophie Chang authored
Bug: 1007374 Change-Id: I1fd66d8f351ac1191aa42688f8fed39a347ce06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836432 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#702335}
-
Yoichi Osato authored
TBR=pbos@chromium.org Bug: 1010670 Change-Id: I81fdc9a761ce1d51d6831140a37cb45875541515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837441Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#702334}
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. Bug: 961614, 1006292 Change-Id: Ie520b78d9b2f305a74a59e089d56c976a9349c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829626Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#702333}
-
Yusuke Sato authored
ARC needs to asynchronously retrieve the current display's density before starting the mini instance. In addition to that, ARCVM needs one more information that is the number of logical CPU cores disabled. Without the information, Concierge cannot launch crosvm with a proper --cpus argument. This CL passes the object for retrieving the information to ArcServiceLauncher, then ArcSessionImpl, and adds 1 more state to ArcSessionImpl to wait for the CPU information before launching the instance. BUG=b:139752657 TEST=components_unittests Change-Id: I7318279c6058b328965665ef3be0f9b51b52a855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815562Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#702332}
-
Ankit Kumar 🌪️ authored
NVDA does not call out images with no alternate text. This CL adds a default alternate text if no alternate text is provided by the PDF. A test has been modified to include an image with no alternate text in the tree. Bug: 981448 Change-Id: I8653b6532e1da64d168ba4f6fdd530d7021fba16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827114Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702331} -
Miyoung Shin authored
This CL converts XRFrameDataProvider{Ptr, Request} in chrome, device and blink to the new Mojo type, and uses pending_remote<XRFrameDataProvider> in vr_service.mojom. Bug: 955171, 978694 Change-Id: I5f4b6f877a5e109bad03d6a0a0baa6dac0cbe56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828722 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#702330}
-
BUG=762641 TBR=xiyuan@chromium.org Change-Id: I9724045866546aeae52a50e364482fb2e7d0400a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836916Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702329}
-
Yoichi Osato authored
TBR=thestig@chromium.org Bug: 1010782 Change-Id: Ia8f9070e7b4bf8e5b3dda4b635d17d5ded8d8d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837319Reviewed-by:
-
Naoki Fukino authored
This adds "Learn more" link on Settings > Device > Storage management > External storage preferences for detailed explanations about the setting. Bug: 1007188 Test: Manually tested on kevin. Change-Id: I4774bc1051e32c994e937fafadc017f9196295de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820922 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702327}
-
Yoichi Osato authored
TBR=lpz@chromium.org Bug: 1010783 Change-Id: Id166287895b8683cbdee68946ba600be4edbcaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837320Reviewed-by:
-
Yoichi Osato authored
TBR=battre@chromium.org Bug: 1010781 Change-Id: Iba7c19d5c4cf12160128ac15e91d9042d0cd7bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837439Reviewed-by:
-
K Moon authored
Add ToVar() and FromVar() methods to DocumentLayout::Options, allowing serialization to and from a pp::Var. This serialization is then used to pass layout options (such as default page orientation) to and from JavaScript (via the "documentDimensions" message). pp::Var is non-trivial to unit test, due to dependencies on the browser's PPAPI interfaces. Instead, this change adds 2 browser_tests, PDFExtensionTest.Layout3 and PDFExtensionTest.Layout4. Each runs the same layout_test.js suite over two slightly different test PDF files, test-layout3.pdf (with 3 pages) and test-layout4.pdf (with 4 pages). There's currently no coverage of deserialization, as we're not doing anything with the layout options sent back from JavaScript yet. We'll start using FromVar() in an upcoming CL (such as crrev.com/c/1747170). Bug: 885110 Change-Id: I8c93b74062576ee07445070e0b4a82f0f861a82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830398Reviewed-by:
-
Yoichi Osato authored
TBR=changwan@chromium.org Bug: 1010179 Change-Id: I67780931d65fa769a5fa801941d6a969798ed799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837318Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b2f9f7fb1ed2..16438a83d608 git log b2f9f7fb1ed2..16438a83d608 --date=short --no-merges --format='%ad %ae %s' 2019-10-03 cjmcdonald@chromium.org Reland "Enable new parallel_emerge impl as default" 2019-10-03 cjmcdonald@chromium.org De-parallelize UnitTestStage 2019-10-03 vapier@chromium.org cros_build_lib: make run & helpers a bit more robust Created with: gclient setdep -r src/third_party/chromite@16438a83d608 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I57fdc2508832f7dec2509ac80d7c8c9044190b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702322}
-
Yoichi Osato authored
TBR=carlosil@chromium.org Bug: 1010183 Change-Id: Ic57588d5ab510b780955552f5393e6cb94ab75f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837438Reviewed-by:
-
Yoichi Osato authored
TBR=tbansal@chromium.org Bug: 1010178 Change-Id: I218e176f58624b6147cfd6df43a346b4e435928e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837436Reviewed-by:
-
Mugdha Lakhani authored
Currently, MINIMAL and LOW site engagement origins will be able to run periodicsync events every 48 and 36 hours, respectively . This change reduces these intervals to 36 and 24 hours respectively. Unit tests have also been updated. This is because UMA data suggests the median site engagement to be 36 (relevant data here: https://uma.googleplex.com/p/chrome/timeline_v2?sid=24484362bf920d4da7531b1aab7bc9d3) All developers we've heard from so far need at least a daily frequency of updates. Even after this change, we'll continue to reduce the frequency of updates with site engagement, although in fewer steps, and stop running updates for sites the user stops engaging with. The browser will continue to not be woken up more often than twice a day. Change-Id: I0f4431d4e93fc4c0789aa6d2d84fd19bc412ba4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831899 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#702319}
-
Yoichi Osato authored
TBR=mastiz@chromium.org Bug: 1010207 Change-Id: Ie1d8cea49b1aa5b1dfd785b1fe667e44fd96e7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837317Reviewed-by:
-
Yoichi Osato authored
This reverts commit 304c2408. Reason for revert: This causes test failure. Bug: 1010801 Original change's description: > [fuchsia] Implement per-app remote debugging in CastRunner. > > * Handle the |enable_remote_debugging| parameter in > chromium.cast.ApplicationConfig to enable per-app remote debugging > in CastRunner. > * Set the CastRunner debugging port to 9222. > * Remove a buildflag to enable remote debugging Context-wide. > * Add a test to check remote debugging is properly enabled per-App. > > Bug: 997895 > > Change-Id: I19aced4e90790e77cc3f55b1118fbf459ae19b14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773707 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702264} TBR=wez@chromium.org,fdegans@chromium.org Change-Id: I0d5499e443b3fe4f640860df9437def2d9466535 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837322Reviewed-by:
-
Vikas Soni authored
Adding vulkan support in MediaPlayer path requires providing VulkanYcbcrInfo to the VideoFrames created in renderer process. This info is sent to VideoFrames as an ipc from gpu process to the renderer process. Change-Id: Idcb80833ae0dd7adb4929f03ddf5f4ddd5c0e723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811801Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#702316}
-
Yoichi Osato authored
TBR=achuith@chromium.org Bug: 1010676 Change-Id: I2eb64a52ce2a9d67ab8c3af10712066f01e2349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837432Reviewed-by:
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. Bug: 961614, 1006292 Change-Id: I260fe04bef3cba60f9045b498d2fb9bd0eed6e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830252Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
Before this patch, "application/signed-exchange;v=b3" in Accept header had the same q-value as "text/html". But if SXG and non-SXG version of a resource are available, browser should prefer non-SXG because SXG adds overhead. This patch decreases the q-value of "application/signed-exchange;v=b3" accept header value to 0.9, which is in the middle of "text/html" and "*/*". Bug: 1003704 Change-Id: I955e16093a601bbe5177d842128ddff405808cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810120Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Yoichi Osato authored
TBR=michaelbai@chromium.org Bug: 1010187 Change-Id: I59a2606784415793e5e352d6db1f663f1d50d364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837433Reviewed-by:
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/449, this CL makes stencilFront and stenciBack optional in GPUDepthStencilStateDescriptor. Bug: 877147 Change-Id: Ied3f567e324c68b179ca51074406d1a6434609f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835362Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#702311}
-
Yoichi Osato authored
TBR=battre@chromium.org Bug: 1010186 Change-Id: I9d56d9225fbfe6069476878c4d531d1d43371515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837316Reviewed-by:
-
Michael Thiessen authored
This doesn't fix any known (to me) bugs (and please revert if it breaks anything). However, it does two things: 1. It makes the code more consistent. 2. It fixes what might be a bad incognito detection method? The dialog probably makes this too obnoxious to use in practice, but it might give a site a way to know if the user is in incognito. The user gesture code was added in https://codereview.chromium.org/1243253004/, which doesn't mention incognito at all, so I'm thinking it was probably just an oversight that the gesture token doesn't get applied while in incognito? Bug: 1006927 Change-Id: I74458549cea9f4aec65c6c41c0a73b4869d44115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832699 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#702309}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I162dd4fa33d3af10a314fd5cd49ec239ddec05fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837134Reviewed-by:
-
Nico Weber authored
chrome/test/base/js2gtest.gni already adds a data statement for all sources (look for copied_source_pattern), so this is behavior- preserving in normal builds. In win/cross builds, js2gtest is a no-op, so this unbreaks the isolate step there, since the .gtestjs file in the outdir doesn't exist in the cross build. Bug: 995737,912946,1010561 Change-Id: I1b8f4ebd0c0ee6532118d3d44bcddeb8ea1725ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837411 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#702307}
-
Yao Xiao authored
The issue: currently the network isolation key for ViewSource is (request url origin, request url origin) since it is a new navigation. When split cache is enabled, this will cause the request to go to network in most cases, which is undesired. Besides, the functionality will be broken when ViewSourcing a cross-origin subframe form post, because in that case the request is required to load from cache while it's not in the cache, thus causing an ERR_CACHE_MISS error. This CL addresses this issue by setting the network isolation key to be (top_frame_origin, frame_origin) of the original frame that triggers the ViewSource. Bug: 1006302 Change-Id: I80d8c9342e9f056e46bd11f1c96f1be7aeb794c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824650Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#702306}
-
Olivier Yiptong authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/base to the recommended methods/types. Bug: 1007847 Change-Id: Idda7c3a5eb98c4d9a819f24b6208c2f1aa642a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830293 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#702305}
-
Staphany Park authored
Bug: 963042 Change-Id: Ic9fbccdabf8ca49b694b4195e7262d3e80a4be6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836662 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#702304}
-
Matt Falkenhagen authored
The functions didn't match the sections. Change-Id: I42a43661cb73a8415ddec6ca2cdd9835a032f563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837311 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#702303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fd092e853e7b..2328d65ab30d git log fd092e853e7b..2328d65ab30d --date=short --no-merges --format='%ad %ae %s' 2019-10-03 jmadill@chromium.org Revert "GN: Componentize vulkan back-end build." Created with: gclient setdep -r src/third_party/angle@2328d65ab30d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I9ddb57e174abdefd801f8da44cfe721326d813df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837216Reviewed-by:
-
Lloyd Pique authored
For displaying the vsync lines in the tool, we need the ideal vsync timestamps. The tool was using the timestamps of the HW_VSYNC_0 events, but this could be off and very jittery by several tenths of a millisecond from the vsync event time just because those events are written out by SurfaceFlinger when responding to the hardware composer vsync callback. The hardware composer vsync callback includes the actual vsync timestamp as an argument, but this is not included in the existing event trace in any way. I went and added a new ARC_VSYNC event which includes the actual vsync timestamp in the profile data, where it is stored in the string after the event name. Reading this event and parsing out the actual timestamp is much more accurate. Switching the tracing tool to using the event means that the vsync lines will be rendered with a consistent spacing, and represent the actual vsync times now, instead of lagging behind by some variable amount. Specifically this change 1) Modifies arc_tracing_event_matcher to allow for a prefix match, and not just an exact name match. Since the timestamp is part of the name string and is variable, a prefix match was required to match these events. 2) A unit test was added to cover the new matching behavior, and in implementing it I went ahead and added move constructors/assignment to ArcTracingEvent for convenience 3) Removes "disabled-by-default-android hal" from the trace options when the tool is used. It turned out this was including some events from HIDL ("HIDL::IComposerCallback::onVsync::passthrough"), which were emitted using atrace_begin/atrace_end, however which could actually execute on separate threads and break an assumption in the tracing tool that they were emitted by the same thread. Perhaps the Android HAL generator code could be adjusted to use atrace_async_begin and atrace_async_end instead, but since we do not seem to need the HAL events, it was easier to just disable their capture. 4) Switches the tracing model to look for the ARC_VSYNC events instead of the HW_VSYNC_0 events, including reading the timestamp out of the name string instead of using the misleading event timestamp. BUG=b:132641796 TEST=unit_tests --gtest_filter=ArcTracingEventMatcherTest* TEST=chrome://arc-graphics-tracing Change-Id: I887a573c74035d783b918ca69c3dbb47fc1e5920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811936 Auto-Submit: Lloyd Pique <lpique@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/master@{#702301}
-
Mugdha Lakhani authored
The logic to decide delay for each Background Sync registration is now completely in the chrome:// layer. The logic to calculate the soonest_delay across registrations across storage partitions for the browser context can be moved to content:// in a new class called BackgroundSyncScheduler. This reduces an unnecessary interaction between chrome:// and content:// layer, allows more code to be shared with embedders of content:// and this logic can be completely tested by browser tests on ContentShell. This simplifies scheduling logic, and also improves testability. Bug: 996166 Change-Id: I0aa15b9bcc35c0f2642c89d1d776668054992647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806576 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Mario Bianucci authored
Prior to now, there hasn't been an integration test to test the full precision touchpad pipeline on Windows, from input through to changes to the screen. This CL aims to change that. Unfortunately, it is currently impossible to inject input at the OS level, so we are just mocking some input, but then the full pipeline is allowed to run before checking the state of the window. Two tests are being added, one for touchpad zooming and one for touchpad scrolling. Both test the gestures normally first, then add preventDefaults to confirm that the events are blocked correctly, then remove the preventDefaults and confirm that the gestures work normally again. Bug: 1000729 Change-Id: I60eaf3f43fed12ea4355e4eb936fd2d2755dd92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806629 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702299}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I2770d719ae2c0af7fffb4a44e5c8b5360522ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837331Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702298}
-
Yoichi Osato authored
TBR=avi@chromium.org Bug: 1010354 Change-Id: I363d2c2917dbb900390ad1f24093a4c87a696f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835896Reviewed-by:
-
Kent Tamura authored
These tests call focus() against elements with 'autofocus'. If autofocus queue was flushed before finishing a test, it showed a console message. We don't need to use 'autofocus' attribute in the tests. Bug: 1010025 Change-Id: Id4836be9b8f1968f33bfc8eefc7edb03edf25a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833367Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#702296}
-
