- 22 Jan, 2021 40 commits
-
-
arthursonzogni authored
This patch does not introduce any functional changes. [Previous patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2631271 [Next patch]: https://chromium-review.googlesource.com/c/chromium/src/+/2450093 For OutOfBlinkSandbox, I am going to provide sandbox flags in WebNavigationParams. Filling this object correctly is key. It holds many security properties: DocumentPolicy, FeaturePolicy, CSP, ... As of today, there are many constructors. It is not easy to know when not filling every params isn't a security issue. Some constructors are used only for test, and it's fine only for them. This patch mark some constructors to be used only in tests. This makes it easy to review all the others, which are critical. After this patch, we can exhaustively list all of them: 1. The initial empty document. 2. The synchronous navigation to about:blank that happens immediately after creating an initial empty document in <iframe> with no explicit src. 3. Navigations (regular and error documents) 4. Pseudo new document with same properties (XSLT, javascript). 5. WebViewPlugin (placeholder data URL) 6. Print selected HTML. 7. Test. TBR=tommycli@chromium.org (said LGTM, but didn't click on +1) Bug: 1151340,1041376 Change-Id: Idb3aea723a5da8e349b760a4587bc7609bffbc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635142Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846066}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.10-r1 to 89-4384.0-1610966529-benchmark-89.0.4389.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I258f84b42350d15ce40f06bd7d7530836128223f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846065}
-
Takashi Toyoshima authored
This patch introduces `is_prerendering` flag into CommitNavigationParams so that we can bring the prerendering state information to the renderer processes without any extra effort. This also removes NavigationRequest.is_prerendering as whenever we need it, commit_params->is_prerendering is available. Also, current approach does not intend to capture all cases as mentioned in the comment around SendCommitNavigation. We'd rely on MPArch in the near future to introduce precised implementation. Bug: 1169032 Change-Id: Ic1c12a77cf3cd6ca175235fd65d0ff1d7f0a968c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640514Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#846064}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.10-r1 to 89-4384.0-1610969724-benchmark-89.0.4389.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I81e620111330e6600f4040747cc8e80e3d26c925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644701Reviewed-by:
-
Kuo Jen Wei authored
Bug: 172340545 Test: tast -verbose run <DUT> "camera.CCA*" Change-Id: I41dac406e805e66036be6c141f2d5fdeafb6d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639994 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#846062}
-
Varun Khaneja authored
https://github.com/aawc/unrar/pull/25 for the corresponding change on Github BUG=1166496, 1166497, 1166498, 1166499, 1166500, 1166501, 1166502, 1166503 Change-Id: Idece6bd531d55f1b379d0a38fad5f74f64323749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634824Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#846061}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611284384-7c6617d93ef1b9fc70abe71fb9acc556bc65d8e5.profdata to chrome-win64-master-1611294737-17c8474f67761118ef8f2490ffa8a435d02d7f3f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4b3e269583880d4a1d817f8837f6016502f493e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644697Reviewed-by:
-
Michael Lippautz authored
Add the proper HashTrait to use the sentinel value for the library version. Bug: 1056170 Change-Id: I62e09904f46a7bb0f3f89d5687e8767d0b936b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643281 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846059}
-
Jason Lin authored
There is a long description about why we need this and how the algorithm work just above class VmInfo in vm_camera_mic_manager.cc. Bug: b/167491603 Change-Id: I7894609dd7d19ae1e69097508e942fca5792cfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643417 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#846058}
-
Alice Wang authored
This CL makes AccountPickerDelegateImpl independent of incognito package by moving the incognito mode policy check to SigninBridge. Bug: 1149857 Change-Id: Ib5ae49f71ea84a08131c70ecd3998eaefe5ac66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640654Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#846057}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a1550b6e356..ad73a7a4eb1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC snijhara@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: snijhara@google.com Change-Id: Ic927d195e863589b90b5d748dd59fa37ae653540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846056}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I771a733d07ae63b455da6fdffae070a6bb0d64e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644636Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846055}
-
Viktor Semeniuk authored
Bug: 1110293 Change-Id: If9e2de7acc4e788136af52f46880151988c2e0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642149Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#846054}
-
Chong Gu authored
Bug: 1054240,1054545,1058255 Change-Id: I945f5de761168432078ecd9c1787289e9608f92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542304 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#846053}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ff5f715e5c4a..c827ccbb58b8 2021-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 67fb6a84 to 318dff18 (435 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I737455704f768501e19108da8ccf11d58ce4fa3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643183Reviewed-by:
-
Saurabh Nijhara authored
This reverts commit 2af86102. Reason for revert: Build bot is failing and this CL appears to be the reason. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-trusty-rel/20312/overview https://bugs.chromium.org/p/chromium/issues/detail?id=1169629 Original change's description: > Switch cc_unittests/viz_unittests to SwANGLE > > This cl changes the software backend used for > running viz_unittests and cc_unittests from > SwiftShader GL to SwANGLE (ANGLE on SwiftShader > Vulkan). Other tests suites may be affected. > > From this cl, performance expectations for test > runs will likely change. For example, cc_unittests > appears to run faster, while viz_unittests and > views_unittests appear to run slower. Note that > this is still using the validating command decoder, > and once the OOP Raster tests can run on the > passthrough command decoder, we'll be able to use > it and gain some performance on all these test runs. > > TBR=kbr@chromium.org > TBR=weiliangc@chromium.org > TBR=eugenis@chromium.org > Reason for TBR: These changes were already reviewed here https://chromium-review.googlesource.com/c/chromium/src/+/2532042 > > Bug: chromium:1060139 > Change-Id: Idb0048d3a8e0dfe6855e1700ed26fb076be0c4f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580360 > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Evgenii Stepanov <eugenis@chromium.org> > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845826} TBR=eugenis@chromium.org,sugoi@chromium.org,sugoi@google.com,kbr@chromium.org,weiliangc@chromium.org,jmadill@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I114a082b893280b51279aebb51f621598064b733 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643283Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#846051}
-
Miriam Polzer authored
A recent bug (crbug/1155533) caused enrollment failures because StorePolicyEx took longer than expected. Record timings for StorePolicyEx to find a reasonable timeout value (or reset it to default). Bug: 1166126 Change-Id: I00376aa1057998f5d2887f71e0fa20285775d335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639838 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#846050}
-
Rushan Suleymanov authored
OnDeviceInfoChange() should be called on each change of the device info list. Some observers expect that this callback will be invoked on each change, even after loading from the persistent storage when the list hasn't been actually changed on browser startup. This CL slightly changes this behaviour. Observers will be notified when the metadata is fully loaded and the local device hasn't been changed. Bug: 1023457 Change-Id: I8012e5dda272bab7d218d9d51dca6ca5af5053ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633623 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#846049}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic1dc22536f9073029518170554c4a372d192909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644486Reviewed-by:
-
Greg Guterman authored
linux-rel-rts is directly comparable to linux-rel, except it has rts. Bug: 1159191 Change-Id: I36c4a63c7b86ea60eeb4f1f3da81dcee1156bf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630246 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#846047}
-
Christos Froussios authored
It is flaky Change-Id: I0a1f011768ddef79c16bd0945231fe3b96dd7146 BUG: 1168464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640037Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#846046}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: Ib6e9b3f4987fe7c39d372059db2b775540c197d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643318 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#846045}
-
Greg Thompson authored
r830353 tried to reduce refcount bumps, but perhaps that was wrong. R=fdoray@chromium.org Bug: 1156603 Change-Id: Ib9a3daa6ea1f087fef14ddeb5e49e74ef875dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596305 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f555b808fbf..b6e28b60dec0 2021-01-22 chrche@microsoft.com [Loc] Migrate css_overview to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a8e0cf9f550daede1b051a78d9794ad44411a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644487Reviewed-by:
-
Simon Zünd authored
The test expectation now account for the recently added Trust Token panel. R=sigurds@chromium.org Bug: chromium:1126824 Change-Id: I63ee32f88bd8ac3772cdbb4579f8fb2475ab3814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644616 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#846042}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I4bc6a1588542d3fcbb33d6ad81f4763a0c604215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643184Reviewed-by:
-
Luca Hunkeler authored
When the script enters an error, we automatically append a "Send Feedback" button. Bug: b/173401004 Change-Id: I62b47a0fb2f332cf74d4aaa1f287d1452c588d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575034Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#846040}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I852b35673e8f5fcf8fa71bcf90f8cd26a3d7c6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642683 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Aya ElAttar authored
- Added warn as one of the restriction levels, and add the required unittests. - Renamed the urls and patterns in the unittests to reduce confusion. Bug: 1169080 Change-Id: I806d1fb7aa8a4c94cd47b02e5be3a8636b2e26ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642776 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#846038}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I82e09683a3af5ed10e1653cc2f743c1a5c639346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643278 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL attempts to make the implementation of this class clearer via some renames, added comments and other minor changes. Some related code in SyncSettingsUtils is also touched: - Rename SyncSettingsUtils.getMessageId() to make it clear the returned value is the same as the sync status summary used in settings, only restricted to the special case of auth errors. The signature is also made more consistent with other methods in the same file. - Use Context.getString() consistently in getSyncStatusSummary(), rather than alternate between this and Resources.getString(). - Add more protective code to getSyncStatusSummaryForAuthError(). The method now guards against the case of no error, or an unknown auth error being passed. This doesn't influence any of the existing callsites. Bug: None Change-Id: I30dd52d2a3af66cc62e2037bc94bd1738f109766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632751 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#846036}
-
chrome://appsdpapad authored
Previously because of the long history of this page (which at some point served as the NTP, aka NTP4) it was served by a custom class which delegated logic to NTPResourceCache. There is no good reason to use the NTPResourceCache for chrome://apps anymore, AFAIK. Using a WebUIDataSource makes a lot of things simpler, like registering resources, localized strings, load time data, and many more. This is in preparation of possibly migrating chrome://apps to JS modules (TBD). Regardless, moving away from NTPResourceCache is a positive step. Bug: 1168053 Change-Id: If82d634c8d7e699dc1c906517c23c40bfaa0b6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629855Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846035}
-
Antonio Sartori authored
This is a refactoring converting the class content::FrameReplicationState to a mojo struct, allowing to get rid of some legacy IPC traits. Bug: 1165841 Change-Id: I76e32f3e05db77685e35f3ed93d64ebd1e859588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640116 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#846034}
-
Hiroki Nakagawa authored
This CL mechanically renames classes as follows: - PrerenderContents to NoStatePrefetchContents - PrerenderContentsDelegate to NoStatePrefetchContentsDelegate - ChromePrerenderContentsDelegate to ChromeNoStatePrefetchContentsDelegate Design doc: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing Bug: 1144577 Change-Id: I3d7aeb8479a2d0e96a0a99a22dd4806a4487becd Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640313 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611262248-acebbca4ed738fd78c31627253df071e74108512.profdata to chrome-win32-master-1611284384-cbab22d10b31440218b066d1280e2c1fdae62cdc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9235239284fd023162dee74dfb4a9ba40dce3bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643527Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611272973-8e4032da22e18455d35fc6237c90007c71899d37.profdata to chrome-linux-master-1611294737-27b810d0fa6cfabfc1ee245c9b50455ece63f3ea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I90366396f29a33c8f6cffb18558add5e93d6d1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643472Reviewed-by:
-
Benoit Lize authored
This reverts commit bb25c608. Reason for revert: WIP DO NOT LAND Original change's description: > Revert "[PartitionAlloc] Better freelist corruption detection." > > This reverts commit ac10443d. > > Reason for revert: Probably breaking mini_installer_tests and ProcessSnapshotTest.CrashpadInfoChild > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112543 > > Original change's description: > > [PartitionAlloc] Better freelist corruption detection. > > > > Some PartitionAlloc crashes are likely due to freelist > > corruption. PartitionAlloc has two types of freelists: in the central > > allocator, and in the thread cache. The central allocator one already > > has a DCHECK() to verify that subsequent entries belong the same > > superpage, which doesn't hold for the thread cache freelists. > > > > This CL: > > - Makes these crash lead to a NOINLINE function > > - Add an interity check to all freelists. > > > > This is not meant to be a security mitigation, but to prevent against > > accidental issues. > > > > Bug: 998048 > > Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218 > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840587} > > TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Idd7f8213dae35146d4ada835cd443505f88749ce > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 998048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612968 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840622} TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,mstensho@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 998048 Change-Id: I799d98335b5617d52a3eeb1e254d64f487144f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613267Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846030}
-
Jason Lin authored
This CL does not change the logic, but moves notification controlling logic into VmInfo. The reason is that we are going to implement some notification debounce logic into each VmInfo. This makes thing a bit simpler. It also merges `VmNotificationObserver` into `VmInfo` because we don't really need a separate class. A few notes: * `vm_info_map_`'s type is changed from `base::flat_map` to `std::map` because VmInfo is not copyable now. * VmCameraMicManager::{Open,Close}Notification() is moved into `VmInfo` with only some trivial changes. Bug: b/167491603 Change-Id: Ib41f68c67887e71563b90aeda37ef54ee60b1138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641827 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by: -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..5b2a5204087d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9bc6597dffd08b06b081bec61ae72f7821db65c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643034Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..5b2a5204087d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If33e7c1f6087cf1f80863b34d66014b0b34211ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643867Reviewed-by:
-
