Commits · 7e9579c8c897cb6512a9e3bb7b1ef975ff39808b · eriksson monteiro / tangled

15 Dec, 2017 40 commits

Don't perform cadence calculations using zero duration. · 7e9579c8

Dale Curtis authored Dec 15, 2017

21ece16c added support for using
the frame duration metadata in the muxed stream, but if the frame
timestamp is already int64_t::max(), computing the end timestamp
based on frame time + duration yields int64_t::max() so we can
end up with a duration of zero.

This updates the conditional to skip frame duration metadata when
we don't have a valid frame duration after the calculation.

BUG=793550
TEST=new unittest

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5bb728f18fbfba7df326b44f7b6159f2395a3fb5
Reviewed-on: https://chromium-review.googlesource.com/828287Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524434}

7e9579c8

Enable the sharing of non-HTTPS canonical URLs. · 38d8c9ba

Gregory Chatzinoff authored Dec 15, 2017

This CL enables the sharing of non-HTTPS canonical URLs if the
display URL is HTTPS, due to a requirements change. It also
updates the logging to treat HTTP canonical URLs as a success
case.

Bug: 794768
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I741949980f2d6d804a673ac82d950cdf735021df
Reviewed-on: https://chromium-review.googlesource.com/826051Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524433}

38d8c9ba

Get sbox_instrumentation_tests running on X64. · d4429890

Sigurdur Asgeirsson authored Dec 15, 2017

Because some intercepts run before the main binary is bound and
initialized, they cannot be instrumented on X64. This is because
the shadow memory is dynamically allocated, and so won't be available
until some time during or after binding.

Bug: 783296
Change-Id: I93b0bd81d325a452205351059bc6ba013618bb99
Reviewed-on: https://chromium-review.googlesource.com/825782
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524432}

d4429890

Revert "Remove navigation start observing from DataUseAscriber" · 07631d12

Thomas Anderson authored Dec 15, 2017

This reverts commit 73722a14.

Reason for revert: Breaking the Linux x64 build
https://ci.chromium.org/buildbot/chromium/Linux%20x64/55031

Original change's description:
> Remove navigation start observing from DataUseAscriber
> 
> There's no reason to PostTask a bunch of data to the IO thread to do a
> no-op method.
> 
> This CL should change no behavior.
> 
> Bug: 792524
> Change-Id: Ia0f88da99c72fa3369b164a2fd25352f77d13544
> Reviewed-on: https://chromium-review.googlesource.com/827980
> Reviewed-by: rajendrant <rajendrant@chromium.org>
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524424}

TBR=csharrison@chromium.org,rajendrant@chromium.org

Change-Id: I00a16f8e2ee77b767f4289ad01ca4a05c711fdc9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792524
Reviewed-on: https://chromium-review.googlesource.com/830473Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524431}

07631d12

Account for dip scale mismatch in VR for control height. · 665f9dec

Michael Thiessen authored Dec 15, 2017

In VR, we change the dip scale of the WebContents, but cannot properly
change the dip scale of Java UI because doing so would require
reinflating said java UI.

This leads to problems when determining the offset applied by the
top/bottom controls. RenderWidgetHostViewAndroid previously converted
the shown ratio of the controls to pixel values using the dip scale
of the WebContents, while ChromeFullscreenManager converted the control
height to pixels using the Java UI dpr. It then treated a mismatch
between these two values as the control container being visible, even
if the shown ratio was 0.

This CL changes the FullscreenManager to always apply fully-hidden
control offsets while in VR since the controls will be hidden anyways.

Bug: 793430
Change-Id: If18aa601ed51ea91cef6b83060972d216a8cd6a9
Reviewed-on: https://chromium-review.googlesource.com/818116
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524430}

665f9dec

Gather metrics on RSA key usage bits. · f8ebd2b9

David Benjamin authored Dec 15, 2017

Bug: 795089
Change-Id: I7772621479504e5797c579f6d45315f836d5bceb
Reviewed-on: https://chromium-review.googlesource.com/827809Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524429}

f8ebd2b9

Revert "Fix Windows touchpad lagging in first tab" · ffe75f56

Jianpeng Chao authored Dec 15, 2017

This reverts commit 12dca865.

Reason for revert: crbug.com/795223

Original change's description:
> Fix Windows touchpad lagging in first tab
>
> Currently the receiving of WM_MOUSEWHEEL messages lags when we open a
> URL on a new window until we resize. The issue was introduced by
> r384698. That CL change wait for MOUSE_EVENT to wait for SENDMESSAGE
> in MessagePumpForUI::WaitForWork to optimize the GPU thread. But the
> GPU thread does not use MessagePumpForUI anymore so it should be OK to
> just remove that code.
>
> The updated version of Chrome was tested to make sure that the hangs
> that were occasionally seen when using chrome://tracing are still gone.
>
> After this CL chaopeng@ need to monitor to make sure that the crash
> rate not increase.
>
> Bug: 713907, 596190
> Change-Id: I7545a867de4851acd4e57c9b8c7a3dd05def1dd8
> Reviewed-on: https://chromium-review.googlesource.com/809829
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523689}

TBR=thestig@chromium.org,brucedawson@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 713907, 596190, 795223
Change-Id: I3f53fd77e7a6545cd214444cac46709cff0142c9
Reviewed-on: https://chromium-review.googlesource.com/830174
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524428}

ffe75f56

Surface synchronization: Introduce flag for default deadline · 89eb2807

Fady Samuel authored Dec 15, 2017

In order to experiment with different deadlines on different machines,
this CL introduces a command line flag to set the default deadline to
synchronize.

Bug: 672962
TBR: sky@chromium.org for services/ui.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I58e8fd8431c439bca35ca0a3cb400046bf0dc2b6
Reviewed-on: https://chromium-review.googlesource.com/828123
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524427}

89eb2807

Ranker owns predictor objects and uses a config for initialization. · c97535bd

Philippe Hamel authored Dec 15, 2017

Ranker also takes care of logging and deals with field trials internally.

Bug: 786472, 778468
Change-Id: Ie583616643ab8ad169df4739a4a18b81a950553f
Reviewed-on: https://chromium-review.googlesource.com/788331
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524426}

c97535bd

Handle offline event in P2PSocketDispatcherHost · 11126aa0

Sergey Ulanov authored Dec 15, 2017

P2PSocketDispatcherHost is supposed to update network list even
when the system is offline (i.e. after last NIC is brought down).

Bug: 789125
Change-Id: Id732ca2e35f7ea435bc960fd37a2656b152fac32
Reviewed-on: https://chromium-review.googlesource.com/802237Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524425}

11126aa0

Remove navigation start observing from DataUseAscriber · 73722a14

Charles Harrison authored Dec 15, 2017

There's no reason to PostTask a bunch of data to the IO thread to do a
no-op method.

This CL should change no behavior.

Bug: 792524
Change-Id: Ia0f88da99c72fa3369b164a2fd25352f77d13544
Reviewed-on: https://chromium-review.googlesource.com/827980Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524424}

73722a14

Revert "Network Error Logging: Ignore Reporting API upload requests" · 80a69990

Mohsen Izadi authored Dec 15, 2017

This reverts commit a8a1b79e.

Reason for revert: Failures on Linux MSan Tests buildbot:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests

Original change's description:
> Network Error Logging: Ignore Reporting API upload requests
> 
> Right now, the ReportingUploader cancels requests once the headers are
> received, which causes the requests to fail with ERR_ABORTED, which
> triggers a NEL report.
> 
> This CL breaks that loop by attaching user data to upload requests and
> ignoring ERR_ABORTED errors stemming from them.
> 
> TBR=mkwst@chromium.org
> 
> Bug: 793392
> Change-Id: Id26516533ec0e7531797717526b015c56a742c1b
> Reviewed-on: https://chromium-review.googlesource.com/817553
> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524390}

TBR=mgersh@chromium.org,juliatuttle@chromium.org

Change-Id: I3e86f06bed769481a2ec6bdec109bdd590493ddc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793392
Reviewed-on: https://chromium-review.googlesource.com/830353Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524423}

80a69990

MSE: Increase const usage in SourceBufferRange classes · 2249115a

Matt Wolenetz authored Dec 15, 2017

Increases usage of const where appropriate in
SourceBufferRange{,ByDts,ByPts} classes. I found and am fixing this while
working on patches to fix bug 791095.

BUG=791095

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If8d70f80e36462fce62451a3a189485bb9774eef
Reviewed-on: https://chromium-review.googlesource.com/825965Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524422}

2249115a

[u2f] Fix U2F BLE UUIDs · 52fec7bc

jdoerrie authored Dec 15, 2017

This change modifies the U2F BLE UUIDs to have extern linkage and
renames them to comply with the style guide naming conventions for
constants.

Bug: 763303
Change-Id: Ica2cb8f62c83d3a2fdcb4cdfc265735675e9e6af
Reviewed-on: https://chromium-review.googlesource.com/829175Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524421}

52fec7bc

Roll src/third_party/skia/ 67a86d50f..29c14a760 (4 commits) · 003f7a27

skia-deps-roller@chromium.org authored Dec 15, 2017

https://skia.googlesource.com/skia.git/+log/67a86d50f38d..29c14a760682

$ git log 67a86d50f..29c14a760 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 caryclark fix very large clipped path limit
2017-12-15 reed hide SkImageDeserializer
2017-12-15 caryclark working on image docs
2017-12-13 caryclark fix zero length dashed lines

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I568feeb43b109d9141e9e7a9c245bad28c1f136e
Reviewed-on: https://chromium-review.googlesource.com/829973Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524420}

003f7a27

Revert "Network Error Logging: Ignore Reporting API upload requests" · 7dc15ab3

Miriam Gershenson authored Dec 15, 2017

This reverts commit a8a1b79e.

Reason for revert: Caused MSan failures. (Thanks Findit!) https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/6611

Original change's description:
> Network Error Logging: Ignore Reporting API upload requests
> 
> Right now, the ReportingUploader cancels requests once the headers are
> received, which causes the requests to fail with ERR_ABORTED, which
> triggers a NEL report.
> 
> This CL breaks that loop by attaching user data to upload requests and
> ignoring ERR_ABORTED errors stemming from them.
> 
> TBR=mkwst@chromium.org
> 
> Bug: 793392
> Change-Id: Id26516533ec0e7531797717526b015c56a742c1b
> Reviewed-on: https://chromium-review.googlesource.com/817553
> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
> Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524390}

TBR=mgersh@chromium.org,juliatuttle@chromium.org

Change-Id: I8aae7138cb616fb86e038463c80560f9e916f0c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793392
Reviewed-on: https://chromium-review.googlesource.com/830313Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524419}

7dc15ab3

[Nav Experiment] Set virtual URL for restore_session.html items. · ca387231

Danyao Wang authored Dec 15, 2017

This CL handles two cases:
1) When restore_session.html is first loaded, set virtual URL to the
   item that will be displayed when session is fully restored.
2) If a restore_session.html is loaded in the webview, set the virtual
   URL to the encoded URL, as that will be the page that will eventually
   be displayed.

Moved session restore logic into a separate util file so it's easier to
test.

Bug: 789993
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1547f792f1e3de0bf97d11dced09383b82c507fc
Reviewed-on: https://chromium-review.googlesource.com/817713
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524418}

ca387231

Reland: Win video capture: use IMFCaptureEngine for Media Foundation · 7c1a115d

Réda Housni Alaoui authored Dec 15, 2017

Fixes for reland:
- "Win8 Tester" browser_tests_functional failure
- "Win8 Tester" capture_unittests failure

Original description:
- Full rewrite of the MediaFoundation implementation video part to use
IMFCaptureEngine
- Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities
- takePhoto triggers a still image capture with the highest available
resolution without stopping the video stream thanks to IMFCaptureEngine

TEST=adapted video_capture_device_unittest.cc and
webrtc_image_capture_browsertest.cc; launch Chrome with
--force-mediafoundation on Win8+ and capture video using
e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/

R=mcasas@chromium.org

Bug: 730068
Change-Id: I3835a48ca8516fc66a6a8394b3709d4dea862f89
Reviewed-on: https://chromium-review.googlesource.com/734042
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521435}
Reviewed-on: https://chromium-review.googlesource.com/810766
Cr-Commit-Position: refs/heads/master@{#524417}

7c1a115d

[Media Router] Fix an attribute name in media_router_bindings.js · 97c114b8

Takumi Fujimoto authored Dec 15, 2017

This CL corrects the provider ID attribute name, which was causing data to not get converted to Mojo properly.

Bug:
Change-Id: I476e17eeb82387090fe6a5f6003fa60d04d40df5
Reviewed-on: https://chromium-review.googlesource.com/828288Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524416}

97c114b8

Local NTP: Expose "MV available" to the page, don't load tiles until it is · 89b8b215

Marc Treib authored Dec 15, 2017

This works around a race condition between loading the page and the IPC
message that contains the MV items.
Before this CL, if the page load won the race, then it would assume there
are no tiles and load incorrect metrics. This CL exposes "did we ever
receive MV tiles" to the page, so it can delay loading them while they're
not available anyway.

This is very much working around the symptoms rather than fixing the root
cause. Unfortunately I have no idea how to really fix the issue.

Bug: 794942, 793818
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I091b71d17d36e28b3f53ceebef6829ef23d82b3b
Reviewed-on: https://chromium-review.googlesource.com/829254Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524415}

89b8b215

[scheduler] Extra protection against empty tasks in scheduler · 2b16b45b

Alexander Timin authored Dec 15, 2017

R=skyostil@chromium.org
BUG=789901

Change-Id: I39e845e80772571c9bac3c0d5f53fb04c3c53be5
Reviewed-on: https://chromium-review.googlesource.com/823031
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524414}

2b16b45b

macOS V2 Sandbox: Harden sandbox by specifying vnode-type for writes. · 411ce7e1

Greg Kerr authored Dec 15, 2017

This hardens the macOS sandbox by specifying an explicit vnode type for
all writeable files, reducing the risk that an attacker can symlink a
file Chrome has write access to, and modify the filesystem at will.

Bug: 793402
Change-Id: I53bbcc84345e432756eff0d2dc18a505719fd521
Reviewed-on: https://chromium-review.googlesource.com/829877Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524413}

411ce7e1

[DIAL] (1st) Added SafeDialAppInfoParser class to parse DIAL app info XML · d94535b3

Bin Zhao authored Dec 15, 2017

Recent changes removed dial_device_description_parser_impl* from
chrome/utility/media_router and introduces a new SafeXmlParser.
(https://chromium-review.googlesource.com/c/chromium/src/+/770920)

Abandoned previous DialAppInfoParser patch
(https://chromium-review.googlesource.com/c/chromium/src/+/745538),
resolved most comments in the new patch and added a SafeDialAppInfoParser
class which uses SafeXmlParser.

Bug: 779892
Change-Id: I1c0d141381e1a8c992888476e8643385a96db06f
Reviewed-on: https://chromium-review.googlesource.com/826126Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524412}

d94535b3

Revert "[cfi-icall] Refactor GL g_driver_* to be CFI-safe" · 2fce2f62

Eric Karl authored Dec 15, 2017

This reverts commit a71b54d8.

Reason for revert: Breaking the Linux Debug NVidia bot. See crbug.com/795332 for more details.

Original change's description:
> [cfi-icall] Refactor GL g_driver_* to be CFI-safe
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. To account for this, we place the function pointers in the
> various g_driver_* structs in ProtectedMemory, a wrapper for keeping
> variables in read-only memory except for when they are initialized.
> Once they are set they can not be tampered with since the memory is set
> back to read-only.
> 
> The generated bindings in gl_bindings_autogen_*.cc are not aware of the
> fact that their implementation is held in protected memory, so instead
> of using base::UnsanitizedCfiCall() we mark the individual function
> stubs with __attribute__((no_sanitize("cfi-icall"))) to disable icall
> checks on the generated bindings since their function pointer calls
> are routed through protected memory.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I6bbf1b9a4122e1d00f6d2a365ae3730b4bb95a73
> Reviewed-on: https://chromium-review.googlesource.com/770252
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524318}

TBR=dcheng@chromium.org,dalecurtis@chromium.org,kbr@chromium.org,sandersd@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: Ib4a1eae5e9f01f5e9ddbb1fcc5c66fc0b91f1015
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365, 795332
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/830173Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524411}

2fce2f62

Roll src/third_party/breakpad/breakpad/ a61afe7a3..c28363020 (4 commits) · e00cccb3

Robert Sesek authored Dec 15, 2017

https://chromium.googlesource.com/breakpad/breakpad.git/+log/a61afe7a3e86..c283630201ac

$ git log a61afe7a3..c28363020 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 rsesek Reconcile -[BreakpadController withBreakpadRef:] with its documentation.
2017-12-11 wittman Update binaries with dump_syms changes to write new field
2017-12-11 wittman Write field indicating multiple symbols at an address in dump_syms
2017-12-05 adamharrison Remove duplicate import.

Created with:
  roll-dep src/third_party/breakpad/breakpad

Change-Id: I75b9d3a240b9818e2f527a591c6be2a61974088c
Reviewed-on: https://chromium-review.googlesource.com/829674Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524410}

e00cccb3

Run blink unit tests under swarming on chromium.webkit mac bots. · 4d8e9e89

Dirk Pranke authored Dec 15, 2017

R=jbudorick@chromium.org

Change-Id: I480364ec2aa241cdfc9b0f016cdb008f5226ecac
Reviewed-on: https://chromium-review.googlesource.com/821558
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524409}

4d8e9e89

Change all vr/latest to xr · 01e52637

Anna Maria authored Dec 15, 2017

Renaming WebVR 2 code to WebXR as per community group desision.

Bug: 670510
Change-Id: Ia85cfe584afa3e21d4634414748e11f3c9b9bfc3
Reviewed-on: https://chromium-review.googlesource.com/823424Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524408}

01e52637

[webkitpy] Treat LayoutNG name mismatch as PASS · 8dfa5b84

Xiaocheng Hu authored Dec 15, 2017

This patch changes the layout test runner to treat LayoutNG name
mismatch (e.g., LayoutBlockFlow vs. LayoutNGBlockFlow) as PASS instead
of TEXT failure, to reduce noise in test result.

Bug: 795043
Change-Id: Ia0a358f7ccf47cc809fff6b20eea1847d4754413
Reviewed-on: https://chromium-review.googlesource.com/828276Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524407}

8dfa5b84

Update V8 to version 6.5.71. · 38856cf6

v8-autoroll authored Dec 15, 2017

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a49f2ad6..eaa72a5e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I247bec30d451790ee7a95c3de3f8b41921d26694
Reviewed-on: https://chromium-review.googlesource.com/829673Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524406}

38856cf6

[AFL] Make metzman@chromium.org an OWNER of third_party/afl · 1866c593

Jonathan Metzman authored Dec 15, 2017

Bug: 
Change-Id: I8f9d5efa70f298fe523fc3caf1d4b1baacd8ebae
Reviewed-on: https://chromium-review.googlesource.com/828714Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524405}

1866c593

Custom Tabs: remove WPR support from customtabs_benchmark script. · e30a30c4

Matthew Cary authored Dec 15, 2017

This script used the old python WPR wrapper, which has disappared in
favor of a Go-based server which may or may not be publically
supported (see crbug.com/795229). For the time being, it seems expedient
to just tear out WPR, and hence traffic-shaping, support in the script.

Change-Id: Ia001929a110b580fb35ae0cc2b8f8d7c80154caf
Reviewed-on: https://chromium-review.googlesource.com/829034Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524404}

e30a30c4

[Telemetry] Remove spaces from story names. · cbd7a670

rnephew authored Dec 15, 2017

TBR: bustamante@chromium.org
Bug: 781409
Change-Id: Ie2c3eda81add06d897369933588363ebc293c4e7
Reviewed-on: https://chromium-review.googlesource.com/823178
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#524403}

cbd7a670

Disable new viz_browser_test failures · 94ef1e1b

Jonathan authored Dec 15, 2017

After landing viz_browser_test on the Windows FYI bot even more failures have
turned up. I'm disabling them until we triage/fix them.

TEST=viz_browser_test
TBR=kylechar@chromium.org

Bug: 794961
Change-Id: I0d80fe1404174e1b94260389877a5c1d6d19333f
Reviewed-on: https://chromium-review.googlesource.com/829616Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524402}

94ef1e1b

Support both default and test Verified Access servers. · 870084cc

Yves Arrouye authored Dec 15, 2017

The servers are picked using the same command line switch that we use
to pick PCAs.

BUG=b:69687094
TEST=None

Change-Id: Ia1c79fda63e2d3d07b44da1ce814974d56d6726d
Reviewed-on: https://chromium-review.googlesource.com/795187
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524401}

870084cc

[vr] Suggestions visual tweaks · 3c9069f3

Ian Vollick authored Dec 15, 2017

This CL adds a drop shadow behind the omnibox suggestions (which needed
a bit of a topological change), adds spacers above and below the
suggestions, and adds and binds corner radii.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If9dc8939896de59708aeedc566a564850fcf3639
Reviewed-on: https://chromium-review.googlesource.com/828391
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524400}

3c9069f3

Fix filter for renamed tests · 4ee9515c

Reilly Grant authored Dec 15, 2017

r524372 renamed a number of tests from WorkerFetchTest.* to WorkerTest.*
and removed parameterization for the OffMainThreadFetch feature. This
change updates the filters for network_content_browsertests to match.

Bug: 794089
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia7b44629161a71d66787477c6077cb26712ecb19
No-Try: true
No-Presubmit: true
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/829974Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524399}

4ee9515c

Roll src/third_party/skia/ 2b4bc3c31..67a86d50f (1 commit) · 50ddaa75

skia-deps-roller@chromium.org authored Dec 15, 2017

https://skia.googlesource.com/skia.git/+log/2b4bc3c31636..67a86d50f38d

$ git log 2b4bc3c31..67a86d50f --date=short --no-merges --format='%ad %ae %s'
2017-12-15 mtklein Try /Z7 on Windows builds.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Id89dcc64df7dc056dbd9afe48d9380eb672b634f
Reviewed-on: https://chromium-review.googlesource.com/829533Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524398}

50ddaa75

Work around a Monorail API bug ('cc' field in issue body) · 053af45b

Robert Ma authored Dec 15, 2017

The type of 'cc' field is inconsistent with the API docs. Marshal the
field to work around the bug for now.

Bug: 765334, monorail:3300
Change-Id: I1b252b649b665e77ff643b34b87ce9587723db0d
Reviewed-on: https://chromium-review.googlesource.com/826186Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524397}

053af45b

[AF] Fixes the scrolling problem with the FormSuggestionView · fbaaaf60

Mohamad Ahmadi authored Dec 15, 2017

Bug: 792879
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic86fa2a72adeab804c22a62efa9b291408e5b482
Reviewed-on: https://chromium-review.googlesource.com/827725Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524396}

fbaaaf60

Upstream track-webvtt-tc[021-025]-*.html tests · d33b073d

Sriram authored Dec 15, 2017

Upstream the below tests from media/track/ to wpt
1. track-webvtt-tc021-valign.html
2. track-webvtt-tc022-entities.html
3. track-webvtt-tc023-markup.html
4. track-webvtt-tc024-timestamp.html
5. track-webvtt-tc025-class-markup.html

Bug: 782555
Change-Id: Ib5159571de1efee1e4cb9b94fcede977e813aad2
Reviewed-on: https://chromium-review.googlesource.com/826846
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#524395}

d33b073d