- 18 Oct, 2019 40 commits
-
-
Gordon Guan authored
Add static thread-safety checks to DiscardableSharedMemoryManager to ensure lock is acquired before using fields which require synchronization. Change-Id: I063676b6d4a03b96c24dde6b509cb368f1f7010e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862861Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Gordon Guan <gordonguan@google.com> Cr-Commit-Position: refs/heads/master@{#707413}
-
Jonathan Backer authored
Copies logic from GLRenderer with InProcCommandBuffer: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?rcl=04fbda1c2420a137a9f85889084a166f8a66b5d9&l=5866 Bug: 1012472 Change-Id: Iaca1be33e548c8987a06729a3571dbb2aed9c04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867191Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707412}
-
Alexander Timin authored
R=skyostil@chromium.org,ahemery@chromium.org Change-Id: I9b4b874f8de4800dbf5d1e9b50c6c94e86be44e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868959 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707411}
-
Aya ElAttar authored
Deprecate the following policies, because the redundancy with PowerManagementIdleSettings and ScreenLockDelays is distracting and misleading. - ScreenDimDelayAC - ScreenDimDelayBattery - ScreenOffDelayAC - ScreenOffDelayBattery - ScreenLockDelayAC - ScreenLockDelayBattery - IdleWarningDelayAC - IdleWarningDelayBattery - IdleDelayAC - IdleDelayBattery - IdleActionAC - IdleActionBattery - IdleAction Bug: 346229 Change-Id: Ib50ad8c0c6b723c15b684b8af4b70758210922eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839957Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#707410}
-
Hitoshi Yoshida authored
Creates elements for constructors. Our new compiler supports constructors in the new style as interface members, and do not support extended attributes' style. Bug: 839389 Change-Id: I42ec9acda2c41baf3dadb18e2221364279b633dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847598Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#707409}
-
Marc Treib authored
ArticleEntry used to be an alias for sync_pb::ArticleSpecifics. However, the Sync data type for articles doesn't exist anymore, and we'd like to delete the protos. So this CL replaces the alias with a simple struct. This lets us remove all build dependencies from dom_distiller to sync. Bug: 1007942 Change-Id: Ia9eb2cb3256a540ab3b2f63e8ae621f92121ed1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869223 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#707408}
-
Rohit Rao authored
Updates to use the new backwards-compatible header and modifies some calls that have changed syntax in EG2. With this CL, the tests themselves remain running as EG1 tests. BUG=987646 Change-Id: I9957c69cfa042224b55015d93236a133f2e7c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869470Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#707407}
-
Michael van Ouwerkerk authored
Bug: 995256 Change-Id: I1b4c1941df162a1946b1e63204be98ea679821aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869509Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707406}
-
Peter Kotwicz authored
This CL fixes WebappSplashScreenTest on Android L that the original CL (https://chromium-review.googlesource.com/c/chromium/src/+/1857205) missed This CL matches the status bar behaviour of WebAPKs to that of TWAs by: - Changing the status bar colour used by WebAPKs when the Web Manifest does not provide a "theme_color" to white. This requires increasing MINIMUM_REQUIRED_CHROMIUM_VERSION_NEW_SPLASH - Making the status bar use dark icons if the Web Manifest provides a light colour. BUG=997793 Change-Id: Ib8fc5ac61536fd8dd4c4c309ce35027a8fc0c872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867306 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707405}
-
Vladislav Kaznacheev authored
This reverts commit e41bbad7. Reason for revert: Breaks dragging to/from overflow bubble. There was a test for that, but it was skipped due to kShelfScrollable enabled by default. Original change's description: > Fix double app icon when dragging app to shelf > > When an app is being dragged from app list to shelf, > a new shelf item is created and made hidden by setting > its size to (0,0). It is supposed to stay at this size > until the drag is complete. > > However, if a drag started very soon after some other shelf > manipulation (e.g. drag leaving the shelf and re-entering quickly), > it is possible for AnimateToIdealBounds to be called asynchronously. > The hidden item's bounds will be animated to full size, resulting > in a visible icon. > > This CL makes AnimateToIdealBounds ignore shelf items with (0,0) size. > > Bug: 985631 > Test: manual > Change-Id: Ieb23beb6ecf635ae60613f5f6217219f7963999b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862507 > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706148} TBR=kaznacheev@chromium.org,manucornet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985631, 1015688 Change-Id: Idbf8910c6d495a59b398592919a7e2ebb21823e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868976Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#707404}
-
Leonard Grey authored
This is necessary to avoid a crash when FireWinAccessibilityEvent checks command line flags. Bug: 1015713 Change-Id: Ided383d5825ecd38e7aed9da5870381bb8a7471e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868591 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707403}
-
Jazz Xu authored
Update lock screen media controls layout and icons. Bug: 1015133 Change-Id: I288f4826e490c18d40217ddbfd4305b25fd8c514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865717Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707402}
-
Etienne Bergeron authored
This CL is adding special handling for the the control codepoints (block C0). Previously, only the control character \n was replaced by its visual symbols. Other control characters are not handled by ShapeRuns which is leading to expensive fallback fonts calls. (see http://crbug.com/993100) Control codes: https://en.wikipedia.org/wiki/C0_and_C1_control_codes The symbols used to display these control characters: https://www.compart.com/en/unicode/block/U+2400 Bug: 1011818, 1014119 Change-Id: I924dcb13c9e0e11d321ef375cd4285432aaf6cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863394 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#707401}
-
Alex Chau authored
- Removed unused methods - Add ForTest for testing methods - Unified SharingMessageHandler creation Bug: 1015826 Change-Id: I99c8e1ea600969bd4bf2df4a648fb4c7746bc4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868958 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707400}
-
Thomas Lukaszewicz authored
Added support for circular profile icons in the People system menu for Mac chromium builds. Updated the reference to the placeholder icon to use the higher resolution version. Bug: 857064 Change-Id: I93e68f13ea88827f4ac939d982d4ac55f83cf2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856876Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707399}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/87ede8895026..2e43102c54d1 git log 87ede8895026..2e43102c54d1 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 lalitm@google.com trace_processor: add benchmark for RemoveIf and UpdateSetBits Created with: gclient setdep -r src/third_party/perfetto@2e43102c54d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: Iecb2ff41cb5e9d0fae3194de79c96c6f6c41ee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707398}
-
Joey Arhar authored
This change removes an unnecessary update to children of <input type="text"> elements when any attribute is modified on the element. A similar patch was made in WebKit here: https://trac.webkit.org/changeset/208653/webkit In the WebKit patch, the update still occurs if the attribute is "value" or "placeholder." We already handle "value" attribute changes in a case in HTMLInputElement::ParseAttribute, and we already handle "placeholder" attribute changes in TextControlElement::ParseAttribute. Since we handle those cases explicitly, we can remove the entire AttributeChanged function. Bug: 1012774 Change-Id: Ib75fde9c5b3e1f9eea4232bf5bfa915d573b9c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865658Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#707397}
-
chrome://device-emulatordpapad authored
Replacing calls to global device_emulator.bluetoothSettings methods with WebUI events and FireWebUIListener(). This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: I3d8bc7f5b008e734670393c0832f741f13195e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868089Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#707396}
-
Lan Wei authored
This reverts commit 916c54c5. Reason for revert: abDragTabSharingUIViewsBrowserTest.DragTab and TabDragTabSharingUIViewsBrowserTest.DragSharedTab fail on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > Add browsertests for tab sharing UI views. > > Add tests to verify tab sharing UI elements: infobars, contents border > and tab sharing indicator. > > Bug: 996722 > Change-Id: I5fa5ec7e4a48a66c1ba9b08ff76b84a105961352 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847287 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707368} TBR=guidou@chromium.org,marinaciocea@chromium.org Change-Id: I3e000bbd82d3fe3f78684d200cb2c10b4171328e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869116Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707395}
-
Rohit Rao authored
BUG=987646 Change-Id: I41920758c20b88c0a20a609286a2203c4be2fce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865404 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#707394}
-
Francois Buergisser authored
When changing the resolution while decoding and using video decoder, VIDIOC_S_FMT on the output buffer will return EBUSY. Before changing the output buffer format, the capture buffer must be destroyed. This patch, moves the capture buffer destruction before changing the output buffer's format as per specification [1]. [1] https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-stateless-decoder.html#dynamic-resolution-change BUG=b:142828922 TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie-kernelnext. TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie-kernelnext. TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie-kernelnext. TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie-kernelnext. Signed-off-by:
Francois Buergisser <fbuergisser@chromium.org> Change-Id: I304cd4b7e52d95bec4dcf4bcb803439c6f8cf273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868574 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#707393}
-
sczs authored
Bug: 1014652 Change-Id: I522701fb329af27600ba038b7f6c7b6bb205fa10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866859Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707392}
-
Thomas Tangl authored
... for regular profiles. Additionally: - Make heading clickable and link to 'Edit person' page. - Remove identity title when profile is not signed-in. - Add horizontal margin to identity text. Screenshot: https://drive.google.com/file/d/1y4ewSqp2Uw3c4DFH3HgwspOS8a4u0i5C/view?usp=sharing https://drive.google.com/file/d/1IK4tjzTewrTd-Ane9forYL377538IvBL/view?usp=sharing Bug: 995720 Change-Id: I608fdc7a6d6aec31def7f8bfde1f9ef355c4de16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868876Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#707391}
-
kylechar authored
This CL switches the order notifying all contexts about context loss and restarting the GPU process for the exit_on_context_lost GPU driver bug workaround. This will ensure the contexts are lost before the process exists. Also add an early out so no new GPU channels are created while the GPU process is exiting. There is no point in creating new GPU channels at this point as it can only cause problems. Bug: 1011420 Change-Id: I10294074cc9f2f087124f1cb68fedf22ed364a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866408 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707390}
-
Bill Budge authored
- Changes very large code entry writing to create an indirection. The first entry is double-keyed just like other size entries. However, it contains response time, size, and a hashed checksum of the data. The checksum is used as a second key for another entry that contains a no header and the actual code. - Changes very large code entry fetches to do a double-keyed read as before. If there is a checksum in the header, that is used as a second key to read the actual code. - Every origin that loads a given resource for the first time will get a cache miss. To get a cache hit, the origin must first generate code and write it to the cache. The code is checksummed using SHA-256 to make it very unlikely for a malicious origin to store its code to the same key as another origin. Origins that generate identical code share the same code entry. Design Document: https://docs.google.com/document/d/1SCH15oCFJW55jsTJZ0T7XAQIZVryI_IJOIENyL_q4n4/edit Bug:chromium:936107 Change-Id: If99d2dada102382d51f97286fb3e5d9d2faf3aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846102 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707389}
-
Alex Chau authored
- The parameter order of manufacturer was flipped Bug: 1009454 Change-Id: Ia2bdcf4acb9693a7deab083c535db3f474337aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866728 Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#707388}
-
edchin authored
This CL moves PerformBatchOperations() out of the responsibility of WebStateList serialization and into the caller's responsibility. This allows callers to define what a batch operation is. For example, when restoring closed tabs, a batch operation includes modifying TabRestoreService at the same time as adding WebStates to the WebStateList. Note: PerformBatchOperation was recently added to web_state_list_serialization in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1865161 Bug: 1014526 Change-Id: I40b11e4fe9b30a5fe18e0e8e404c298b04676d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867389 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#707387}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34a196e3. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I117e86fa0e271dc3c885853c57da6e77f65e901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869349Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707386}
-
Armando Miraglia authored
When applyConstraints is called on a track, the capabilities are limited to what the settings already set on the track. This also means that the constraints algorithm needs to guarantee that the same processing-properties type is selected. So far, we have done so by allowing a single processing-properties group to be initialized when the capabilities are set. This approach is, however, incompatible with applyConstraints reconfiguration. This CL guarantees the same requirements, but simplifying the logic and always initializing all the processing-based groups for processing. It also adds the possibility to inspect the processing type selected by returning the extra field when the select-settings algorithm is run. BUG=796964 Change-Id: Ib34f7d33eb3aa8e1460aebcda20941df0503fa62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847275 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#707385}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: I57cc3e19641af73e745ea1b224947586ba2287bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834035 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#707384}
-
Matt Menke authored
Also add NetworkService API to enable partitioning auth cache entries by NetworkIsolationKey, and a field trial to set it to true. All done in one CL to allow integration testing. Bug: 993806 Change-Id: I323826847cda68e0e1acd776dc6ba260743d3952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865411 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#707383}
-
Derek Beckett authored
Adding an API that will refresh (refetch) Enterprise Policies when called. This will remove the need for automated testing to go to the chrome://policy page, and "click" the refresh button via a js call. Bug=chromium:1012712 Test=Locally deployed and tested and basic unittest. Change-Id: Iedc3c2e349cceb7f8b076259877d548b9f4babda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683103 Commit-Queue: Derek Beckett <dbeckett@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707382}
-
Mikel Astiz authored
Some of the SyncEncryptionHandler APIs are about decrypting pending keys, but the keys themselves should NOT be added directly to the main cryptographer, to avoid leaking keys accidentally (or wrong ones). Instead, let's use temporary keybags to decrypt pending keys. Bug: 922900 Change-Id: Ie7af21ce7dccdc1422e3b4375f9519b5835ea379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866829Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707381}
-
Luke Zielinski authored
This will fix the breakage of go/wpt-waterfall and resume running tests. Bug: 996842 Change-Id: I1df7072de6f344c846cffa044b87ed57e3bdd51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864563Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707380}
-
Dan Harrington authored
This change simply avoids using RunUntilIdle. I found that RunUntilIdle was taking 10 seconds for every invocation -- but not on every test run. I'm not sure of the cause, but using RunUntilIdle is bad practice anyway. Where possible, I'm using QuitClosure, but we can't do that in all cases. Bug: 1014706 Change-Id: Icf538182c9572eaa26aa8d5dd6365981555ee1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864418 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707379}
-
Olivier Li authored
This is done to be able to prepare tests before eventually submitting a CL that flips the experiment to ENABLED_BY_DEFAULT. Bug: 661143 Change-Id: I6b614bb4400478a7e90de78562a54083af1b3bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865596 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707378}
-
Randy Rossi authored
The ConvertToAXActionData() function in automation_internal_api.cc was leaving the horizontal_scroll_alignment and vertical_scroll_alignment fields in AXActionData to their default value of ax::mojom::ScrollAlignment::kNone. When the target was a blink object, web_ax_object.cc would then use 'no scroll' values for both hidden and partially hidden cases for its converted blink::ScrollAlignment struct. This was causing the SCROLLTOMAKEVISIBLE action to not scroll the view to make the object visible. Bug: 1015144 Test: Manual test with display assistant screen reader Change-Id: I20dcd48587704ba42a33c7d27fb81c7d8a8a4ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864824Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707377}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/299bea643826..7f418fc2677a git log 299bea643826..7f418fc2677a --date=short --no-merges --format='%ad %ae %s' 2019-10-18 courtneygo@google.com Vulkan: lineloop support for DrawArrayIndirect Created with: gclient setdep -r src/third_party/angle@7f418fc2677a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: If1a7fee2a720728e61bc0db22e366d631524546c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707376}
-
David Benjamin authored
Bug: none Change-Id: Iadcb1b111922a417e09293e2e73bec7b464e9c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869031 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707375}
-
Yuki Shiino authored
I guess that this breakage was caused by https://crrev.com/c/1834142 or related patches. Change-Id: I1b93bd71743474432de38e86e6384f4b76b575eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869230Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707374}
-