GitLab

Adapted from rsleevi's original patch. The initial version of the tool rewrites
all implicit conversions of scoped_refptr<T> to T*, even unsafe ones where a
temporary scoped_refptr<T> is assigned to a T*. A small tweak/hack has also
been added to run_tool.py to allow it to handle replacements that contain
embedded newlines.

BUG=110610
R=mdempsky@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/446203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288163 0039d316-1c4b-4281-b951-d872f2087c98

I also updated ProvisionalSaveFailure in histograms.xml, which was an oversight from a previous cl.

BUG=386402

Review URL: https://codereview.chromium.org/421563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401778
TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/450823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288161 0039d316-1c4b-4281-b951-d872f2087c98

R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/444163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288158 0039d316-1c4b-4281-b951-d872f2087c98

Now this condition never happens after r287686 and BUG=344393
r287686 got rid of lost_resource from this condition.
BUG=344393 made a client never destructed before releasing all mailboxes.

BUG=344393

Review URL: https://codereview.chromium.org/451723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288157 0039d316-1c4b-4281-b951-d872f2087c98

std::string.

R=mek@chromium.org

Review URL: https://codereview.chromium.org/448193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288156 0039d316-1c4b-4281-b951-d872f2087c98

url_request_http_job.cc contains a TODO comment for WebSocket
throttling. Since this was landed in
https://codereview.chromium.org/240873003 the comment is no longer
needed. Remove it.

BUG=343107
TEST=net_unittests

Review URL: https://codereview.chromium.org/445373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333201

Review URL: https://codereview.chromium.org/444253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338538
R=rvargas@chromium.org,brettw@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/444323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288152 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288151 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/da7a944e293d27ec5c7be06b224921ae0058d35a..0aeea6d344f12e35e29a79f4bbc48af88f913204

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/446423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288150 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275039
NOTRY=True

Review URL: https://codereview.chromium.org/437323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288149 0039d316-1c4b-4281-b951-d872f2087c98

Pass ServiceProvider thru ViewManagerService::Embed() allowing embedder & embeddee to expose services to each other alongside the Embed action.

R=darin@chromium.org,sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/433513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288148 0039d316-1c4b-4281-b951-d872f2087c98

This allows badging the wrench menu and showing the "Update
Google Chrome" item in the menu when critical variations
updates are available.

BUG=394855

Review URL: https://codereview.chromium.org/421643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279351

Review URL: https://codereview.chromium.org/427903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288145 0039d316-1c4b-4281-b951-d872f2087c98

> With the overlay path moving back to passing AcceleratedWidgets, move the implementation back into the surface factory.
> 
> Review URL: https://codereview.chromium.org/445163003

TBR=achaulk@chromium.org

Review URL: https://codereview.chromium.org/447073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288144 0039d316-1c4b-4281-b951-d872f2087c98

The socks client socket correctly requests the HostResolver only
give it IPv4 addresses, but the HostResolver ignored that flag when
passed IPs directly.  This fixes that behavior.

BUG=379031

Review URL: https://codereview.chromium.org/435603008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368750
R=sadrul
TEST=on device and desktop

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287772

Review URL: https://codereview.chromium.org/404423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288142 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390267

Review URL: https://codereview.chromium.org/442803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288139 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=darin@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/445253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288138 0039d316-1c4b-4281-b951-d872f2087c98

With the overlay path moving back to passing AcceleratedWidgets, move the implementation back into the surface factory.

Review URL: https://codereview.chromium.org/445163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288137 0039d316-1c4b-4281-b951-d872f2087c98

This is a first, very small step towards making NaCl work in app_shell.

BUG=400577
TEST=compiles
TBR=brettw@chromium.org for moving a few lines out of chrome/common/BUILD.gn into extensions/common/BUILD.gn

Review URL: https://codereview.chromium.org/435343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288136 0039d316-1c4b-4281-b951-d872f2087c98

This CL re-lands https://codereview.chromium.org/410033002 while addressed a few issues.
1. --results-directory must be passed along with --generate-gtest-json
2. --test-platform, --annotate, --build-number, --builder-name should be passed in order to upload results to correct dashboard
3. This CL depends on https://codereview.chromium.org/414223011/ to fix a bug in runtest.py

BUG=329102
R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/414383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288134 0039d316-1c4b-4281-b951-d872f2087c98

Changes test ozone platform to not produce any output when --ozone-dump-file is not specified. Also modifies the test ozone platform to not implement any event dispatch.

BUG=178543

Review URL: https://codereview.chromium.org/419993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288132 0039d316-1c4b-4281-b951-d872f2087c98

Sets the origin for a value when the value is dereferenced. Previously if you did
  foo = 6
  deps = [ foo ]
You would get the message:
  ERROR at //BUILD.gn:15:9: This is not a string.
    foo = 6
          ^
Which in this case is pretty confusing since that's obviously the case, and you really want to know where it was dereferenced.

With this patch the message is:
  ERROR at //BUILD.gn:21:5: This is not a string.
      foo,
      ^--
  Instead I see a integer = 6
which is more actionable.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/439513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288131 0039d316-1c4b-4281-b951-d872f2087c98

Using bindService() with implicit intents is unsafe, and will be
prohibited in L once the targetSdkVersion gets bumped.

Also check that the intent resolves before using it, to avoid
crashing the app.

BUG=399418
TEST=Pressing the FEEDBACK button shows Feedback screen.

Review URL: https://codereview.chromium.org/451543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288130 0039d316-1c4b-4281-b951-d872f2087c98

operator delete apparently isn't throw() with msvs (at least in
_HAS_EXCEPTIONS=0 builds like ours). This fixes the two remaining
warnings in this file:

..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function previously declared with an implicit exception specification redeclared with an explicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete(void* p) throw() {
     ^
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new(52,16) :  note(clang): previous declaration is here
void __CRTDECL operator delete(void *) _THROW0();
               ^
In file included from ..\..\base\allocator\allocator_shim.cc:334:
..\..\base\allocator/generic_allocators.cc(39,6) :  warning(clang): function previously declared with an implicit exception specification redeclared with an explicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete[](void* p) throw() {
     ^
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\crtdbg.h(1054,16) :  note(clang): previous declaration is here
void __CRTDECL operator delete[](void *);
               ^
2 warnings generated.

There also wasn't a std::nothrow overload for delete, so add that for
completeness while here. (For C++14, we might have to add sized
overloads too at some point.)

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/447513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288129 0039d316-1c4b-4281-b951-d872f2087c98

tasks on each SequencedTaskRunner.

By using a nestable task the RundownTaskCounter was guaranteed that the task would START after current
tasks had also STARTED but not necessarily COMPLETED..!

BUG=386126

Review URL: https://codereview.chromium.org/440893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400861

Review URL: https://codereview.chromium.org/430703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288127 0039d316-1c4b-4281-b951-d872f2087c98

crbug/397634 describes crashes that occur occasionally in the crazy linker
when loading the browser shared library.  These crashes have been observed
only in the M37 beta.

The current theory is that part of the address range that the crazy linker
must map with MAP_FIXED for shared RELRO to work may, on occasions,
already be mapped.  If it is mapped then the crazy linker's MAP_FIXED
to reserve space will overwrite it, with unpleasant results.  The crazy
linker tries to use a range of addresses that is 'safe' from use by the
system, but it may not be watertight.

This fix should work round the problem by removing the MAP_FIXED from
the mmap that reserves space, so that if any part of the range is already
occupied then the mmap returns a valid mapping, just not at the requested
address.  If that happens the fixed address load fails, and the
ChildProcessService retries with a non-fixed address.

This is mildly suboptimal since it loses the gain from shared RELRO, but
the library will still load and run.  Occurrences of this in the M37
beta suggest that it will be a relatively rare event.

So far the bug reported by the beta has not shown up in testing, but
something a little similar can be simulated by deliberately moving the
crazy linker's wanted address to around the heap.  With this perturbation
in place and without this fix, the browser crashes.  When this fix is
added the browser/renderer library loads and runs, and correctly reports
back-out and retry in logcat.

BUG=397634

Review URL: https://codereview.chromium.org/443393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288126 0039d316-1c4b-4281-b951-d872f2087c98

This functions is not called anymore in Blink and thus it has no effect
here in Chromium. So no need to keep overriding it.

This also deletes web_solid_color_layer_impl.* because it becomes unused with this change.

BUG=None
TEST=None
R=enne@chromium.org

Review URL: https://codereview.chromium.org/431273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288125 0039d316-1c4b-4281-b951-d872f2087c98

I can't repro locally. I tried with a release/debug build and with
full/light.

BUG=400495
TEST=none
R=zhaoqin@chromium.org
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/447953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288124 0039d316-1c4b-4281-b951-d872f2087c98

When signing in from the new avatar bubble, since the inline template has no "choose what to sync" link, thus Chrome shows an inline confirmation in the avatar bubble upon signin completes and blocks sync until the bubble is closed.

However, when some modal warnings show up before signin completes, they steal the focus thus the avatar bubble wont be able to show confirmation for sync settings and sync will be blocked infinitely.

A temporary workaround is to just start sync immediately if a modal warning is shown, since in all cases the dialog mentions that user data will be synced.

I will add a sync settings link to all modal dialogs later so that user could configure sync settings before sync starts.

BUG=435423005

Review URL: https://codereview.chromium.org/447883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394434

Review URL: https://codereview.chromium.org/440293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288118 0039d316-1c4b-4281-b951-d872f2087c98

The histograms don't seem to be used anymore (do not show up in UMA). The
hang-detector and about:profiler produce relevant useful data for detecting jank.

BUG=none

Review URL: https://codereview.chromium.org/435603011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288116 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179700:179716&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288115 0039d316-1c4b-4281-b951-d872f2087c98

record & replay to work with AGSA

BUG=396157

Review URL: https://codereview.chromium.org/423213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/449043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288112 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/441883003/ and an additional
downstream patch

BUG=400694

Review URL: https://codereview.chromium.org/440123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288111 0039d316-1c4b-4281-b951-d872f2087c98