GitLab

Bug: 863171
Change-Id: Ibf9c93098fef18bbda60370d6bdd771442debd9f
Reviewed-on: https://chromium-review.googlesource.com/1145788Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577209}

Due to some bad versions of Vulkan Runtime/Loader, there are crashes when
Vulkan is called for the GPU supported Vulkan versions and extensions.

From the logs, most vulkan-1.dll crashs are from the following versions.
As of 7/23/2018,
0.0.0.0 -  # of crashes: 6556
1.0.26.0 - # of crashes: 5890
1.0.33.0 - # of crashes: 12271
1.0.42.0 - # of crashes: 35749
1.0.42.1 - # of crashes: 68214
1.0.51.0 - # of crashes: 5152

The GPU could be from any vendors, but only some certain models would
crash. For those that don't crash, they usually return failures upon GPU
Vulkan support querying even though the GPU drivers can support it.

The solution of this CL is to skip the Vulkan GPU info collection if bad
Vulkan versions are detected.

Bug:850384,863546

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I80cf1f7a45d6d501db678bdf18d98f5e95930e1d
Reviewed-on: https://chromium-review.googlesource.com/1146984Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577208}

This reverts commit d3408523.

Reason for revert: A proper fix landed with https://crrev.com/c/1141356

Original change's description:
> ozone/drm: No CTM on external monitor on i915
> 
> When using a CTM on i915 with some monitors, for some resolutions,
> colors don't look right.
> 
> This CL pretends external displays don't support HW CTM on i915.
> 
> Bug: 848540
> Change-Id: Ibdf3d2ef4bc8e2fce5669086043d54f715263fab
> Reviewed-on: https://chromium-review.googlesource.com/1128406
> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573140}

TBR=marcheu@chromium.org,dcastagna@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 848540
Change-Id: I9a0ae39f46e629879f45f1d43e65a2e43da62505
Reviewed-on: https://chromium-review.googlesource.com/1146782Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577207}

If the window is closed after GetThreatDOMDetails finishes, but before
OnReceivedThreatDOMDetails is run, |sender| is invalid. Instead, we
observe FrameDeleted and track which frames are closed. Then we know
to skip this RenderFrameHost when GetThreatDOMDetails runs.

Bug: 817724, 860445
Change-Id: I2c8ed6c6a160264d91ca9b5a4760e53a7606f487
Reviewed-on: https://chromium-review.googlesource.com/1146997Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577206}

In a browser window without BrowserActionsContainer, there is no Cast
toolbar icon to anchor the dialog to. So we anchor it to the top center
of the window.

Bug: 853371

Change-Id: If79016f0bd06e322db8b96621ab058e215ba5364
Reviewed-on: https://chromium-review.googlesource.com/1145237
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577205}

Bug: 854704
Change-Id: I00c25bee75cb69d36af1ab022847cf08100f5e88
Reviewed-on: https://chromium-review.googlesource.com/1144640Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577204}

BUG=800825

Change-Id: I8aaaf6a3e80cf6a0075fab4e73a60e7610d9b60d
Reviewed-on: https://chromium-review.googlesource.com/1145861
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577203}

Continuation of work in bug 646094.
Preparing to activate an errorprone check to flag
context#getApplicationContext calls. The goal is to prevent storing the
resulting context as a class property, and instead use ContextUtils.

Bug: 846456
Change-Id: I2c3efdf6c0de690ee8a9a06a523c773722c07196
Reviewed-on: https://chromium-review.googlesource.com/1095997Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#577202}

BUG=766926

Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782
Reviewed-on: https://chromium-review.googlesource.com/1145674Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577201}

This allows more easy testing of the feature under development/
experimentation.

Bug: 516866
Change-Id: I8418b9c61ad42214491c8b97edfcfe71f879b14f
Reviewed-on: https://chromium-review.googlesource.com/1146818Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577200}

This CL restructures the two client browsers tests to be parameteized
such that different tests can be enabled for USS incremently.

Bug: 516866
Change-Id: Ifc7b8aa39992e30fef876d28b9b29f1419426972
Reviewed-on: https://chromium-review.googlesource.com/1146927Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577199}

Branching Chrome v69.
We are adding supporting of Chrome v69 and dropping supporting of Chrome v66

Change-Id: Id9b75ef78dd14da34f5165cbc6f64b3a188a5eb9
Reviewed-on: https://chromium-review.googlesource.com/1146993Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577198}

This tests ChromeVox integration with an out-of-process mojo app.

Bug: 851578
Test: interactive_ui_tests
Change-Id: I23a6cbf9bf93d675f5cc774e3df82eb4be5a334f
Reviewed-on: https://chromium-review.googlesource.com/1132555
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577197}

Refactor, minimize and clean up code. Moved the non-refresh/non-touch
tab close button highlight colors to theme_properties.cc since there
was a theme element.

It's still using the close (X) icons instead of painting them since the
coordinates of the strokes are very odd. Also, the "touch" version of the
icon drawn by outlining the X with a complicated path.

Once actual specs for the icon are available, the code can be updated.

TBR=estade@chromium.org

Bug: 838152
Change-Id: I2abca3be74f08649b3472f22fa31d0f897789e70
Reviewed-on: https://chromium-review.googlesource.com/1145590Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577196}

It's no longer used.

BUG=842365
TEST=none (removal of dead code only)

Change-Id: I7ec73de3686591c4697ea6b58dfbeeb5961d0648
Reviewed-on: https://chromium-review.googlesource.com/1146983Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577195}

Run the dialog modally on mac so that the dock and main menu are
blocked.

Bug: 865760
Change-Id: I734ba42a3110b6a71fa2aaae807ef9b1f763a90d
Reviewed-on: https://chromium-review.googlesource.com/1135728
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577194}

This implements a caching logic to store the Android volume tables in native
code. This avoids constant JNI calls that can slow things down too much leading
to problems (see bug for more details).

Bug: [internal] b/71871956
Test: Running on a several AThings Cast-enabled speakers, as well as unit-test.

Change-Id: I5c769d0d98e3d4b00f01d74a0b0ded984993431e
Reviewed-on: https://chromium-review.googlesource.com/1134589Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577193}

Suspended means state when an app was for some reason disabled on
Android. For example as a result of policy apply. We should gray out
such apps and prevent launch attempts.

Key points of this CL
  * Register new state, suspended for ARC app OnAppReadyChanged renamed
    to OnAppStatesChanged and called all times when any ARC app state
    is changed.
  * ArcAppIconLoader is extended to apply gray effect in case app
    becomes suspended.
  * ArcAppModelBuilder was implemented before ArcAppIconLoader was
    introduced and it has own logic to handle ARC app icons. To prevent
    code duplication this builder is moved to ArcAppIconLoader as many
    other consumers in Chrome.

TBR=kerrnel@chromium.org
TBR=poromov@chromium.org

BUG=863567
TEST=Manually + unit tests.

Change-Id: Icfd2e2df37726b6abb76b0be7bf73da05e621b22
Reviewed-on: https://chromium-review.googlesource.com/1142687
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577192}

Forward keystore_name, keystore_password and keystore_path to
android_apk_or_module to actually make use of those parameters.

Bug: 866352
Change-Id: I8c330b46b4d0d4f33db40b2f6fef69dd2a3ce74a
Reviewed-on: https://chromium-review.googlesource.com/1146901Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577191}

Bug: internal b/111451219
Change-Id: I9ffa8324d3392cf7ced97465c4a65fdcd8c0c00c
Reviewed-on: https://chromium-review.googlesource.com/1145793
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577190}

Seems like a long shot to fix the flakiness of this browser test, but
this fixes an error anyways.

Bug: 817270
Change-Id: I97bf32f5924f58e0965c80587eedd419a9739ca1
Reviewed-on: https://chromium-review.googlesource.com/1145863
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577189}

Bug: 858885
Change-Id: I9ea772268411272c86e333ec4041b3e17b38f3af
Reviewed-on: https://chromium-review.googlesource.com/1142541
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577188}

Also replacing `app` by `menu` as the platform agnostic button name.
This is part of an effort of splitting the monolitic VrShellGl and add
tests to each part.

Bug: 865486
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7aa916b61d74ddada59c4cd4c8608c1ec25a7e23
Reviewed-on: https://chromium-review.googlesource.com/1145239
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577187}

AppKit runs its sheet animation in UI-thread blocking loop. There is no
way to swap in a frame from the compositor while it is running. So
failing to wait means we animate a blank window.

Fix by restoring the wait that regressed in r574771

Test=Bookmark Star -> More...: Ensure the window does not animate in blank.

Bug: 865331
Change-Id: Ifd87944e3ae0d3af5f5b7eb8569e9a7c98e1be0c
Reviewed-on: https://chromium-review.googlesource.com/1146136
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577186}

TBR=xunjieli@chromium.org

Bug:728081
Change-Id: I18ac62be4f68fb8501ab6c7064fc273b4ed58ff4

NOTRY=true # webkit_layout_tests flake crbug.com/866520

Change-Id: I18ac62be4f68fb8501ab6c7064fc273b4ed58ff4
Reviewed-on: https://chromium-review.googlesource.com/1146495
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577185}

This is update for reland crrev.com/c/1145563

TBR=xiyuan@chromium.org

Bug: 822488
Test: Manually
Change-Id: If3a0ab1ff717b04a3f9c9995c0522c43fc0aba4b
Reviewed-on: https://chromium-review.googlesource.com/1145787
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577184}

This reverts commit a8bfbc28.

Reason for revert: 70.0.3500.0 still exhibits these crashes

Original change's description:
> Disable all compositor recycling
> 
> Previous patch to disable compositor recycling only disabled for
> BridgedNativeWidget. Now disable for everything.
> 
> TBR=ericrk
> 
> Bug: 863817863817863817863817
> Change-Id: I09fed3b84e7df23d540c4a4db528f43efa8bac15
> Reviewed-on: https://chromium-review.googlesource.com/1146325
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577095}

TBR=ccameron@chromium.org,ericrk@chromium.org

Change-Id: I3672137e22f8e654192a1bcbace908b0367e7248
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863817863817863817863817
Reviewed-on: https://chromium-review.googlesource.com/1146960Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577183}

Bug:866261
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af

NOTRY=true  # layout test flakiness

Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af
Reviewed-on: https://chromium-review.googlesource.com/1146330
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577182}

IPAddressObserver and ConnectionTypeObserver are deprecated in favor of
NetworkChangeObserver.  This CL replaces a class that subclasses them with
an (almost identical) internal class which does not expose them directly.

For more details see the design doc linked in the bug below.

Bug: 754695
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic65ce6aa4df57893504e9eaf3042fb2deb355115
Reviewed-on: https://chromium-review.googlesource.com/1133325
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577181}

TBR: ericorth@chromium.org
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I27876e432541b30a7c4832bae61e22faa37888b7
Reviewed-on: https://chromium-review.googlesource.com/1145772Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577180}

Measures usage of the following APIs:
- RTCPeerConnection.getTransceivers()
- RTCPeerConneciton.addTransceiver()
- RTCRtpTransceiver.direction (getter/setter)

// The run was green except for unrelated failures with
// mac_chromium_rel_ng that have happened on multiple CLs
NOTRY=True

Bug: 866433
Change-Id: I430680fa3109681c38e82a7b8d2203e7ec18544e
Reviewed-on: https://chromium-review.googlesource.com/1146659
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577179}

Historically, new stats have bypassed stats OWNERs review and made it to
Chrome stable. This will cause import breakages if stats are added to
the legacy getStats() API in third_party/webrtc assuming:
1. They are present in a normal call setup, i.e. shows up in the
   scenario modelled by:
   WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback
2. The new stat does not recycle an already existing whitelisted name.

// The run was green except for unrelated failures with
// mac_chromium_rel_ng that have happened on multiple CLs
NOTRY=True

Bug: 822696
Change-Id: I2e6735ae6f1b987eb64865cb510eb65a6a1e4126
Reviewed-on: https://chromium-review.googlesource.com/1146726
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577178}

Bug: 865927
Change-Id: I0ec37849d27eb41e464cd815c8ce744d72a538f5
Reviewed-on: https://chromium-review.googlesource.com/1145134
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577177}

Bug: 805612
Change-Id: I1ec642dd31a69a00b3c3bc56a5a43ea5f85e2985
Reviewed-on: https://chromium-review.googlesource.com/1144646
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577176}

The test was missing EXPECT_*() statements on other platforms than Mac/Windows.

Bug: 816389
Change-Id: Ib50b315445e810025f403faaad7bd1f288369b7f
Reviewed-on: https://chromium-review.googlesource.com/1145623Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577175}

The SlimNav experiment is hitting the CHECK(_webUsageEnabled) in
-ensureWebViewCreatedWithConfiguration when loading placeholder
URL while web usage is disabled. One cause for this situation is when
clearing website data while an interstitial is presented over a native
view. WebInterstitialImpl::DontProceed() is called after web usage is
disabled and it triggers the reload of the native view, which in turn
triggers the placeholder load. Deferring the load fixes the problem,
because the web view is recreated immediately after.

Other causes for placeholder load when web usage is disabled exist, but
the causes are not fully understood. This CL fixes the crashes in these
cases as well. This should uncover behavior changes, that hopefully give
us more details to fix the root cause later.

A downstream egtest for the interstitial case is added in
http://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/654301

Bug: 865985
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I03d928ce82d128c2f67f36e204731576e479d497
Reviewed-on: https://chromium-review.googlesource.com/1145725Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577174}

A recent bisect in the linked bug shows that it's passing again.

NOTRY=true
TBR=nednguyen@chromium.org

Bug: 803461
Change-Id: If9e240bbb03a7941ae3fe4ea48149bfe606d9ec4
Reviewed-on: https://chromium-review.googlesource.com/1146772Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577173}

This change adds in KeyEvent handling to support keyboard usage with
the controls buttons. They should be activated when the 'enter' or
'space' keys are used.

The previous implementation of OnKeyEvent used an OverlayWindowViews
tracking of which control is being focused, which is now obsolete.

Bug: 866291
Change-Id: I8a59337aa7aef5c95da081a9b5f33762462eeaef
Reviewed-on: https://chromium-review.googlesource.com/1146283Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577172}

Change-Id: Ie5ed5f28bfdc5a7914dac544db17deac45e1f3b0
Reviewed-on: https://chromium-review.googlesource.com/1129044Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577171}

A recent bisect in the linked bug suggests that they aren't flaky
anymore.

NOTRY=true
TBR=nednguyen@chromium.org

Bug: 842163
Change-Id: I79442bf895ff3596f1b1c8ae3db8ccb596041e78
Reviewed-on: https://chromium-review.googlesource.com/1146765Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577170}