- 23 Mar, 2020 40 commits
-
-
sandromaggi authored
Before this change only /search was allowed, now all Google subdomains are supported. Bug: b/152027637 Change-Id: I3aeafbc16f6984cc9ed7710adbfd2680c3b2a9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112555Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#752429}
-
Greg Thompson authored
The mini_installer_tests suite sometimes suffers failures caused by state left on a machine by previous runs of this or other tests. This change adds new processing to the force_clean mode of RunCleanCommand that interprets expectations in the 'clean' state as directives to put the machine into that state. This should reduce flakes caused by previous tests. In particular: - The abstract Verifier class and VerifierRunner have been collapsed into a generic property_walker that traverses a property dictionary and dispatches to type-specific verification functions. property_walker.Verify replaces VerifierRunner.VerifyAll. - property_walker.Clean is introduced, which walks a property dict and dispatches to type-specific clean function. - The guts of the {file,process,registry} verifiers are now in type-specific "operations" files. - Each of the {file,process,registry} operations files now has a Clean operation. Big thanks to zmin@chromium.org who started this effort in https://codereview.chromium.org/2747023002/. BUG=698997,1059314 Change-Id: I8c249e4bcffaae280aa4d877c5da8224dac11df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111178 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752428}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce427e7174b8..8cb91971a35b Created with: gclient setdep -r src-internal@8cb91971a35b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie22817ab89082c1166b0395ae9672739e93af51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115494Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752427}
-
Mugdha Lakhani authored
Several classes inherit from PageInfoUI and create a PageInfo object, which needs a pointer to a PageInfoUI object in turn to be constructed. This CL removes all usage of PageInfoUI from PageInfo's constructor by adding a SetUiAndInit method on PageInfo. This eliminates a potential source of crashes wherein PageInfo calls into PageInfoUI (concretely, the PageInfoUI subclass) from its constructor, the latter tries to access its PageInfo member, and that member is null precisely because it is in the process of being set. There is no behavioral change, as all creation sites of PageInfo now call its InitializeUIState() method immediately after constructing it. One detail: Prior to this change, |security_level_| wasn't set in the PageInfo constructor's initialization list but was rather set via the call to ComputeUIInputs() that occurs in the constructor. With this CL |security_level_| *needs* to be set in the initialization list as that passed-in value is used as input to ComputeUIInputs(), which is now called from InitializeUIState(). Bug: 1052375 Change-Id: I61143f3bdc4e02097d4c27db7f46bfab2355f934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105296 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752426}
-
Miguel Casas authored
This test-only flag allows for bypassing the picker UI for screen/ window/tab capture selection. It's used in browsertests [1], and it's needed for ChromeOS Tast tests (see bug), however in real machines the name of the capture device is not just "Entire screen", but "Built-in display" [2], or includes e.g. the server IP:port in the case of window/tab. This CL relaxes the flag by making the parameter a substring of the to-be-allowed capture source, so that e.g. "display" will cover all possible display names etc. [1] https://source.chromium.org/search?q=kAutoSelectDesktopCaptureSource&sq= [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/strings/ui_strings.grd;l=1028;bpv=0;bpt=0 Bug: 1063449 Change-Id: I73f41352482839df792fd3a048d989f32fe62768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113410 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752425}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d67bef80..bc540552 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58b0e8d8009e88c1157a5427fb9360753db8bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115571Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752424}
-
Jan Wilken Dörrie authored
This change implements handling not being able to obtain a plaintext password from the backend for the compromised credential edit dialog. Fixed: 1063560 Change-Id: Id8d22c9e3ea4b96b0063ef7772147a09d687272e Bug: 1063560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115330 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#752423}
-
Sean Harrison authored
This was originally going to go under the recent cookies section, but since that was removed it has now been added underneath the other toggles on the page, in a similar position to where it was on the previous cookies page. Bug: 1032584 Change-Id: I34ffc45a35b52ecbdf08916c2873f02ff7277cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107867 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#752422}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I524af3118581c046a746a34d2b77a9ec5b2f7ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111673 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#752421}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c591f1048c69..c41827fa748d git log c591f1048c69..c41827fa748d --date=short --first-parent --format='%ad %ae %s' 2020-03-23 sigurds@chromium.org [issues] Factor out common affected resource view functionality 2020-03-23 eric.rannaud@gmail.com [devtools] No detailed CPU samples of JavaScript program recorded on Linux Created with: gclient setdep -r src/third_party/devtools-frontend/src@c41827fa748d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1055871 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d02bd44e8e8a3c37cf9cc011d0cc617f8250dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752420}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be36db1024ce..c32c5dd61e17 git log be36db1024ce..c32c5dd61e17 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 jonaso@webrtc.org Add terelius as OWNER in call/ 2020-03-21 alexhenrie24@gmail.com Fix bad frees in error paths of WebRtcAecm_Create 2020-03-21 hta@webrtc.org Refactor ssl_stream_adapter API to show object ownership 2020-03-20 peah@webrtc.org Ensured that all files in APM are using the webrtc namespace Created with: gclient setdep -r src/third_party/webrtc@c32c5dd61e17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c849b3f3c3f185004ee6d397d301f1e94dcce8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115492Reviewed-by:
-
Aaron Leventhal authored
Even though dump w/o crash is not a real crash, it skews the crash data analysis. Bug: 1063308 Change-Id: I55d16beffe8a4fcef5e505d923a755e0481d3aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113685Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#752418}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I59bcaa9ee6699f11f3ed55a60d3de16b3d3b533d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115491Reviewed-by:
-
Vadym Doroshenko authored
TBR=jdoerrie@chromium.org Bug: 1063723 Change-Id: I1530fa10368b964dcb5c8cbd121521499b10e763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115411Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#752416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b41fb280f77b..ce427e7174b8 Created with: gclient setdep -r src-internal@ce427e7174b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icd368aa8fef14f35bc8e8daae67864465f740733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115292Reviewed-by:
-
Mansi Awasthi authored
This CL creates text field nodes using PdfAccessibilityTextFieldInfo sent from plugin process and inserts them in the PdfAccessibilityTree. A feature flag is added to guard PDF Form accessibility feature. This CL also includes test to validate the creation of text field nodes in PdfAccessibilityTree. Bug: 1030242 Change-Id: Idd92c04c8dd4f30b821d109284e0c0e724ab960b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087318 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This cl adds the affected resources to an issue to allow the frontend to link to them. Bug: chromium:1039607 Change-Id: Iad728c2ccd73d5ec7913323b54aa3ddeaef11ecb Design-Doc: https://docs.google.com/document/d/1F6R5Bpb3qHNzGPNBSXwEJ_eP8L-anIj0WinxOIyAh54/preview Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050276Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#752413}
-
Robbie Gibson authored
Before, only the text in the main frame would be zoomed. Now, the text in all frames is zoomed, using the zoom level of the main frame (and storing the resulting zoom modifier under the main frame's url). Bug: 1062611 Change-Id: I8d6fc6c7daa9135bb05ab2af9c8a2cfe3aa79fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111298Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#752412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb7e7387e61f..4c7460aceb93 git log cb7e7387e61f..4c7460aceb93 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 1c9f24263e6c..22d73d15e778 (1 commits) Created with: gclient setdep -r src/third_party/angle@4c7460aceb93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ib5b9ea0a8f63feeb031b4a050023b67d643626a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114843Reviewed-by:
-
arthursonzogni authored
The test is flaky, because it rely on a 4s timeout. This is not enough always enough. This patch splits this test into 4. One for every execution context: - Document - ServiceWorker - DedicatedWorker - SharedWorker This allows the timeout to become 'infinite', while still making sure the passing tests are still executed. Currently, only the SharedWorker hasn't been implemented yet. As a result it is marked as [ Timeout ] Bug: 1061029 Change-Id: If9a8e7b65d91cccffeeedb3f1a13d5e6e32e41bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112556 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Native code can return null ProfileSyncService pointer when sync is completely disabled. This cl checks for null pointer when setting sync error in SyncSettingsUtils. Bug: 1059703 Change-Id: Ia09139a51afe5d931add2e49c956d83310730fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111314Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#752409}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Ifff1c6be5d2cdcfa59d998c2fdf17961345d4ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111291 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1063016, 1015841 Change-Id: I4ed8b40738ce57a8b0fcb7aea66db3e0cc9f600b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109701 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#752407}
-
Benoit Lize authored
This reverts commit 113ebf6d. Reason for reland: fixed the Android release builds. Original change's description: > base/allocator: Improve PartitionAlloc perftests. > > Add: > - Comparison with the system allocator > - Better concurrent workloads for competing threads (identical as the > test) > - Reporting of the total allocation rate, and the worst thread > - Varying number of competing threads > > This is useful to evaluate the performance of PartitionAlloc with > various changes, such as changing its locking to base::Lock, or > implementing a thread cache. > > Bug: 998048 > Change-Id: I4c5f837f9e1b5af19b2f80bd79f3d3181166d930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111160 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752077} Bug: 998048 Change-Id: Ife2cf7e33eb17c56d25f9f66ceeee87db617d3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113973Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#752406}
-
Fredrik Söderqvist authored
Rather than having FEImage resolve the element reference on every operation that may involve it, have the creator of the FEImage (the SVGFEImageElement) resolve the reference and pass it to the FEImage. Bug: 1028063 Change-Id: Icabe881d980abe995a96dbf54df81da151e0e610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111157Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#752405}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a80b423b2136..c591f1048c69 git log a80b423b2136..c591f1048c69 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 sigurds@chromium.org [issues] Don't clear issues that logically belong to current navigation 2020-03-23 bmeurer@chromium.org Fix DESIGN_GUIDELINES.md link in README.md. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c591f1048c69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060628 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifce41974f345172ad5fc194c3e3f8ef9a6d38cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114846Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit fccf3a8f. Reason for revert: This CL breaks on Linux MSan bot FidoCableDiscoveryTest.TestDiscoveryFindsNewAppleDevice FidoCableDiscoveryTest.TestDiscoveryFindsIncorrectDevice First failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22909 Original change's description: > Give the desktop a public key in QR handshakes. > > This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. > it gives the desktop a public-key. That key is included in the QR code > and means that an attacker who sees the QR code cannot impersonate the > desktop and pair with the phone. (The other direction is still possible, > however, and seems fundamental without the user entering a confirmation > code on the desktop.) > > BUG=1002262 > > Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#752196} TBR=agl@chromium.org,martinkr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002262 Change-Id: Id75ad0bab2862b3dafe73d20cf762883cc24faf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113771Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be8affce16ac..b41fb280f77b Created with: gclient setdep -r src-internal@b41fb280f77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I55fd5a3257ceac7e2f42dd1948c3de63dce94b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114845Reviewed-by:
-
Gauthier Ambard authored
The button is no longer used for search, it is now used for opening new tab. Fixed: 974751 Change-Id: I7de359e3c8801ec3f936a19cdb6b16358a48c47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106851 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752401}
-
Ian Struiksma authored
This test is failing due to a Javascript processing change. The test should work if re-recorded but not looking to update the password test cases cipd instance for just this single failure. Disabling for now until other tests are added/updated for a cipd batch. Bug: 1061553 Change-Id: If459e5cac54234459cd423d7599e77f0b72afc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111390 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#752400}
-
Eric Leese authored
Both tests rely on internals that we shouldn't be testing and make it harder to change devtools. Bug: chromium:670180 Change-Id: I35934db8cfafa418f12ea096f5f1d971ac34d4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112554Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#752399}
-
Clemens Arbesser authored
Bug: b/152013302 Change-Id: I3bfc9628c01c130e49630bfddf08898ce9b68838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111319 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Ian Struiksma authored
A couple changes to product code caused some failures. Re-recorded 1 test (walmart_ca) after javascript processing caused WPR failure and needed the fresh site. Altered: cvs dsw home_depot gamestop neiman_marcus pizzahut_uk rei rakuten tractorsupply recipe .test files to expect different formatting for credit card after blur/focus changes from crrev.com/c/2023496 dsw, home_depot, gamestop needed extra click events added to their recipes to handle this change as well. Bug: 1061126 Change-Id: I5a5426b283e2decdaca2531c3869ff91c060609a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112963 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
-
Tomasz Moniuszko authored
It's not used on Windows anyway as there's platform-specific implementation in chrome/browser/ui/views/color_chooser_win.cc. Change-Id: Ic799890799f70141ae1e245e3a62df5cf707947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108141Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#752396}
-
Patrik Höglund authored
EngProd haven't touched these tests in years, so I don't think we need to be owners of them anymore. Bug: None Change-Id: I02383eee2adf0cecd32c2e7dfd314bb21bccba18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109757 Auto-Submit: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Side Yilmaz authored
ContextualSearchSceneLayer. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ContextualSearchSceneLayer class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ic8946777cbc4d6d9d585b89f67578dc6ff930719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107861 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#752394}
-
Gauthier Ambard authored
https://chromium-review.googlesource.com/c/chromium/src/+/2024895 https://chromium-review.googlesource.com/c/chromium/src/+/2027787 Bug: none Change-Id: I4f8ae1753f557f5dd5d9216619a94d7dc9d40d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111094Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
The print preview UI used HasCustomPageSizeStyle() to decide if the CSS dictates the given page size, or if a UI to change the page size should be available when printing to PDF. We returned true when the size descriptor only contained an orientation, which does not give the user an opportunity to select if "size:landscape" should print to Letter or A4. Instead, replace HasCustomPageSizeStyle() with a GetPageSizeType() to pass the page size type out of Blink instead of a boolean to make it possible for the printing UI to disable the UI for selecting page size and orientation separately. The testRunner API for hasCustomPageSizeStyle() is removed since it was only used for a single test which we now have coverage for in unit tests. This CL should not have any behavioral changes. Bug: 1016235 Change-Id: Id12c4310f87fc99b17660c355913150f12ff3e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107598Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752392}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a431038c911..13c0df80dca5 git log 6a431038c911..13c0df80dca5 --date=short --first-parent --format='%ad %ae %s' 2020-03-22 ramakrishnan.nikhil@gmail.com [docs] Fix building docs if `srcdir' != `builddir'. 2020-03-21 ramakrishnan.nikhil@gmail.com [docwriter] Drop support for Python < 3.5. Created with: gclient setdep -r src/third_party/freetype/src@13c0df80dca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I43a54d99663fc8cca2acd0896e90ce56a518bb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113204Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#752391}
-
Anatoliy Potapchuk authored
Currently, AccessibilityControllerImpl is mid-way of the refactoring for feature controls. This CL makes other features be controlled by their own Feature or FeatureWithDialog instance. We will remove/rename redundant methods in the following CL. Bug: 1051892 Change-Id: I840a2d64ff20e51e67656c55a4572ae2aff479bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108020Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#752390}
-
