- 01 May, 2018 40 commits
-
-
Xiaohan Wang authored
Previously move-only types are not supported in gmock so we had to use a hack to workaround the issue. Now this is supported by gmock, and we can mock those methods directly. This CL only updates mock_filter.h and related tests. More changes will come later. Bug: 759710 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7ed40687c0eb2248b6f04989bad94e7bb17e37ba Reviewed-on: https://chromium-review.googlesource.com/1036649Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555143}
-
Erik Luo authored
Allow Console to evaluate without throwOnSideEffect when the entire expression meets the same strict conditions used by JSAutocomplete. Bug: 810176 Change-Id: If5c80250cd75d81eec1e495d0414903213fac930 Reviewed-on: https://chromium-review.googlesource.com/1028934 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#555142}
-
Helen Li authored
Bug: 837753 Change-Id: Iaf98bcb0b98b096880a0e888da690e411505b3c4 Reviewed-on: https://chromium-review.googlesource.com/1037245 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555141}
-
Raymond Toy authored
Move many but not all WebAudio AudioParam tests to WPT. The criteria was whether Firefox passed the tests or, if not, the errors are actually bugs in Firefox. Most of the failures are because Firefox threw the wrong type of error. We also skipped over most of the tests that use offline.suspend(). Bug: 745778 Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f Reviewed-on: https://chromium-review.googlesource.com/1036456Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555140}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaad06800c9481fb681d957ef11aa927829d71d3f Reviewed-on: https://chromium-review.googlesource.com/1037190Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555139}
-
Becca Hughes authored
Add flag states and preload version to chrome://media-engagement to make it easier to diagnose bugs in MEI. BUG=835938 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I736f17f5b020b459c236abdabd9d0961efea29d3 Reviewed-on: https://chromium-review.googlesource.com/1024805 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555138}
-
Kevin Marshall authored
Wrap file path references with "EnsureFileExists()" which acts as a simple identity function, except for invalid paths for which it raises IOErrors. Bug: 837200 Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 Reviewed-on: https://chromium-review.googlesource.com/1037778Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555137}
-
Dan Sanders authored
This CL standardizes the |natural_size| computation in all decoder implementations to use the decoded |visible_size| and the VideoDecoderConfig's pixel aspect ratio. Bug: 766657, 837337 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I01a5bd59c353d6f07fd02c9fc3d3e64ab1a04434 Reviewed-on: https://chromium-review.googlesource.com/1026992 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555136}
-
Gabriel Charette authored
Precursor for https://chromium-review.googlesource.com/c/chromium/src/+/1035788 TBR=fdoray@chromium.org Bug: 825327 Change-Id: Ic6e7440c152dde11b6cab9c1ccddd46106d48d8b Reviewed-on: https://chromium-review.googlesource.com/1037634 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555135}
-
Dirk Pranke authored
It would be good if we could use `gn refs` to tell us which target generated a given executable. The docs suggested that refs should do this, but it doesn't appear to do so. Bug: 837876 Change-Id: I45f45bb3346ed21ede83fbacdea2207f1322ad69 Reviewed-on: https://chromium-review.googlesource.com/1033506 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555134}
-
Ahmed Fakhry authored
This CL adds: - Ctrl + Search + M to toggle the fullscreen magnifier on/off - Ctrl + Search + D to toggle the docked magnifier on/off It also adds their entries in the keyboard shortcut helper, and the keyboard overlay. BUG=838310 TEST=Added new test. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65119263a39f3630118c87332099c7ec7e73439a Reviewed-on: https://chromium-review.googlesource.com/1036533Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555133}
-
Bo Liu authored
Log intentional kill UMAs yet a new histogram entry. This time, instead of logging all possible combinations of states that we might care about, aggregate them into counts on the client side directly. So it's not really a "histogram" exactly. The up side is that this will be easily extensible in the future. Add renderer visibility to TerminationInfo which is needed for one of the new UMAs. Bug: 693484 Change-Id: I9bf4cc8cfa969a8098bcdabf002585f0bf4a713a Reviewed-on: https://chromium-review.googlesource.com/1032093Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555132}
-
https://pdfium.googlesource.com/pdfium.git/+log/ea603b9f0baf..b5902c780751 $ git log ea603b9f0..b5902c780 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 hnakashima Fix possible integer overflows in CFX_RTFBreak. 2018-05-01 thestig Add struct CJBig2_GRDProc::ProgressiveArithDecodeState. Created with: roll-dep src/third_party/pdfium BUG=chromium:838095 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0b6eee2a9f50d795a803b5dac8dfeea010c07e68 Reviewed-on: https://chromium-review.googlesource.com/1036940 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555131}
-
Kevin Marshall authored
The revised comments more accurately reflect the current runner behavior. Bug: 808057 Change-Id: I4b193241a26034d608f3e1281eea7f4ce21dd510 Reviewed-on: https://chromium-review.googlesource.com/1037780 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/166bc4ceedaf..1eb58e1f8892 $ git log 166bc4cee..1eb58e1f8 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 mmoss Add a recipe config to enable the bot_update "--with_tags" flag. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825063 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I807cb34b62e6f5f71fd32fc8377242fef4ac9a41 Reviewed-on: https://chromium-review.googlesource.com/1037463Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555129}
-
Kevin Marshall authored
Fuchsia, running on the test bots, was sometimes taking too long to return data to AudioSyncReader (observed 21ms, max 20ms), which lead to test flakes. Bug: 838367 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If2e25357acd70eaa28c6e618e696cc39ea9ba372 Reviewed-on: https://chromium-review.googlesource.com/1036196 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Tarun Bansal authored
When downlink client hint is attached to the request during main frame navigation, convert kbps to Mbps correctly. Change-Id: If0b12bb2eb0acc85ed64d349ca0e28f2c6a0b025 Bug: 838364 Reviewed-on: https://chromium-review.googlesource.com/1036190 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555127}
-
Michael Thiessen authored
This CL ensures that popups, like the sogou popup, show up on standalone VR devices. To support popups on standalones, we have to turn VR mode off before showing the popup, using the window focus change to know when to turn VR mode back on. Bug: 830041 Change-Id: I4771970fe5d4c13b6a3c9756aa6e8dbcf4689084 Reviewed-on: https://chromium-review.googlesource.com/1036204Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#555126}
-
Dave Tapuska authored
Created a java side mirror object to the class that can be parceled into an intent so that it works with the FullscreenActivity code. Change TabObserver from onToggleFullscreenMode to onEnterFullscreenMode/onExitFullscreenMode so that we could pass the FullscreenOptions around. This change does not have any behavior changes as of yet it is just plumbing passing options around. BUG=829937 Change-Id: I8599df0e155de78704d70dd22f886cd94f68d6ff Reviewed-on: https://chromium-review.googlesource.com/1030837Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/859155b40806..4e78157a8a47 $ git log 859155b40..4e78157a8 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 perezju [soundwave] Add pandas_sqlite.InsertOrReplaceRecords Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iccb759f29763321b1455b9bae9d9d96ac94f02e3 Reviewed-on: https://chromium-review.googlesource.com/1037444 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555124}
-
Devlin Cronin authored
Revision efe0c886 added a check to verify that extensions that would be loaded in all cases (in order to fix a crash in ExtensionPrefValueMap). However, this depended on knowing the type of extension, which was determined by the manifest (stored in the extension preferences). Unpacked extensions do not store the manifest, so this caused a crash. As a workaround, gracefully handle the case of the extension having no manifest. This is only safe because the only type of extension that we would still load with extensions disabled is a theme, and themes do not need entries in ExtensionPrefValueMap. This is a pretty ugly/hacky solution, but should work to fix the crash. Also add a regression browser test for the same. Bug: 836624 Change-Id: Ie7c766ceee261504b1d3f2cc570b7072e71e0f71 Reviewed-on: https://chromium-review.googlesource.com/1035448 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555123}
-
crystallambert@chromium.org authored
Bug: None Change-Id: I8c9c12a5f958a16d191b1be555245fe27ebdebcb Reviewed-on: https://chromium-review.googlesource.com/1037803Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#555122}
-
glevin authored
As per crbug.com/788027 Comments 1,6,7: - Update checkbox text to "Don't show again" - Move "Don't show" checkbox to content area - Consolidate text into one paragraph - Change title text to "Warning: Experimental feature" - Remove X (Close) button from upper right window to <account>". Verify that dialog is Harmonious. Bug: 788027 Test: Open two multi-profiles, right-click on a window, select "Move Change-Id: Ia50d338271349d47a947b6d7c9e3a9bc13ade44f Reviewed-on: https://chromium-review.googlesource.com/941612 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555121}
-
Danyao Wang authored
This ensures that back/forward buttons can be updated correctly for iframe navigations, which are not visible via DidStartNavigation and DidFinishNavigation callbacks of WebStateObserver. Bug: 835799 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc08db795617519244a6414bbe800b38953e7dbf Reviewed-on: https://chromium-review.googlesource.com/1036453 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#555120}
-
Toni Barzic authored
Adds optional tabId to echoPrivate.getUserConsent consentRequester argument. The tabId identifies the tab which requested user consent to verify the device's eligibility for an offer. The tabId will be used to determine in which browser window the dialog asking the user for consent should be shown. End goal is to remove GetAssociatedWebContentsDeprecated usage from echo private API implementation. Merely replacing it with GetSenderWebContents does not work, as the method gets called from the component echo extension's background page, so the sender web contents does not correspond to the actual contents from which the request came. This change is step 1 in removing GetAssociatedWebContents usage from echo private API. After this step GetAssociatedWebContents usage will be restricted to the case where tabId was not passed to the method. It will be followed up with: 2. Changing echo extension to pass tabId to getUserConsent method. 3. Replacing remaining GetAssociatedWebContents usage with GetSenderWebContents - at this point tabId would not be passed to the getUserConsent method only if the method was called from a platform app, in which case GetSenderWebContents is appropriate. Bug: 461394 Change-Id: If6b2913aab17bb1745d040996cad0696a293d97f Reviewed-on: https://chromium-review.googlesource.com/1035784 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555119}
-
Albert J. Wong authored
partition_alloc.h has been a dumping ground for all objects related to PartitonAlloc. The original code used many inlined top-level functions making the implementation very coupled. This splits out most of the critical clusters of functionality into separate files with roughly one struct/class per file. The split makes the module layering and interaction boundaries much clearer. Because of the heavy use of inlining, and the highly coupled nature of the original code, it was not possible to make a clean split yet between declaration and implementation. Therefore, this splitting required introducing "-inl.h" files because too many of these objects reached direclty into each others's fields. These "-inl.h" files can likely be reduced in future refactors. Bug: 766882 Change-Id: Iceeccc64a1d810a68cedfb28599dfbcf66642b98 Reviewed-on: https://chromium-review.googlesource.com/1006154Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555118}
-
Ken Rockot authored
Mojo passes around base::ProcessHandle values for various reasons. On most systems this is fine, but at least on Windows, a ProcessHandle refers to an owned reference to a system process object, and if not careful it's possible for a base::ProcessHandle value to inadvertently change meaning over time. This CL introduces the concept of a move-only ScopedProcessHandle within Mojo, which on most platforms is just a base::PlatformHandle. On Windows, this represents an owned base::ProcessHandle which closes on destruction and clones correctly using DuplicateHandle rather than merely copying the raw handle value. ScopedProcessHandle is used in a few places where process handle ownership semantics were previously weaker than necessary, or were correct but implemented ad hoc. This also updates ScopedPlatformHandle (and supporting code like Channel::RewriteHandles) such that the |owning_process| field (if not the current process) is always an owned process handle. This ensures that when such handles are closed in unsent messages, they can be safely closed in the target process (from within the source process) without any risk of raciness against target process termination. Bug: 837612 Change-Id: I943bb5f70ede56351d52b2ecea7d76fcfdee46ce Reviewed-on: https://chromium-review.googlesource.com/1036459Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555117}
-
David Black authored
Currently defaults to voice but will eventually be read from user preferences. Bug: b:78637398 Change-Id: I61d5d2090ff70d2af4f212c9c27cad0ad90eb029 Reviewed-on: https://chromium-review.googlesource.com/1034373Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#555116}
-
Scott Violet authored
BUG=837689 TEST=none Change-Id: Ie04f4e48afd0f6a33bc66b5f7921f83b79e1729d Reviewed-on: https://chromium-review.googlesource.com/1033915Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555115}
-
Steven Valdez authored
This changes the file handler to be a default handler, allowing user-specified handlers to take precedence over it. Previously you were unable to set a handler to selectively handle certain file requests without constructing a new test server and adding the handlers manually in the correct order. TBR=horo@chromium.org Change-Id: Ie15313dbe6744ce692b78c08ea088be9fd920065 Reviewed-on: https://chromium-review.googlesource.com/1034822Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555114}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa03bd93b7c1..dc3192b30a9e $ git log aa03bd93b..dc3192b30 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 reed pin offset request before applying to region 2018-05-01 kjlubick Update SamsungChromebook2012 to m67 2018-05-01 caryclark Revert "remove obsolete color defines" 2018-04-30 fmalita [skottie] Add support for round-corners geometry effects 2018-05-01 caryclark remove obsolete color defines Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I5899d2e90a6d0277a83523bab7bf99156b8a54ce Reviewed-on: https://chromium-review.googlesource.com/1037197 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555113}
-
David Black authored
Temporarily bypasses eligibility checks for development purposes only. Bug: b:78826751 Change-Id: I1bd9b57ff816285dc662ded51cd12a3ce6135999 Reviewed-on: https://chromium-review.googlesource.com/1034301 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
Migrated blink to v8::Isolate::SafeForTerminationScope and add this scope inside V8ScriptRunner methods since callsites should be ready for termination. This scope allows termination inside direct API calls and forbid it by default inside any recursive call. After this CL terminateExecution should be pretty safe and ready for use. Yang's original proposal: https://bit.ly/2K8KGgG R=haraken@chromium.org,yangguo@chromium.org,jochen@chromium.org Bug: chromium:820640 Change-Id: I28fa60cab05718194ff9377751188c66cf15e04b Reviewed-on: https://chromium-review.googlesource.com/1026166 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24ba22b7..bcccb182 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie7fce3cc61da50d2cc8296ac4fc0db77e30759a6 Reviewed-on: https://chromium-review.googlesource.com/1036212Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555110}
-
Stefan Zager authored
In the process of swapping out a frame which hasn't *quite* finished loading, we may call into code meant to run when a frame finishes loading and is preparing to be displayed. Add a condition to detect that circumstance, and skip the prepare-for-display stuff. BUG=837524 R=japhet@chromium.org Change-Id: I3a64c41353d5ff31fe97cc2411673eab280108bc Reviewed-on: https://chromium-review.googlesource.com/1024912 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Tao Bai authored
This patch implements 3 UMA histograms, these are - Whether autofill service enabled - Autofill session state - Submission source. Bug: 831829 Change-Id: I904466832db8296924d51a055b1c630deab6553c Reviewed-on: https://chromium-review.googlesource.com/1008862Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#555108}
-
Sean Kau authored
Bug: None Change-Id: Ifbbf8b138e420733d9e2523ea26473171e119d9b Reviewed-on: https://chromium-review.googlesource.com/1036538Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#555107}
-
John Abd-El-Malek authored
This is now possible since NavigationMojoResponse is on when network service is disabled. Now tests don't need multiple paths when they need to intercept or monitor a frame request, depending on whether the network service is enabled or not. In this patch, I've simplified one test as an example. I'll do the rest in followups to keep this patch smaller. Bug: 776589 Change-Id: I7d1419b152072810e789560a598e14d87fb2ce19 Reviewed-on: https://chromium-review.googlesource.com/1036593 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555106}
-
Raymond Toy authored
If the IIRFilter is known to be unstable, we can bypass the computation of the tail time because we know a priori that the impulse response won't converge to 0. So, in construction of the IIRFilterNode where we determine if the filter is stable or not, pass a stability flag to the IIRProcessor. Then computation of the tail time can check the IIRProcess to see if the filter is stable or not. If not, just return the max tail time value. Bug: 837872 Change-Id: I9f0e030c2a9e5a5b5635c964214fdafdd57e8668 Reviewed-on: https://chromium-review.googlesource.com/1035722Reviewed-by:
-
Bruce Dawson authored
The sandbox normally closes open handles when lowering the token, however this often includes querying object type information from invalid handles. When the Handles checker is enabled this triggers exceptions which then make App Verifier harder to use. Since the Handles checker is quite useful it is worth disabling the closing of handles when App Verifier is loaded. This is detected by looking for vrfcore.dll. Bug: 836315 Change-Id: I2c794caf5e9b1c719376aabe780c7dcde7be56cd Reviewed-on: https://chromium-review.googlesource.com/1032783Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555104}
-
