- 06 Nov, 2019 40 commits
-
-
Mustaq Ahmed authored
We had mouseup events "sharing" the tokens created on mousedown events. Tokens are no-op now with UAv2 except for extension messaging, but that last remaining dependency is not related to mousedown vs mouseup events. Bug: 959850 Change-Id: I075e0bb17e0324e4248b5682deba21acbe24c409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661403 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712980}
-
Ewann authored
- Renames download_directory_util.cc to download_directory_util.mm. - Adds UIFileSharingEnabled flag to info.plist. It allows access to user's Documents. - Moves downloads folder to user's Documents. - Makes downloaded files persistent. Bug: 1013072 Change-Id: Idf4e92455babe678c1c8551cad06638f1003ba72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856099 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712979}
-
Greg Thompson authored
BUG=546640 TBR=bashi@chromium.org Change-Id: I3cf922b974fe5259962f50e2e5431900d2e3b9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900989Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712978}
-
Mikhail Khokhlov authored
This CL unifies diagnostic writing in one place so that we no longer depend on diagnostics written by metrics computation code. Bug: 981349 Change-Id: I8e08c8b52c5e64de77d2dbc39e19b3e8d12e2b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893879 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#712977}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bf053b6f3c73..d9f8b063cd7b git log bf053b6f3c73..d9f8b063cd7b --date=short --no-merges --format='%ad %ae %s' 2019-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa7c1e25..3cb32697 (712817:712927) Created with: gclient setdep -r src/third_party/webrtc@d9f8b063cd7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibf7bb11380cdc54a2e5e423da0dccd59371e0742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900914Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712976}
-
Andy Paicu authored
TBR=xiyuan@chromium.org Bug: 949490 Change-Id: Ic9b20c0a6c3c9898867a1c903b0a5dc6f797a0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901068Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712975}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/879d97b05d..ecbd8964b9 TBR=sigurds@chromium.org Change-Id: Ia5c6dbd17ca8f3d2c86770d87823bd32aa5e48c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901071Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712974}
-
Pâris MEULEMAN authored
Wrap OAuth2TokenService GetAccessToken, InvalidateToken, GetNewAccessToken in IdentityManager and use it in dependencies. This is a step of the layering of Signin and Identity in Android and a precursor to the internalization of Oauth2tokenservice. details here: https://docs.google.com/document/d/1_ks5kg3qr6TVq7NT6MFg6lh5Yiv-1lic6Rsd9nu5ubI Bug: 934688 Change-Id: Idf7cde0546a32fe815f87ae3cea95cd092edfa79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764128 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#712973}
-
Denis Kuznetsov authored
Bug: 1021608 Change-Id: I7086c7086f2a8e8978f4034c002115e1328e6ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899998Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712972}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba61465d..a423bb8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I86cdbf8512615fffd9e8ce477c8952bf370149db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900887Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712971}
-
Andy Paicu authored
TBR=alexmos@chromium.org Bug: 1021895 Change-Id: I94ca6541149962bddcce3a9989c163930427501e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901073Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aae71bda01a7..19dd51b005fe git log aae71bda01a7..19dd51b005fe --date=short --no-merges --format='%ad %ae %s' 2019-11-06 geofflang@chromium.org GL: Expose PBO extensions 2019-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e0d5544c9864..d9fbf0234869 (3 commits) Created with: gclient setdep -r src/third_party/angle@19dd51b005fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I8aea320ac708d03c967e4bc1c7cfdc5587bcc67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712969}
-
Andy Paicu authored
TBR=afakhry@chromium.org Bug: 1021902 Change-Id: I96aa923f74e479a0c77332aa69aedb49c65de148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900988Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712968}
-
Findit authored
This reverts commit 3ee72aa0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 712958 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlZTcyYWEwODA4ZTkwNDc4ZTNjODEyZTg3NDAwM2NjNDVmZjVjN2IM Sample Failed Build: https://ci.chromium.org/b/8897545226615962368 Sample Failed Step: compile Original change's description: > Add Opus benchmark (NEXUS5) as gtest. > > This CL introduce a benchmark (based on flim@'s work), > checking CPU timing of encoding/decoding on a NEXUS 5. > This is why the test is only triggered by dedicated bot > (android-opus-kitkat-arm-rel). > > It is wrapped in a gtest for quick validation at Opus roll time: > * Green: We're all good. > * Red: Manual investigation required. > > Bug: chromium:1002973 > Change-Id: I80c79cff995fd0d8f5a7fa01b0f92ff99fb318bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890053 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Felicia Lim <flim@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Yves Gerey <yvesg@google.com> > Cr-Commit-Position: refs/heads/master@{#712958} Change-Id: Ie814fc5428e47963df70861413f59e8ecc216e8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1002973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901109 Cr-Commit-Position: refs/heads/master@{#712967}
-
Ewann authored
- Adds persistent downloads's flag. Bug: 1013072 Change-Id: Ic5db8f631d0740748807434fddb52ba1da5505f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852086 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712966}
-
Andy Paicu authored
TBR=weili@chromium.org Bug: 1021883 Change-Id: Ie3eaeb80c82bac99d9aa6657f1a35a63edab46a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899378Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712965}
-
Yuzu Saijo authored
This CL removes ServiceWorkerFoo tests from bfcache bot filters as https://crrev.com/c/1898165 should have fixed the test failures. Bug: 1020884 Change-Id: I0814144091cb2827199504e11bf31c06441e05a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900802Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#712964}
-
Ramin Halavati authored
Blocking 'Persistent' filesystem type in incognito mode had resulted in a backdoor to detect users being incognito. Since all stored data in incognito mode are ephemeral and they only last until the session is open, we can enable persistent filesystem type in incognito mode as well and treat it similar to a temporary one (which is in-memory). This feature is still DISABLED by default, behind "EnablePersistentFilesystemInIncognito" flag. third_party/blink/tools/run_blink_wptserve.py out/Default/chrome --incognito --enable-features="EnablePersistentFilesystemInIncognito" http://localhost:8001/wpt_internal/file-system-api/temporary_vs_persistent.window.html Bug: 990592 Change-Id: Ie49bc204f500c8f07e265adb0a5fe46371862d1e Tested: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875252 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712963}
-
Richard Knoll authored
The MessageView renders a drop shadow[1] on Windows that adds insets to the content view of notifications. We need to set the reduced width as size of the |message_view_| to correctly calculate bounds and wrapping behavior. Before: https://imgur.com/pftjgrG After: https://imgur.com/wEsv5EN [1]: https://cs.chromium.org/chromium/src/ui/message_center/views/message_view.cc?l=107&rcl=2b3975c5de2635f5a436fb950b42fd5b657ae09f Bug: 1001047 Change-Id: I8a8b75aea4bdb800596d7790fafa541f2b50a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895333Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712962}
-
Rune Lillesveen authored
Remove the method as it is no longer used. Change-Id: Ib5a18d1575ddce078157ed684af50fceb39278ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899861Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712961}
-
Sylvain Defresne authored
The add a space between the word "found" and the path to the resources that cannot be loaded when logging the error. Bug: none Change-Id: I3818f22e4ef580e1ec1846ab7573201b12174af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899853 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712960}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f798ed2acd8a..0f5f46f39281 git log f798ed2acd8a..0f5f46f39281 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 achuith@chromium.org xbuddy: Move to chromite. Created with: gclient setdep -r src/third_party/chromite@0f5f46f39281 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I75781e8b5032d027bbce4de6a234c0e5edbde0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712959}
-
Yves Gerey authored
This CL introduce a benchmark (based on flim@'s work), checking CPU timing of encoding/decoding on a NEXUS 5. This is why the test is only triggered by dedicated bot (android-opus-kitkat-arm-rel). It is wrapped in a gtest for quick validation at Opus roll time: * Green: We're all good. * Red: Manual investigation required. Bug: chromium:1002973 Change-Id: I80c79cff995fd0d8f5a7fa01b0f92ff99fb318bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890053Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#712958}
-
Makoto Shimazu authored
Bug: 632580 Change-Id: I9c72ae2f0df48124d417682c97a1bd2c35b1f6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864499 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#712957}
-
Michael Lippautz authored
Bug: 1019191 Change-Id: I4a92d28681ce0aa6788642d96cf0d3c4e3c40fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899999Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712956}
-
Andrew MacPherson authored
Benchmarking on both amd64 and arm Chromebooks shows that PFFFT gives a performance improvement on Web Audio tests requiring FFTs. Using the Web Audio Bench at https://spotify.github.io/web-audio-bench/ Dell Chromebook 11 3189 (amd64): TEST Base PFFFT Change Convolver-128f-3ms 3866 3555 -8.04% Convolver-1024f-23ms 10064 8222 -18.30% Convolver-2048f-46ms 12236 9671 -20.96% Convolver-32768f-743ms 26130 19417 -25.69% Lenovo Yoga N23 (arm): TEST Base PFFFT Change Convolver-128f-3ms 5372 5382 +0.19% Convolver-1024f-23ms 10489 9234 -11.96% Convolver-2048f-46ms 12336 10554 -14.45% Convolver-32768f-743ms 25722 20272 -21.19% Bug: 1021027 Change-Id: Ieb5cd7af32d632bf252fcbad2101c1a5d2b91970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893203Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#712955}
-
Alice Wang authored
This CL disables the flaky bookmark promo dismiss tests. TBR=bsazonov@chromium.org Bug: 1020068 Bug: 1020069 Change-Id: I003baa162588b14eae1f480fa69fb5e72edf9f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899375 Auto-Submit: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712954}
-
Takashi Sakamoto authored
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33985 deterministic failures KeepAliveOperationTest.NotifiesObserversOnResponse KeepAliveOperationTest.RecordsResponseDuration https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8910702062804733408/+/steps/chromeos_components_unittests/0/logs/Deterministic_failure:_KeepAliveOperationTest.NotifiesObserversOnResponse__status_FAILURE_ON_EXIT_/0 Change-Id: I034570a4376e8d39545c31dca035ff4f61c84510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660381Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712953}
-
Yuzu Saijo authored
This CL fixes a bug where RemoveControllee can be called twice in ServiceWorkerVersion: :OnControlleeDestroyed. Change-Id: I7ea604f09a36e6bf1b63d45bee9623ba13d8e555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900795Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#712952}
-
Yuzu Saijo authored
This CL adds CHECKs to figure out where the crash is coming from around bfcache and ServiceWorker integration. Bug: 1021718 Change-Id: I8cf144618fa79591e9f9b2679b8535b50eeac2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900796 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712951}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icc3f80fdc9a15ad26b50cc27ad5d9bc9a9d018c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712950}
-
Yoshifumi Inoue authored
This patch changes "inline_box_traversal.cc" to utilize |NGInlineCursor| instead of |NGPaintFragment| for preparation of migraing |NGFragmentItem|. This patch will reduces 1000+ failed web_tests in |LayoutNGFragmentItem| flag. Bug: 982194 Change-Id: I7f889755ff44beaa63e83f47db415b65969394d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888242 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712949}
-
Matt Falkenhagen authored
Bug: 1009795 Change-Id: Ib33c1242228e674442f21dea8a56ef456d84b886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899231Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712948}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e0d5544c9864..d9fbf0234869 git log e0d5544c9864..d9fbf0234869 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 dneto@google.com Fix Go lint issues: comment exported symbols (#3014) 2019-11-05 afdx@google.com spirv-fuzz: better computation of data synonym facts (#3010) 2019-11-05 afdx@google.com spirv-fuzz: make equivalence classes deterministic (#3011) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d9fbf0234869 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I3e808ddde7f45fabdef640e175c4623228e57bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712947}
-
Leon Han authored
It just contains a member 'string? record_type' which we can just put into NDEFScanOptions directly. BUG=520391 Change-Id: I161d52de3b28aef2b95724cfe20d95252cbb57b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899841Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#712946}
-
Michael Lippautz authored
Reland "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." This reverts commit bdc5aa8e. Reason for revert: Crasher has been stealth-fixed, see https://crbug.com/1021171. Original change's description: > Revert "Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map." > > This reverts commit 481fb0c1. > > Reason for revert: speculative revert for crbug.com/1019839 > > Original change's description: > > Remove DOMDataStore::WrappedReference and hold TraceWrapperV8Reference directly in ephemeron map. > > > > Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710616} > > TBR=jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Iba339b519f2aa602773ceb79c95948c1cffdcbdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893282 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711289} TBR=ulan@chromium.org,jbroman@chromium.org,haraken@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iae455af51181d191f08e7af16cd8a1413aea2b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899783Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712945}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1d09b983031b..aae71bda01a7 git log 1d09b983031b..aae71bda01a7 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader aaa64b76c0b4..88264e3e188d (3 commits) Created with: gclient setdep -r src/third_party/angle@aae71bda01a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: Ic3db40c69e51eef8435a20f0f4987aee3ffcddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712944}
-
Bettina authored
Bug: 1020768 Change-Id: If4cd121caffbf35c092e764c2d5de96b403c1872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895330Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712943}
-
Alexandros Frantzis authored
When running on a system with a CPU family/model beyond the last entry in the CpuUarch table, the CPU id to CpuUarch mapping code tries to access an invalid iterator/entry and crashes. Check for this case and return an empty CpuUarch instead. Bug: 1021000 Change-Id: I2bc19427a03c0fe6906838bdcb2134021fc213df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893200Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Alexandros Frantzis <alexandros.frantzis@collabora.com> Cr-Commit-Position: refs/heads/master@{#712942}
-
Henrique Ferreiro authored
Remove nonexistent header files from the whitelist. Change-Id: Ibd68cb0ee9d3293da1ef38ed8596bcb5c7669024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891195Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712941}
-