- 17 Oct, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64886a69..355cbd32 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a06a5fb62664a40a08ce16d0791a9e2277e696e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481881Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818221}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3334c3b2baeb78f4d723ba18ec548de4440e518f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818220}
-
David Black authored
This CL adds the overflow badge that is drawn when dragging more than 2 holding space items at a time. Demo: http://shortn/_eZZZJznuAp Note that the screen recorder did not capture the cursor moving with the drag image but it actually does so on device. Bug: 1139113 Change-Id: I5c16dcc2d1123896b8df982abfc069e874732da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481749 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818219}
-
Peter Kotwicz authored
This CL makes fetch_all.py copy the generated DEPS file back to //DEPS BUG=1064277 Change-Id: I457c8a84d21bf1f6940fecfd261f1761f1d5e3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476834Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24bbfbb1f544..f87d979a3090 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I3cc90e9570992ba23a58e4aecd7ab824230f40c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481664Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818217}
-
Koji Ishii authored
This patch implements |GetHyphenationDictionary| for |ShellContentBrowserClient|, so that we can enable the minikin hyphenation engine for |web_tests| for testing, and |content_shell| for debugging. The |GetHyphenationDictionary| was added in r817902 crrev.com/c/2462893 to allow |ContentBrowserClient|-derived classes to specify the dictionary directory. Also adds |PathExists| check in |HyphenationImpl| because its task runner allows blocking calls. The flag is not enabled yet, but crrev.com/c/2315564 runs bots on top of this patch. Bug: 652964 Change-Id: I28c6153b5b404ec035382ffa664873d0781dcc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478122Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818216}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/088a6f219279..1f3ac1f8e068 2020-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2aa0b3d2..1d65b746 (818053:818170) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie923e45f8573c9b3c5d7e752b32d8b0091b936d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482502Reviewed-by:
-
Daniel Hosseinian authored
Clean-up of PDFViewerElement including: - Setting of default values in Polymer property declaration rather than constructor. - Alphabetical ordering of properties. - Deletion of redundant property initializations. Change-Id: Iedde59831c1c417e6129ec6789e33a107773c374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477420Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#818214}
-
yiyix authored
Add FontKerning to the new Canvas API, which is currently under the runtime flag, NewCanvas2DAPI. Bug: 1137055 Change-Id: Ic95f74e76eecc2a1fd3aa152d89a4e593a8a8e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470418 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#818213}
-
Chris Davis (EDGE) authored
The JSON fuzzing tests failed to write JSON via JSONWriter::Write that was successfully read with JSONReader. This was due to an edge case where we are writing the JSON and have reached max depth (200) but have non-container leaf entries at that level and nothing deeper. This case should be supported by the JSONWriter to match the JSONReader and JSONParser. Also added a unit test for this case. Bug: 1138450, 1013934 Change-Id: I98fcd63c957ab4e85a322d923bef18b981220383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477239Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818212}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/957c117e514f..5d73338a50dc 2020-10-16 chonggu@google.com [Fuchsia] Add --fuchsia-device-address flag to allow specifying Fuchsia device's IP address If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1080854 Tbr: rmhasan@google.com Change-Id: Ia8548a689d131c65dd754ee707eeeee0b2729239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482163Reviewed-by:
-
Peter Kotwicz authored
BUG=1064277 Change-Id: If9eec6cab0138bc49dc6cb3e673e1b59230f3bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463593Reviewed-by:
-
Mike Wittman authored
Moves the registration before the early-out on Android based on kUmaBackgroundSessions, to ensure that it's always recorded on startup. Bug: 1004855 Change-Id: Iacf1bb315fe79d59eb7b5d6d8c73e3feaa964312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472341 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#818209}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibc083284453b168cfc840e53840dabb3ab8ef8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482204Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c12c8877aee..24bbfbb1f544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icc6a5d552452d7f29fe072a33dd6eb81466e5c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482384Reviewed-by:
-
dpapad authored
The latest version has support (among others) for Dynamic JS modules and BigInt. Fixed: 1139102 Change-Id: I70c0b30f3d5ef622a6d382d811ad774b6b9d3748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478884 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Ryan Heise authored
Bug: chromium:1138953 Change-Id: I8dbe67cf62348217be1f9e441c020e33fc563b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480819Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Auto-Submit: Ryan Heise <heiserya@google.com> Commit-Queue: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#818205}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fba124a48346..088a6f219279 2020-10-16 deadbeef@webrtc.org Fix possible deadlock when handling SCTP_SEND_FAILED_EVENT notification. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137936 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I493b5226600435440abde4e557dd37b0533c13b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482386Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602870879-71fddc22f2ceb12188759a1d8869c82a8b2155fa.profdata to chrome-linux-master-1602892676-bf21d7ac84386f5c5d5b8c904987f5e8c042ca52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id678b144907c744c73f902f95dcde429024e8daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481732Reviewed-by:
-
Mike Wittman authored
The use of SIGURG conflicts with the sampling profiler, which is already using that signal to drive stack sampling on Android. SIGWINCH appears to be otherwise unused in ART, bionic, and Chrome. Bug: 1136547 Change-Id: Iadecaebd383e4b39ba547c8a9cd5d0ebf6ae640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469459Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51ff0d0509b6..37c400146e59 2020-10-16 timvp@google.com Revert "Vulkan: Fold deferred clears into current clears" 2020-10-16 cnorthrop@google.com FrameCapture: Move shader and program source to shared cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: PUBG MEC Change-Id: I2df1c6300dbb6430bf233415719a03dcd8da11a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482383Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1cf32d03..64886a69 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I332fea194e87ca451e966c7933e21cd52c882124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482362Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602870879-c4d95eb6e866d4e52485aa00dae385a889389fa8.profdata to chrome-mac-master-1602892676-2e67f7ade6fea6d137ea5d86faa841297fe18fa8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibb906b69e3674420894a450ae30e2de10c2bb5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482385Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602838722-3d3847c86317a9aa85069273b7be64c1533b4e7a.profdata to chrome-win32-master-1602860364-832acf5629dcf54dc1d765b5c65780fd100e8b4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4773c7bb86b709f898afe705d37bec15ebcd145c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481411Reviewed-by:
-
Ian Prest authored
This change eliminates the usage of the deprecated SkFontLCDConfig, which stores font-related monitor properties in some global variables. Chromium is the only client of this deprecated API, and the Skia team has wanted to remove it for some time. Unfortunately, the use is fairly widespread within Chromium: 1. The globals are set directly in a handful of places via calls to SkFontLCDConfig functions. 2. The globals are used (indirectly) whenever an SkSurfaceProps is initialized with the kLegacyFontHost_InitType flag, and also when an SkCanvas or SkSurface are created without specifying the props. The correct long-term plan would be to retrieve the values from the Display (ideally per-monitor values) and pass them along as needed. But given the extensive usage, the only reasonable short-term approach is to lift the globals out of Skia and bring them "in-house" into Chromium. To that end: -- Undefines SK_LEGACY_SURFACE_PROPS. -- New globals and APIs in /skia/ext/legacy_display_globals.* -- Replaced "SkSurfaceProps(kLegacyFontHost_InitType)" with calls to new API: skia::LegacyDisplayGlobals::GetSkSurfaceProps() -- Found places where SkCanvas and SkSurface were created and props weren't already specified; passing the LegacyDisplayGlobals in most cases, but `nullptr` (or empty SkSurfaceProps) if it was clear without doing much analysis that no text was being drawn. This gets us closer to the end-goal by allowing Skia to fully remove the deprecated APIs, and also surfacing a lot of places where the use of the globals was hidden by indirect usage. Change-Id: I8fffaee4933c03ee828d2ffab858f53d92c59f4d Bug: 1126992, skia:3934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378763Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818197}
-
Charlene Yan authored
Bug: 1116118 Change-Id: I25c9ef0647a98464badb5642b2c7c567d8ba4bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481069Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#818196}
-
Varun Khaneja authored
Fixed: 1138405 Change-Id: I2f6b74468f61b7f13fec47b58598536d47067832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476909 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818195}
-
Wenbin Zhang authored
After argument was updated in crrev/c/2479565, it is not populated to the shard map to take effect. Adding it in this CL. Bug: chromium:1136900 Change-Id: I5b165a8b925addf1dbf9f11de1b093b5109f54b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482343 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#818194}
-
Becca Hughes authored
Change-Id: I28592a8cd09e89c2d980b55cb2e495d789a2ca1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480714Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#818193}
-
Rebekah Potter authored
This reverts commit 0397ac4e. Reason for revert: Two tests that had expectations updated in this CL are failing consistently on Win7 Tests, see https://bugs.chromium.org/p/chromium/issues/detail?id=1139546 Original change's description: > [Controls Refresh] Update controls styles for dark mode > > This CL updates the dark mode styles for the following controls: > 1. <meter> - border color. > 2. multi-select - foreground text color. > 3. Button: Dark mode button design has no border and has unique fill > color. Thus, a specific set of color enums is created for only > buttons. Button's border color is styled to match its fill color > in order to give the appearance of no borders and keep its > dimensions unchanged. This impacts: button, file, and color > controls. > > > Bug: 1107290, 1099624 > Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357 > Commit-Queue: Yu Han <yuzhehan@google.com> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818119} TBR=ellyjones@chromium.org,masonfreed@chromium.org,yuzhehan@google.com,yuzhehan@chromium.org Change-Id: I9eee08b77da1bf2887b72e1990bf9e76d6334c59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107290 Bug: 1099624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482166Reviewed-by:
-
Brian Sheedy authored
Adds the 1 pixel ignored border argument to the GPU video pixel tests that use Sobel filters and didn't have it already. This should hopefully allow some flakes I've been seeing on the ARM-based Mac DTKs to be auto-triaged. Bug: 1105656 Change-Id: I8b317335492e6eb025b151ba4a575c27c342ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482086 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#818191}
-
Brian Sheedy authored
Adds an additional failure suppression for the WebGL2 conformance tests on the ARM-based Mac DTKs for deqp/functional/gles3/framebufferblit/default_framebuffer_00.html. TBR=ynovikov@chromium.org Bug: 1130118 Change-Id: I98e2856c47c5256388d6a061b4041c56436d8482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481953Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#818190}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9cee07983fc9..fba124a48346 2020-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e7588486..2aa0b3d2 (817908:818053) 2020-10-16 joedow@google.com Fixing ASAN container-overflow error in DxgiOutputDuplicator 2020-10-16 hta@webrtc.org Deprecate GetRemoteAudioSSLCertificate If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138446 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If173831dc9addf52127f4f37482cbc5154db4486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481936 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d77d4ca4c542..0a749cf45c8c 2020-10-16 jalyn@microsoft.com Settings: Add Keyboard Shortcuts Docs Link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic073f147340416c9dfd109302d7ae02e98581e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481728Reviewed-by:
-
Victor Hugo Vianna Silva authored
The method is unused. SyncEnums::ENCRYPTION_COMPLETE also becomes unused and is deprecated. Bug: 1033040 Change-Id: I100ed858d43151d437076947c1cf5fcf5831af3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479164 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818187}
-
Greg Thompson authored
It doesn't provide any additional signal over other data sources. BUG=1138415 R=chromium-metrics-reviews@google.com Change-Id: I56185e4be8055ff49c72cb3f8016dc943cdbc397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479562 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/426436686c95..3c12c8877aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475,chromium:1138953 Tbr: rbpotter@google.com Change-Id: I1587b38184a10a8f521f38e09298f127972516a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482164Reviewed-by:
-
Stefan Zager authored
Speculative fix for crasher. Root cause is most likely one of these: https://chromium-review.googlesource.com/c/chromium/src/+/2220868 https://chromium-review.googlesource.com/c/chromium/src/+/2113390 On further reflection, it really doesn't make sense to force the root GraphicsLayer of a throttled frame to get hooked up into the layer tree. We can dispense with DisableCompositingQueryAsserts, because the call to CanBeComposited will already check for throttling. If that call comes back 'true', then the child frame *better* have advanced its lifecycle far enough to allow compositing state queries. BUG=1133662 Change-Id: Ie3be72c7ccc9837d15268e6e6fe39e39227dfd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482047Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#818184}
-
Aya ElAttar authored
Changed "*.company.com" to "company.com" to avoid confusion with blacklist-url-patterns Change-Id: Ica9df34c04da6ba09786f5b9f8372d93dd87ec62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467863Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#818183}
-
Michael Crouse authored
The DataUse.BytesReceived histogram does not cover larger reports from the OS and makes it difficult to measure changes in data use. Bug: 1132481 Change-Id: I2a0df744f0178ce16aad75cf024c86f28b0d11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459792 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#818182}
-
