GitLab

This is an attempted relanding of
https://codereview.chromium.org/1348833003, which was reverted in
https://codereview.chromium.org/1450083002 . This cl includes changes
to address the problem in https://crbug.com/555576 .

It turns out that DecrementCapturerCount() can trigger a call to
content::WebContentsImpl::WasHidden(), which eventually calls
ThumbnailTabHelper::UpdateThumbnailIfNecessary(), starting the
thumbnail generation process all over again. It also appears that the
bitmap capture operation is not necessarily synchronous, so calling
DecrementCapturerCount() anywhere within ProcessCapturedBitmap()
potentially disposes of the web contents before the thumbnail has been
captured.

This new cl differs from the original (1348833003) only in
thumbnail_tab_helper.cc, where I now unregister the ThumbnailTabHelper
from further notifications within UpdateThumbnailIfNecessary(), and
call DecrementCapturerCount() once the final callback is completely
finished with the web contents.

BUG=530707

Review URL: https://codereview.chromium.org/1461463002

Cr-Commit-Position: refs/heads/master@{#370809}

OnComputeScroll can synchronously update the scroll offset. However, it
is called immediately before draw, which is synchronous and synchronizes
the scroll offset. So UI scroll offset is stale for only a short time.

Note that stale scroll offset from UI is ignored during draw, so this
does not break flings.

BUG=545633

Review URL: https://codereview.chromium.org/1601743008

Cr-Commit-Position: refs/heads/master@{#370808}

The geolocation tests did not work because:
- They referred to incorrect test pages.
  Correct test pages:
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_on_load.html
    https://chrome-internal-review.googlesource.com/#/c/27084/3/test/data/android/geolocation/geolocation_watch_on_load.html
- A race condition was causing LocationProviderAdapter.newLocationAvailable() to
  be often called prior to LocationProviderFactory.LocationProvider.start().

In addition to fixing the above problems, this CL makes
org.chromium.chrome.browser.GeolocationTest more similar to
- org.chromium.android_webview.test.GeolocationTest
- org.chromium.content.browser.ContentViewLocationTest
In particular, all of the tests now:
- Use the same test page
- Use MockLocationProvider

BUG=141518
Test=Less flakiness

Review URL: https://codereview.chromium.org/1599113002

Cr-Commit-Position: refs/heads/master@{#370807}

BUG=571098

Review URL: https://codereview.chromium.org/1603203002

Cr-Commit-Position: refs/heads/master@{#370806}

Instead of reading PreRead options from the registry every time they
are needed, read them once and store them in a global variable.
This optimization isn't immediately useful as PreRead options are
currently read only once per process. However, with the upcoming
/prefetch:# experiment, the browser process will need the PreRead
options every time it launches a process.

This CL also has these benefits:
- The caller of GetPreReadOptions doesn't need to know the product
  registry path. This will allow content to get the PreRead options
  to decide whether it should use a /prefetch:# switch when
  launching a process.
- The PreRead options are returned as a bit field instead of by
  setting multiple booleans. This will facilitate the addition of
  new PreRead options.

BUG=577698

Review URL: https://codereview.chromium.org/1610733002

Cr-Commit-Position: refs/heads/master@{#370805}

Review URL: https://codereview.chromium.org/1619933003

Cr-Commit-Position: refs/heads/master@{#370804}

relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527

Review URL: https://codereview.chromium.org/1572353002

Cr-Commit-Position: refs/heads/master@{#370803}

BUG=578344

Review URL: https://codereview.chromium.org/1617253002

Cr-Commit-Position: refs/heads/master@{#370802}

Review URL: https://codereview.chromium.org/1612133003

Cr-Commit-Position: refs/heads/master@{#370801}

BUG=441785
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/1613233004

Cr-Commit-Position: refs/heads/master@{#370800}

R=piman@chromium.org
BUG=514815
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1608303002

Cr-Commit-Position: refs/heads/master@{#370799}

Merge branch 'master' of https://chromium.googlesource.com/chromium/src

Merge branch 'master' of https://chromium.googlesource.com/chromium/src

The following code change introduced an issue:
https://codereview.chromium.org/1554313002

There a couple of issues causing the problem.
1. One is the conditional waiter for HostOnline having short timeout. This is addressed by increasing the timeout.
2. Second issue is that, the following line times out and there by resulting in Chromoting waterfall failure. This is changed to ExecuteScript, since we don't need to validate the result from Refreshing the Chromoting Window.
From:
bool refresh_host_list = ExecuteScriptAndExtractBool("remoting.hostList.refreshAndDisplay()");
To:
ExecuteScript("remoting.hostList.refreshAndDisplay()");

BUG=577465

Review URL: https://codereview.chromium.org/1607143002

Cr-Commit-Position: refs/heads/master@{#370798}

https://chromium.googlesource.com/skia.git/+log/19032f72165f..ae4741893693

$ git log 19032f721..ae4741893 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 egdaniel Add ability to add general layout qualifiers GrGLSLShaderVar

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1613983003

Cr-Commit-Position: refs/heads/master@{#370797}

This patch:
 1. Adds a camera image icon. Currently just sets a cameraActive
    property and hides the static image preview pane, but functionality
    will expand in subsquent patches.
 2. Adds a preview pane as described in the mocks for the selected
    image.

BUG=563721

Review URL: https://codereview.chromium.org/1610973002

Cr-Commit-Position: refs/heads/master@{#370796}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/d6d5f6f2ca4c..70e59b141840

$ git log d6d5f6f2c..70e59b141 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 kschimpf PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

CQ_INCLUDE_TRYBOTS=
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/1617983003

Cr-Commit-Position: refs/heads/master@{#370795}

BUG=573289

Review URL: https://codereview.chromium.org/1601383002

Cr-Commit-Position: refs/heads/master@{#370794}

BUG=577943

Review URL: https://codereview.chromium.org/1619663004

Cr-Commit-Position: refs/heads/master@{#370793}

Java:
* Make InfoBarContainer#addInfoBar() a private method so it can't
  be abused anymore.

* Get rid of InfoBar.dismissJavaOnlyInfoBar() and the assorted
  InfoBarListeners to prevent them from being used incorrectly.

* Introduce a SimpleConfirmInfoBarBuilder class that makes it
  easier for devs to create infobars that operate mostly in
  Java that are still backed by native InfoBarDelegates.

C++:
* Expose InfoBarIdentifier enum to Java-side code.  Although the
  end goal is to get rid of Java-only infobars entirely, we're
  still stuck with a generic infobar for popping up errors from
  ChromeWindow#showCallbackNonExistentError() (e.g.).

* Introduce an Android-specific SimpleConfirmInfoBarDelegate
  class that listens for button clicks and alerts a Java-side
  listener.

Tests:
* Renames InfoBarTest2 to InfoBarContainerTest.  These weren't running
  at all because the test filters look for Java classes ending with
  the word Test, not Test2.

* Deletes a few InfoBarTest2 tests that need to be rewritten for the
  stacking world (on newt@'s agenda).

* Edited tests that directly accessed the InfoBarContainer#addInfoBar()
  to use the new SimpleConfirmInfoBarBuilder instead.

BUG=172427,543205,569776

Review URL: https://codereview.chromium.org/1596713003

Cr-Commit-Position: refs/heads/master@{#370792}

Added new libraries to the Chromium third-party library collection:
1. Netty 4 Server. See http://netty.io
2. Netty fork of Tomcat Native (netty-tcnative). See http://netty.io/wiki/forked-tomcat-native.html
and the library tc-native depends on:
3. 'Apache Portable Runtime'. See http://apr.apache.org

The server provides support for Http/2 protocol, which is needed for testing some of the Cronet features
on Android, in particular, the new Bidirectional Streaming API.

To build the netty-tcnative library call:
ninja -C out/Debug netty-tcnative

The output files can be found here:
- out/Debug/lib/libnetty-tcnative.so
- out/Debug/lib.java/netty-tcnative.jar

BUG=563732

Review URL: https://codereview.chromium.org/1537473002

Cr-Commit-Position: refs/heads/master@{#370791}

R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/1609973002

Cr-Commit-Position: refs/heads/master@{#370790}

BUG=577300
TBR=junov

Review URL: https://codereview.chromium.org/1615953004 .

Cr-Commit-Position: refs/heads/master@{#370789}

Fixed algorithms that compute bounding rectangles and word start offsets to take into account IA2 hypertext and i18n.

1. std::string was being used instead of base::string16.
2. Start offset and len did not take into account embedded objects in IA2 hypertext and existing functions worked on the assumption that object hierarchy had been flattened.
BUG=578341
R=dmazzoni@chromium.org
TESTED=NVDA console, browser tests

Review URL: https://codereview.chromium.org/1598583002

Cr-Commit-Position: refs/heads/master@{#370788}

R=sky
BUG=563932

Review URL: https://codereview.chromium.org/1616563002

Cr-Commit-Position: refs/heads/master@{#370787}

A CDM is registered after it's succussfully created (so the CDM ID is valid).
Check the CDM ID to decide whether we need to unregister it.

Review URL: https://codereview.chromium.org/1603413004

Cr-Commit-Position: refs/heads/master@{#370786}

This change adds UMA histogram metrics to track user interactions with
the UI surfaces introduced by WebUSB. We record the,

 * disposition of the device detected notification,
 * disposition of the device chooser, and
 * revoked permissions.

BUG=556845

Review URL: https://codereview.chromium.org/1584283003

Cr-Commit-Position: refs/heads/master@{#370785}

Currently, continuous read uses the Node predicate. We want to use the DOM_NODE predicate because it doesn't chunk up nodes quite as much. This results in smoother reading (e.g. not breaking apart between lines).much.

Review URL: https://codereview.chromium.org/1592513002

Cr-Commit-Position: refs/heads/master@{#370784}

MediaPlayer.create() can throw Runtime exception.
Catch the exception to prevent app crash.

BUG=579702

Review URL: https://codereview.chromium.org/1611193004

Cr-Commit-Position: refs/heads/master@{#370783}

PopupZoomer will stick to the initial container view and will refuse to switch
when ContentViewCore.setContainerView() is invoked. This is by-design as we
never intended to support disambiguation popup for WebView or fullscreen video.

Removes @RerunWithUpdatedContainerView and re-enables the test.

BUG=167045

Review URL: https://codereview.chromium.org/1611863002

Cr-Commit-Position: refs/heads/master@{#370782}

We need this to make snapshots work in mus. GLRenderer::GetFramebufferPixelsAsync calls this function to respond to CopyOutputRequests.

BUG=557397

Review URL: https://codereview.chromium.org/1610783002

Cr-Commit-Position: refs/heads/master@{#370781}

This fixes enums to be always SHOUT_CASE, uses LAST_FOO instead of
FOO_COUNT to avoid NOTREACHED() cases in switches, and moves the
bitflags "enum" MainThreadScrollingReason into its own file, making it
a struct (for scoping) with a set of constants inside instead, not an
enum.

R=aelias@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1604053002

Cr-Commit-Position: refs/heads/master@{#370780}

I'm trying to remove CookieStore::GetCookieMonster, since it's
weird and ugly to have most consumers of a class have hard
dependencies on it being a particular subclass of that class.

Also make a test using the method no longer hold onto references
to the CookieStore, in preparation for de-reference-counting the
class.

BUG=579653

Review URL: https://codereview.chromium.org/1613473002

Cr-Commit-Position: refs/heads/master@{#370779}

It got busted after the repository merge. You still have to run it from
third_party/WebKit. It doesn't work if you run it from src/.

Also update comment to note that it now does reorder gyp(i) entries.

Tested locally by doing a dummy move in each of chromium and blink.

Review URL: https://codereview.chromium.org/1614633002

Cr-Commit-Position: refs/heads/master@{#370778}

If the unit test is run and the DCHECK fails on an Android device it will crash
the browser and report unknown to the test runner for this test and all
successive tests, making it difficult to find the failing assertion and failing
test.

BUG=NONE

Review URL: https://codereview.chromium.org/1617593004

Cr-Commit-Position: refs/heads/master@{#370777}

https://chromium.googlesource.com/skia.git/+log/233bab918f1c..19032f72165f

$ git log 233bab918..19032f721 --date=short --no-merges --format='%ad %ae %s'
2016-01-21 msarett Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler
2016-01-21 senorblanco Fix bounds computations for SkDisplacementMapEffect with negative scale.
2016-01-21 mtklein DM: dump images for task failures too (but not skipped tasks)
2016-01-21 scroggo Add version number to images tested in DM
2016-01-21 mtklein Demo fuzz for Herb

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review URL: https://codereview.chromium.org/1615073003

Cr-Commit-Position: refs/heads/master@{#370776}

Directories other than paint/ use it now.

BUG=499321

Review URL: https://codereview.chromium.org/1616643002

Cr-Commit-Position: refs/heads/master@{#370775}

gfx::Display is designed to be copied, so no one should inherit from
gfx::Display.

BUG=426656

Review URL: https://codereview.chromium.org/1614953003

Cr-Commit-Position: refs/heads/master@{#370774}

BUG=579770
R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/1614563002

Cr-Commit-Position: refs/heads/master@{#370773}

(This is a refry of https://crrev.com/1566263002 with
the bitrate allocation algorithm in Blink ISO Chrome).

Original description: --------------------------------------
This CL updates MediaRecorderOptions to reflect the bitrate
settings in the spec [1]. Those params are wired all the way
down to {Video,Audio}TrackEncoder where they are used to
configure libvpx and opus, resp.

If param |bitsPerSecond| overrides the other two if specified
and the spec leaves down to the UA to divide its value among
video and audio: this CL allocates 90% to video and 10% to audio.

Also added a DCHECK for opus #channels and sampling rate,
which opus hardcode-limits in a pretty clumsy way (feast
your eyes in [2]).
--------------------------------------------------------------
Diffs with this previous CL:
- Chrome gets just the consolidated audio and video bit rates.
- The bit rate calculation micro algorithm is in MediaRecorder.cpp
- Added a LayoutTest checking for throwing when the rates
are too high.

BUG=575301
[1] https://rawgit.com/w3c/mediacapture-record/master/MediaRecorder.html#MediaRecorderOptions
[2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/opus/src/src/opus_encoder.c&sq=package:chromium&type=cs&l=169

BUG=575301

Review URL: https://codereview.chromium.org/1610473002

Cr-Commit-Position: refs/heads/master@{#370772}

Revert of Have each SandboxedProcessLauncherDelegate maintain a zygote. (patchset #15 id:440001 of https://codereview.chromium.org/1532423003/ )

Reason for revert:
Revert "Have each SandboxedProcessLauncherDelegate maintain a zygote."

This reverts commit 3c1e16b4.
This broke the Site Isolation FYI bot failure:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/7700

To re-land the CL, that failure needs to be diagnosed and corrected.

Original issue's description:
> Have each SandboxedProcessLauncherDelegate maintain a zygote.
>
> To improve component updates of PPAPI plugins, Chrome needs multiple zygotes.
> This will allow the PPAPI zygote to be recreated when a plugin is updated.
> This CL allows Chrome to maintain a zygote for each process type by having
> each SandboxedProcessLauncherDelegate maintain a class which can communicate
> with its respective zygote. This CL will be followed up with work to allow
> customization of zygotes, which will give Chrome the improve component update
> experience.
>
> BUG=569191
>
> Committed: https://crrev.com/3c1e16b490255119b6f70f94d1716645e897b185
> Cr-Commit-Position: refs/heads/master@{#370488}

TBR=mdempsky@chromium.org,thestig@chromium.org,avi@chromium.org,mseaborn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569191

Review URL: https://codereview.chromium.org/1617213002

Cr-Commit-Position: refs/heads/master@{#370771}

BUG=516018

Review URL: https://codereview.chromium.org/1618703005

Cr-Commit-Position: refs/heads/master@{#370770}