- 25 Sep, 2014 40 commits
-
-
anujk.sharma authored
BUG=314505 Review URL: https://codereview.chromium.org/597853003 Cr-Commit-Position: refs/heads/master@{#296640}
-
thestig authored
BUG=112278 NOTRY=true TBR=ericwilligers@chromium.org Review URL: https://codereview.chromium.org/606523002 Cr-Commit-Position: refs/heads/master@{#296639}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/1ff6c52..81f4797 TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/606503003 Cr-Commit-Position: refs/heads/master@{#296638}
-
ankit2.kumar authored
There is no reason for the following files to live in content/ layer and they should all be moved to ui/ layer. BUG=302114 Review URL: https://codereview.chromium.org/574673003 Cr-Commit-Position: refs/heads/master@{#296637}
-
thestig authored
BUG=417570 NOTREECHECKS=true NOTRY=true TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/600333002 Cr-Commit-Position: refs/heads/master@{#296636}
-
nednguyen authored
Revert of Installs test CA to android devices as part of browser startup so that apps can be tested with prox… (patchset #8 id:140001 of https://codereview.chromium.org/572123002/) Reason for revert: Making the Android nexus perf bot all red. Original issue's description: > Installs test CA to android devices as part of browser startup so that apps can be tested with proxy HTTPS server without code changes. > > BUG=412826 > > Committed: https://crrev.com/f28d9cace2df4a9dcaa992c4df5b85e3b2674dbb > Cr-Commit-Position: refs/heads/master@{#296619} TBR=tonyg@chromium.org,slamm@google.com,slamm@chromium.org,wuhu@google.com NOTREECHECKS=true NOTRY=true BUG=412826 Review URL: https://codereview.chromium.org/606533002 Cr-Commit-Position: refs/heads/master@{#296635}
-
kbr authored
Required exposing new Mac versions to Telemetry's test expectations. Added unit test. BUG=417415 Review URL: https://codereview.chromium.org/597383002 Cr-Commit-Position: refs/heads/master@{#296634}
-
kulkarni.a authored
BUG= Review URL: https://codereview.chromium.org/588603002 Cr-Commit-Position: refs/heads/master@{#296633}
-
thestig authored
Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/601983002/) Reason for revert: Broke Android bots: http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/2225 http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/66337 Original issue's description: > Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/) > > Reason for revert: > All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19 > > Original issue's description: > > Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/) > > > > Reason for revert: > > Not all bots have Java 7 yet :( > > > > Original issue's description: > > > Set the javac target and source to 1.7 > > > > > > BUG=336589 > > > TBR=yfriedman@chromium.org > > > > > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b > > > Cr-Commit-Position: refs/heads/master@{#295162} > > > > TBR=cjhopman@chromium.org,yfriedman@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=336589 > > > > Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99 > > Cr-Commit-Position: refs/heads/master@{#295165} > > TBR=cjhopman@chromium.org,yfriedman@chromium.org > BUG=336589 > > Committed: https://crrev.com/119c6fa8247481d2e36910d30175d0214fd2ece5 > Cr-Commit-Position: refs/heads/master@{#296630} TBR=cjhopman@chromium.org,yfriedman@chromium.org,aurimas@chromium.org NOTREECHECKS=true NOTRY=true BUG=336589 Review URL: https://codereview.chromium.org/603833002 Cr-Commit-Position: refs/heads/master@{#296632}
-
jamiewalch authored
Previously, menus were dismissed by adding a click handler to the <body>, but that doesn't intercept clicks on the plugin element and complicates the logic somewhat because a second click on the button while the menu is visible then triggers both the show and hide handlers by default. This CL adds an explicit <div> covering the entire window, but behind the menu in the z-order. This <div> doesn't prevent window dragging, despite being on top of the title-bar, so I've also made that conditional on there being no menu visible. BUG=416307 Review URL: https://codereview.chromium.org/592793003 Cr-Commit-Position: refs/heads/master@{#296631}
-
aurimas authored
Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/) Reason for revert: All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19 Original issue's description: > Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/) > > Reason for revert: > Not all bots have Java 7 yet :( > > Original issue's description: > > Set the javac target and source to 1.7 > > > > BUG=336589 > > TBR=yfriedman@chromium.org > > > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b > > Cr-Commit-Position: refs/heads/master@{#295162} > > TBR=cjhopman@chromium.org,yfriedman@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=336589 > > Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99 > Cr-Commit-Position: refs/heads/master@{#295165} TBR=cjhopman@chromium.org,yfriedman@chromium.org BUG=336589 Review URL: https://codereview.chromium.org/601983002 Cr-Commit-Position: refs/heads/master@{#296630}
-
donnd authored
BUG=416225 Review URL: https://codereview.chromium.org/601003002 Cr-Commit-Position: refs/heads/master@{#296629}
-
oshima authored
Introduced c/b/ui/views/athena/athena_util so that arbitrary code under chrome/browser doesn't have to depend on athena/ BUG=414340,410499 Review URL: https://codereview.chromium.org/603033002 Cr-Commit-Position: refs/heads/master@{#296628}
-
jam authored
Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/) Reason for revert: flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850 failures: TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 LoggedInSpokenFeedbackTest.AddBookmark Original issue's description: > Add test for ChromeVox keyboard commands. > > This is just a couple of quick sanity checks to prevent future regressions > like the one in the linked bug. It tests both a Search+Shift shortcut and > the corresponding Prefix Key shortcut. > > Adds support for sending the meta modifier key in > aura/x11 tests. > > BUG=404470 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 > > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 > Cr-Commit-Position: refs/heads/master@{#293687} > > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a > Cr-Commit-Position: refs/heads/master@{#296074} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Review URL: https://codereview.chromium.org/603823002 Cr-Commit-Position: refs/heads/master@{#296627}
-
erikchen authored
The OSX 10.10 dictionary changed its suggested corrections to "bouy", which used to include "buoy". I updated the test to check that "bouy" has the suggested correction "bout", which is present in the dictionary for both OSX 10.9 and OSX 10.10. BUG=390276 Review URL: https://codereview.chromium.org/591313002 Cr-Commit-Position: refs/heads/master@{#296626}
-
hashimoto authored
Only chrome is interested in implementing these methods. Move the code to ChromeAppDelegate. BUG=411352 Review URL: https://codereview.chromium.org/557833007 Cr-Commit-Position: refs/heads/master@{#296625}
-
jamiewalch authored
These may need to be made more elaborate once we start using them in browser tests, but I've verified that they can be used to mock a basic connection with resize support. Review URL: https://codereview.chromium.org/593313003 Cr-Commit-Position: refs/heads/master@{#296624}
-
sdefresne authored
The unittests (WebDataServiceAutofillTest.CreditUpdate) assume that the newly modified credit card information will be the first one returned. Since it has the highest date_modified value, this imply a descending ordering of the cards when iterating. The unittests were previously flaky as the precision of date_modified is not high enough and both card ended up with the same value most of the time. When the test was taking slightly more time to run, then the modified car would end up last and the test would fail. BUG=None Review URL: https://codereview.chromium.org/600873002 Cr-Commit-Position: refs/heads/master@{#296623}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/0f7197b..b5fae93 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=borenet@google.com Review URL: https://codereview.chromium.org/597813003 Cr-Commit-Position: refs/heads/master@{#296622}
-
sergeyu authored
Some macros in sys/socket.h were using _ASSING() macro, which wasn't defined anywhere. BUG=402993 Review URL: https://codereview.chromium.org/598223002 Cr-Commit-Position: refs/heads/master@{#296621}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e229507..1ff6c52 TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/601043002 Cr-Commit-Position: refs/heads/master@{#296620}
-
wuhu authored
Installs test CA to android devices as part of browser startup so that apps can be tested with proxy HTTPS server without code changes. BUG=412826 Review URL: https://codereview.chromium.org/572123002 Cr-Commit-Position: refs/heads/master@{#296619}
-
mgiuca authored
Previously, it only checked the major version number (this was a regression as a result of switching to Git). Also abstracted version checking to a testable CheckVersion function, and added tests for ParseVersion and CheckVersion. Also added better documentation everywhere about the format of the --check-version option. BUG=406993 Review URL: https://codereview.chromium.org/506863005 Cr-Commit-Position: refs/heads/master@{#296618}
-
jackhou authored
Previously, caption buttons were set at creation time. With this CL, minimize and maximize buttons can be added and removed throughout the lifetime of a window. BUG=412241 Review URL: https://codereview.chromium.org/581953002 Cr-Commit-Position: refs/heads/master@{#296617}
-
erikchen authored
The test relied on implicit assumptions about the system font. The system font changed in OSX 10.10. I changed the test to always use a fixed font. BUG=390276 Review URL: https://codereview.chromium.org/595053002 Cr-Commit-Position: refs/heads/master@{#296616}
-
gunsch authored
R=lcwu@chromium.org BUG=336640 Review URL: https://codereview.chromium.org/602593004 Cr-Commit-Position: refs/heads/master@{#296615}
-
wjmaclean authored
At present, the NavigationEntry page type always reports PAGE_TYPE_NORMAL for all committed entries, even if an error page is currently showing. There is a need for a mechanism to detect when an error page is showing in order to prevent zooming in that case, so we modify the navigation entry to correctly report error pages. BUG=403268 Review URL: https://codereview.chromium.org/580133002 Cr-Commit-Position: refs/heads/master@{#296614}
-
rvargas authored
BUG=416722 R=thestig@chromium.org Review URL: https://codereview.chromium.org/606473002 Cr-Commit-Position: refs/heads/master@{#296613}
-
hansmuller authored
The default value for NullableString should be null (was ""). Mojo struct fields whose type is string? should be initialized to null, not "". BUG=417039 Review URL: https://codereview.chromium.org/605443002 Cr-Commit-Position: refs/heads/master@{#296612}
-
aurimas authored
Revert of Findbugs roll from 2.0.3 to 3.0.0 (patchset #1 id:1 of https://codereview.chromium.org/604623002/) Reason for revert: findbugs expectations needs updating together with this roll. Original issue's description: > Findbugs roll from 2.0.3 to 3.0.0 > > BUG=None > > Committed: https://crrev.com/cb90500709f6f56788fdd8c15da345220aa5b983 > Cr-Commit-Position: refs/heads/master@{#296595} TBR=tedchoc@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/597263003 Cr-Commit-Position: refs/heads/master@{#296611}
-
rvargas authored
BUG=416722 R=rtenneti@chromium.org Review URL: https://codereview.chromium.org/605513005 Cr-Commit-Position: refs/heads/master@{#296610}
-
rvargas authored
BUG=416722 R=shadi@chromium.org Review URL: https://codereview.chromium.org/598243002 Cr-Commit-Position: refs/heads/master@{#296609}
-
sky authored
Otherwise the sides may be clipped out. BUG=417493 TEST=see bug R=ananta@chromium.org Review URL: https://codereview.chromium.org/604463003 Cr-Commit-Position: refs/heads/master@{#296608}
-
qinmin authored
After a seek, both audio and video decoder job will start prerolling. However, audio decoder job can finish prerolling much earlier than video decoder job. As a result, audio will start playing before video starts. And we will see some fast motion when video try to catch up with audio after it starts rendering. internal b/17527385 Review URL: https://codereview.chromium.org/596093002 Cr-Commit-Position: refs/heads/master@{#296607}
-
sbc authored
I introduced these leaks recently and really should have run valgrind. In future out valgrind bot should find such things pre-submit. Review URL: https://codereview.chromium.org/605433003 Cr-Commit-Position: refs/heads/master@{#296606}
-
noel authored
Notify RenderView webview() when the Page color profile changes so it can update and repaint all color profiled elements on the Page. Not used as yet: the IPC from the browser-side will be added later (need to resolve issue 338130, issue 357443 first), so this change is just more plumbing. CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg BUG=368663 Review URL: https://codereview.chromium.org/592753003 Cr-Commit-Position: refs/heads/master@{#296605}
-
groby authored
BUG=none TBR=mpearson@chromium.org R=jiayul@chromium.org Review URL: https://codereview.chromium.org/601033002 Cr-Commit-Position: refs/heads/master@{#296604}
-
rvargas authored
BUG=416722 R=piman@chromium.org TBR=cpu@chromium.org (sandbox_win.cc) Review URL: https://codereview.chromium.org/606463002 Cr-Commit-Position: refs/heads/master@{#296603}
-
rvargas authored
BUG=416722 R=garykac@chromium.org Review URL: https://codereview.chromium.org/602763003 Cr-Commit-Position: refs/heads/master@{#296602}
-
gunsch authored
This helper method is also used by internal Chromecast calls. R=lcwu@chromium.org,byungchul@chromium.org BUG=400914 Review URL: https://codereview.chromium.org/606483002 Cr-Commit-Position: refs/heads/master@{#296601}
-
