- 30 Jul, 2019 40 commits
-
-
Avi Drissman authored
This matches Aura behavior. In addition, native Mac menus take key focus so this matches platform behavior better, too. BUG=986247 TEST=as in bug Change-Id: I92dc11c73d390f348b087aaaa8dd3b15e62b86b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718453Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682299}
-
Maksim Ivanov authored
Add more browser tests for the CryptohomeKeyDelegate implementation, for these scenarios: * a key that supports two algorithms simultaneously; * another signature algorithm (PKCS #1 v1.5 SHA-1) besides PKCS #1 v1.5 SHA-256; * an unsupported signature algorithm; * the extension removing the key that it reported before; * the extension failing the signature operation. Bug: 826417 Change-Id: Ie298c506a26debfcead64fb8209a2174fedc52b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706440 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682298}
-
Lutz Justen authored
Increases the begin frame delay in ScrollAnimatorSimTest. This works around an issue where ScrollAnimatorSimTest.TestDivUserScrollCallBack was consistently broken on tsan, presumably because it took too long on this heavily instrumented build. TBR=lanwei@chromium.org,bokan@chromium.org BUG=chromium:987981 TEST=Repro steps mentioned in #5 of bug don't work anymore. Change-Id: Iad1205cd0ad8bacc5c6ce618c23a8ae27d706c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724685Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682297}
-
Oleg Davydov authored
there is no reason to call ExtensionManagementFactory::GetInstance to access it. More, GetForBrowserContext calls GetInstance itself. ExtensionManagementFactory: :GetForBrowserContext is a static method, so Change-Id: Ib761361258047b144edc8c2ee725c2b1811f6697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724511Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Sam Burnett authored
Bug: 895821 Change-Id: If34c7c76d59d713a57fac8d9901f3549f990a7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704680 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#682295}
-
Steven Bennetts authored
Bug: 853953 Change-Id: If221bdeaa048f3d94cc375f87f81af2f10e2b5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697430 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682294}
-
Nektarios Paisios authored
When the anchor or the focus objects for a selection are on a platform leaf object, then the anchor and focus offsets should necessarily refer to a text position and not a tree position, since leaf objects never have children and therefore any anchor or focus offsets cannot refer to child indices. Objects that are designated as leaves on certain platforms might not be leaves on every platform. For example, in the internal accessibility tree, native text fields are not leaf objects. They include a whole subtree inside them, which exposes all of the text. However, AXSelection in Blink should never return positions that are inaccessible to platform APIs so it is a safe assumption that any position on a platform leaf object should refer to a text object. The user visible change is that editing now works on the Mac without random navigation errors. R=aleventhal@chromium.org Bug: 988139 Change-Id: I1180274222b8899ec81bb031c35def98d89594bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725129 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#682293}
-
chrome://omniboxmanuk authored
Replaced handleNewAutocompleteResponse with HandleNewAutocompleteResponse in the mojom and cpp files. Retained lower case in the JS file. Bug: 891303 Change-Id: I0399aed03bc857c28452162d2a783d4b989843d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724861 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682292}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dc0b9e2f86a..7bacbf71f7d3 git log 9dc0b9e2f86a..7bacbf71f7d3 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 michaelludwig@google.com Update SkPicture version for simplified image filter enums 2019-07-30 halcanary@google.com experimental/editor: Editor::markDirty() private helper 2019-07-30 robertphillips@google.com Add GrContext::defaultBackendFormat 2019-07-30 fmalita@chromium.org [skottie] Fix property observer scoping for effects 2019-07-30 fmalita@chromium.org Clean up SkBaseDevice::CreateInfo 2019-07-30 robertphillips@google.com Add GrCaps::isFormatCompressed 2019-07-30 reed@google.com remove drawlooper bots, as that code is now gone Created with: gclient setdep -r src/third_party/skia@7bacbf71f7d3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:987392 Change-Id: I3d6a5e9f805891f8df90dcc462018527a6741db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682291}
-
Wei-Yin Chen (陳威尹) authored
Bug: 956205 Change-Id: I0960ddb12101f35c60c26a70c5592230964ac5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725521 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682290}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Ia640a3c60f69d607bdf932b090235a5493a1a368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725425 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682289}
-
Abhijeet Kandalkar authored
This is a reland of b223de22 with compile fix for internal builds (see PS1->PS2) Original change's description: > Convert services/media_session services to new Mojo types (6/n) > > The primary goal of this CL is to convert usage of |functions| of > interface AudioFocusManager and port dependent files to adopt new > implementation. > > Bug: 955171 > Change-Id: I2c8f269b2b36034b9ebc5beb1aef56ee3db691b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715367 > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682154} TBR=abhijeet@igalia.com, kinuko@chromium.org, rockot@google.com, oshima@chromium.org Bug: 955171 Change-Id: If48f271b14f2f74477273f909fa11a8b0771ffd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725639Reviewed-by:
Abhijeet Kandalkar <abhijeet@igalia.com> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682288}
-
Ricardo Quesada authored
This CL adds "className" attribute, in case it is defined, in the AutomationNode.toString() function. This is helpful when inspecting the automation hierarchy in Chrome OS, where the className is used frequently. TEST=Run this JS code:``` var myRoot; chrome.automation.getDesktop(r => myRoot = r); myRoot.toString();``` And it includes the className in the nodes that have it defined. BUG=chromium:982453 Change-Id: Icaeba586bda6ddcae536063718f8527be69f5f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693701Reviewed-by:Doug Turner <dougt@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682287}
-
Yi Su authored
The new layout of NTP articles based on EUCD compliance is ready for testing. Bug: 979143 Change-Id: Iad8e6569ac81674e0bcd474bbda03ad73bddb12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720238 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682286}
-
Tanmoy Mollik authored
Build components/signin/core/browser targets without implicit conversion from CoreAccountId to std::string All build targets for signin/corebrowser/BUILD.gn now builds without implicit conversion from CoreAccountId to std::string. Bug: 959157 Change-Id: Icd4bc11e21fddb2591b4fe8544b85dc0e0e992cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718411 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682285}
-
David Benjamin authored
The SSLVersionMax policy was introduced in 2017 to allow administrators to disable TLS 1.3, as a temporary workaround for buggy middleboxes. It was always documented in policy_templates.json to be temporary and stop working in M75, with notice in both M74 and M75 release notes. Remove the implementation of the policy. Bug: none Change-Id: Idec7c14101d2199cd5fad23897a5e76cd26025c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716059 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 985695 Change-Id: Ie6dfa5717219e06a5b7188e50c88b25b32ef69e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726049 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#682283}
-
Omer Katz authored
fix broken tests due to no allocation policy for pre-finalizers Bug: 988445 Change-Id: I5d795c118aecd1e0fbe8d7c0b1a63a07f1901be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726029Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682282}
-
kylechar authored
Add --show-aggregated-damage command line flag which activates a red highlight around the damage rect for the final aggregated CompositorFrame. It can be difficult to diagnose damage rect related problems so this may prove useful for debugging. DamageFrameAnnotator has the ability to draw an arbitrary number of DebugBorderDrawQuads even though it only produces one. This is intentional so it can easily be extended for other debugging tasks. Bug: none Change-Id: I4f97009b139978b228eaf58d70ebdc5c88f88f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717230Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682281}
-
Mohammad Refaat authored
TBR=marq@chromium.org Change-Id: I4379fe780d4365b9857a9e3a8b692112152b32df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726091Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#682280}
-
Geoff Lang authored
TBR=kbr@chromium.org NOTRY=true BUG=989050 Change-Id: Ic1f1b0fa6a3727a5b94657ff04442cf8b4f494f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724504 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682279}
-
Lutz Justen authored
[Sheriff] Revert "AppCache: Reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers (4)" This reverts commit 1ac215fe. Reason for revert: Breaks ChromeDoNotTrackTest.FetchFromSharedWorker on Linux MSan, see https://crbug.com/988997 Original change's description: > AppCache: Reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers (4) > > In the current implementation, WorkerShadowPage provides DocumentLoader to > ApplicationCacheHost for shared workers. This blocks WorkerShadowPage removal > (see the issue). To unblock it, this series of CLs reduce dependencies on > DocumentLoader from ApplicationCacheHost for shared workers. > > This CL... > > - moves WillStartLoading(), WillStartLoadingMainResource(), > IsApplicationCacheEnabled(), and |document_loader_| from ApplicationCacheHost > to ApplicationCacheHostForFrame. > - introduces WebLocalFrameClient::GetAppCacheHostIDForSharedWorker() to take an > appcache host ID from WorkerShadowPage with bypassing DocumentLoader. This is > a stopgap implementation, and will be removed by follow-up CLs soon. > - makes ApplicationCacheHostForSharedWorker binds itself with the backend in the > constructor instead of WillStartLoadingMainResource() that is a part of the > lifecycle of DocumentLoader. > > The follow-up CLs will create ApplicationCacheHostForSharedWorker in > WebSharedWorkerImpl instead of DocumentLoader. That will completely remove > DocumentLoader association from ApplicationCacheHost for shared workers. > > Bug: 982996 > Change-Id: I5beedd7600291a6f4867d35505e658b7f7194fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722932 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682075} TBR=mek@chromium.org,haraken@chromium.org,nhiroki@chromium.org Change-Id: Id8437f48e455cefaafa8c031d682a7abc4f8997e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 982996, 988997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726033 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
Gustavo Avena authored
Bug: 983109 Change-Id: I236709b5b17caa9e78b1fdff47b12d4ea5b2b275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715304 Commit-Queue: Gustavo Avena <gustavoavena@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#682277}
-
Rayan Kanso authored
Currently, if a user opts out of sharing a contact property, like a phone number, that can be detected by the exposed JavaScript result. This change makes it so that opting out from a sharing a property is indistinguishable from the contact not having any entries for that property. Bug: 988961 Change-Id: Ic9e72e9d4aeaf89825b7aa264491b8d114f4a07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724687 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Colin Blundell authored
Bug: 970295 Change-Id: I09a0a335b324a8b321b5f8deed3de5933d889118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724683Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682275}
-
Michael Lippautz authored
- Minor ThreadHeapStatsCollector fixes - Refactor sweeping finalization to reflect the two-step approach (Notify -> PostSweep) that already happened in practice. Initially landed see https://crrev.com/c/1713626 Bug: 982754 Change-Id: I358e0cb43129fd631c31b626e64157e3ba57ce07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724675 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682274}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e5d9dba..45872947 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd183941f838f40387005c7c8961b89efba96042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724644Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682273}
-
Kevin Ellis authored
This patch makes several of the internal methods in animation.cc private. Specifically, the now private methods are: SetCurrentTimeInternal CurrentTimeInternal PlayStateInternal This CL is part of a series of patches aimed at transitioning to the use of methods that are well documented in web specifications. In particular, PlayStateInternal is not spec compliant as it introduces an extra play state (pending). Bug: 960944 Change-Id: I22d59fc37a9f48863e7b52ab32b9d74e164bcfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716964Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682272}
-
Jordan Demeulenaere authored
Change-Id: I69a14a6e77e53e6eea77aa1c5e4e905b59ae6720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724761Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#682271}
-
Colin Blundell authored
Similar to the code usage snippet that was added for AccessTokenFetcher. Bug: 970295 Change-Id: I80b261978ff475e39a01d03b5756ec81cb7b45d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724078Reviewed-by:
-
Stephane Zermatten authored
Before this change, both unexpected taps and cancels were recorded as SHEET_CLOSED. This was wrong, as unexpected taps should be recorded as OVERLAY_STOP. Change-Id: I6f368611ecaf541fe70bc7a81195c91ada6da116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726089 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#682269}
-
Mugdha Lakhani authored
For Periodic Background Sync, we decide the next event time for a registration based on other existing periodicsync registrations for this origin. Skip this check for one-shot Background Sync registrations. Currently, if we have both a one-shot and a periodic Background Sync registration for a given origin, this check will be applied to the one-shot sync registration as well. This is unnecessary. This CL removes it and adds a unit test. Bug: 989003 Change-Id: Iff2b1d0444878444c6c1743f6ae0882caca86dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725638Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#682268}
-
manuk authored
Followup to making the feature default enabled. Bug: 966462 Change-Id: Ic7924049df1e14373c0a695878d51d32d0d77ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724118Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682267}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b24e912d9bae..e90f86832eff Created with: gclient setdep -r src-internal@e90f86832eff The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I1b259f2b193c928ed06bfef1219c304fb5f8bf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682266}
-
Ian Kilpatrick authored
There was special logic added for zero width inlines in: https://chromium-review.googlesource.com/c/chromium/src/+/870950/ This logic allowed for zero-width layout opportunities beside floats for inline-level content. This also added a TODO saying this was probably wrong for floats. .... it turned out this was wrong for floats. :) This adds a flag to switch between these two behaviours. Bug: 988505 Change-Id: I2db5e0b9cb6f90cb131821ad205728289d9098ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725309Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682265}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e671a6937e36..4c2c8d173f38 git log e671a6937e36..4c2c8d173f38 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 capn@google.com Compile GLSL in a critical section Created with: gclient setdep -r src/third_party/swiftshader@4c2c8d173f38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137828018 Change-Id: Ie560611019e1ac27e51437da53a401316ff305cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726069Reviewed-by:
-
Adam Langley authored
I think this comment is out of date. (At least I can't find DefaultPolicy.) Therefore update it to reference FeatureDefault, which I think is correct. Change-Id: Iab8fbd9eb71f269d159c8eab5c9de86a2b884a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724468 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#682263}
-
Juan Antonio Navarro Perez authored
We're making stricter requirements on how clients can interact with result objects; in particular they should call DidRunPage before attempting to read (iterate over) the stored results. This is needed to allow the following catapult CL to land: https://chromium-review.googlesource.com/c/catapult/+/1725950 Bug: 973837 Change-Id: I51b1f757344607a497bdca99b86d71583fffaf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725912Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/753002daef60..7deaf37e9442 $ git log 753002dae..7deaf37e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 bnc Make QuicSpdyStreamBodyBuffer manage consuming HEADERS frame header and payload. 2019-07-25 renjietang Create HTTP/3 unidirectional stream only when stream limit allows. 2019-07-25 fayang gfe-relnote: In QUIC, replaces QuicStream::priority_ with QuicStream::precedence_ and pluming it to write_blocked_list. No functional change expected. Not protected. 2019-07-25 bnc Rewrite QuicSpdyStreamBodyBuffer's consumed byte tracking algorithm. 2019-07-25 bnc Add QpackHeaderTable::draining_index(). 2019-07-25 bnc Use QpackEncodeRequiredInsertCount(0) instead of 0 in QpackEncoder. 2019-07-24 dschinazi Internal QUICHE change 2019-07-24 renjietang gfe-relnote: n/a - Remove unused member variable in QuicSpdySession 2019-07-24 nharper Add tool for testing quic interop Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src update flags R=rch@chromium.org Change-Id: Ic6c9b0ae4f4d4dadd928d771eb6b64ded55f497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721459Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682261}
-
Kush Sinha authored
If Chrome OS Account Manager - Has been fully initialized, and - Receives an initialization request with a callback, that callback is never invoked. Fix this by calling initialization callbacks instead of just early exiting in the case of duplicate initialization requests. Bug: 967602 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I2d072c50df158c81adc1be497c9891603ac52038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722532 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
