GitLab

This is a reland of a6f6697e

The test, GetAccessibleTabModalDialogTitle, failed on OSX because
tab-modal dialogs are treated as native windows in Voiceover.
This fix is unnecessary on OSX so the test is now disabled there.

Original change's description:
> Tab modal dialog title should be accessible window title
>
> Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title
> to AT (insert+T on JAWS and NVDA) when active. To accomplish this,
> BrowserView::GetAccessibleWindowTitle should report the title of
> the dialog when one is active.
>
> Bug: 775680
> Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle
> Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642
> Reviewed-on: https://chromium-review.googlesource.com/1184039
> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587371}

Bug: 775680, 879074, 879253
Change-Id: I4351a6487a4cb582383fe18b97e825a986464f59
Reviewed-on: https://chromium-review.googlesource.com/1197333Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587845}

Test: browser_tests
Bug: none
Change-Id: I2f4841af05d1ca2b0ea3ad686e8e1b322549b3d2
Reviewed-on: https://chromium-review.googlesource.com/1197903Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587844}

BUG=874341
R=sky

Change-Id: I996a9f57e569acb62eec7e27f8ae0015b92d0ceb
Reviewed-on: https://chromium-review.googlesource.com/1196932Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587843}

Previously, there was no way for a consumer to distinguish a graceful
socket close from the data pipe being closed for something other than a
network error (Network Service crash, NetworkContext shutdown, etc).

Bug: 878136
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ibf0f1bbe0603a5db2d40945b12d59f243e7e34e9
Reviewed-on: https://chromium-review.googlesource.com/1196964Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587842}

After experiment, the hover state on dark/image of the gear icon should
be lighter instead of darker to make it visible. Also change the active
state setting for gear icon on dark/image

Bug: 867768
Change-Id: I1b993297788ed6145ac7a32acfd85b766bd67999
Reviewed-on: https://chromium-review.googlesource.com/1197410Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587841}

- Use more descriptive error message than the generic failure message when
failing to mount an SMB share because it is SMB1, which is unsupported.


Bug: chromium:757625
Change-Id: I8293ce065293172cd3faacab7fac304908069f09
Reviewed-on: https://chromium-review.googlesource.com/1196009
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587840}

The Storage API [1] defines the "persistent-storage" string to allow
querying the state of the permission. Plug this into the Permission
API [2] implementation and add a web platform test.

[1] https://storage.spec.whatwg.org/
[2] https://w3c.github.io/permissions

Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FRAmGlAoDTY/discussion
ChromeStatus: https://www.chromestatus.com/feature/4770049554382848

Bug: 878525

Change-Id: Ia12fb43676e04e7e60ad58b5ffbd7ee22f78ffc4
Reviewed-on: https://chromium-review.googlesource.com/1194106
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587839}

This patch delegates the task of reporting context to GSA to
Contextual Search. This is being done in preparation to make the
ContextualSearchObserver package protected since its use is extremely
feature specific.

Bug: 878006
Change-Id: I340a6196210a4709cebef03e477e241be1633bb4
Reviewed-on: https://chromium-review.googlesource.com/1198003Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587838}

TBR=inferno@chromium.org,liaoyuke@chromium.org

Bug: 879389
Change-Id: I74ab663e1b7e69457d6f81cfa6890422610f4c9a
Reviewed-on: https://chromium-review.googlesource.com/1197829
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587837}

Records the number of resource loading tasks split by priority. Recorded
each time a task is executed.

Bug: 870349
Change-Id: Ic643cf1c5a578017c5cc8a78471c3ea7ebfc617d
Reviewed-on: https://chromium-review.googlesource.com/1185199
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587836}

The property is used to determine if we need to show the "Restore
default shortcuts" option. Previously this was calculated by checking
the tile source of the most visited items, but this did not account for
the case where there are no available items. As such, if there were no
custom links, the restore default option was disabled.

Bug: 879082
Change-Id: Ia15f4fc863642b520234c061ee5ecf6f7a54c50e
Reviewed-on: https://chromium-review.googlesource.com/1197465
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587835}

Clicking on the same custom background image tile should be considered
as unselecting the tile. Therefore, the done button should not be
clickable after that.

Bug: 879002
Change-Id: I2396660dec1a10d2a4acd05e8d80672db8072a3c
Reviewed-on: https://chromium-review.googlesource.com/1197463
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587834}

Bug: 875053
Change-Id: Ia0d4f40619c2d9f7a271e78857a86b9b63a3dc0b
Reviewed-on: https://chromium-review.googlesource.com/1194876Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587833}

This change hides the controls on the Picture-in-Picture window on all
platforms while moving the window or when the size updates. Previously,
this was handled on Windows.

The controls cannot be interacted with during the resize and dragging
actions. They also slightly obscure the video, especially the play/pause
icon. Removing the controls will allow the user to view the final video
size and position.

Bug: 877987
Change-Id: I788d8cb5690e3c587f93b21ad7eb7d0a2c69ecef
Reviewed-on: https://chromium-review.googlesource.com/1197722Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587832}

This Cl adds strings only.

Bug: 852553
Change-Id: Icc72b2c36a8c25a9a115aed33c555be0cf412e00
Reviewed-on: https://chromium-review.googlesource.com/1197845
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587831}

Bug: 873588
Change-Id: I089aa1919242effd05ad753a2f21ef3293320e36
Reviewed-on: https://chromium-review.googlesource.com/1197337Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587830}

The test seems to be timing out while taking a page screenshot after
the test completes, and this isn't the important part of the test.
Instead, rewrite it as a context_lost test, and include two variants:

  ContextLost_WorkerRAFAfterGPUCrash
  ContextLost_WorkerRAFAfterGPUCrash_OOPD

Tbr: fserb@chromium.org
Bug: 851213
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib1556ad9f693003b6b216085a0b1665cad017314
Reviewed-on: https://chromium-review.googlesource.com/1197942Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587829}

Before this CL, the user could click on the entire sink button to stop
casting. This CL makes just the stop button within the sink button
clickable.

The sink button and the stop button in it are given the same tag, so
CastDialogView that handles the clicks doesn't distinguish between the
two.

Icon size and padding are also adjusted to match the mocks. The icon
used in the sink button is tentative and will be replaced.

Screencap:
https://drive.google.com/open?id=1pT8U3712lotA8D-VaIwY-tROKIBuMvYB

Bug: 878194
Change-Id: I42346bad4d40d9c119325e3dd245a61d5fd70397
Reviewed-on: https://chromium-review.googlesource.com/1192355Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587828}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/a71cda985de2..74d6276bbc07

$ git log a71cda985..74d6276bb --date=short --no-merges --format='%ad %ae %s'
2018-08-29 baileyberro smbprovider: Add SMB1 unsupported ErrorType

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: Idc7a62460827c02cf2567038af5864056235baed
Reviewed-on: https://chromium-review.googlesource.com/1197789
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587827}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/59cbc10725c5..5053a10675a7


git log 59cbc10725c5..5053a10675a7 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 chingcodes@google.com signing: Add BiosSigner
2018-08-30 chingcodes@google.com signing: Add ECSigner
2018-08-30 chingcodes@google.com signing: Add FutilitySigner


Created with:
  gclient setdep -r src/third_party/chromite@5053a10675a7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I5e0f3b8fef20289519eb1e468b98e52ee80756c2
Reviewed-on: https://chromium-review.googlesource.com/1197295Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587826}

This fixes the a11y label for the "Other Google services"
expand button on the syncSetup settings page.

Bug: 853996
Change-Id: Ib7dc0b0ce02ab26417553e9b6204b7f4e121a4a9
Reviewed-on: https://chromium-review.googlesource.com/1197822Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587825}

This CL updates the DisconnectWindow class for Windows to allow it
to auto-hide after a period of inactivity (currently 10 seconds).
The dialog will then be reshown when local user activity is seen.

BUG=877176

Change-Id: Icc1e8d7db74690eac54e4084f18e1021830e0765
Reviewed-on: https://chromium-review.googlesource.com/1188597Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587824}

After the ebuild update, Chrome can assume there's only one version
of the Highlights app existing at a time, and it's the correct version
so board checking is not necessary.


Bug: 819404
Change-Id: I29b837131376a1c47ac3458bb98643c0bfa14e7d
Reviewed-on: https://chromium-review.googlesource.com/1197364
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587823}

ExtensionActionRunnerBrowserTest.ActiveScriptsAreDisplayedAndDelayExecution
has been flaky on Windows. Looking at the test, this could be caused by
not waiting a sufficient amount of time after loading the extension for
the extension background page to register a listener for the tab update.
This, in turn, would result in the extension not appearing to want to
run when it should.

Solve this potential issue by dispatching a "ready" message from the
extension once it has registered the listener, and waiting for that
message in the C++ before creating the new tab. Also explicitly wait
for the script to be injected in the case of automatic injection, and
wait for the blocked action to be added for the case of requiring
consent.

Additionally, break apart the test from being a single test that
exercised four different expectations to four tests, each managing a
single expectation. This eliminates the chance of any of the test steps
interfering with one another.

Bug: 867882

Change-Id: I2859bd35573415080e3c70a3e08bf2108430ee28
Reviewed-on: https://chromium-review.googlesource.com/1195844
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587822}

Bookmarks caches the tableView scroll offset, so whenever
bookmarks is closed and re-opened, we maintain the scroll offset
and the user is in the same position as before dismissal.

As part of supporting dynamic type on Bookmarks this approach is
no longer valid since:
-The row height might change due to the size of the font.
-The row height is not calculated unless the cell is dequeued,
this means that when the content offset is set to the cached value
(when re-oppening Bookmarks) the position offset is correct, but
the content being displayed are not. This happens because the cells
that weren't displayed when setting the offset manually used the
estimatedRowHeight instead of their real height. This messes up the
cache value.

In order to support dynamic height/type this CL changes the cache
so it stores the tableView row instead of the tableView scroll
offset. It also updates the pref values so they store an int instead
of a double.

It also deletes BookmarkHomeSharedState cellHeightPt and updates
the estimatedRowHeight value to 65.

This CL doesn't introduce dynamic height yet, that will be done in
a follow up CL.

Bug: 869671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6cd5f8baa8b385d3045ab5e9d0ff54a9d8202b63
Reviewed-on: https://chromium-review.googlesource.com/1157684
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587821}

Bug: 879306
Change-Id: Ia1458ab7275bbcfeeb24e358b5702cb5d5e57c2e
Reviewed-on: https://chromium-review.googlesource.com/1196025
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587820}

https://chromium.googlesource.com/angle/angle.git/+log/5fdc38cf171b..44b2c0b1d349


git log 5fdc38cf171b..44b2c0b1d349 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 fjhenigman@chromium.org Avoid rebase_path() in BUILD.gn.
2018-08-30 fjhenigman@chromium.org Avoid rebase_path() in tests/BUILD.gn.


Created with:
  gclient setdep -r src/third_party/angle@44b2c0b1d349

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Iac641dda1c8d0220973eeb890f303fd856245546
Reviewed-on: https://chromium-review.googlesource.com/1197293Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587819}

Before we may set auth token while assistant manager is creating, now
we wait for it to reach running state to refresh token.  This may happen
during start and settings toggles.

Bug: b:113591813
Test: locally compile
Change-Id: Iccc672844734be3a25d4b6cc761cc16cbe8e0d34
Reviewed-on: https://chromium-review.googlesource.com/1197844Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587818}

Previously, only gestures (i.e. tap) would trigger the controls to hide
after a certain period of time. This change also adds this behavior for
keyboard interaction to avoid forcing the user to blur the window to
hide the controls.

Bug: 879294
Change-Id: I697099c317c05a8e206acfab24848b8fd0ce149d
Reviewed-on: https://chromium-review.googlesource.com/1197408Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587817}

The new metrics are as follows:
- The number of apps user selected.
- The ratio of selected and recommended apps.
- Whether the reocmmend apps screen is shown.
- The user action on the recommend apps screen.

Bug: 835029
Change-Id: Ibdb3e14d1405693f9569bf4e6161027ce3fd7fbc
Reviewed-on: https://chromium-review.googlesource.com/1196037
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587816}

This CL adds a summary string for 'Google activity controls' that is
shown if there's a child account on the device.

Bug: 814728
Change-Id: I0e36d7c8adbaa32ac9e857c9a7ccb6846d570771
Reviewed-on: https://chromium-review.googlesource.com/1196603
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587815}

Create a KeyDerivationParams struct that encapsulates all information
needed to derive a key from a password. This includes the key derivation
method and any other method-specific parameters. Unhardcode the constant
salt for scrypt and accept a salt via KeyDerivationParams, as a
method-specific parameter.

Effectively replace *all* instances of KeyDerivationMethod with
KeyDerivationParams, since KeyDerivationMethod is no longer enough
information to be able to properly derive a key. The only mentions of
KeyDerivationMethod remain in SyncEncryptionHandlerImpl and its unit
tests, as they need to serialize and deserialize the method and
method-specific parameters separately in Nigori.

Add generation of a random salt to the code path where a new encryption
passphrase is set (only when we are using scrypt for key derivation;
PBKDF2 still uses the old hardcoded salt for compatibility reasons) and
persist it in Nigori. Read the salt when constructing a
KeyDerivationParams instance from an existing Nigori.

TBR=treib@chromium.org,sdefresne@chromium.org

Bug: 878890
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie4bde573d68a0bfeeec375c0d5d59e3d8c4e3437
Reviewed-on: https://chromium-review.googlesource.com/1196380
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587814}

Right now we have a active_touch_in_progress_ to indicate whether there
is an active touch or not. It is true when we receive ACK for touch
start and false at touch end.

From the current crash report, we are seeing multiple consecutive ack
for touch end, without any ack for touch start in between.

This CL changes the active_touch_in_progress_ to num_of_active_touches_.
It is increased by one when we receive ack for touch start and decrease
by one at touch end. At touch end, we only reset touch action when this
number is zero.

In theory, touch start and associated touch end should arrive in pair.
This CL does a DumpWithoutCrashing if this number is ever larger than
one.

Bug: 851644
Change-Id: I584f1aad56bf5bc5c08e20e3ae4ca36d5f9e3586
Reviewed-on: https://chromium-review.googlesource.com/1196696Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587813}

This adds an optional "ProxyErrorClient" client to the NetworkContext which
receives notifications of errors in the PAC script, as well as notifications
of failed URL loads that may have been proxy related.

Bug: 876568,851609
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I645ef91875135fcc81a7bd113442a0b65c661e65
Reviewed-on: https://chromium-review.googlesource.com/1192123Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587812}

Previously we were running the cc::Surface for Videos project on the media thread.
This was found to cause some smoothness regressions. This CL fixes that by pushing the
work onto its own thread.

TBR=gab@chromium.org

Bug: 866508
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide12cb6cebc9dea83a7686c09e6688537bf3389a
Reviewed-on: https://chromium-review.googlesource.com/1176879
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587811}

This adds the bridge code to allow Android Chrome to access the native
Query in Omnibox implementation that lives within the omnibox/
component.

Bug: 874592
Change-Id: I6d6721c648b9de453f4a17791bc91001ac104b1a
Reviewed-on: https://chromium-review.googlesource.com/1196162
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587810}

This change updates the service_manager::Instance code to reference its
options_.instance_sharing value instead of "service_manager:all_users"
and "service_manager:singleton" in the "required" section of its
interface provider specs.
Tests and existing manifests were updated accordingly.

Bug: 866967
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I699ec3411b7ec84023fbb56f85186ad5519515c4
Reviewed-on: https://chromium-review.googlesource.com/1195892Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587809}

This CL removes the restriction on the maximum number of WebAPK share targets
by switching from a checked-in ShareActivity{{index}} to an activity alias.

Bug=None

Change-Id: I40567760615da5a9e0c218621df6eac749cf80d0
Reviewed-on: https://chromium-review.googlesource.com/1191088
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587808}

AudioOutputDevice needs to be destroyed on non-UI thread
to avoid blocking.

Bug: b/112782871
Test: Manual test with DCHECK on.
Change-Id: I8e7fd7d9656ff8a9152f10d48d4575055763bd63
Reviewed-on: https://chromium-review.googlesource.com/1197046
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587807}

This reverts commit d63515c2.

Reason for revert: breaking all webview benchmark

BUG:878965

Original change's description:
> Remove unneeded list from event_stream_logger.js
> 
> Change-Id: I8494b52cd7a38d2b52184f4fb02030d3a05da776
> Reviewed-on: https://chromium-review.googlesource.com/1187861
> Reviewed-by: Yuki Awano <yawano@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Eriko Kurimoto <elkurin@google.com>
> Cr-Commit-Position: refs/heads/master@{#585742}

TBR=dtseng@chromium.org,yawano@chromium.org,elkurin@google.com,sarakato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I65b1079c6496f83cbe2a332d8e7570eb3a92d244
Reviewed-on: https://chromium-review.googlesource.com/1196840Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587806}