- 06 Jan, 2020 40 commits
-
-
Andrew Grieve authored
Special top-level directory no long necessary now that we use binary resources in robolectric tests. Bug: 963624 Change-Id: I7330001028df10025ba0e11b310d9df586f7b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984477Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728527}
-
Ben Kelly authored
Its possible for the RenderProcessHostImpl to be destroyed on the UI thread before the BinderRegistry is destroyed on the IO thread. Bug: 1038019 Change-Id: Id6cb87fa0c4ea72c814d6f81ca296ec7be5f6f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986135 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#728526}
-
Christopher Grant authored
This change adds a pure 32-bit version of Monochrome, Trichrome and Webview to the 64-bit build configuration. Building these targets generates a product equivalent to building the targets on a 32-bit config. However, by adding these, we have the option of building all Monochrome and Trichrome products on a single 64-bit builder, and, we share the compilation work (as opposed to the obsolete process of "APK merging" parts from a 32-bit build into 64-bit products). The targets added here are the public versions. This change was originally reverted, because it exacerbated an unknown dependency problem with Trichrome, causing problems on trybots. That issue was fixed separately, meaning that these changes should be able to re-land safely: Revert: 8faa5fc4 Trichrome fix: d2a17895 It is being relanded with a follow-on change (that was also reverted), updated to handle WebView bundles: a2897b6b Also added to this version is coverage of the new webview bundles. TBR'ing torne and agrieve as they've already reviewed the original changes. TBR=torne@chromium.org, agrieve@chromium.org Bug: 1027573 Change-Id: Ie1c9f042a7046505b081bfb9312e48ee8ee3b197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960575Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#723897} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985527 Cr-Commit-Position: refs/heads/master@{#728525}
-
Andrew Grieve authored
In favor of using the new & simpler "sources" attribute. TBR=agrieve # Trivial BUILD.gn in components/ Bug: 1026378 Change-Id: I1bc6db5f66262bef18b0c458435e742230c1d4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982187 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728524}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6334d594f68c..8db9eccc0baf git log 6334d594f68c..8db9eccc0baf --date=short --first-parent --format='%ad %ae %s' 2020-01-06 cepheus@frii.com Bump revision Created with: gclient setdep -r src/third_party/glslang/src@8db9eccc0baf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Idff09dac36fd73ed26551428c6b9d96fff31e147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728523}
-
Antonio Gomes authored
Instead, WTF::String is used. BUG=787254 R=haraken@chromium.org Change-Id: I046b6309b56e5d7664b0e7983d712aa3b21a12a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988289Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728522}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/933ea8c301b1..f3d6c36de379 git log 933ea8c301b1..f3d6c36de379 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 kjlubick@google.com [canvaskit] Add npm release target to ship smaller binaries Created with: gclient setdep -r src/third_party/skia@f3d6c36de379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I16638533758c0d7c11f83c26369730759956ac5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987937Reviewed-by:
-
Mikhail Khokhlov authored
Some tests depend on "telemetry_chrome_test" target directly, bypassing "perf" target. This CL moves the dependency on trace_processor_shell from "perf" to "telemetry_chrome_test" to make sure that all tests can use the trace processor to convert proto traces. Bug: 1038780 Change-Id: I308024cd5ec06bd4989ff983e28e9f26b19f792c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983173Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#728520}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8987f8f14e92..347030813829 git log 8987f8f14e92..347030813829 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 tvanderlippe@chromium.org Migrate worker_main/ to ESM 2020-01-06 tvanderlippe@chromium.org Migrate toolbox_bootstrap/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@347030813829 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d9eb3b37456ddb3027d4470fae8476c878f99e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987935Reviewed-by:
-
Andrew Grieve authored
Saves 300ms on my machine Bug: 1036740 Change-Id: I88a0cbb8d207ac1ef4710bd771b8eb69d6c2f514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980314 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728518}
-
David Bokan authored
We kept |touch_scrolling_| simply to be able to set the |is_direct_manipulation_| bit on the scroll state in ScrollBy. It's cleaner to simply have InputHandlerProxy set this bit correctly in all cases. The majority of this CL is simply adding an extra parameter to the state creation method in unit tests so that we can set the bit correctly there too. This was a mechanical change. Bug: 1016229 Change-Id: If0c46d283fb030f205ffd39cdb0c04dd9e1bd7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981335 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728517}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0dbd769597c4..3d45c872224d Created with: gclient setdep -r src-internal@3d45c872224d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia983fb90908af6c18e19f4a411e44be4e1a5909a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987938Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728516}
-
Andrew Grieve authored
For non-official builds, sets compression level to 1, which yields a ~4% worse compression ratio, but compresses twice as fast. For official builds, sets compression level to 9, which yields a 0-1% better compression ratio, and compression twice as slow. On my machine, apkbuilder.py for Monochrome.apk in debug goes from 7.5 to 6.2 seconds, and with is_officail_build, 9.6 seconds. Bug: 1036740 Change-Id: I9296dcb45358a6c5cf742fc404dadbbbaec522fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980313 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
* Disable v1 signatures for Monochrome * Disable v3 signatures always * Adds timestamps for profiling (behind APKBUILDER_DEBUG) Signing debug Monochrome.apk goes from 10 seconds to 3 seconds. Here's an after breakdown from my machine: I 59413 9 Started (apkbuilder.py) D 59413 29 Adding AndroidManifest.xml D 59413 33 Adding assets/ D 59413 360 Adding classes.dex D 59413 1713 Adding lib/ D 59413 2107 Adding res/ D 59413 2286 Adding Java resources D 59413 2294 Running zipalign D 59413 2614 Signing apk I 59413 7513 Job's done (apkbuilder.py) Bug: 1036740 Change-Id: Ic12f52e5e3bd79ca057513cc2ae3d1c344d9858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980310Reviewed-by:
-
Gauthier Ambard authored
This CL cleans PageInfo up, preparing for a new design. The PageInfoModelObserver wasn't used, so it is removed. All the other things removed were never called, so they can be removed. Bug: 1038919 Change-Id: I95a6630bd3ff0c03c3cf9af4b25cb4ef88e33ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986789 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728513}
-
Antonio Gomes authored
This CL changes PCDF to operate over WTF's Bind() helpers instead. BUG=787254 R=haraken@chromium.org Change-Id: Id812a11796e80a1a68de71e8a2f928c1416aa6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988287Reviewed-by:
-
Sami Kyostila authored
Bug: 1006539 Change-Id: Ie8788b614d2ce945974d45223e2044c58d7a04dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988351 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#728511}
-
Corentin Wallez authored
These failures were introduced by a shared image change [1] that cannot be reverted because of merge conflicts. Suppress while the issues are being worked on. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1985128 Bug: chromium:1039232 TBR=ynovikov@chromium.org TBR=tommi@chromium.org Change-Id: I1db450ce3a6bd245327bb4068d89d41f48afdadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988350Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#728510}
-
Yuki Shiino authored
Introduces v8_interface_bridge.h and makes generated v8_interface.h compilable. Bug: 839389 Change-Id: If5d75cb72eafa398f70dfa3667a562000df5d1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988092Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#728509}
-
Boris Sazonov authored
This CL removes unused code that was behind MobileIdentityConsistency feature flag. Bug: 980849 Change-Id: I78dd6b212ff011c9d2361874055783902d3619eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976701 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#728508}
-
Greg Thompson authored
This document explains the Chromium policies for files in the `User Data` directory. BUG=958893 Change-Id: Ia941d3a532cae176a5ed5e5b159f7a72feaef6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715823 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#728507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b30c2651879a..0dbd769597c4 Created with: gclient setdep -r src-internal@0dbd769597c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2b0707677d386cbd7e0acccb6bfe68bfbe5a1e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988150Reviewed-by:
-
Stepan Khapugin authored
This is a fix for broken input of the first combined character in the omnibox (for example in Korean). This introduces a regression on older OS versions when using third party keyboards; however this regression is *already* happening on the latest iOS 13 builds. This is a temporary fix; a proper fix is to change pre-edit behaviour so that it wouldn't set text or change selection in the omnibox when it exits pre-edit. Such a fix is a lot more fragile and will be rolled out behind a flag, but we need to fix the common-case input of combined character on latest OS now. Bug: 1030476, 988431, 875918, 873544 Change-Id: I33248fdb17d75e215dedea11469de94dd7dc183c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980746 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#728505}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41dcfb68. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib36a3dd006935aff8f6be38e8f03e13bbfa1e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988286Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728504}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1db2661f17c..933ea8c301b1 git log f1db2661f17c..933ea8c301b1 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 kjlubick@google.com [canvaskit] Add build flag for pathops Created with: gclient setdep -r src/third_party/skia@933ea8c301b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Ie292f46b0d20e47cab5b30ca8d81eea016935933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988149Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd2b2ce5d7b8..8987f8f14e92 git log fd2b2ce5d7b8..8987f8f14e92 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 tvanderlippe@chromium.org Migrate sources/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@8987f8f14e92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46069e50d7b072016a961eb640a66c83a145fe09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988148Reviewed-by:
-
Corentin Wallez authored
Update skia_renderer_gl_blink_web_tests expectations to allow flaky media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html TBR=ynovikov@chromium.org Bug: chromium:1027772 Change-Id: Ie4b9b5578c09adbfeff5c53cdd814bcb0042f93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988346Reviewed-by:
-
Mugdha Lakhani authored
To be checked in after these CL has been checked in: https://chromium-review.googlesource.com/c/chromium/src/+/1985985 https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985661 Bug: 1038678 Change-Id: I7e579e4017d29dc9af72f01a533c843f3baeb2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980697Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#728500}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: If4c4c2fdd7edbcc43f5b093638bcd06d512995ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978660 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL is part of the profile info cache refactoring project. Bug: 305720 Change-Id: I0c1c2058a7f5ec1078dd84c516dcbc4e73fa144e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985843Reviewed-by:
-
Rune Lillesveen authored
Caused a fuzzer crash because ancestor marking of ChildNeedsStyleRecalc happened with out-of-date FlatTreeNodeData. Bug: 1034265 Change-Id: If36225997187bd1a3dcfb6ea4b9519ce44172711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986800Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#728497}
-
Corentin Wallez authored
This test started failing after https://chromium-review.googlesource.com/c/angle/angle/+/1952166 probably due to a driver bug that's mentioned in that CL. Suppressing to keep the waterfall green while it is investigated. Bug: chromium:1000354 TBR=ynovikov@chromium.org Change-Id: I201119ae13d3d98f83befe0171d67da446c82c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986804Reviewed-by:
-
Anders Hartvoll Ruud authored
Instead of removing animation properties from the cascade, it's cheaper to just skip them using the Exclude functionality. BUG=947004 Change-Id: Ic42ca2ef396a61cd8e1828f5022717a189f8f02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986796Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#728495}
-
Alex Keng authored
This CL uses a different approach to implement the rounded corner for <meter> to address the 1 pixel gap issue. The previous approach [1] (which uses clip-path applied on -internal-meter-clip) is reverted, and the new approach is using [overflow: hidden] on -webkit-meter-bar, and [display:grid] on -webkit-meter-inner-element. Note we can't just use overflow:hidden without changing display to grid since the baseline alignment would change (per CSS 2.1 spec, see [2] for details. (vertical-align:bottom doesn't work either)). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1858295 [2] https://stackoverflow.com/questions/20152795/making-a-span-element-inline-block-and-overflow-hidden-will-displace-him Bug: 1021231 Change-Id: I51ffab57983c268620b6c81927dabd32043aa0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980951 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#728494}
-
Morten Stenshorne authored
It seems that the list of failing Linux tests is identical to the one already added for Windows, so I just copied that. These tests seem to fail consistently locally (Linux). TBR=masonfreed@chromium.org Bug: 1035582 Change-Id: I18e76d6e1550ffd35418b4f83dc97828daac9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986835Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#728493}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d74594bbbb71..fd2b2ce5d7b8 git log d74594bbbb71..fd2b2ce5d7b8 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 tvanderlippe@chromium.org Migrate perf_ui/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@fd2b2ce5d7b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id05c815f6127a6d54c75d1c79e584118a5d8bf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987857Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 1018640,1038346 Change-Id: I6d94787430441377669ceb7bbf5d62c22a01390f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980263Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61fe7a44e909..b30c2651879a Created with: gclient setdep -r src-internal@b30c2651879a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifbba52b8e926b79a72532830d68ad7cb733691ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987859Reviewed-by:
-
Tobias Sargeant authored
This paves the way to unfork the weblayer MinidumpUploader, which splits MinidumpUploadCallable into two classes, one of which is responsible for uploading a single minidump. Unfortunately that causes a naming collision; resolve it in favour of renaming the minidump_uploader class, which is responsible for managing the upload of multiple minidumps as a JobService job. Bug: 1029724 Test: run_webview_instrumentation_test_apk -f \ Test: 'org.chromium.android_webview.test.services.MinidumpUploadJobTest#*' Test: run_chrome_public_test_apk -f \ Test: 'org.chromium.components.minidump_uploader.*#*' Change-Id: Ib82dd334e77ee0e60a3c35a0d2f8bd38cfb6ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975881 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#728489}
-
Monica Basta authored
This CL is part of the profile info cache refactoring project. Bug: 305720 Change-Id: I70c4642227b9cf39ee71db983ea987bbde79d1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985777Reviewed-by:
-
