- 09 Oct, 2020 40 commits
-
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/7c2e104ffbe4..a84f9718f35f $ git log 7c2e104ff..a84f9718f --date=short --no-merges --format='%ad %ae %s' 2020-10-09 junyer Ensure that RE2::Arg works even with overloaded ParseFrom(). Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I6dc8022ea1f2d99535f9938f7a1027171cd3eb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461698 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815661}
-
David Bokan authored
UMA isn't enabled on most devices that use spatial navigation and no one is actively looking at this so let it expire in M85. Bug: 1088658 Change-Id: I4aa10d3fd2cb1d9b6dc6d7318c3a1bbfe605bd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443498Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815660}
-
Ella Ge authored
The crash report shows the IllegalArgumentException is because of package name is null. Add a null check before getting the installer package name. Bug: 1136018 Change-Id: I90f38bfcf67cf5de41996b3bf463633e2db2bca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457369 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815659}
-
Clark DuVall authored
There are various bugs with resources in isolated splits including: - RemoteViews can't access them - Splash screens for activities with themes defined in the isolated split fail - Bugs like crbug.com/1133898 (not strictly isolated split related though, but this fixes it for the chrome split) - Possibly more... For now I think it makes sense to move all resources to the base module to avoid these and any not yet uncovered bugs. Later we can see if it makes sense to move these back into the chrome split. Bug: 1126301 Change-Id: Id4b3d20b8d88dcea9b7ba2d090c07714324cee1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463642Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815658}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010090700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/TGyqQ0i-VwfJWUWkmWGzsrQ0c-MmVg_nP2-LKMWnCQYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ib0de79c4a78956cad601d2a029a7916e8389d53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463388Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815657}
-
Benjamin Beaudry authored
This change makes the AXPlatformNodeTextRangeProviderWin endpoints helper class a tree observer, allowing it to keep its stored |start_| and |end_| position valid. By observing the trees that the |start_| and |end_| position are in, the AXPlatformNodeTextRangeProviderWin::TextRangeEndpoints can adjust its endpoints if the node they are on is deleted. When this is the case, the position is then moved to the parent node. Known issue: In some cases, a node can get deleted alongside its parent. When this is the case, moving the position to its parent wouldn't solve the issue of the invalid position as the parent, itself deleted, wouldn't be a valid anchor. I have not observed this issue in practice, but I think it could be a good idea to keep that in mind. Change-Id: Ib0fd7bef9040b8744a0b1e0d7ea2d6b58c7477d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432805 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c251d370b65e..0ad07c924552 2020-10-09 treehugger-gerrit@google.com Merge "Fix slice combining in RAIL mode metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic9e4158db4d225c0f02a20fb36951572df98a271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815655}
-
Haiyang Pan authored
It has been running at 100% since crrev.com/c/2446513 and so far works fine. The test pool http://shortn/_382OI523IF and host pool http://shortn/_ro7oQn8de4 both looks healthy. Bug: 1111436 Change-Id: If373ba784928488f2c4a4c0e089ae42f212f2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461599Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#815654}
-
Scott Violet authored
The specific case this exercises is the overflow:visible axis. I couldn't find any wpt tests for this, and it seems worth adding. BUG=1087667 TEST=wpt/css/css-overflow/overflow-clip-hit-testing.html Change-Id: Iafe042a02737f69f47750900fe7027e711d96004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458726Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815653}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010090700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/P-2JwDZls8V1LNOlmHoxgPlVs68icpTYuJyIwCQQ-okC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Iaa49700f25310cfcd8ead0b15ada91c5b38dbc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463522Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bf76269e147..c251d370b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I14a699ee2568d519969e8d52d0b52754c6ade947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461917Reviewed-by:
-
Becca Hughes authored
Change-Id: I362f36de0759cb75892a102c3658885b3dd9b7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410738Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#815650}
-
Clark DuVall authored
We are investigated using isolated splits for Chrome, and splitting //chrome code into a DFM. Due to b/169196314, all service classes must be present in the base module. See go/isolated-splits-clank for more details. This change creates a new minimal target for PaymentDetailsUpdateService which the base module will depend on. Bug: 1126301 Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815649}
-
Dirk Pranke authored
This converts the two test suites from 'script' tests to 'generated_script' tests, pushing more of the command line logic into GN targets (and the generated wrapper scripts). Bug: 816629 Change-Id: I0ebca0c54d61c6c60734147ebfef1673bd262ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462623Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Sahir Vellani authored
New feature (off-by-default) will enable smoothness mode for wheel scrolling. This will allow us to experiment and measure the impact on user scrolling. Instead of only considering precise scrolls as 'actively scrolling' we will consider all scroll updates for which delta was consumed on the compositor. Bug: 1056460 Change-Id: I21ccfdb3c4e67e7738ec568f48d750e950d5f43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443550 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815647}
-
Wenbin Zhang authored
crrev/c/2459799 added [Skip] tag for the stories: animometer_webgl_indexed, animometer_webgl_indexed_multi_draw_base_vertex_base_instance, animometer_webgl_indexed_multi_draw Though, even if they're skipped, the current logic still checks their achieve status. This CL will set those stories as DESKTOP_ONLY. Synced with Shrek and these stories will not be ready for mobile for now. Expectation file needs to be update to pass the PRESUBMIT, which complains that the tag on expecation does not apply to those stories. Will be another CL to update the logic to skip the achieve checking logic. Bug: chromium:1136227 Change-Id: I52f4b10b6c3399634611cb69d7b33f66c843ae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462226 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#815646}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa8c4617869e..658ae8fc6aba 2020-10-09 johnstiles@google.com Reland "Put top level FPs into their own functions" 2020-10-09 ethannicholas@google.com refactored more SkSL IRNodes 2020-10-09 egdaniel@google.com Reland "Rename GrStencilAttachment class to generic GrAttachment" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I1879227438e14b155bb10b8fc2f5883c47382f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463255Reviewed-by:
-
ckitagawa authored
Paint Preview Player Test is failing due to how threading is different in that test. This works in prod so let's just remove the checks for now. Bug: 1136888, 1136712 Change-Id: I5aa0623dbd7465b2069d9534b299a3e23668b9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463327Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815644}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Icf2da5098a87d00798cd01cf53e5ebdf04354582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461380Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815643}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I579500a705436e6c36b8b56c241ab5f8b5e9018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462260Reviewed-by:
-
Mohamed Amir Yosef authored
This CL uses a smaller arrow (and different arrow) in the move bubble to be aligned with the arrow used in move bubble in chrome://settings/passwords It also adds some margins around the new smaller arrow. Screenshot: https://screenshot.googleplex.com/3ApL5zYMe8A2HQi Bug: 1100814 Change-Id: I83caa8ad0ec2d78a65cc9bd5517b17068d6cce6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461318Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#815641}
-
Mikel Astiz authored
No behavioral changes: this class groups the two preexisting observing functions in a single interface to improve readability. On iOS, some temporary code is introduced to avoid breaking the build or the behavior for downstream implementations of ChromeTrustedVaultService. Change-Id: I28e8a78148ce65f69e07ff4782e3570e266d3c10 Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461007 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#815640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cd5015ec. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3b0b5b19e4ab834b78f26825ff3183729644c59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460950Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815639}
-
Olivier Robin authored
In side by side mode, it is possible to switch the keyboard focus between 2 applications. In that case, no notification is sent to Chrome. But the keyboardView is recreated on getting the focus back, and it is possible to use this signal to retrigger accessory view. Bug: 1125095 Change-Id: I06e8301ab6aec8fa58a78fed2c94516a1d2fa3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445410 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#815638}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I13561748b18f77d6040bdf1256e3dd003a1b8b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461381Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815637}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ia27612e37a3d5c944a0d8ef3bf3af5250cf508ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462263Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I0f52a7aeba36f13a2cb20018888c049303edc0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459346 Auto-Submit: George Burgess <gbiv@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#815635}
-
Alice Wang authored
This CL hides the incognito row when incognito mode is disabled by the policy IncognitoModeAvailability. Bug: 1136777 Change-Id: I44c004870d6cd51b67951bbcbd853a8b11636c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461319 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815634}
-
Mehran Mahmoudi authored
This CL cleans up the player integeration logic with Chrome, which mostly lived in TabbedPaintPreviewPlayer. That class is now divided in two: One is responsible of showing a paint preview in a tab, and the other controls the logic related to the show-on-startup experiment. This CL also gets rid of most of the logic related to the demo mode. Demo mode now also uses the TabbedPaintPreview for displaying a paint preview. Finally, this CL organizes the various callbacks that PlayerManager needs into one interface. Bug: 1132451 Change-Id: I748b6bb43d78d174c1a4f79ce8f4325cd2970e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432752 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815633}
-
Mihai Sardarescu authored
This CL removes some Android-only logic that avoided downloading the account info when the account info was invalid. This ensures that the account info is correctly updated when the user signs in to Chrome. This CL also fixes a subtle bug that lead to the avatar image not being downloaded on start-up if the previous attempt to download the avatar image failed. Bug: 1135958 Change-Id: Ia31993f969aac2fc6b7c6f1ed325eb012ad33dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461310 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815632}
-
David Bienvenu authored
This reverts commit bb86e3cd. Reason for revert: <crbug.com/1135885> Original change's description: > Ensure that devtools stays visible when window is made smaller. > > Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550 > > Bug: 974178 > Change-Id: I5792cbd065d1437de2fa44d43407eb70e7b22960 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447094 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814196} TBR=caseq@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974178 Change-Id: Idbfcdf1170a60d940d3989d2b0f9bc8e84f74129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462639Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815631}
-
Jeroen Dhollander authored
These methods (IsSettingSupported and SupportsModifySettings) are not called by Libassistant anymore, and are removed from the API altogether in 1.50 Bug: b/170170824 Change-Id: Ic9bbbfd06661ba8cfe128850bd07a6dc5a395508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451401Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#815630}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11158c21..07b0b1dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b48a3d89a2f0bcfe73d6bc14db2c5a44a10ca77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815629}
-
Elly Fong-Jones authored
After this change, ShellView is only responsible for being the contents view of the content shell, and not also for doubling as the window's delegate. Instead, a separate delegate (of the stock WidgetDelegate class) is constructed and installed. Bug: 1075649 Change-Id: I3bc18b53d3c660da21571ca969541699d524af3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461591Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#815628}
-
Tanmoy Mollik authored
Add a test resource to use in place of user profile picture in tests. The tests that require it are also updated. Bug: 1125452 Change-Id: I0b6323b4c9d76816e3216c14d9ca5cd338c60b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401658Reviewed-by:
-
Jacobo Aragunde Pérez authored
This is a follow-up to crrev.com/c/2431526, where we fixed the "save card" and "translate page" bubbles as a side-effect. Now we add some tests to prevent future regressions in these bubbles. Bug: 1119349, 1119367, 1119734 Change-Id: I6e78e4aa1f5377d8512d574ae8deaa0437e51f67 AX-relnotes: Announce "save card" and "translate page" alert dialogs. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460886Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#815626}
-
Hajime Hoshi authored
Bug: 1088512 Change-Id: I95c6688bdf1fc106e77fae90fc4e37e42c99ec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434017Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Change color to grey_500 for both light mode and dark mode. Screenshot: https://crbug.com/1135915#c4 Bug: 1135915 Change-Id: I29e790195a4f6d276dceb32aab1d19ba5dc7744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456527Reviewed-by:
-
Clark DuVall authored
Requested by peconn@ in http://crrev.com/c/2462176. Bug: 1126301 Change-Id: Id5d18fbefa553655e0a28db63c9cc64b1231d39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462173 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Ewann authored
This CL enables customSeparator in Settings if the SettingsRefresh flag is enable. Bug: 922511 Change-Id: I119e37403c4161301e35982bb5733cee0497263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461327 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815622}
-
