- 11 Jan, 2017 40 commits
-
-
marq authored
BUG=679349 Review-Url: https://codereview.chromium.org/2627663002 Cr-Commit-Position: refs/heads/master@{#442847}
-
yukishiino authored
Supports V8<Type>Partial::preparePrototypeAndInterfaceObject. BUG= Review-Url: https://codereview.chromium.org/2620013002 Cr-Commit-Position: refs/heads/master@{#442846}
-
tyoshino authored
FetchRequest is a parameter object for calling ResourceFetcher::requestResource(). Its usage should be limited to requestResource(), it's callers and ResourceFetcher's methods directly called by requestResource() (this is already enforced by annotating FetchRequest with STACK_ALLOCATED). Logic in FrameFetchContext should be limited to what we cannot put in ResourceFetcher for dependency reason. It's better passing what's only needed. BUG=671533 R=yhirano@chromium.org Review-Url: https://codereview.chromium.org/2555713002 Cr-Commit-Position: refs/heads/master@{#442845}
-
droger authored
AutocompleteActionPredictor::StartPrerendering actively destroys the existing prerender when a new one is created, even if the new one is a duplicate. Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender must return a handle to it, and not null. That way it increases the reference count on the prerender and prevents it from being destroyed. This can be done by simply changing the ordering of the existing code. BUG=679714 Review-Url: https://codereview.chromium.org/2622893002 Cr-Commit-Position: refs/heads/master@{#442844}
-
nacl-deps-roller authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/026b76327c0c..94bbb858ca38 $ git log 026b76327..94bbb858c --date=short --no-merges --format='%ad %ae %s' 2017-01-10 dschuff Set bot names back to precise for trybots Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review-Url: https://codereview.chromium.org/2623173002 Cr-Commit-Position: refs/heads/master@{#442843}
-
ericwilligers authored
We rAF until the property has changed, instead of using setTimeout. BUG=248938 Review-Url: https://codereview.chromium.org/2621853002 Cr-Commit-Position: refs/heads/master@{#442842}
-
qyearsley authored
This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file. NOEXPORT=true BUG=676491 Review-Url: https://codereview.chromium.org/2619163005 Cr-Commit-Position: refs/heads/master@{#442841}
-
tkent authored
This is the second try to fix a performance regression of menulist rendering. The first try [1] didn't have major improvement. This CL reverts it, and cache another value. [1] crrev.com/438496 BUG=673754 Review-Url: https://codereview.chromium.org/2600873002 Cr-Commit-Position: refs/heads/master@{#442840}
-
ericwilligers authored
We now wait for the end event instead of using setTimeout. BUG=248938 Review-Url: https://codereview.chromium.org/2618293002 Cr-Commit-Position: refs/heads/master@{#442839}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyFontVariationSettings from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIFontVariationSettings.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIFontVariationSettings.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIFontVariationSettings.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2613723003 Cr-Commit-Position: refs/heads/master@{#442838}
-
yoichio authored
This patch converts following tests to utilize w3c test harness with |assert_selection()| to ease of maintenance for improving code health('=>' means move/renaming): LayoutTests/editing/selection/4947387.html => LayoutTests/editing/selection/modify_move/move-by-paragraph.html LayoutTests/editing/selection/after-line-wrap.html => LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html => LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html This is preparation to remove default styles on contenteditable containers. See crbug.com/427135. BUG=427135,679977 Review-Url: https://codereview.chromium.org/2525273002 Cr-Commit-Position: refs/heads/master@{#442837}
-
yoichio authored
This CL copies from |VisibleSelection::showTreeForThis()| and renames following "base" and "extend". TEST=No change in behavior Review-Url: https://codereview.chromium.org/2533693002 Cr-Commit-Position: refs/heads/master@{#442836}
-
johnylin authored
In VideoDecodeAcceleratorParamTest.TestSimpleDecode there are many ASSERT_xx while testing, which aborts test and doesn't delete GLRenderingVDAClient in GetRenderingTaskRunner. 1. For thumbnail test, in fact it doesn't need ASSERT for MD5 missing, wrong format, or comparison failure since it won't break any other things. Change to EXPECT_xx and LOG(ERROR). 2. Delete GLRenderingVDAClient in VideoDecodeAcceleratorParamTest::TearDown(). When ASSERT happens it aborts test immediately and call TearDown(), so we can make sure GLRenderingVDAClient is deleted. BUG=654677 TEST=test debug version of video_decode_accelerator_unittest on Elm 1. For thumbnail test, try to not push md5 file and the test will fail and end gracefully. Add an invalid entry in md5 and the test will pass with error messages. 2. Try to make assertion in any place inside TEST_P. Test will fail and end gracefully. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2596193005 Cr-Commit-Position: refs/heads/master@{#442835}
-
Philip Jägenstedt authored
BUG=680050 TBR=pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2625083002 . Cr-Commit-Position: refs/heads/master@{#442834}
-
Philip Jägenstedt authored
BUG=680043 TBR=mikhail.pozdnyakov@intel.com Review-Url: https://codereview.chromium.org/2622183003 . Cr-Commit-Position: refs/heads/master@{#442833}
-
Philip Jägenstedt authored
Something in this range broke the Mac builder: https://chromium.googlesource.com/chromium/src/+log/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1%5E..1a7740c44a6c4d03423c4b5ff7d746e1a1b7363e?pretty=fuller r442828 is the most obvious candidate which may have affected builds. BUG=679607 TBR=kbr@chromium.org Review-Url: https://codereview.chromium.org/2626993002 . Cr-Commit-Position: refs/heads/master@{#442832}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/fb00390b46b3..db52cf3b040d $ git log fb00390b4..db52cf3b0 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 reed move SkDraw.h to core Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Review-Url: https://codereview.chromium.org/2620283003 Cr-Commit-Position: refs/heads/master@{#442831}
-
joone.hur authored
The caret height should be calculated by using the FontMetrics instead of the selection height. BUG=588060 TEST=editing/caret/caret-height-multi-line.html Review-Url: https://codereview.chromium.org/2517383002 Cr-Commit-Position: refs/heads/master@{#442830}
-
ksakamoto authored
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ou_Dwfp8Ons/mCaMNPPdFAAJ BUG=678547 Review-Url: https://codereview.chromium.org/2619823003 Cr-Commit-Position: refs/heads/master@{#442829}
-
kbr authored
BUG=679607, 663188 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2627553002 Cr-Commit-Position: refs/heads/master@{#442828}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/29a9f87a8bcd..44bc1f818dd7 $ git log 29a9f87a8..44bc1f818 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 npm Fix m_nb_mct_records calculation in opj_j2k_read_mct 2017-01-10 dsinclair Strip out custom allocator code 2017-01-10 dsinclair Split xfa_textlayout apart. 2017-01-10 dsinclair Remove custom allocator from CFDE_TxtEdtBuf. 2017-01-10 tsepez Remove CFX_ArrayTemplate in cfx_psrender. BUG=678461 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2628783002 Cr-Commit-Position: refs/heads/master@{#442827}
-
grt authored
BUG=577816 Review-Url: https://codereview.chromium.org/2621713004 Cr-Commit-Position: refs/heads/master@{#442826}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/b554c05ac115a BUG=673754 TBR=tkent@chromium.org Review-Url: https://codereview.chromium.org/2627823002 . Cr-Commit-Position: refs/heads/master@{#442825}
-
luoe authored
TabbedLocations used to materialize tab contents on tabSelected. Now, they materialize only if the tab is selected while the TabbedPane is showing, or when the TabbedPane is being shown. BUG=none Review-Url: https://codereview.chromium.org/2617293002 Cr-Commit-Position: refs/heads/master@{#442824}
-
henryhsu authored
BUG=673210 TEST=open camera app and see the vid/pid is converted to lower case in log Review-Url: https://codereview.chromium.org/2621693003 Cr-Commit-Position: refs/heads/master@{#442823}
-
xiaofeng.zhang authored
Using switch is the best option here to get compile time verification, and we can catch it if WebServiceWorkerEventResult gains a new type later. Here also replace some if-return with DCHECK. BUG=None Review-Url: https://codereview.chromium.org/2606303002 Cr-Commit-Position: refs/heads/master@{#442822}
-
tbansal authored
Value of the EffectiveConnectionType enum is provided by the NetworkMetricsProvider. A new class EffectiveConnectionTypeObserver has been added which listens to the changes in the EffectiveConnectionType, and lives on the same thread as the NetworkQualityEstimator. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=677158 Review-Url: https://codereview.chromium.org/2605553002 Cr-Commit-Position: refs/heads/master@{#442821}
-
xiaochengh authored
This patch converts editing/pasteboard/5075944.html with assert_selection to promote the use of w3c testharness and improve code health. It is also a preparation for https://codereview.chromium.org/2626933002 BUG=679616, 679977 Review-Url: https://codereview.chromium.org/2621213002 Cr-Commit-Position: refs/heads/master@{#442820}
-
khmel authored
This fix regression compared M55 build. TEST=Manually, close LSO page and observe that Play Store checkbox in settings turns off. BUG=b/34199954 Review-Url: https://codereview.chromium.org/2625833002 Cr-Commit-Position: refs/heads/master@{#442819}
-
ericwilligers authored
We force a style recalc at the start, and wait for compositor at the end. BUG=248938 Review-Url: https://codereview.chromium.org/2619933002 Cr-Commit-Position: refs/heads/master@{#442818}
-
sky authored
And makes mash use RootWindowController directly. My next step is to fold WmRootWindowController back into RootWindowController. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2620913003 Cr-Commit-Position: refs/heads/master@{#442817}
-
varkha authored
Makes the thumb highlighted when the slider control is focused helping when controlling volume or brightness with a keyboard. BUG=658783 Review-Url: https://codereview.chromium.org/2619953002 Cr-Commit-Position: refs/heads/master@{#442816}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyFlexBasis from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIFlexBasis.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIFlexBasis.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIFlexBasis.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2613843002 Cr-Commit-Position: refs/heads/master@{#442815}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyFontSizeAdjust from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIFontSizeAdjust.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIFontSizeAdjust.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIFontSizeAdjust.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2617443005 Cr-Commit-Position: refs/heads/master@{#442814}
-
horo authored
Currently we use WebServiceWorkerResponse to pass the navigation preload response from ServiceWorkerContextClient::NavigationPreloadRequest to FetchEvent. But to show the network timing information in DevTool's network tab, we need the timing information in ResourceResponseInfo in blnik side. So this cl change the code to use WebURLResponse which contains the timing information. BUG=649558 Review-Url: https://codereview.chromium.org/2618313003 Cr-Commit-Position: refs/heads/master@{#442813}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyColumnGap from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIColumnGap.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIColumnGap.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIColumnGap.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2609933004 Cr-Commit-Position: refs/heads/master@{#442812}
-
sashab authored
Move LocalDomWindow unusedPreloadsTimer to TaskRunnerTimer, which associates it wuith the frame's timer task queue. BUG=624694 Review-Url: https://codereview.chromium.org/2625953002 Cr-Commit-Position: refs/heads/master@{#442811}
-
aazzam authored
A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyClip from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIClip.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIClip.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2614783003 Cr-Commit-Position: refs/heads/master@{#442810}
-
ericwilligers authored
We avoid timing dependence by rAF looping until the animation is in progress. BUG=248938 Review-Url: https://codereview.chromium.org/2621603002 Cr-Commit-Position: refs/heads/master@{#442809}
-
napper authored
Made -webkit-rtl-ordering property independent. Also updated independent-inheritance-fast-path.html to include webkitRtlOrdering. Tested using independent-inheritance-fast-path.html. BUG=628043 Review-Url: https://codereview.chromium.org/2626893002 Cr-Commit-Position: refs/heads/master@{#442808}
-