- 11 Oct, 2019 40 commits
-
-
Daniel Vogelheim authored
Bug: 959693 Change-Id: I15712d202d410dda6237f7fbc259d8bdb421be10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626857 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#705151}
-
Jimmy Gong authored
- CupsPrintersEntryManager contains both saved and nearby printers. - This new class handles the model manipulation of printers and calls on its listeners to let the views know when the models have been updated. - Adds CupsPrintersEntryListBehavior to observe the change events from CupsPrintersEntryManager. - Updated tests to reflect this change. Bug: 1009659 Test: End to end manual, browsertests Change-Id: I86f2a4d521de644a0fb4b5e3c01ef55e704642a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830292Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#705150}
-
Matt Jones authored
This patch allows users of the BottomSheetContent api to choose the height that their feature peeks at. Supplementing this change are a number of height modes that the new getPeekHeight can return; namely DEFAULT and DISABLED. These changes roll two existing methods into a single, generic one. All users of the api have been updated and tests have been added for the new functionality. Bug: 986310, 968246, 1012231, 1006029 Change-Id: Ia4b4c2c2839909c3c8f9da39b1b35283dd47eb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832603 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/106e86516480..9b33e3602340 git log 106e86516480..9b33e3602340 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-11 borenet@google.com [infra] Fix presubmit by pinning tools/build 2019-10-11 egdaniel@google.com Fix GL RGB format bytes per pixel. Created with: gclient setdep -r src/third_party/skia@9b33e3602340 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I8ee0d98e7ec38e5b36ce3abe342b930f3bd9f2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705148}
-
rbpotter authored
Initialize everything to available, so that we don't briefly expand more settings due to having <= 6 available settings between setting availability from document settings and setting availability from destination capabilities for PDFs. Bug: 1013045 Change-Id: Idbcaa78d433f314415425e6ebaf699122c6d7803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853824 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705147}
-
Raphael Kubo da Costa authored
Replace uses of content::ExecuteScriptAndExtractString() and variations with content::EvalJs(). The code looks smaller, simpler and easier to understand. Change-Id: I1ebac4f1084176d490487d548eec931021df5f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855979 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#705146}
-
Joe DeBlasio authored
This CL downgrades the security icon of pages when a Safety Tip is available for the page. The updated icon is the generic (i) NONE icon. It now looks like this, even on secure sites: https://drive.google.com/file/d/1J0oWA4yue1ydYTNT0R_bIj-cLm7LNUXV/view?usp=sharing This CL also moves the Safety Tip UI feature flag to security_state's feature set. This change was necessary to read the feature from within components. Bug: 1004849 Change-Id: I892b3d0c12d13e04bd486f33ed686b1f7398795a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848413 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705145}
-
Sebastien Marchand authored
This CL creates a new ChromeBrowserMainExtraParts derived class to own memory management related classes. This includes the new EnterpriseMemoryLimitPrefObserver, which tracks changes to the TotalResidentSetLimitMb enterprise policy and starts/stops the EnterpriseMemoryLimitEvaluator (which the PrefObserver owns) accordingly. Larger project documentation here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714# This also disable the memory::MemoryPressureMonitor as it's not being used (we're using base::util::MemoryPressureMonitor). Bug: 980965 Change-Id: Iae632b6681d1574006d38fee9b38bf4d6e5545af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790290Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#705144}
-
Scott Violet authored
BUG=none TEST=covered by various layout tests Change-Id: Ie0fb73cf53fd7d8fb2716738e53d41c16f3536ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851387 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705143}
-
Lei Zhang authored
PrintJobWorker::UpdatePrintSettings() is used for printing, but does not log any information in case of a crash. Add a ScopedPrinterInfo here to capture printer driver info for the duration of the call, so crashes in this code path can give more clues as to what is causing the crashes. Bug: 1013433 Change-Id: Ic6e1dab3cb40a70c408fb8a0a3c6d08601b24cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855298 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705142}
-
Avi Drissman authored
A parameter was added to the code signing configuration in https://crrev.com/c/1834843, but was not added to the notarization entry point. This correctly adds the parameter to avoid parameters ending up in the wrong positions. BUG=913074 Change-Id: I1ac340ea682e62c2f22607b3238bba714d7d8604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856560Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705141}
-
Joe Mason authored
I linked my @google.com and @chromium.org accounts and it made the @chromium.org account the primary in gerrit, which is the opposite of what I intended. Change-Id: I2899702c7235a63914908de6257f637340026a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852984Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705140}
-
Richard Knoll authored
Instead of showing the raw timestamp as a number, format it according to ISO8601. Example output: Show Trigger Timestamp: 2019-10-11T14:56:38.351Z This will always use UTC as timezone. Bug: 1004118 Change-Id: I1f6b3980915cf24dea2bc896400587aa4b55dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855969Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705139}
-
Tatiana Buldina authored
Update ExecuteClearElement() to check element type and state and throw kInvalidElementState if they are incorrect Bug: chromedriver:3005 Change-Id: I0ee8a35767113b1a9dc9bee29687290ae7325161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832664Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#705138}
-
John Chen authored
Disabling the following two failing perf tests on Android webview: * blink_perf.canvas/putImageData.html * blink_perf.canvas/putImageData_RAF.html?RAF NOTRY=true TBR=crouleau@chromium.org Bug: 1013618 Change-Id: I622829a643b8ec6ea477956abb28e06bf7912f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856559Reviewed-by:
-
Martin Robinson authored
View text fields need to emit text changed signals when kValueChanged accessibility events are received. We do this by following the hypertext generation path for these nodes. Bug: 1012423 Change-Id: I64684d380c1f3f72d1dd20c044e087c1c237e7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852244Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#705136}
-
Shakti Sahu authored
In the original UX, each day consisted of multiple sections based on mime types. The image section had menu button allowing us to select the entire group and perform share or delete. This adds complexity to mutator and should be cleaned up. Bug: 1013196 Change-Id: I71cf4d8e42784b8013bbda5c97fb90792ef38f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852405Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705135}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5952b718415..8f41e5d14063 git log f5952b718415..8f41e5d14063 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 treehugger-gerrit@google.com Merge "Fix conversion of 'print' events from the field" 2019-10-11 primiano@google.com Merge "CI: run install-build-deps also on bazel bot" Created with: gclient setdep -r src/third_party/perfetto@8f41e5d14063 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifd59f7837ccdf852465794401121ef4bcb2b6926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855475Reviewed-by:
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within miscellaneous Chrome feature tests, including Password Manager, payments, page load metrics, etc. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Ic4944308327312038d1e92523ac1188530f54b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850732Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705133}
-
Jan Wilken Dörrie authored
This change modifies the Touch To Fill trigger logic to respond to WebAutoFillClient's DidReceiveLeftMouseDownOrGestureTapInNode event. Furthermore, this change introduces a ShouldSuppressKeyboard method on PasswordAutofillAgent returning true iff Touch To Fill is currently shown. Bug: 1013131 Change-Id: Ic88d83594458b3a975cf1f7bea70e51f4a5e4bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856040Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#705132}
-
Hitoshi Yoshida authored
In general, IDL prohibits to use keywords as identifiers. But the spec defines some places; arguments, operation names, and attribute names. This CL makes our IDL parser to be more consistent with current spec, and also updates few IDL files that can be consistent with their specs with this change. Bug: 839389 Change-Id: I60802ae211c3dffd4e9f3a76ad5dd2a3910791a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855623Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#705131}
-
Shakti Sahu authored
This CL adds : 1 - Security icon and URL for the preview page 2 - Updates title of the page when navigated to another page Bug: 1007499 Change-Id: I069e57e545907b2000eaebe996392d72da40d6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844341Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
-
Michael Thiessen authored
This CL does three things: 1. It moves unrelated logic out of launchWebApkIfSoleIntentHandler() 2. It unifies the browser fallback URL handling path. 3. It avoids unnecessarily calling isValidWebApk on a lot of packages There is a functional change here: we no longer require an intent URL to specify a package for its fallback URL to be handled by a WebApk. (The package could have been any package, even unrelated to the WebApk) Bug: 1006927 Change-Id: I1dd4bf26e40706a37900377e280623aa5ae129fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837478Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#705129}
-
Joe DeBlasio authored
This CL prevents Chrome from evaluating client- or server-side safety tip heuristics if the URL is present on the component-updater-provided allowlist. Bug: 1009518 Change-Id: Ieb8e88b7d4b1aa88caf68492b8ff1ce4eb6d9fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849133Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#705128}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/88c57b498266..af9c6ce85491 git log 88c57b498266..af9c6ce85491 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 vapier@chromium.org run_tests: clear python compiled caches Created with: gclient setdep -r src/third_party/chromite@af9c6ce85491 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iaa5e11086227696e3a7379bbe7373a7af74579f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855473Reviewed-by:
-
Thomas Tangl authored
... and wait for SyncTransportActive during the setup. Bug: 995720, 1012167 Change-Id: Ib0523c68738f226a29171fabc64264cf36c03f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856061 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705126}
-
Yi Gu authored
When a remote frame has an local ancestor with pointer-events: none, the frame and all its descendants should be excluded in hit testing. See https://docs.google.com/document/d/1xN1bRigzahOgUM4cEuyHGhe069TRc5-0rXz1JZsgCP8/edit?usp=sharing Bug: 1002245 Change-Id: I9e2f86b1d1e6727a66499639994d269d301f1a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836954Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705125}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e57b4bc55c0..e3703bb8b8af git log 8e57b4bc55c0..e3703bb8b8af --date=short --no-merges --format='%ad %ae %s' 2019-10-11 tandrii@chromium.org Release newest bb tool. Created with: gclient setdep -r src/third_party/depot_tools@e3703bb8b8af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1004140 Change-Id: Iacfa4e7d4df76e52271c441442643bf0680d1db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855472Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/51bf20029462..5740f3e2b8fd git log 51bf20029462..5740f3e2b8fd --date=short --no-merges --format='%ad %ae %s' 2019-10-11 danilchap@webrtc.org Clarify expectation on GlobalLock 2019-10-11 gustaf@webrtc.org Fix bypass of unnecessary resampling Created with: gclient setdep -r src/third_party/webrtc@5740f3e2b8fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/130016532 Change-Id: Ide7481d7dc71f8be9efe552a36d4d825b052f8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855471Reviewed-by:
-
Dave Tapuska authored
When this code was changed to not use the RevocableInterfacePtr it was assumed that the calls into the mojo bindings only occurred while the object's associated context was still alive. It is possible to have a reference to a cache storage object from a frame that has been destroyed and make calls to it. In this case the RevocableInterfacePtr previously dropped them because the calls would fail. Now we will return a promise that is rejected. BUG=1012781,1012358 Change-Id: I9504af8245be13137db82e39e3dc5a702c89e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854184 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#705122}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert some uses of base::Bind/base::Callback (this is a multipart change) in components/prefs and services/prefs to the recommended methods/types. Bug: 1007719, 1007831 Change-Id: Ib83da5603c9888c2704de80b4d40ea27fdcc3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844998 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#705121}
-
Aaron Colwell authored
This fixes WebView crashes introduced by http://crrev.com/c/1837093 . This change introduces an exception for the origin consistency check because WebView doesn't generate opaque origins for data: URLs. This is a temporary workaround to avoid crashing while we figure out how to make data: origin behavior more consistent with other platforms. Bug: 1013171, 991607 Change-Id: I304fef3d5eda5bd0d31495e62e4292641392575f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852421 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705120}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/04988676..ddd5171b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93cfb1eb9c15337945d887d07bee02eefdea2959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855663Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705119}
-
Andrew Grieve authored
And add step for ErrorProne. Change-Id: Ic6054026e5c8d7b47a0f212499076b8f8d5ff8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855470Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#705118}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ae022faf53b9..1c462ebc904c git log ae022faf53b9..1c462ebc904c --date=short --no-merges --format='%ad %ae %s' 2019-10-11 sugoi@google.com Stencil buffer texture sampling Created with: gclient setdep -r src/third_party/swiftshader@1c462ebc904c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142385547 Change-Id: I57e70d89ac9abdfad47046120bde8b4c98ee3e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855469Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df640e6d14a5..106e86516480 git log df640e6d14a5..106e86516480 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d9c4ee328bc..67486ec24551 (18 commits) Created with: gclient setdep -r src/third_party/skia@106e86516480 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: If6dbe676f8a573b7a4c32552e966980460dde145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855468Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in components/zoom to the recommended methods/types. Bug: 1007758 Change-Id: I00b967cd051ff169824c9438e4d4a218482230d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832271 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#705115}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7dbbaa34. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1cca5fe80c476e62cd6fca3d425a3fd3df0ac605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855662Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705114}
-
Adam Rice authored
Add a comment to note that creating a WritableStream with a high_water_mark of 0 will result in piping not working. Change-Id: Iacf6769fa017b56f192789b02fb1ce13df4e4986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852347Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#705113}
-
Albert Chaulk authored
An exo surface is collapsed into a single CompositorFrame during presentation; if there is an aura window displaying webcontents it will be rendered on top of all exo content due to the actual viz layer structure This replaces the contents of an exo layer with the web contents by emitting a SurfaceDrawQuad instead, drawing the web contents in the correct position As a consequence the aura window corresponding to the web contents is hidden as we do not want it drawn in the usual aura manner Bug: b/141980352 Test: desktop build w/ webview Change-Id: If45aa68e80f115f36ef0edee34f03c09f06dfcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850366Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#705112}
-
