- 14 May, 2019 40 commits
-
-
Dan Beam authored
R=kristipark@chromium.org BUG=957353 Change-Id: I8eae1cad80062ff3ee97f8eef2bfad774058f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609588 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659335}
-
Vlad Tsyrklevich authored
Refactor the CrashAnalyzerTests to use CrashAnalyzer::GetExceptionInfo() instead of AnalyzeCrashedAllocator()--this is in anticipation of an upcoming refactor. There is no functional change, but it does have the benefit of having these tests use the public interface instead of a private internal method. Bug: 960532 Change-Id: I19cf964e15f08c0b6444103087acb050b63da228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611201 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659334}
-
Marcin Wiącek authored
BUG=948866 Change-Id: I5606e5c7195b4ed59f0a943ae5f73d53f7d1c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610761Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#659333}
-
Sergey Ulanov authored
Now DefaultEnableGpuRasterization is enabled by default on Fuchsia. It doesn't have any effect yet, until we enable Vulkan and OOP-R. Bug: 962617 Change-Id: Ieebc9ba8976e66123a26d76980924cb1ec86f843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610220Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659332}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbffd54f..147d8dd0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7fda9d851ecc2ec902d4658d5b615f9c4bc464ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611117Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659331}
-
Timothy Loh authored
This CL adds unit tests for PluginVmManager::LaunchPluginVM, checking that it calls the expected DBus functions and requires Plugin VM to be allowed. Bug: 904853 Test: unit_tests --gtest_filter="PluginVmManagerTest.*" Change-Id: Iea991c6a84679c8756c8a0ca31862ef50a033cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608967 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#659330}
-
John Lee authored
Change-Id: Ib8eb0e84d208642e366640f0fc00f0d53b95e127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610879 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#659329}
-
Nicolas Ouellet-Payeur authored
This is a reland of 9d58d481 It also fixes an issue with crash reports not being uploaded by Chrome with the original patch. Bug: 960710 Original change's description: > [Headless] Split browser/renderer process dependencies > > This CL splits //headless:headless into 2 components: > - :headless_renderer > - :headless_non_renderer > > :headless_renderer is intended for child processes, and has a smaller > footprint than :headless_non_renderer. > > For release builds, this reduces the size of chrome_child.dll by about > 9.7MB. > > Bug: 929408 > Change-Id: I514a1bb5604f8ab8d6c6031970b5c7a965a8393d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570654 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656433} Bug: 929408 Change-Id: I2464ce7a380cc8765b3515cf8e1754d06a7cb65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606224 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#659328}
-
Suman Kancherla authored
This change displays a tab modal dialog seeking the user's consent before proceeding with an XRSession creation when a website calls requestSession. If the user allows, execution continues as before but if they don't, the promise is rejected. Bug: 958033 Change-Id: I198f91d8dd6a9c1a48c69501e264ab897f0b1322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603205 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#659327}
-
Min Chen authored
Bug: 937907 Change-Id: I2cd5baccd1f5acef58b051937447794eb49b7338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607183 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#659326}
-
Caleb Rouleau authored
This makes it easier to add or remove benchmarks as needed. Bug: 961830 Change-Id: I53501cf3fb249b0e8e4485292b3026dd743f77d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610750 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659325}
-
Hui Yingst authored
Changed the parameter type for ProfileManager::AddProfile() from raw pointer to std::unique_ptr. Also changed return value type for Profile::CreateProfile() from raw pointer to std::unique_ptr. BUG=959492 Change-Id: I64909b8f672aef78ef095d03aefda51337dcea4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598177Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/114240247a61..95764ff31ecd git log 114240247a61..95764ff31ecd --date=short --no-merges --format='%ad %ae %s' 2019-05-13 rmhasan@google.com [Typ] Use the same pool for all enabled tests and their retries Created with: gclient setdep -r src/third_party/catapult@95764ff31ecd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Change-Id: I75453da99025230d11a3c16532b145301c30ecc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659323}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0a1eeb80641a..7d7985589b8f git log 0a1eeb80641a..7d7985589b8f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 shrekshao@google.com Skip validating draw buffers when RASTERIZER_DISCARD is enabled. Created with: gclient setdep -r src/third_party/angle@7d7985589b8f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962555,chromium:962636 TBR=syoussefi@google.com Change-Id: I7acedd7db695f360ff5ce4970b41ac140ba79097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610781Reviewed-by:
-
Julian Watson authored
Bug: 932339 Change-Id: I609be5c7589b1171bd6016f758f1f2acfa0cd04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609004 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#659321}
-
Yue Zhang authored
This change enables dragging to reorganize tabs in grid tab switcher with groups. It is now behind the flag TabGroupsAndroidUiImprovements. Bug: 961433 Change-Id: I1c5b873984574a4e860baea7145c514f8fe7c610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604499 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659320}
-
rbpotter authored
Update PDF viewer zoom buttons in the new Print Preview to have background-color google-grey-600 and icon color white, per UX feedback. No changes requested for dark mode, so there should be no change to the buttons' appearance in dark mode. Bug: none Change-Id: I3df248338283f53ca307dd2e9997b5533019e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610309Reviewed-by:
-
Tsuyoshi Horo authored
This CL introduces PrefetchedSignedExchangeInfo struct, which keeps the information about a prefetched signed exchange. It is created in PrefetchedSignedExchangeCache and passed to SubresourceLoaderParams and will be passed to the renderer process in CommitNavigation IPC's CommitNavigationParams. Bug: 935267 Change-Id: Id67c2ce99801f6c89d679cf9efaf65617d68cdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600438Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659318}
-
Rakib M. Hasan authored
Bug: chromium:937516 Change-Id: Id7055ac6221a94caa3af8928cfa0478eccfb4abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610482Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#659317}
-
Donn Denman authored
This CL sets expires_after="never" for the metrics used in the Contextual Search dashboard (at go/cs-metrics-dashboard) and adds a comment to that effect in each entry. Also sets expiry for a key UMA metric needed for chronav calculation to M-80. BUG=953453, 621669 Change-Id: I1d3a5bba857c275a69b911f283c8182fa47cb2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604314Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#659316}
-
Matthew Wang authored
Shill's portal state is being split into three new states: - kStateNoConnectivity: no internet connectivity - kStateRedirectFound: shill is behind a portal and was able to find a redirect URL - kStatePortalSuspected: shill suspects that it is behind a portal but wasn't able to find a redirect URL Since these states are communicated to Chrome via D-Bus, we need to update Chrome to recognize and handle these new states. Bug: 946866 Change-Id: Ifc933be0368aafb46d8d07d707489c70e3e924d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586474 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659315}
-
Chris Palmer authored
ajwong pointed out that `PartitionRootBase::max_allocation` was used only in tests. This CL additionally `DCHECK`s that it is not being mis-used in the most simple ways. In the future, we might be able to change the API such that `SizeSpecificPartitionAllocator` 'knows' its allocation size and just allocates it, without needing a `size` parameter. This CL also does some code cleanup. This involved making sure we always observe `PartitionAllocReturnNull` in every case where `MEMORY_TOOL_REPLACES_ALLOCATOR` is defined; previously we did not. Bug: None Change-Id: I04aa797176851e15ef3a0b803b85ddd038e0f772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607149Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659314}
-
Aidan Wolter authored
Do not filter ethernet interfaces if --require-wlan=false. Previously, no matter the value, we ignored ethernet interfaces. Bug: b/132300724 Test: Set --require-wlan=false, observe connected Change-Id: Ia00fa0da562fb3abb7a80be4688e87dbdab23dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610654Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#659313}
-
Toni Barzic authored
Added test for enabling and disabling virtual keyboard and docked magnifier accessibility features. BUG=953020 Change-Id: I380baa5ee34bdb3b006751d13e0566470b2f5dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607132Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659312}
-
Michael Spang authored
Add a new FYI bot for Fuchsia that builds with angle_top_of_tree. Bug: angleproject:3146 Change-Id: I993faf11739c6074c60b8dc7613489110fb15d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610748Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/417f2332fcf4..06f5b2262451 git log 417f2332fcf4..06f5b2262451 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@06f5b2262451 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I94465acd5d47f66f3e572b63be905a9eb4744aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610782Reviewed-by:
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 Change-Id: I1b7b49fb04a62566295620e172e7d51078d6375f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598897Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#659309}
-
Simon Que authored
These builders have been updated to use the RBE Prod cluster. Bug: 947436 Change-Id: I72294b236a65e29c97d56f7eaf95fd3443c7b747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608964Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#659308}
-
Aaron Colwell authored
- Move the majority of set_process_reuse_policy() usage into creation functions since most calls are made almost immediately after a Create call. - Created SiteInstanceImpl::CreateReusableInstanceForTesting() to explicitly mark instances where tests are creating SiteInstances that they expect to be able to reuse a process AND are expecting to not ever receive a default SiteInstance. This method will make it easier to avoid breaking tests when SiteInstanceImpll::CreateForURL() is updated to allow the default SiteInstance to be returned. - Minor changes to make sure set_process_reuse_policy() is never called on the default SiteInstance. Bug: 958060 Change-Id: I3e6a2dc9eb1f3f2abaccc690b2d8b1edd7e2b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603413Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#659307}
-
François Degros authored
Bug: 778674 Change-Id: I763c20ebc74902c2a3e633f63a804bebda5490ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610260 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#659306}
-
Sam Goto authored
Explainer: https://github.com/sso-google/sms-otp-retrieval Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Drmmb_t4eE8 Design Doc: https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit WICG Thread: https://discourse.wicg.io/t/sms-otp-retrieval/3499 Bug: 670299 Change-Id: I990c32cf248200277e50ffb127d9828a62ef3a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590392Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659305}
-
Vladislav Kaznacheev authored
While menu is being shown, it is preventing Chrome from exiting. However, if a menu is opening while Chrome is already shutting down, this currently causes a CHECK failure (see linked bug). The CL is adding shutdown detection logic to ChromeViewsDelegate and avoids showing a menu if a shutdown is detected. Note that no callbacks (such as OnMenuClosed) are called. Bug: 960925 Test: none Change-Id: Ie282f353b94a5c79a29ba5f770808d552d8e2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601419 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/628604eefdb9..65b1e97d13eb git log 628604eefdb9..65b1e97d13eb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Only perform attachment load/store ops for used attachments Created with: gclient setdep -r src/third_party/swiftshader@65b1e97d13eb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ic492f9c3f2dcf402cba9c7d351a8f8eab75fb32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610778Reviewed-by:
-
Jinsuk Kim authored
Uses image src url if alt text is missing. This is how image opened in a new tab works. Bug: 960130 Change-Id: Id592a091c445486f8ee81e4d7090366f5719301c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605380Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659302}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2d0ebdef207..8f877b2e3820 git log b2d0ebdef207..8f877b2e3820 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 tsepez@chromium.org Replace CountedFaceCache with RetainPtr<CFX_FaceCache> 2019-05-13 tsepez@chromium.org Rename CXFA_Node::RemoveChild() to RemoveChildAndNotify() 2019-05-13 tsepez@chromium.org Add more helper methods to tree_node.h Created with: gclient setdep -r src/third_party/pdfium@8f877b2e3820 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I49b6e97604e451bff16fa78806332f3f6cf78d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610783Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I7868559255a04fdf354fdd843c91ea0779a33072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603214Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Darwin Huang authored
Ref: https://abseil.io/tips/131 https: //stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11?lq=1 Change-Id: I10dffd5bd13d6f619e4f758ec154947bbef86d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607185 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Separate the "More Info / Remove..." context menu entry for Suggestion Transparency into two context menu entries: - Why this suggestion - Remove suggestion This was vetted by our UX folks, and so we are also committing these strings to our translated strings. The implementation of the "Why this suggestion" info bubble will be in a separate CL. Bug: 929477 Change-Id: Ia406107bf9f6b50354f2b8f9ccf6b472571d799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610846 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659298}
-
Matthew Braithwaite authored
Change-Id: I78d857a03de71c27988793e50b143dd8f4523c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603403 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659297}
-
Vlad Tsyrklevich authored
Linux crashpad support is now sufficiently enabled to allow running the GWP-ASan crash handler unit tests under Linux. (The client tests are still blocked on allocator shim updates.) Change-Id: I409cebaa9cdaed5da546266d0af470d2b25a09ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610605 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
