- 07 Mar, 2019 40 commits
-
-
Livvie Lin authored
Since the override summary is used in some cases even when a form was not edited, i.e. kMarkHttpAsParameterDangerous, a different name would be more descriptive. Also add checks in the browser test that this summary is present. Change-Id: I294c68b0e57d2a87b501960185b7c91b2a3e0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507319Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638671}
-
Sky Malice authored
Bug: 924739 Change-Id: I40f649645349d7671b76bd9f480ff4207b89c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487709 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638670}
-
bsheedy authored
Fixes JavaScript run in iframes during VR instrumentation tests not being run on the UI thread, which was hitting a recently added DCHECK. TBR=billorr@chromium.org Bug: 939410 Change-Id: I5d3eba0e8075306cff0182c7d10c4c81204afc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508582Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638669}
-
Jarryd authored
This change will remove UMA logging and related logic for expired origin count metrics that live in QuotaManager. Change-Id: I117d93b23a140e6e59aac0fe3f2adef3cd078f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506562Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638668}
-
Min Qin authored
Android currently doesn't report crash stack when renderer hangs. This CL will ask the renderer process to dump the stack to crash report page, without crashing it. Maybe i can do this for OOP network process alone for the crbug, but I think in general, we should have the stack for non-responding renderers. BUG=934317 Change-Id: I5d039c3c6d026e4b608a4f39da4b71933b19c566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498415Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638667}
-
bsheedy authored
Makes VrBrowserNavigationTest#testNavigationButtons cover more of the manual test requirements. Specifically, ensures that the buttons are properly greyed out when they're disabled and that clicking on the back button can't cause the browser to go to a different tab. Bug: 887510 Change-Id: Ie4a09c2286d58f6a7a9d0539995bc226132213a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497471Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638666}
-
Robert Liao authored
This reverts commit 33fbc186. Reason for revert: Suspected in a bunch of proto crashes here: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11240 Original change's description: > Create golden file loader for the time limit consistency tests. > > Bug: 935711 > Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: G. Silva <gfaus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638569} TBR=pkasting@chromium.org,michaelpg@chromium.org,hgrandinetti@chromium.org,gfaus@chromium.org Change-Id: If5471f6687bac6a7fcbaa62f6e67bf4abb93b5ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508583Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638665}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffb1ffb82284..db5c5ade84ad git log ffb1ffb82284..db5c5ade84ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 ehmaldonado@chromium.org gclient: Fetch refs/{branch-heads,tags}/* if needed. Created with: gclient setdep -r src/third_party/depot_tools@db5c5ade84ad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938160 TBR=agable@chromium.org Change-Id: Icbdd5562aeb5408f3e67d0f9bcc0a221b4b12131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638664}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7eb7a82223577ece936bed46e2c515377ff05a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509233Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638663}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames some variables. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this prevents is: third_party/blink/renderer/core/fileapi/file_reader_loader.cc:358:16: error: declaration shadows a local variable [-Werror,-Wshadow] MojoResult result = consumer_handle_->BeginReadData( ^ third_party/blink/renderer/core/fileapi/file_reader_loader.cc:346:54: note: previous declaration is here void FileReaderLoader::OnDataPipeReadable(MojoResult result) { ^ third_party/blink/renderer/core/aom/accessible_node.cc:288:16: error: declaration shadows a local variable [-Werror,-Wshadow] Element* element = accessible_node->element(); ^ third_party/blink/renderer/core/aom/accessible_node.cc:278:43: note: previous declaration is here bool AccessibleNode::GetProperty(Element* element, ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:43:16: error: declaration shadows a local variable [-Werror,-Wshadow] for (Node& node : FlatTreeTraversal::AncestorsOf(node)) { ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:40:14: note: previous declaration is here for (Node& node : range.Nodes()) { ^ third_party/blink/renderer/core/loader/frame_loader.cc:892:10: error: declaration shadows a local variable [-Werror,-Wshadow] auto request = mojo::MakeRequest(&navigation_initiator); ^ third_party/blink/renderer/core/loader/frame_loader.cc:798:20: note: previous declaration is here FrameLoadRequest request(passed_request); ^ third_party/blink/renderer/core/script/modulator.cc:52:20: error: declaration shadows a local variable [-Werror,-Wshadow] } else if (auto* scope = DynamicTo<WorkerGlobalScope>(execution_context)) { ^ third_party/blink/renderer/core/script/modulator.cc:45:20: note: previous declaration is here } else if (auto* scope = DynamicTo<WorkletGlobalScope>(execution_context)) { ^ Bug: 923510 Change-Id: I82659c403eb15b4f676d24b97414bfbbced9d701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508517 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#638662}
-
Leonard Grey authored
Bug: 939251 Change-Id: Ifbb8384ce97adaf68a32264aa575883886114e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508573 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638661}
-
Eric Stevenson authored
The monochrome_public_apk__merge_manifests produced the expectations file and takes a fraction of the time to build. Also added a note about making sure your branch is updated. Change-Id: I3abea3a082ec348c79e92c60c43515829e5dc320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509014 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638660}
-
Vlad Tsyrklevich authored
The slots_ member was always misnamed, as it is really an array of metadata _about_ slots, not the slots (pages) themselves. The slot_metadata member variable would be clearer as 'metadata_addr' to denote that it's an address. These renames are in anticipation of an upcoming change that will make slots/metadata more distinct (no 1:1 mapping.) Bug: 939142 Change-Id: I58e5f8035ea571fe7c0b0a4fb6bb0114580984e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507217 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a6918d7b72a9..2f722bfc7ccb git log a6918d7b72a9..2f722bfc7ccb --date=short --no-merges --format='%ad %ae %s' 2019-03-07 pprabhu@chromium.org config: Migrate 4 paladins to Skylab Created with: gclient setdep -r src/third_party/chromite@2f722bfc7ccb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0ad5dd0c03e23a65889a32e5b056ed6a73f950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509032Reviewed-by:
-
chrome://managementYann Dago authored
When clicking on the 'Managed by your organization' message in the settings page and menu, open chrome://management if the "link-management-page" flag is set to true. Bug: 938991 Change-Id: If2f14a3818a00fc4dd82c46d704d0452415c6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506497Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638657}
-
David Roger authored
This was causing a crash on startup if an account was removed from the device while Chrome was not running. Bug: 936953 Change-Id: I45662ace9c498b6db8b719251e8f7f461dc5531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505447Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#638656}
-
Patrick Noland authored
Bug: 939015 Change-Id: If4fbd01fd671b67114dc9f37055f845c4fdc2a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506654 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Auto-Submit: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#638655}
-
Michael Crouse authored
created a Top Site Provider for querying SiteEngagementService Implemented a feature flag controlled by IsOnePlatformHintsEnabled() for enabling OnePlatform API and requests. Implemented the Top Site Provider inference and implementation for querying the Site Engagement Service to provide the list of top hosts for the OnePlatform to perform the Hints Request to the Cacao server. Updated the unittests for Previews Optimization Guide and Previews Decider Impl to include the TopSiteProvider being passed. Wrote a PreviewsOnePlatformHintBrowserTest for confirming the feature flag and code path is executed safely. Bug: 932707 Change-Id: I2d1a048a86e8c8b33c98c07312cc77bafa9b52dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478362 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#638654}
-
Tim Volodine authored
Add some flaky tests that are failing on android_mojo and android_mojo_rel bots. Because we use android_mojo bot for CQ these tests currently block patches that are trying to land. BUG=936757,939355,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I21052efd28af0f8b693e53df59705db15496e6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508461Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I29bba4682051ec93ff2bb75547a3e7de213f25c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508913Reviewed-by:
-
Aran Gilman authored
The test was originally disabled due to https://crbug.com/101984. The flakiness occurred for Vista builds only, and the bug has not had a significant update since 2012. Bug: 101984 Change-Id: Ifadf55ae2d867e816db2795c9a7eaed0377cc276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497128 Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#638651}
-
David Benjamin authored
The go/ link doesn't have an 's' at the end. Change-Id: Iae22758ebcc448ac8b86c02c735ba9f5a4ca5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506761 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#638650}
-
Nicolás Peña Moreno authored
Currently we need to notify ImageElementTiming whenever an element will be destroyed, so that it can be removed from the HashSet of images that have been seen by ImageElementTiming. This CL adds unittests for this behavior. Bug: 879270 Change-Id: I7719b9c2bfc594cbf4070b1fe66c9e5325a3a552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506660Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638649}
-
Katie D authored
ScopedTaskEnvironment::NextScheduledRunTime was returning Now() (aka now_ticks_) because sequence_manager is idle, but then ScopedTaskEnvironment::MaybeFastForwardToNextTask DCHECKS that now_ticks_ is strictly < run_time, which was causing test failures. Now that ScopedTaskEnviornment is fixed we can re-enable these tests. Bug: 935651 Change-Id: I5a0cb2967001995a54f2245bac4e5f9022514001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500018Reviewed-by:
-
Bo Liu authored
We use View.getGlobalVisibleRect, and the transform and viewport from functor to compute info for the viewport: * the tile memory budget, which ideally is computed from the size of the visible portion of webview * the viewport and transform used to raster the right tiles at the right scale We usually use getGlobalVisibleRect and transform from functor together if is_layer is false, making the assumption that they both transform between the window space and view space. This turns out not to be true. Instead, use getGlobalVisibleRect to compute the tile budget. And always use the viewport and transform from functor together for tile raster, since they are guaranteed to work together. Change-Id: I4d1346501dab14dbb7b7ca160e0c88fee64aa3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506759 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638647}
-
Robert Ogden authored
This CL adds TCP and HTTP timing UMA on every successful request to the client config service. This UMA will be used server side to compare with other metrics for evaluating network quality. Bug: 939121 Change-Id: I84d7867d03f16a57e4131e0043fbc922d50ff187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506442Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d4d2a3cf7b9..356474278798 git log 2d4d2a3cf7b9..356474278798 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Improve error message if perfetto invocation fails. 2019-03-07 fmayer@google.com Read from socket to prevent clear notification to service. Created with: gclient setdep -r src/third_party/perfetto@356474278798 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I496e166cba1724b1d47675e842f891db54d5cb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508914Reviewed-by:
-
Emircan Uysaler authored
VDA implementations require config.container_color_space and config.target_color_space information to be set to provide correct output. For WebRTC frames that carry this information for VP9.2, we can reinitialize VDA with this info for the correct colors. Bug: 939387 Change-Id: Ib2ef4c7fdfbeef5e6f25a887e32a5c9c4c2e170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476065 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#638644}
-
Etienne Pierre-doray authored
SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost is flaky on all platorms. TBR=boliu@chromium.org Bug: 939338 Change-Id: I21f13d8651b52647f61a0bb8f92d943ff96e7def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508894Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#638643}
-
Elly Fong-Jones authored
Bug: 859172 Change-Id: I94d6400a9b0ef983ace670c3adfad68b71c75819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506752 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638642}
-
Shivani Sharma authored
If a navigation entry was marked as skippable because it added an entry using pushState, then a user gesture on the page should reset the skippable bit. If the pushState was done after the user gesture, then the entry would not have been marked as skippable to begin with. This change will make the behavior independent of the ordering between user gesture and pushState. content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureResetSameDocumentEntriesSkipFlag content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureDoNotResetDifferentDocumentEntrySkipFlag Test: Bug: 937423 Change-Id: Ie1e55815163ca84950ed7e04fbfa55c06f86c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499834 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638641}
-
Dan Harrington authored
This adds the original_url to the information returned when a page is removed from the offline page model. See bug for motivation. Bug: 884291 Change-Id: I25d11e58347379e06c4a0de8a1cb5b1830cdf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473830 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#638640}
-
sangseok.jang authored
ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT is no longer in use, because BookmarkBarInstructionView is removed. However, it still remains, so it is cleaned up. Bug: NONE Change-Id: I7ce14646fafaf07fc426aa96d1b4dab073b51ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506679Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#638639}
-
Kyle Milka authored
This reverts commit ed15ce53. Previous change prevented promos and search suggestions from appearing properly. Required manual resolution for merge conflicts. Bug: 770640 Change-Id: I37add613a23567d57912623c02441cdb68d261e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507249 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638638}
-
Eugene But authored
Before this CL, GetPendingItemIndex() used to return last committed item index for the new navigations (none-reload, none-back-forward). Presumably this was done before CRWSessionController implemented pendingItemIndex support, when CRWSessionController immediately changed committed item during back-forward navigations. pendingItemIndex support design doc: https://docs.google.com/document/d/1GvsaoNtMO7d87FzoysOW5GqH6XErI5g2cinKhkPk7bQ/edit This CL returns -1 for new navigations, which matches //content. There are 3 places where GetPendingItemIndex is used outside of ios/web: - IOSLiveTab::GetPendingEntryIndex (new implementation matches content, which is the right approach) - GetPossiblyPendingItemAtIndex (new implementation should have no effect because index should be in [0;size] bounds, but this is just an assumption and it's actually unclear if GetPossiblyPendingItemAtIndex relied on undocumented and incorrect behavior). - ReadingListWebStateObserver::LoadOfflineReadingListEntry (new implementation should make the whole block of code obsolete, but it should be fine to leave it as it is because ReadingListWebStateObserver is going to be removed soon). Bug: 665189, 899827 Change-Id: I9538b693c924790620140b37d6c4fea6cce26fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504231 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638637}
-
Christopher Cameron authored
Bug: 906453 Change-Id: Ice07136126ce35d128054276e86ac641aba2c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507235Reviewed-by:
enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#638636}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I37c84f9367743b3d2f758eaf9bf0d1094b65aad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507201Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638635}
-
Anne Lim authored
Gets a new parameter (supported_card_bin_ranges) from the GetDetailsForSaveCardResponse proto, which contains a list of pair of numbers representing ranges of supported card bins. If a card doesn't fall under any of the ranges, the card won't be offered upload save and will be saved locally instead. Change-Id: I17a8742f0d20788131ffb2af29d8a6bcb21c09f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496251Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Bug: 766077 Change-Id: Ie52fc2eea6e96580bb064ac3b9c877a0ef96ff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508466Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#638633}
-
Matt Menke authored
ConnectJobs no longer care about group names, so having them store the name is a bit of a layering violation. ConnectJob group names were used for a NetLog event and by the socket pools to locate the group a ConnectJob belonged to. To resolve the first issue, group names are now logged by a NetLog event by the socket pools before starting each ConnectJob (which will require an update in the net log viewer code). To resolve the second issue, Groups are now ConnectJob::Delegates for all the ConnectJobs associated with the group. Beyond fixing the layering violation, this CL serves two purposes: It will make it easier to change group_name from a string to a struct, and it will make it easier to make CommonConnectJobParameters a per-pool object. Bug: 927100, 533571 Change-Id: Ife570e1277ef18b4d916eb6d3ab91a9fccf2bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506567Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638632}
-
