- 05 Sep, 2019 40 commits
-
-
Andrei Chulkov authored
This CL sets the final version the title, explanation and button strings for the password manager onboarding dialog. Bug: 983445 Change-Id: Ibc265894f04877be5f89676e295fa7a7d6c37cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781638Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#693791}
-
Andrei Chulkov authored
This CL makes the password manager hide the save password infobar before showing any of the leak detection dialogs. The update password infobar is not affected by this. Bug: 1001052 Change-Id: Ic07e5fb9eb5ae081e2bc3c02de4df8971cbd105b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782900Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#693790}
-
Pavol Marko authored
If certificates have been specified in ONC policy to be used by a sign-in screen extension, PolicyCertService now uses them. The mapping between extension id (from policy) and StoragePartition is performed in PolicyCertService (see comments in PolicyCertService::GetPolicyCertificatesForStoragePartition). Extension-specific certificates are only allowed if: (*) The extension has isolated storage, i.e. it has its own StoragePartition and (*) The Profile is using CertVerifierBuiltin (which is unconditionally true for the sign-in screen Profile since CL:1750004). A browsertest has been added to ensure that the other StoragePartitions in the sign-in screen Profile do not respect the additional extension-specific certificate. Bug: 939344 Test: browser_tests --gtest_filter=*PolicyProvidedCertsForSigninExtensionTest* Change-Id: If29413049a46ee4f742718253dbbbc7ecdc31ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702425 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693789}
-
Morten Stenshorne authored
The break-before value should only be propagated if we're not at a valid class A breakpoint. This is only the case at the first in-flow child. Propagating it in other situations could cause spurious forced breaks in the ancestry, as the new test would demonstrate. The actual fix here is to simply check that we're at the first child, but I rearranged the code a little while I was at it, to keep the block fragmentation code more closely together. We'll also no longer update the has_processed_first_child_ member unless we're block-fragmenting. Change-Id: I831e162adae0d4b56231c118274ba1083da1fc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787320Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#693788}
-
Matt Menke authored
Internal requests should not end up in file URLs, and Safari handles other requests, so we shouldn't need it. FileProtocoloHandler is no longer in use on other platforms, so we should be able to delete it. Bug: 934009 Change-Id: I00749a080b8bcda2a3ff4655a40ce9835e42e608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783911Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693787}
-
Danan S authored
Bug: 1000743 Change-Id: I9bc22f6b73c48302415c2a8899e83cf1905372aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784009Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693786}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/base/test. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 891670 Change-Id: I9cd9d893ec5a68f3f25fbab9c8e361de6e8c61bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786825 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693785}
-
Danan S authored
We suppress the dialog in this instance because after an account has been supervised because the user must sign out completely. Bug: 1000904 Change-Id: I2df6f3b03d14516af8d81bdd3580eb5a498496c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786917Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693784}
-
Felicia Lim authored
- Patch https://git.xiph.org/?p=opus.git;a=commit;h=cd529ed - Undo change from https://chromium-review.googlesource.com/c/chromium/src/+/1746617, which truncated the buffer too early Bug: 986727 Change-Id: Iefb890ff828d8703a24bd61ec1411c8476b03a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785648Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#693783}
-
Robbie Gibson authored
Somehow, I had forgotten to set the color correctly for dark mode. Bug: 1001062 Change-Id: I9d61043234b5b88439afdff43067cf6eedc23f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786444 Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#693782}
-
Danan S authored
This ensures that the user will not be able to log back in to the device without going through the initial login screen again. We don't want the user to be able to temporarily log in under the expired tokens if the device hasn't yet received the signal indicating token revocation from the server. Bug: 1000948 Change-Id: Ib373dd0548c9bbe58f6c3cb05766f7c40d97f6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786857Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This is a reland of 67e6ba1c The original change was authored by yoichio@chromium.org. This CL adds an initialization code of WebSocketFrame::data. Original change's description: > [WebSocket] Reduce memcpy at websocket_frame_parser.cc > > This patch removes memcpy at WebSocketFrameParser::Decode to > WebSocketFrameChunk. > To share memory, this changes WebSocketFrame and WebSocketFrameChunk > member type from `scoped_refptr<IOBuffer>` to `char*` referencing > WebSocketStream memory in most cases. > That change needs all users of the classes taking care of reference > life cycle. > WebSocketBasicStream and WebSocketDeflateStream keeps the memory > until next ReadFrames(). > Most tests just copy and hold the memory. > > ToT: 196 MB/s > Patch: 212 MB/s (+8%) > Also this work is accelerated upon more memory consuming flag. > See comments for detail. > > Bug: 865001 > Change-Id: If97651eb61e44805f413fdb7469a5dead5300d21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774420 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693542} CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng TBR=johnchen@chromium.org Bug: 865001 Change-Id: Iaf44e620b8ac8f5c7c8b7a6a78f38d461936d079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787799 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#693780}
-
Vladimir Levin authored
This patch adds select multiple layout. With my proposed implementation, https://github.com/w3c/csswg-drafts/issues/4229#issuecomment-527505519, it should lay out as if the whole contents were sized to content-size, not just an individual item. This patch implements this. However, if there is an alternative solution that is agreed upon in the issue, then I will adjust the implementation. https://groups.google.com/a/chromium.org/d/msg/blink-dev/RMCpsWaqds0/_H9hTQ5tAgAJ R=chrishtr@chromium.org, ikilpatrick@chromium.org Bug: 991096 Change-Id: I22e02127b0196f03bc6842b47b3dd468013e11bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782013 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693779}
-
Elly Fong-Jones authored
This change: 1) Makes the close button on the download shelf keyboard-focusable 2) Makes the download item buttons and their "more options" menu buttons keyboard-focusable 3) Adds ink drops to the download item buttons Bug: 1000998 Change-Id: If6bdb743acceb69164ece8d762304a38f7bcb065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786835 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#693778}
-
Etienne Bergeron authored
This CL is adding a trace event to get details on the way the text is split into runs before text shaping. The split text is passed to ShapeRuns which is trying to find appropriate fonts for the best glyphs coverage. Unfortunately, some unexplained cases are really slow (see crbug/995789). We determined that some cases were related to Emoji (see crbug/873423). This code is intended to determine other block of unicode are causing an expensive font fallbacks. This code can safely be reverted when the bug (crbug/995789) is fixed. R=robliao@chromium.org, asvitkine@chromium.org CC=drott@chromium.org Bug: 995789 Change-Id: I7406c80b6acf9faaf7dd46184e6d04fdd7d4c5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785099Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Sasha McIntosh authored
Current cache usage histogram is dominated by samples in the 0-1 range, making percentile comparison difficult. This change prevents 0% samples from recording to the metric Renderer4.GpuImageDecodeState.CachePeakUsagePercent. Bug: 963619 Change-Id: I8a334d260ee5aeedd2cb6f9db2e8c1cf2f2bdb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783303 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Auto-Submit: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#693776}
-
Clark DuVall authored
With this change, WebLayerShell now only depends on the weblayer/public dir, and has no other dependencies on chrome code. A new APK WebLayerSupport has all the implementation and must be installed alongside WebLayerShell for it to work. Change-Id: Iab3b346831c8d8737a0b3ca509455b7499b31ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779428Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#693775}
-
Brandon Goddard authored
This change enhances the accessibility of the Network tool Timing tab by making the following changes: - Add hidden global headers to give column context to screen readers - Slight modification of color contrast for section headers (> 4.5) - Updated "TIME" to "DURATION" to avoid confusion - Applied ARIA heading for soft headers - Restructured columns to remove empty table cells from being read by a screen reader - Added ARIA labels to waterfall column that read the start time of the request. (Column 3 indicates the duration of that part of the request timing). Bug: 963183 Before: https://imgur.com/qKzqyYv After (with screen reader): https://imgur.com/Sk6vuT6 Change-Id: Ife782e02929f2a1624fd0b827b4e1f729babd209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647132Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693774}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextRequest to new Mojo types. It also updates GetNetworkContext from resource_provider.mojom and CreateNetworkContext and network_service.mojom and methods and members which implement them. Bug: 955171, 978694 Change-Id: I053a8957685e4eed9d44615a5e74b451dc75fe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782203Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#693773}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5339a20. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" 668359aa "[Trusted Types] Rework default policy error handling." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I66564945d37cec158a1d26a76b3b32e70443f306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787957Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693772}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /extensions. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 891670 Change-Id: I47605ff3866dc5c77c5e58944d27849ee2469534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786949 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#693771}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/vr. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=alcooper@chromium.org Bug: 891670 Change-Id: Ib2a8e5bdbfa859777406af079f62760ce69b9b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786686 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#693770}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/supervised_user. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=agawronska@chromium.org Bug: 891670 Change-Id: I808784b2f4c625f6a0284ce721aa2f0f7a071120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786826 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693769}
-
Stephen Chenney authored
Deferred commits (aka Paint Holding) is only allowed on same origin navigations using the http family of protocols. Test that we correctly compute the flag. Also clean up comments in cc tests. Bug: 805798 Change-Id: Ic6f4b1c5125188260eb43c7f01df5be14cbd3e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785921Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693768}
-
Marina Ciocea authored
Per UX request[1], set the tab list to a fixed height equal to the equivalent of 10 tabs. [1] https://docs.google.com/presentation/d/1lSy73_cgj01sdhsV0HZAFL-hht99Iv-4QJyLWF1K_D8/edit?disco=AAAADnnSWPk Bug: 998485 Change-Id: Iafd40caa506ee7dbcad8f1302a23131fd415dcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787382Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#693767}
-
Richard Knoll authored
This happens if OnThemeChanged is called on an error dialog and there are devices or apps to select from. Bug: 1001112 Change-Id: I0ce6873fa62dc2c3344412f9af6d1d3197d0da97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787546Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693766}
-
Vladimir Levin authored
This complicates the code a little bit. I don't think this is strictly necessary, since the savings it would provide for the single frame are defeated by the fact that we need to paint that frame, so we process the lifecycle anyway. When intersection observer runs, we'll still update the throttling status. I've re-opened the referenced bug with hopes of coming up with (and documenting) a good solution that would save us as much lifecycle processing time as possible. R=chrishtr@chromium.org, szager@chromium.org, erikchen@chromium.org Bug: 976391 Change-Id: I209ce44e4a17042c937de31d538e85548b583ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783876Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693765}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 891670 Change-Id: Iecc1db230e4c701499857b1376a721c845d13cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785598 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#693764}
-
Javier Ernesto Flores Robles authored
Bug: 999957 Change-Id: I04645a21455d0ed7aeb6dc014f68b234a09a3793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787500 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693763}
-
Jan Krcal authored
This CL removes tests that become obsolete by http://crrev.com/660350. The only purpose of these tests was to test how a metric gets recorded. This metric was removed by the the CL above. Bug: 1000617, 1000455 Change-Id: I6c370e3fec9805942df379d8b752b5781533b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786448 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693762}
-
Yusuf Sengul authored
Bug: 1001031 Change-Id: Ia8c41cc878a3957686bb897af5c68c96280fe456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786832Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#693761}
-
Ian Clelland authored
Bug: 856601 Change-Id: I91a13f97a5c038e1a570f83ace203f9a52cc2a62 TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786933Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#693760}
-
Alison Maher authored
This change adds a paint phase for backplates in forced colors mode. The backplate paint phase goes before the float and foreground paint phases and after the background paint phase. The new paint phase has been added for both the backplate implementation for LayoutNG and non-LayoutNG. Bug: 970285 Change-Id: I51badafa9564b6e477ab794fed9b8e2caee4b441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757271Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693759}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/preferences. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jonross@chromium.org Bug: 891670 Change-Id: I2267eede47df2efb13f39d8be4500a24f82d2de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787112 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#693758}
-
Nick Diego Yamane authored
UpdateX11EventForChangedButtonFlags function is not used anywhere and UpdateX11EventForFlags is used in one unittest but with no effect (native_event() returns null) so remove both. Bug: 965991 Change-Id: Ida9b30be22a13cc8cdb2cac424b1968754aa3021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785182Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/blink. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bokan@chromium.org Bug: 891670 Change-Id: I626ba137031b1d510206f119075f23024408141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786940 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693756}
-
Finnur Thorarinsson authored
Bug: 988275, 860467 Change-Id: I9b4d02e5dd8eb449ba7b0c98e36964fcd8eb31bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781429Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#693755}
-
Lowell Manners authored
NavigationControllerBrowserTest.HistoryBackTwiceFromRendererWithUserGesture SitePerProcessBrowserTest.TwoCrossSitePendingNavigationsAndMainFrameWins It looks like these were fixed. Probably either by javascript freezing or not caching pages that are currently loading. Bug: 999848 Change-Id: I69eb7ffb19651e796d9f94dee96f797036bffb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787380Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693754}
-
Rakina Zata Amni authored
Because the rendersubtree attribute is also cloned. Bug: 998030 Change-Id: I7bdf0c94578203feaf418d05dd150b4b6ad5c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787619Reviewed-by:
-
Rakina Zata Amni authored
After the move from presentational hints to direct style adjustment, rendersubtree containment addition & locking works with SVG elements. Bug: 998030 Change-Id: Ibf10f2614b1562fd58b67fafbf25051b8608d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787481Reviewed-by:
-
