- 20 Sep, 2019 40 commits
-
-
Victor Fei authored
Fix for AXPlatformNodeWin::get_IsSelected (ISelectionItemProvider:: get_IsSelected) to return false by default if the node supports ISelectionItemProvider. Previously, we threw UIA_E_INVALIDOPERATION for node that supports ISelectionItemProvider but not explicitly marked as selected. The motivation behind this change is due to Windows Narrator announcing "No Item in View" for list items because their ISelectionItemProvider:: get_IsSelected by default returns UIA_E_INVALIDOPERATION and confuses Narrator. Bug: 844149 Change-Id: Iafc1c083dd0feb98b8d1a2d3b18c38284105e2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810060 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698537}
-
Aidan Beggs authored
Before this change, autofill had its own logic for determining a page was secure. This CL changes the behavior to match the security state shown in the omnibox. Bug: 701018 Change-Id: Idd38fc77f93155412961c29a85f237c42ad21563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808226 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698536}
-
Josh Nohle authored
Wait to call InstanceIDDriver::GetInstanceID() until necessary. This is a fix that allows enough time for the CryptAuthGCMManager to add itself as an app handler for the app ID "com.google.chrome.cryptauth". If GetInstanceID() is called before this happens, Instance ID data will not be successfully retrieved from persisted storage and the data risks being overwritten due to https://crbug.com/1006276. In future work, we plan to delegate Instance ID tasks to the CryptAuthGCMManager, but this quick fix works for now. Bug: 1006280, 899080, 951969 Change-Id: I2ea092d97f2afc1bb995b1582cdc66366f530337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814660 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698535}
-
Sam Burnett authored
Bug: 895821 Change-Id: I9163dfa15df2a91ec9cc1b7882b387f6ac9bd79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710756Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Sam Burnett <sburnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#698534}
-
Daniel Hosseinian authored
If the print scaling option is set to PP_PRINTSCALINGOPTION_FIT_TO_PAPER, scale the contents to fit the paper, regardless of the printable area of the paper for the specified printer. Bug: 989978 Change-Id: I033f70f60b3e2d05371785291016b21fe428d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810078 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#698533}
-
Adithya Srinivasan authored
Add a basic test for the devtools console working correctly with portals. For this test to work correctly, I also had to fix an issue where the document's load event was being sent before the portal's load event. Bug: 929356 Change-Id: I61c26edc4078553cfce73e3095b78f3cb25f42fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800479 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#698532}
-
danakj authored
When a renderer has an unload handler (which can be caused by opening devtools apparently), the browser sends a ClosePage IPC to the renderer when it requests to be closed, and waits for ClosePage_ACK before sending the WidgetMsg_Close IPC and closing the tab. When sending the ClosePage_ACK was moved to RenderViewImpl, the Send() method was changed when to stop sending IPCs. In RenderWidget it checked RenderWidget::closing_. But in RenderViewImpl it checks RenderWidget::is_closing(). These look the same but they were different, causing the ClosePage_ACK to never be sent. This CL rectifies the situation by making is_closing() simply return closing_, which restores the previous behaviour and allows browser-renderer interactions between the close request and the actual close action. The is_closing() included the host_will_close_this_ variable, which exists for a rather convoluted reason. When WebPagePopupImpl requests to be closed through the RenderWidget, it immediately destroys its Page object, and its main frame. That means the RenderWidget's WebWidget (which is the WebPagePopupImpl) becomes crashy and invalid after requesting to close. All the methods in the WebWidget API early out when page_ is null to handle this scenario. Except one, the GetURLForDebugTrace() method, which is called when making a LayerTreeFrameSink. To solve this problem in the past, rather than making this method early out (or whatever other method it was at that time), we made RenderWidget avoid making a LayerTreeFrameSink once a close has been requested, to indirectly avoid using the WebWidget. Now that we understand this area of code more fully, we can solve this at the site of the problem in WebPagePopupImpl, and early out in GetURLForDebugTrace() like we do in other WebWidget methods. That means we don't need host_will_close_this_. The mistake here was leaking the host_will_close_this_ state out of RenderWidget and using it for more than it was intended. But since we don't need the variable at all in its more narrow scope we remove it. R=avi@chromium.org Bug: 995123 Change-Id: Iaad83c7e3892908150672d9860a6db4307ffe432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814689Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698531}
-
Steven Bennetts authored
Currently we do not show the VPN feature pod unless a VPN is connected. This fixes that by requesting the list of configured VPNs and showing the button if any exist. Bug: 982222 Change-Id: I939f2eb9ee74771c47468aad7256b5884640cc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815222 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Alex Newcomer authored
Add tests for the Hotseat logic added in an earlier CL. Bug: 1002132 Change-Id: I13e78651c86c2d3f305a46a7e3396d0aac7ea2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812457Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698529}
-
Bruce Dawson authored
An array reference allows the creation of a function that will accept arrays of the desired size. This allows a static_assert with teeth, and the removal of a magic number. No behavior or correctness change happens but this makes the code correct by construction. Change-Id: I6146cb74da391d7970950f705be0a4c82b7d61e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815258 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#698528}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32d64a5d..2425b4f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06e8ad1c17fee28812ea26379963f1698549a8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698527}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b6fa949c4539..44f462b00178 git log b6fa949c4539..44f462b00178 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 sugoi@google.com Fix support for OpKill as non-terminator Created with: gclient setdep -r src/third_party/swiftshader@44f462b00178 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ib9a05b47d749c7341c764891eca75ef9dc20cec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698526}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04fd21513bfa..ef83cc5458bf git log 04fd21513bfa..ef83cc5458bf --date=short --no-merges --format='%ad %ae %s' 2019-09-20 danilchap@webrtc.org Add fuzzer testing for Dependency Descriptor rtp header extension Created with: gclient setdep -r src/third_party/webrtc@ef83cc5458bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I94062723e221c2591a9df4ed7d3e5a62a5fb87aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816860Reviewed-by:
-
Manu Cornet authored
Change-Id: Ifda5eb576f1b8e7d8b635b319a1d02a661744e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815588Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#698524}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If1168a9566a042902410d902057a09faafc1bc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808310 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
-
Pavel Feldman authored
Change-Id: Iba19664d4e350826ce89b89788bc2e68a5ed1c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815885Reviewed-by:
-
Brian Sheedy authored
Changes use of PrintResult to PerfResultReporter in viz_perftests and whitelists the tests for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I078c3094ca44c41b7a33c205a22b8017c3068975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815341Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#698521}
-
arthursonzogni authored
A new android bot has been added. This add the failing tests to the filters. TBR=lowell@chromium.org Bug: None. Change-Id: I4dd4511e8b14cca6d5ae113801bc6f3319769fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816553Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698520}
-
Natalie Chouinard authored
Remove unused context parameter in HelpAndFeedback's getInstance method. Also fix presubmit errors in affected files. Change-Id: I74d7f3bccedbf29f516554ffc53b20374edd6565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814394Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#698519}
-
Robert Ogden authored
Simply removing these tests since this implementation was never launched. Bug: 1005295 Change-Id: Ia2799658867ad5a0be45f238f0def5b95800ef32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815883Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#698518}
-
Robbie Gibson authored
These two items didn't have button set on their accessibility traits. Bug: 979696 Change-Id: I117a10155ca13a23145320f6296640fd7154d454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815122Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#698517}
-
Peter Kasting authored
This also fixes an issue I suspect has been present a long time, where the horizontal scroll arrows pointed the wrong way in RTL. (This is also visible in the "expected result" movie on the bug.) Bug: 1005767 Change-Id: I701c0b99e797855868110f17ce386cd0491d3b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815878 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#698516}
-
Randy Rossi authored
This CL detects when the children's order has changed in a tree update in order to invalidate the unignored index in parent cache. Before this change, the added test case would fail and could cause an infinite loop in the tree walker in the extension. Bug: 1005799 Test: Added unit test and manual testing of display assistant Change-Id: I902e74b0b5e25b949486bc9d7edc208cdd2aa846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813521Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698515}
-
Collin Baker authored
Previously, only the highest priority alert was returned from GetTabAlertStateForContents. This changes it to GetTabAlertStatesForContents which returns all current alerts, in descending order of priority. A convenience function, GetFirstTabAlertStateForContents, is provided to keep existing call sites simple. Bug: 1004983 Change-Id: I170309007d5f3f01c6eff924fa451dd4809abc16 TBR=avi@chromium.org Change-Id: I170309007d5f3f01c6eff924fa451dd4809abc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814545 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#698514}
-
Robert Ogden authored
Bug: 990083 Change-Id: I8d3ac999d517cd4ed56245150a4bba6c576291d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815589 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Greg Thompson authored
- Only create a task running for anonymization when needed. - Only post a task to delete the anonymizer when there is one. - Run the callback immediately if there don't happen to be any sources. Bug: None Change-Id: Ib1ed94ed22802850b4cf311d45e4800510309412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816471Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#698512}
-
David Maunder authored
It has been determined to remove 'stale' and roll our close suggestions into one flag. All variations for the feature (e.g. stale tab threshold) will be done under this one flag. Bug: 1004555 Change-Id: Ia199b84bef19ff2a91e267f8a05a3954d8b7fb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808173 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698511}
-
Yasmin authored
It's possible that GetWidget returns null if there is no parent view. Bug: 988461 Change-Id: I483153282f082f7531589dc06928913139549d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816504Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698510}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f2d41d1be9d..d7f28aae3d89 git log 8f2d41d1be9d..d7f28aae3d89 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 jmadill@chromium.org Vulkan: Pass CommandGraph when updating serials. Created with: gclient setdep -r src/third_party/angle@d7f28aae3d89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ida52d73963ce6a437a730a8042f0dde381629f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815651Reviewed-by:
-
danakj authored
The zoom level is a member of the VisualProperties. The browser side RenderWidgetHostImpl reads it from the site map when building the visual properties. When a cross-origin navigation completes to a new RenderWidget/Frame then the RenderWidgetHost is shown, which triggers a VisualProperties update. Thus the RenderWidget gets the right zoom level after a cross-origin navigation. (Same-origin navigations don't change zoom level.) The page zoom limits are reset to constants after each navigation, but that is the only call to the method changing the limits. So they are already effectively a constant. Remove the plumbing to set them to their own values, and fix the constants in WebViewImpl to be correct. Drop the IPC back to the browser, it already has the right constant values there. R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: Idfab9518592201833dd782f82ab5c6adea829080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809500 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Yasmin authored
Bug: 988461 Change-Id: Iaeccbb32fdac1fd236e7d0b9bed6ec0f0aec11ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816542Reviewed-by:
-
Rune Lillesveen authored
Bug: 1003192 Change-Id: Ic623462e77468d29baa0f3daf1acb7774b006cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816457 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#698506}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Tbr: agrieve@chromium.org Bug: 929661 Change-Id: Iead2b36f9526ba122fe1bfdfb73eab5c1696abbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815048 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698505}
-
Mugdha Lakhani authored
Mark BackgroundSync.LaunchTask.* metrics obsolete, now that the code logging them has been deleted. Bug: 924490 Change-Id: I66c445ef70e6bfed9c15aaaa28bc682416828ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811119 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698504}
-
Erik Chen authored
When creating a Popup Widget, we use the main frame, possibly undead RenderWidget. Instead we should use the local root RenderWidget. Instead it should use the local root render widget. Bug: 912193, 419087 Change-Id: I5280ea48e44f96f4cc4bc4d9a7885f3343c5b7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814672 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Erik Chen authored
In the future, undead RenderWidgets will no logner exist. This CL updates RenderViewImpl::CloseWindowSoon to check for this condition. Bug: 912193 Change-Id: Icbe449794080d36368eac5c9ffe90a198709dbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814673 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It has no definition; all real calls access LocalDOMWindow::isSecureContext. Change-Id: I82c37f54baef4de6f5efde7702874eaf02d0e232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816487 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
arthursonzogni authored
Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1803443 turned linux-bfcache-rel into linux-bfcache-debug. Then the web_tests failed to run: https://chromium-swarm.appspot.com/task?id=47612740eb139410 ~~~ Found 6800 tests (total 82400); running 6378, skipping 422. Checking build ... Unable to find test driver at /b/s/w/ir/out/Release/content_shell For complete Linux build requirements, please see: https://chromium.googlesource.com/chromium/src/+/master/docs/linux_build_instructions.md Build check failed ~~~ The web_tests is trying to use the release binaries to run the tests, but only the debug ones are build. Bug: 1005653,976219 Change-Id: Ice438ec30c263f88aed77c0ba8250822318dd920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811126Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698500}
-
Matt Menke authored
This method is no longer used. It was added so that ResourceDispatcherHost could create a URLRequest itself, and then pass it over to ResourceLoader, which took ownership and set itself as the delegate. It also allowed the downloads code to create its own URLRequests before handing them off to the RDH. Also make URLRequest::get_upload() a test-only method. It had been used to allow extensions to poke at upload data, which is no longer done in the network stack. We could remove this method entirely, reworking the tests that use it, but that's probably not worth the effort. Bug: 934009 Change-Id: I9b2fc70da7b7d9867c396760b26d583067802b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814393Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#698499}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb59a6aa3f71..04fd21513bfa git log fb59a6aa3f71..04fd21513bfa --date=short --no-merges --format='%ad %ae %s' 2019-09-20 danilchap@webrtc.org Cleanup passing rtp packet to ulpfec receiver. 2019-09-20 philipel@webrtc.org Removed unused frame_size param from RtpFrameObject ctor. 2019-09-20 nisse@webrtc.org Delete support for enabling adaptive isac mode 2019-09-20 philipel@webrtc.org RtpFrameObject now takes an EncodedImageBuffer in its ctor. Created with: gclient setdep -r src/third_party/webrtc@04fd21513bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If62c7d4996b16a90b9aa4402e957ca5ad68539a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816817Reviewed-by:
-
