- 12 Sep, 2017 40 commits
-
-
Tom Sepez authored
Reciprocal of SandboxTypeFromCommandLine(). Fix a few more places where we need to treat network sandboxes as unsandboxed. Change-Id: Ice093ff819fd7376bda9f44352f20e8784c1dccd Reviewed-on: https://chromium-review.googlesource.com/658560Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#501350}
-
Tom Anderson authored
Running RPM find-requires on libwidevinecdm.so on Debian Testing reports no libstdc++ dependency, but running it on Ubuntu Trusty does. This CL explicitly allows libstdc++.so as an RPM dependency -- this is a requirement to reland r501104. BUG=758654 R=thestig@chromium.org Change-Id: Ie008e51184b92cf891b4f74c1a432b771adfec5d Reviewed-on: https://chromium-review.googlesource.com/662401Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501349}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4298cb322ef3..000134387797 $ git log 4298cb322..000134387 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 dskiba Respect tracing time in startup tracing agent. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0aeae70423e05326ebe08e533befcab6eeca15f8 Reviewed-on: https://chromium-review.googlesource.com/663564 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501348}
-
Steven Bennetts authored
This shows the list of Shill devices in chrome://network Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icf7fdce83722a3a84b82baee28b35bd5b40ad4c0 Reviewed-on: https://chromium-review.googlesource.com/656377Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501347}
-
Scott Graham authored
There's no advisory file locking, cross-process mutex or semaphore, or implemented flock on Fuchsia currently. So fallback to using dot-file locking for the time being. Bug: 758634 Change-Id: I7be88b0930eca3d4527e6ff161914987ac2150cb Reviewed-on: https://chromium-review.googlesource.com/661321Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501346}
-
bsheedy authored
Updates the VR motion-to-photon latency test's output.json format to match the newer version used by Telemetry and other script tests. This is necessary because the chromium_tests recipe was recently updated to assume that a test is disabled if the results don't include the "tests" key, which is causing results to not be uploaded to the dashboard. Bug: Change-Id: I15102724d3a688bd80b87e583c85dd159cc9feba Reviewed-on: https://chromium-review.googlesource.com/662879Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501345}
-
Artem Strygin authored
Use received bytes count as the value for progress, not chunks count. Reason for reland: The fix of revert reason has been added. Bug: 755061 Original change's description: > Revert "Reland of Improve linearized pdf load/show time." > > This reverts commit 9a6d1487. > > Reason for revert: https://crbug.com/755061. This appears to be > causing a serious regression in loading. The loading bar does not > appear as expected and appears all at once at the end as the screen > displays. There is 5-6seconds of nothing happening which makes it look > like the browser has stopped working. > > > Original change's description: > > Reland of Improve linearized pdf load/show time. > > > > XFA forms loading has been fixed. > > Now for document with single non XFA page, the form load first. > > This is necessary for correct loading pages, because in XFA document > > the page count and them contents may be changed after loading form. > > > > See > > https://codereview.chromium.org/2558573002/ > > > > For test this: > > build chromium pdf with XFA support > > and open any document from > > https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ > > > > Original CL: > > https://codereview.chromium.org/2455403002/ > > > > Original description: > > Improve linearized pdf load/show time. > > Reduce Pdf Plugin's count of reconnects. > > Add tests for PDFPlugin DocumentLoader. > > > > DocumentLoader was splitted into separate components, and missing tests was added for them. > > > > The main ideas in this CL are: > > > > 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position. > > 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind) > > 3) Isolate RangeRequest logic into DocumentLoader. Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing). > > 4) Fill this logic by tests. > > > > Example URL: > > http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf > > Comparison of changes: > > https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing > > > > Change-Id: I97bb25d2e82bcb4ba2e060af8128f49b9c0680d9 > > Reviewed-on: https://chromium-review.googlesource.com/581292 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Dan Sinclair <dsinclair@chromium.org> > > Commit-Queue: Art Snake <art-snake@yandex-team.ru> > > Cr-Commit-Position: refs/heads/master@{#489755} > > TBR=rsesek@chromium.org Change-Id: I78e10565f639c26faae29b3cf854419208af8665 Reviewed-on: https://chromium-review.googlesource.com/615302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
(000 09-08 - 09-18) dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#501344}
-
Eugene But authored
Cancelling system long press gesture cancels all system UI (selection and context menu). Cancelling system context menu UI is intentional, because Chrome want to show own context menu. Cancelling system selection UI was a bug. Bug: 763985 Change-Id: I19fb9b7a90948a2ae9151028d4b7bff53e65b0cf Reviewed-on: https://chromium-review.googlesource.com/663780 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501343}
-
Elliot Glaysher authored
Bug: 706200 Change-Id: Iceaa1b1bac05b348274ddd78040ded6e4a4de42e Reviewed-on: https://chromium-review.googlesource.com/641377 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501342}
-
Ryan Hamilton authored
Change-Id: I8d0df310e716f3663704f5bfb087ac85c7d1fb64 Reviewed-on: https://chromium-review.googlesource.com/663563Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501341}
-
Isha Bobra authored
There is a chance that a race condition occurs where the page returns canScrollForward/backward/up/down/left/right as true but actually the page cannot scroll further. In those cases the scroll function in browser android accessibility should return false instead of true. Bug: 763014 Change-Id: I777b5fb562713e0bd835a354adab9cbf86fcd853 Reviewed-on: https://chromium-review.googlesource.com/661718Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#501340}
-
Helen Li authored
SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL is to remove sdch code from net/url_request. This is the first CL in the series. Bug: 762686 Change-Id: If467b19a2b963c3790bf372ab278bbf847052ddf Reviewed-on: https://chromium-review.googlesource.com/660999Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501339}
-
Toni Barzic authored
When searching for a test (user) profile, the test sin question would search for the first non signin profile on Chrome OS. In addition to sign-in profile, the tests should ignore lock screen apps profile as well (userless profile recently introduced to Chrome OS, which is used to run lock screen apps). BUG=758930 Change-Id: I61ae2da9513d80a598b5fc0f6e28cf90abe81c18 Reviewed-on: https://chromium-review.googlesource.com/661147Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#501338}
-
Steven Bennetts authored
This CL provide support for Cellular devices with no service: * Cellular networks all use the same specifier so that the guid remains consistent (we only support one Cellular Service) * Assume a SIM may be present unless Cellular.NetworkTechnology is CDMA so that the SIM UI shows up even if NetworkTechnology is unset (e.g. because there is no Service). * Create a dummy Cellular NetworkState when none exists so that Cellular Device properties are translated and passed to the UI. This also allows Cellular network UI to be shown so that Device properties can be viewed and SIM and FoundNetworks may be selected. Bug: 717063 Change-Id: I1e23e7ba48821124ad219bb67fea2ca86e2d6ccd Reviewed-on: https://chromium-review.googlesource.com/653723 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501337}
-
Theresa Wellington authored
Also update the logic for when to set the toolbar background during content transitions so that they look better when going from the incognito NTP to other contents. BUG=763313 Change-Id: I3fdd98caeb0c61ddfd2b6c5fc9c4d82222ac9dd0 Reviewed-on: https://chromium-review.googlesource.com/662363Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501336}
-
Ryan Landay authored
This is the final CL to add support for Android SuggestionSpans (at least ones not marked with FLAG_MISSPELLING; there will be one or more additional CLs to add support for those). This CL includes: - Changes to ImeAdapter to make it pass SuggestionSpans into InputMethodController - Changes to InputMethodController to make it create suggestion markers from the passed-in SuggestionSpans - Additional methods in TextSuggestionController for getting the list of text suggestions under the cursor, and applying a suggestion - More Mojo code to pass information about text suggestions back-and-forth between browser and renderer code - Changes to SuggestionsPopupWindow and TextSuggestionHost so we can show either a spell check or a text suggestion menu Bug: 672259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3f30543586901baec4648d265874a303efafbd44 Reviewed-on: https://chromium-review.googlesource.com/627172 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#501335}
-
Derek Cheng authored
This patch implements the following: - auto-dismiss notification issues after 1 minute - auto-dismiss non-notification non-blocking issue after 5 minutes This is done by posting a task to clear a given issue after it has been added to the IssueManager. Part 2 will be to dismiss non-blocking issues following a successful cast from the Media Router UI. Bug: 763432 Change-Id: I6c55d4c272b8fc09b48935c6d4011d893e0cea58 Reviewed-on: https://chromium-review.googlesource.com/658138 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#501334}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/74dac545488c..2ab4b2b871c0 $ git log 74dac5454..2ab4b2b87 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 brianosman Remove symmetric three stop special case 2017-09-12 rmistry Break up the prefix to make some presubmits stop complaining Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I1a84601405c3785190fcffc2f65cfb7919470283 Reviewed-on: https://chromium-review.googlesource.com/663777Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501333}
-
Matthew Jones authored
Other varieties of the toobar depend on the shadow drawable not changing. This change reverts the bottom_toolbar_shadow to its original state (crrev.com/c/646428) and creates a separate one for Chrome Modern. BUG= Change-Id: I3b7964cf603df1308a00942cd728726d5268f71c Reviewed-on: https://chromium-review.googlesource.com/660984 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501332}
-
Xiaohui Chen authored
Previously, some places would change voice interaction states without notifying ash. Now we make sure each change would properly send out notifications so ash could updates its UI. BUG=b:65496623 TEST=build and flash locally, manually test UI updates properly Change-Id: I6e9eae6c98b4e02469a3d84a53d6f181d5378330 Reviewed-on: https://chromium-review.googlesource.com/658558 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#501331}
-
Chris Mumford authored
leveldb_proto::Options is a small subset (mostly) of leveldb::Options. It had two leveldb::Options members (shared_cache and write_buffer_size), and a (possibly empty) database_name. This change deletes leveldb_proto::Options in lieu of using leveldb::Options. This simplifies the code as well as adds support for the remaining options specified in leveldb::Options. Bug: 762587 Change-Id: Ia7872ecb09b2b181354c820ac3296ea6304a80b0 Reviewed-on: https://chromium-review.googlesource.com/655697Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#501330}
-
MinChen authored
Changes: 1. Call TrayBackgroundView::Inialize in PaletteTray::Initialize to add the widget observer for palette tray widget. Then when palette tray anchor changed its AnchorUpdated() can be called. 2. Call SystemTray's UpdateClippingWindowBounds() in WebNotificationTray::UpdateAnchored(). Since when the shelf is bottom alignment, the anchor tray of WebNotificationTray bubble is SystemTray. Bug: 759233 Change-Id: I036e3d2a58541398821424ed31b6534c50b5033b Reviewed-on: https://chromium-review.googlesource.com/653313Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501329}
-
Xu Xing authored
This is a reland of aa28a986 Original change's description: > viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest > > As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox > into LayerTreeREsourceProvider, move the call of > DisplayResourceProvider::CreateResourceFromTextureMailbox > into LayerTreeResourceProvider::CreateResourceFromTextureMailbox. > > The usage of CreateResourceFromTextureMailbox is listed here: > https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit > > BUG=757291 > > Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529 > Reviewed-on: https://chromium-review.googlesource.com/654444 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500974} Bug: 757291 Change-Id: I3a480f72dd6761e940f67f56d636eaf2340df4cc Reviewed-on: https://chromium-review.googlesource.com/662437Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#501328}
-
Scott Violet authored
This is needed to properly convert pixels to DIPs, otherwise things like the the magnification controller don't work. BUG=706200 TEST=covered by test Change-Id: Ie5c841c75080f239b0b3e01469ca0af1435e0756 Reviewed-on: https://chromium-review.googlesource.com/662057Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501327}
-
Bernhard Bauer authored
This is a reland of 6d4871d1 Original change's description: > Reland "Split ThumbnailProviderImpl cache into a LRU and a deduplication cache." > > This is a reland of a4f8bff1 > Original change's description: > > Split ThumbnailProviderImpl cache into a LRU and a deduplication cache. > > > > Bug: 718925 > > Change-Id: I8bfe2d4b743c8fdb014b2112683aba1f74835753 > > Reviewed-on: https://chromium-review.googlesource.com/582958 > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500574} > > TBR: twellington@chromium.org > Bug: 718925 > Change-Id: I68b0184d30c4bc4e712e3ceb1522879b15f5e1d7 > Reviewed-on: https://chromium-review.googlesource.com/659879 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500948} Bug: 718925 Change-Id: I5101af7da3a470499901e57fab08d1ec580eec04 Reviewed-on: https://chromium-review.googlesource.com/663017Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501326}
-
Henrik Boström authored
It turned out that without making this event dispatching conditional on the flag it would fire anyway. It only fires if you listen to the event using addEventListener('track', X), not if you use ontrack = X. When it fires and the flag is off it looks like RTCTrackEvent members such as track and streams are undefined because RTCTrackEvent is behind flag. With this change you get the expected behavior with and without the flag enabled. Also fixes https://github.com/webrtc/apprtc/issues/481 Bug: 761612 Change-Id: Ideaf636633821b0bd9718ef0d2a7a8e7e8b289c1 Reviewed-on: https://chromium-review.googlesource.com/663259Reviewed-by:Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501325}
-
Yuke Liao authored
Origianlly, the code coverage script uses "llvm-cov export" to get the code coverage, but the problem was that it took too long to run and contains a lot of unrelated information, and for example, it took more than 5 minutes to generate code coverage data for ios_chrome_unittests. This CL speeds up the report generation by changing to use "llvm-cov report", it's more hacky, but it's significantly faster. This change reduced the time to generate code coverage report for ios_chrome_unittests from more than 5 minutes to less than 1 minute. Bug: 763956 Change-Id: Ib62a29fef67ea6973e063893af2164b34a25841c Reviewed-on: https://chromium-review.googlesource.com/661677 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501324}
-
Theresa authored
This reverts commit 7b2e0e41. Reason for revert: Failing on Android Tests (dbg) Original change's description: > Initialize PathUtils for the decoder service > > This should fix the crashes that we've been seeing on the bots, so those > have been re-enabled as well. > > BUG=761060 > > Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551 > Reviewed-on: https://chromium-review.googlesource.com/663219 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501265} TBR=peter@chromium.org,finnur@chromium.org Change-Id: I2f41b0d15b06f55f978e81e7503e52d9301260c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761060 Reviewed-on: https://chromium-review.googlesource.com/663420Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501323}
-
Nicolas Dossou-gbete authored
Bug: 762549 Change-Id: Iebd5c5dc7d3c3d3d46c4acb8bb03142413e82515 Reviewed-on: https://chromium-review.googlesource.com/663341Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501322}
-
Tomasz Garbus authored
On iOS calling navigator.credentials.get() would result in an error saying "Check failed: false. Trying to read an unregistered pref: profile.was_auto_sign_in_first_run_experience_shown" In this CL the preference is being registered in PasswordManager::RegisterProfilePrefs() Bug: 453048 Change-Id: I744bfa19e018a3543de3349c0833d4d062a016e6 Reviewed-on: https://chromium-review.googlesource.com/663220Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Cr-Commit-Position: refs/heads/master@{#501321}
-
Sadrul Habib Chowdhury authored
chromeos always builds with ozone, and no longer has direct dependency on x11. So USE_X11 is no longer applicable for chromeos code. BUG=750642 Change-Id: Iade4e609dbbb5d20d7a683153d23f84fc7848b46 Reviewed-on: https://chromium-review.googlesource.com/663403 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501320}
-
Fredrik Söderquist authored
Change-Id: If895e92065d23e3da4f5d659c114abf024038b38 Reviewed-on: https://chromium-review.googlesource.com/663537 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#501319}
-
David Reveman authored
This adds trilinear filtering support to layers. All layers with this type of filtering a rendered to a render surface and mipmaps are generated for the render surface when supported by renderer. This allows for more efficient and higher quality down-sampling. It can provide a significant performance improvement when combined with render surface caching. BUG=757020 TEST=cc_unittests --gtest_also_run_disabled_tests --use-gpu-in-tests --gtest_filter=GLRendererPixelTest.DISABLED_TrilinearFiltering Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I14eb1b06231c9732651670f0cd4b95f95344f5b2 Reviewed-on: https://chromium-review.googlesource.com/621540Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501318}
-
Jun Cai authored
This CL changes code at PlatformSensorAndProviderTest.java to use assertTrue and assertFalse instead of assertEquals for boolean to improve code readability. Bug: None Change-Id: Ieb77fd683dc4c3b135e7498b6a2443a91d17b4bd Reviewed-on: https://chromium-review.googlesource.com/660411Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#501317}
-
James Forshaw authored
This reverts commit 251a3311. Reason for revert: People building with actual VS2015 according to the official instructions don't have the definitions for some of the AC functions. I'd argue they shouldn't be building with that but it seems that it's part of the official instructions. Reverting for now. Original change's description: > Implemented changes to Sid class for AC support. > > This CL implements changes to the sandbox Sid class to support the creation > of Capability Sid objects. It also contains a few refactoring efforts to > cleanup up older code. > > Bug: 760977 > Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng > Change-Id: Id9c05b8017abb81896c1bc30f23599441812d1fd > Reviewed-on: https://chromium-review.googlesource.com/649026 > Commit-Queue: James Forshaw <forshaw@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501229} TBR=pennymac@chromium.org,forshaw@chromium.org,wfh@chromium.org Change-Id: Icafd0c2281d8442562fc24c869ca88595277f065 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760977 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/663698Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501316}
-
Irmak Kavasoglu authored
This cl completes the password selection feature functionality for linux/chromeos/windows platforms. Now we are actually saving the selected password when user clicks save button. Bug: 753806 Change-Id: Ia61c2f49bf43b4c7fc456cb99ed0eb5582e89df5 Reviewed-on: https://chromium-review.googlesource.com/663317 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501315}
-
Alex Moshchuk authored
All but two of these tests appear to be now passing. Bug: 174705, 242167, 84719, 241245, 242196, 241164, 243648, 169622, 232340, 763808 Change-Id: I50732446c54a1de54b3b6a233650855e7f785742 Reviewed-on: https://chromium-review.googlesource.com/661997 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501314}
-
kylechar authored
This CL makes CompositorFrameSinkSupport into a mojom::CompositorFrameSink. CompositorFrameSinkSupport already implements the interface so this is a trivial change. This CL also replaces CompositorFrameSinkSupportClient with mojom::CompositorFrameSinkClient. The two interfaces were almost identical, minus WillDrawSurface() method, which was only used in DelegatedFrameHost. WillDrawSurface() is replaced with a callback. This simplifies [Root]CompostiorFrameSinkImpl. CompositorFrameSinkImpl only needs to hold the Binding/InterfacePtr and delegate calls into CompositorFrameSinkSupport. The client can be passed in directly. This CL also cleans up test implementations of CompositorFrameSink[Support]Client. Bug: 762743 TBR: weiliangc@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib4f1fd6a22badce9ae77a7bb484c6ab465e4d7c5 Reviewed-on: https://chromium-review.googlesource.com/641990 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#501313}
-
Koji Ishii authored
Collapsed spaces are defined as "zero advance width, invisible, but retains its soft wrap opportunity". When the first space does not create break opportunities, collapsed spaces should create one. Example: <span nowrap>a </span> b The space before "b" is collapsed, but needs to create a break opportunity, because the space after "a" does not. This patch improves following tests, though they fail for other reasons. fast/text/whitespace/inline-whitespace-wrapping-3.html fast/text/whitespace/inline-whitespace-wrapping-4.html fast/text/whitespace/inline-whitespace-wrapping-5.html [1] https://drafts.csswg.org/css-text-3/#collapse Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5dd0468909f28c7db610c115fdaece4418ba86c8 Reviewed-on: https://chromium-review.googlesource.com/660937Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#501312}
-
Jun Cai authored
Currently there are radian and degree conversion constants in both generic_sensor_consts.h and orientation_util.h. This CL moves them to generic_sensor_consts.h. Bug: None Change-Id: I7de69b7e9536bb003158ab9d3611ec9a621211fc Reviewed-on: https://chromium-review.googlesource.com/661077 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501311}
-