- 01 Feb, 2018 40 commits
-
-
Alan Cutter authored
The method BoundsAnimator::CreateAnimation() is only overridden by a test class that doesn't really need to do so. This CL removes the test subclass and the virtual keyword from CreateAnimation(). This is a code clean up and has no change in behaviour. Change-Id: I633f1163125cca423da4aff54ffafc0922bf0658 Reviewed-on: https://chromium-review.googlesource.com/895207Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#533531}
-
Darren Shen authored
This patch implements the new CSSMathValue serialization algorithm [1]. As explained in the bug, this serialization is impossible to do by converting to CSSValues and then serializing them, so we have to implement this from scratch. We tried to make the code follow the spec algorithm as closely as possible for easier understanding/verification. [1] https://drafts.css-houdini.org/css-typed-om-1/#calc-serialization Bug: 803688 Change-Id: I48987d2b76b0bac55389a014588f3fe40aecf10a Reviewed-on: https://chromium-review.googlesource.com/896422Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533530}
-
Yoshifumi Inoue authored
This patch introduces test cases for |StartOfWord()| with |PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: I5b2452cf45c3063ed67d436def4b05a3a617b424 Reviewed-on: https://chromium-review.googlesource.com/895208Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533529}
-
Reilly Grant authored
This change renames public/interfaces to public/mojom and *_struct_traits_* to *_mojom_traits_* in //device. As a side effect the //device/vr/public/mojom directory was created to hold vr_service.mojom and //device/screen_orientation/public/interfaces was moved to //services/device/public/interfaces as the rest of that directory had already been moved to //services/device. Bug: 806965 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb8cf29107aaae89a9f616a864e079551da63768 Reviewed-on: https://chromium-review.googlesource.com/894142Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533528}
-
Eugene Ostroukhov authored
Bug: 789317 Change-Id: I4ef5f83dc37261b053bf698919aa93ad77375fad Reviewed-on: https://chromium-review.googlesource.com/861199Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533527}
-
Matthew Jones authored
In practice, this means changing the Chrome Home checks to Chrome modern design checks. BUG=803090 Change-Id: Id511842962d72234db4a5c7fb99311f19ed09cda Reviewed-on: https://chromium-review.googlesource.com/896523Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533526}
-
Yoshifumi Inoue authored
This patch changes "skip-over-uneditable-in-contenteditable.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: I9aa13fdf989bddbe578676815072ce3b3207bc7d Reviewed-on: https://chromium-review.googlesource.com/895128Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533525}
-
Devlin Cronin authored
One of the variants of GetPropertyUnsafe() was unused. Remove it. Bug: None Change-Id: I518789c94f00cbd6225159cfcfd6004b94151b64 Reviewed-on: https://chromium-review.googlesource.com/896387Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533524}
-
Yoshifumi Inoue authored
This patch introduces test cases for |EndOfWord()| with |PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: I598b650c495af5587f6417f04fff4f8236b69903 Reviewed-on: https://chromium-review.googlesource.com/895228Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533523}
-
John Abd-El-Malek authored
Context: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/OtU2gBvN_EE/TUIl4j9cAAAJ Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib40dc4625ead75f0e612bf719e7dba428cbeed35 Reviewed-on: https://chromium-review.googlesource.com/896204 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533522}
-
Kyle Horimoto authored
This CL adds two metrics: (1) Success rate for GATT connection attempts. (2) Effective success rate for one or multiple connection attempts, using retries if a previous connection failed (up to the maximum number of retries). These metrics aid in our ability to analyze what our effective connection stability is. Bug: 805219, 672263 Change-Id: I407c3af03eb86ccc80807395e1f18a5bff2b71a4 Reviewed-on: https://chromium-review.googlesource.com/894445Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533521}
-
Steven Holte authored
Bug: 793082 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2576f1ae6d40bb20fa641bfaf24089db4dd5e29e Reviewed-on: https://chromium-review.googlesource.com/884941 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#533520}
-
Christopher Lam authored
This CL changes the Cut/Copy/Paste shortcuts to be triggered through the web events so that the browser menu's edit buttons will work in the bookmark manager. Bug: 807104 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I57dfa94825b450de6d69f45f9a36085bd43775c3 Reviewed-on: https://chromium-review.googlesource.com/892549Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#533519}
-
Kevin Bailey authored
OmniboxView::UpdateTextStyle() needs to know if the text is a URL, but so does its caller. Rather than calculate it twice - a non-trivial run through Classify() - pass it. Bug: 669727 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a8be0bfaaf7fd6c2b5ada831de65340e71d47d6 Reviewed-on: https://chromium-review.googlesource.com/890658 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533518}
-
Shubhie Panicker authored
keepalive (renamed to KeepActive) is true if there is a running service worker, or shared worker or unfinished fetch keep-alive. In this case the scheduler should not freeze the renderer. If keepalive state changes then run UpdatePolicy, as a frozen renderer may need to be woken up. For full discussion, see: https://groups.google.com/a/google.com/d/msg/chrome-lifecycle-apis/qjPzJF0quRs/lurC3EWqAAAJ Change-Id: Iafa3e1b745ede38d2dcd6d89b232cc4d12e1e785 Reviewed-on: https://chromium-review.googlesource.com/869172 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533517}
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/3e444ad8860b..f5964c36e1dc $ git log 3e444ad88..f5964c36e --date=short --no-merges --format='%ad %ae %s' 2018-01-31 xhwang Remove carriage return (CR) in Windows CC_IDENT string 2018-01-30 xhwang Updating build configs for M66 roll 2018-01-29 xhwang media: Update build_ffmpeg.py to pull Android API level 2018-01-25 xhwang Merge FFmpeg for M66. 2018-01-19 chcunningham Remove ffmpegsumo.dll cruft. 2018-01-21 sw v4l2_m2m: Fix integer overflow in timestamp handling 2018-01-21 jamrial avcodec/mpeg12dec: fix preprocessor check for mpeg1_nvdec hwaccel 2018-01-21 sw v4l2_m2m: Fix free of the wrong pointer in an error path 2018-01-08 jun.zhao lavfi: add denoise and sharpness VAAPI video filters. (...) Created with: roll-dep src/third_party/ffmpeg BUG=777484 Change-Id: I91e9bea380dc7782c7f7dee751e268a29d270c12 Reviewed-on: https://chromium-review.googlesource.com/896571Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533516}
-
Pavel Feldman authored
DownloadManager has public SetDelegate method and tests and or other subsystems can install their own implementations of the delegate. Bug: 805905 Change-Id: Iecf1e0aceada0e1048bed1e2d2ceb29ca64295b8 TBR: tests updated to follow the API change. Reviewed-on: https://chromium-review.googlesource.com/894702Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533515}
-
yiyix authored
Draw occlusion is introduced to reduce overdraw in chrome between different layers. Before drawing the compositor frame to the screen, Draw Occlusion iterate through every DrawQuad in the CompositorFrame then remove DrawQuads that are not shown on screen. The side effect is that it may take too long to iterate through many small non-overlapping DrawQuad. In this patch, I added a "skip rect", that is if the |visible_rect| of a DrawQuad is smaller than this size, it will be drawn to screen regardless it's shown or not. I did some research on a perfect size for "skip rect": https://docs.google.com/document/d/1N8o7Nvx-qsSGx4aKd-6OwVJHGMsSZZGmlORU7aK6sGs/edit Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I180053a5158832715145391eaaed29a3828834f1 Reviewed-on: https://chromium-review.googlesource.com/867477 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#533514}
-
Nico Weber authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/4a02ec03038d..ac4a549e29fb $ git log 4a02ec030..ac4a549e2 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 lv Extend ifdef to include helper functions 2018-01-31 lv Remove barrier to fix Android build. 2018-01-31 thakis Make breakpad build with -Wimplicit-fallthrough (on linux) 2018-01-17 pcc Do not use non-standard stdext::checked_array_iterator with libc++. 2018-01-08 lv Only restore the signal handler if sigaction has not changed 2017-12-22 nisarul Fixed file extention for minidump_upload in tools_linux.gypi Created with: roll-dep src/third_party/breakpad/breakpad Bug: 801780,177475 Change-Id: Ibab0e22bf2ca8c4f490b48203e182f90c3fba5aa Reviewed-on: https://chromium-review.googlesource.com/895822Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533513}
-
Ahmed Fakhry authored
When the feature is enabled: - Caption buttons will have 8px spacing between one another. - Browser's frame caption buttons will have a bigger height. BUG=805267 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib697ac229e9665377800cc5f58d42341b5ea01b6 Reviewed-on: https://chromium-review.googlesource.com/885508 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#533512}
-
Casey Piper authored
Initial U2F specifications specified a U2F version that was not compatible with ISO 7816-4. As some authenticators require this older GetVersion command, falling back to that initial command upon failure with the current GetVersion command. R=hongjunchoi@chromium.org, jdoerrie@chromium.org Bug: 805778 Change-Id: Id7f8a040aae323ba59c1d3c1418d8b5b8bb8953d Reviewed-on: https://chromium-review.googlesource.com/894894 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Juan Lang <juanlang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533511}
-
Sidney San Martín authored
When extracting URLs from a pasteboard, keep going if WebURLsWithTitlesPboardType doesn't yield anything. This fixes an issue where drags from a legacy macOS WebView fail because they populate WebURLsWithTitlesPboardType in the pasteboard without any content. (It also looks like there was a crash here if the pasteboard contained an empty list of URLs.) Bug: 799533 Change-Id: I034bcc5bb9cedb86b5cca95601e7bd560eb45965 Reviewed-on: https://chromium-review.googlesource.com/895924 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533510}
-
kylechar authored
Change GpuChildThread to shutdown VizMainImpl cleanly. VizMainImpl needs to shutdown the GPU and compositor thread in a specific order, however the implementation of VizMainImpl::TearDown() requird that it be called from a third thread. Reorder the VizMainImpl::Teardown() logic so it can be called from the GPU thread and move it to the destructor. Remove most WaitableEvent usage since we can rely on Thread::Stop() to synchronize with thread destruction. Also simplify GpuHost and WindowServer destruction. Bug: 785023 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Idbac0d6b91fc32b403a359fdcf3d7ea62c17f682 Reviewed-on: https://chromium-review.googlesource.com/893520Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533509}
-
Sadrul Habib Chowdhury authored
The renderer processes can have a compositor thread. The gpu process can also have a compositor thread (for the display compositor). So, introduce a COMPOSITOR_THREAD enum so that we can add support for the sampling profiler for the compositor thread in renderer and gpu processes. BUG=788808 Change-Id: I6cfe49d441ef636ce4a3c1ca4c60b7d09e7bc201 Reviewed-on: https://chromium-review.googlesource.com/892362Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#533508}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab41a172..c5c99c66 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id0ed98f350c936bbedb0163abf3c43656c5b3ac6 Reviewed-on: https://chromium-review.googlesource.com/896242Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533507}
-
Daniel Erat authored
Remove a few flags that are never set from crash_keys.cc: --max-unused-resource-memory-usage-percentage --termination-message-file Bug: 778261 Change-Id: Ib06e832fa9133c4310cf5358f50778ea1917e4d2 Reviewed-on: https://chromium-review.googlesource.com/894828Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#533506}
-
https://pdfium.googlesource.com/pdfium.git/+log/8a9f2e13d13f..66ce22c6cdb3 $ git log 8a9f2e13d..66ce22c6c --date=short --no-merges --format='%ad %ae %s' 2018-01-31 xlou Experimental API for N-up feature support for print 2018-01-31 hnakashima Roll android_ndk, build, buildtools. 2018-01-31 rharrison Remove handrolled bsearch from FGAS_GetUnicodeBitField 2018-01-31 dsinclair Move initializers to header for CXFA_ItemLayoutProcess 2018-01-31 rharrison Remove handrolled bsearch from XFA_GetScriptAttributeByName 2018-01-31 dsinclair Cleanup visibility in CXFA_ItemLayoutProcessor 2018-01-31 dsinclair Create CXFA_Node::PresenceRequiresSpace Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie739351cef4dd6d73c3ab11ff6e44144b2160105 Reviewed-on: https://chromium-review.googlesource.com/896568Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533505}
-
Jay Civelli authored
Removing extra clean-up steps in the SetUp() method of the SSLUICaptivePortalListResourceBundleTest as they cause the test to hang when calling SetUpCertVerifier after the NetworkService has been stopped. Bug: 807779 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8d356d80ef1c95e98c5baacf8766d56b35d75abc Reviewed-on: https://chromium-review.googlesource.com/896370 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533504}
-
Naoki Fukino authored
We've used "More actions..." for the label of tasks' dropdown menu, since it can contain multiple types of tasks. Now that the dropdown menu contains only OPEN type tasks, we should rename it to "Open with...". Bug: 786652 Test: Manually tested on kevin. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3667f20e1490987ba3a87555f2e3af4f4369e22b Reviewed-on: https://chromium-review.googlesource.com/892727Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#533503}
-
Matthew Jones authored
The tab switcher toolbar color is transparent when modern is enabled and the default modern color when accessibility is enabled. BUG=803090,803091,803098 Change-Id: I4bef7df8b98e06ec29f90a0a444e63f7d5d2f6d0 Reviewed-on: https://chromium-review.googlesource.com/895050Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#533502}
-
Will Harris authored
This is to help diagnose a stability issue. BUG=806661 NOTRY=true Change-Id: I92f05cce48e3e35bdcbbe036d8d38d83e59d3692 Reviewed-on: https://chromium-review.googlesource.com/896366Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#533501}
-
Hongchan Choi authored
This CL enables a cross-thread messaging from AudioWorkletNode constructor to AudioWorkletProcessor (subclass) constructor. Spec: https://webaudio.github.io/web-audio-api/#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor WG decision: https://github.com/WebAudio/web-audio-api/issues/1459 Bug: 792533 Change-Id: I4fe5bc8188f98533e6c046406002f1cfcb7ff3b8 Reviewed-on: https://chromium-review.googlesource.com/812509 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533500}
-
Tommy Steimel authored
TBR=tkent@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807791 Change-Id: I287861e41300bd55ab2fd4022de691cb0623fa16 Reviewed-on: https://chromium-review.googlesource.com/896375 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533499}
-
Ian Vollick authored
With this change, we begin repositioning based on laser direction deltas once repositioning is enabled. Also adds a scrim to the content quad while repositioning is happening. We also update controller labels. Bug: 800563,800556 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I19bdc286c7b7be2dc5df8a6690b965098959559e Reviewed-on: https://chromium-review.googlesource.com/894902 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#533498}
-
Patti authored
This reverts commit ed10b068. Reason for revert: This causes crbug.com/795272, but there isn't a good fix for this at the moment. Revert this as a workaround for now. Original change's description: > Desktop Page Info/Harmony: Never decrease the size of PageInfoBubbleView. > > The PageInfoBubbleView, when long strings are selected in its comboboxes, can > sometimes expand its original size in Harmony mode. It will then shrink again > if the long combobox option is changed back to a shorter one. This makes the UI > move around a lot, so prevent it from getting smaller again. > > Bug: 657250 > Change-Id: I49262900cc386ae2e57e02ba82a51cdae12e08a9 > Reviewed-on: https://chromium-review.googlesource.com/771050 > Reviewed-by: Lucas Garron <lgarron@chromium.org> > Commit-Queue: Patti <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516966} TBR=lgarron@chromium.org,patricialor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 657250, 795272 Change-Id: Ibbefa40b7dd32e1f69bdb04c4895594f053985a7 Reviewed-on: https://chromium-review.googlesource.com/894927Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533497}
-
Greg Kerr authored
This CL enables the V2 GPU sandbox and includes necessary cleanup to do that. Most importantly, it calls API to block launchservicesd, and it allow coreservicesd, like the current sandbox, because the graphics stack crashes if it cannot contact it. Bug: 749839 Change-Id: Id3d27854ebb7dabd47de748427074bb7317d9427 Reviewed-on: https://chromium-review.googlesource.com/896268Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533496}
-
Kyle Horimoto authored
Before this CL, a crash could occur due to the following: (1) Tether connection is active. (2) Connection is lost to the underlying Wi-Fi connection. TetherNetworkDisconnectionHandler is notified of this change, then posts a new task to handle the disconnection. (3) Before the new task is run, the Wi-Fi network is removed from NetworkStateHandler. (4) The task is run, and TetherNetworkDisconnectionHandler requests that NetworkStateHandler return the network associated with the disconnection. (5) Since the network had been removed, NULL is returned. (6) TetherNetworkDisconnectionHandler attempts to invoke the path() function on the null pointer, resulting in a segfault. This CL fixes the issue by obtaining and caching the network's path as soon as the disconnection occurs instead of waiting until a later time to fetch the path value. As a result, this CL also refactors the way that NetworkConfigurationRemover works; instead of taking a Wi-Fi network GUID as a parameter, the class now takes the Wi-Fi network path as a parameter. Bug: 806944, 672263 Change-Id: I074aa691ca533616516a3e624be71fde832f382f Reviewed-on: https://chromium-review.googlesource.com/894497 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533495}
-
Fabio Tirelo authored
Bug: 806324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0587b535d982d6174e0ed13af50c7fab33942fc Reviewed-on: https://chromium-review.googlesource.com/890120 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#533494}
-
Michael Spang authored
The tracing control directory was originally part of the debug filesystem at /sys/kernel/debug/tracing. We have to support this location in order for tracing to work on older kernels. Bug: 786091 Test: chromecast/tools/trace.py Change-Id: Iccde78471201ab0bf9f4577057c28935f0909ce3 Reviewed-on: https://chromium-review.googlesource.com/896625Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533493}
-
Reza.Zakerinasab authored
Bug: 806994 Change-Id: Ic1fd685f49a284f220ba39facfd6f8ac6710806b Reviewed-on: https://chromium-review.googlesource.com/895056Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#533492}
-