GitLab

GCC is stricter than clang when it comes to class members' names and how
they can change the meaning of a previously existing symbol with the same
name:

    ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:72:77: error: declaration of ‘blink::{anonymous}::AnimationMockChromeClient& blink::{anonymous}::LocalFrameViewTest::ChromeClient() const’ [-fpermissive]
       AnimationMockChromeClient& ChromeClient() const { return *chrome_client_; }
                                                                                 ^
    In file included from ../../third_party/WebKit/Source/core/loader/EmptyClients.h:39:0,
                     from ../../third_party/WebKit/Source/core/layout/LayoutTestHelper.h:17,
                     from ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:10:
    ../../third_party/WebKit/Source/core/page/ChromeClient.h:94:19: error: changes meaning of ‘ChromeClient’ from ‘class blink::ChromeClient’ [-fpermissive]
     class CORE_EXPORT ChromeClient : public PlatformChromeClient {
                       ^~~~~~~~~~~~

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer
explanation, but essentially having a |ChromeClient()| method can change the
meaning of references to |ChromeClient| in the code dependending on where it
is declared, which contradicts the C++ standard.

Fix it by renaming the method to |GetAnimationMockChromeClient()|.

Change-Id: I3d92e960384ba6b8d1885f7fed2618085ce19855
Reviewed-on: https://chromium-review.googlesource.com/968425Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#544031}

Increases fuzzer coverage to match changes in cl 924187. Hopefully also
fixes the referenced bug, because this now explicitly initializes
CachedDocumentParameters::integrity_features when called from the fuzzer.

Bug: 818396
Change-Id: Ica18606543bd5cb36df567a132a6fe2b1da9620f
Reviewed-on: https://chromium-review.googlesource.com/968508
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544030}

Bug: 810203
Change-Id: I69036af7dab173d84afaf39b52653461225d3e3b
Reviewed-on: https://chromium-review.googlesource.com/909413Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544029}

GCC is stricter than clang when it comes to class members' names and how
they can change the meaning of a previously existing symbol with the same
name:

    ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp: At global scope:
    ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp:12592:3: error: declaration of ‘blink::LocalFrameView* blink::SlimmingPaintWebFrameTest::LocalFrameView()’ [-fpermissive]
       }
       ^
    In file included from ../../third_party/WebKit/Source/core/frame/LocalFrame.h:41:0,
                     from ../../third_party/WebKit/Source/core/page/Page.h:33,
                     from ../../third_party/WebKit/Source/core/page/PageVisibilityObserver.h:31,
                     from ../../third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h:44,
                     from ../../third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:32,
                     from ../../third_party/WebKit/Source/core/html/canvas/ImageData.h:34,
                     from ../../third_party/WebKit/Source/bindings/core/v8/serialization/SerializedColorParams.h:8,
                     from ../../third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h:11,
                    from ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp:45:
    ../../third_party/WebKit/Source/core/frame/LocalFrameView.h:105:19: error: changes meaning of ‘LocalFrameView’ from ‘class blink::LocalFrameView’ [-fpermissive]
     class CORE_EXPORT LocalFrameView final
                       ^~~~~~~~~~~~~~

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer
explanation, but essentially having a |LocalFrameView()| method can change
the meaning of references to |LocalFrameView| in the code dependending on
where it is declared, which contradicts the C++ standard.

Fix it by renaming the method to |GetLocalFrameView()|.

Change-Id: I3aa9502080708653bdff68eaec51fe61850b4877
Reviewed-on: https://chromium-review.googlesource.com/968424Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#544028}

device_utils.GetPids is being deprecated. Switch its clients to
use ListProcesses and GetApplicationPids instead.

Bug: catapult:#4103
Change-Id: I32e935918ea8f9da586caa91c5e9e8a0b6ac65a2
Reviewed-on: https://chromium-review.googlesource.com/962801
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544027}

When opening a new tab for the same origin as a the current tab,
the new tab was incorrectly linked to the currently open tab's
MediaEngagementSession.

This adds a check to only allow the sessions to be linked if the
new tab navigation originated from a link on the current tab.

BUG=819807

Change-Id: I02f892372f1aa92f830f891a369732a4fc7b8883
Reviewed-on: https://chromium-review.googlesource.com/962242
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544026}

Bug: 822849

Change-Id: If2c0f615f4b9e610ca9ec745e081622efed1d887
Reviewed-on: https://chromium-review.googlesource.com/967081
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544025}

TBR=msw@chromium.org

Bug: 823043
Change-Id: I4c113f6630340907aec7870487176a2046f035ac
Reviewed-on: https://chromium-review.googlesource.com/968602Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544024}

TBR=emaxx@chromium.org
TBR=pastarmovj@chromium.org

Bug: 822975
Change-Id: I03062d8eb1c8c3221cf07eb08587e4d9c97ed5e2
Reviewed-on: https://chromium-review.googlesource.com/968507Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544023}

We've had poor Android test coverage on the ToT bots, as shown by the
recent clang roll. Historically that's been due to flakiness of running
Android tests. But now that everything's on swarming it should be
better, and this uses the config from linux_android_rel_ng which runs on
the CQ and seems to be very stable.

Bug: 817298
Change-Id: Ie992c49c9a86037529f8ac6bd70c7ce7b732850c
Reviewed-on: https://chromium-review.googlesource.com/968243Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544022}

Bug: 821917
Test: components_unittests --gtest_filter=Suggestions*
Change-Id: Ia6a4389b42c42936ba9d0f8014e2d32b8426a70d
Reviewed-on: https://chromium-review.googlesource.com/967872Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544021}

https://skia.googlesource.com/skia.git/+log/4410d7ff7572..fe0253f8bb64

$ git log 4410d7ff7..fe0253f8b --date=short --no-merges --format='%ad %ae %s'
2018-03-16 robertphillips Alter GrSurface/GrSurfaceProxy flags to prepare for GrTexture/GrTextureProxy -specific flags

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I94940df71f0dbfc15035ee1eca38968f15bc26e7
Reviewed-on: https://chromium-review.googlesource.com/968541
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544020}

Filter out new consisten Mac filters in viz_content_browsertests and
viz_browser_tests

TEST=viz_browser_tests, viz_content_browsertests_
TBR=kylechar@chromium.org

Bug: 760181
Change-Id: Idde59c0abb342a19bf5539b4771ea7aca586bc51
Reviewed-on: https://chromium-review.googlesource.com/968545Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544019}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8c5929de..9cf8abb7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ief0faf2cb789048efc5fb6c50fbc64c212398b95
Reviewed-on: https://chromium-review.googlesource.com/968344Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544018}

Move throttling code to scheduler/common/ as a preparation to enable
throttling for worker threads.

R=alexclarke@chromium.org
BUG=776416

Change-Id: I78e4e249bcacf7ccc0c6feae48cd44a534c36a56
Reviewed-on: https://chromium-review.googlesource.com/966621
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544017}

This CL deletes Label Manager sources and unittests since it is not used
anymore.

Bug: 729154
Change-Id: Ic8e9cc8dbebd4317d53c0b48ac683b44de99593b
Reviewed-on: https://chromium-review.googlesource.com/967051Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544016}

Use BuildInfo directly to check the SDK version in NotificationSettings.

Bug: 821431
Change-Id: Ie3ca8b6dc2cf200ab06d3e1aa6820bca341db1c5
Reviewed-on: https://chromium-review.googlesource.com/966284
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544015}

This reverts commit 6683995b.

Reason for revert: crbug.com/823235

Original change's description:
> Vaapi: Remove ConditionVariables and use PostTask
> 
> This CL removes the use of the ConditionVariables inside VaVDA and
> uses instead PostTask()ing. This removes blocking the worker
> thread, which allows for moving other tasks there, e.g. the
> Surface Blit (as done in the follow up WIP CL crrev.com/c/947341)
> 
> For all that goodness, this CL:
> 
> - Refactors the waiting logic that on ToT is spread between
>  GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and
>  simplifies it in DecodeTask() itself.
> 
> - Moves the |curr_input_buffer_| filling logic in
>  GetCurrInputBuffer_Locked() into DecodeTask() proper.
> 
> - Reduces the scoped of the |lock_| in DecodeTask() (note that
>  |curr_input_buffer_| and |decode_| are only used on the decoder
>  thread -- added a .h comment).
> 
> Minor stuff: This CL also moves together the declaration of the
> related member vars |input_buffers_|, |curr_input_buffer_| and
> |available_va_surfaces_|
> 
> TEST=simplechrome+crosvideo (including seeks) on soraka, and
> v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true).
> 
> Bug: 717265
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ib167115dd2a4ebaeaea3ba3b5a205779d659f479
> Reviewed-on: https://chromium-review.googlesource.com/949283
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542955}

TBR=posciak@chromium.org,kcwu@chromium.org,mcasas@chromium.org,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I62361a33067140eb42112ccf7613136137bc30e2
Reviewed-on: https://chromium-review.googlesource.com/967967
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544014}

We want Chromium to build with enable_webrtc=false. I will initially
add a build bot in chromium.webrtc.

Bug: chromium:811678
Change-Id: If3f23a70f0102f5b65bb46e5e91eee3c0b1bbeb2
Reviewed-on: https://chromium-review.googlesource.com/960125
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544013}

This flag was originally added to ui::base::win to suppress a specific
error message when attempting to open a file via the shell using the
"open" verb. The flag has additional side-effects and shouldn't be used
when invoking ShellExecute().

R=grt@chromium.org

Bug: 819809
Change-Id: I7db2344982dd206c85a73928e906c21e06a47a9e
Reviewed-on: https://chromium-review.googlesource.com/966964
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544012}

This reverts commit 1fa1c441.

Reason for revert: broke downstream builders

Original change's description:
> android build: Split process_resources GN rule and script.
> 
> The process_resources() GN template and the associated
> process_resources.py script are huge and difficult to understand
> because they can be used to perform two slightly related
> different things.
> 
> In preparation for a future CL that will introduce a new resource
> compilation mode, this CL tries to clarify the situation by splitting
> them into two sets of GN template + script:
> 
>    - prepare_resources() + prepare_resources.py, which are
>      used to create .resources.zip archives of raw/uncompiled
>      resources for resource related targets, as well as
>      generating a corresponding R.txt and .srcjar(R.java)
>      file.
> 
>      This corresponds to what process_resources() did when
>      it was called from android_resources() and junit_binary().
> 
>      Note that this always generates non-final resource IDs,
>      as well as a dummy onResourcesLoaded() method, necessary
>      to compile, but not link, the ResourceRewriter class
>      used to implement the system webview feature.
> 
>    - compile_resources() + compile_resources.py, which are used
>      to compile all resource dependencies of a given binary
>      (e.g. android_apk) into an intermediate .ap_ file.
> 
>      This corresponds to the behaviour of process_resources()
>      when called from android_apk(). This generates final
>      resource IDs by default, unless |shared_resources| or
>      |shared_resources_whitelist| is used.
> 
>      Also, as a simplification, |shared_resources_whitelist|
>      now implies |shared_resources|, except that it restrict
>      the list of non-final resource IDs.
> 
> - Removed generate_constant_ids, since compile_resources()
>   will always generate constant ids unless shared resources
>   are being used. And prepare_resources() always generates
>   non-constant IDs, as before the CL.
> 
> + Add documentation for the prepare_resources() and
>   compile_resources() internal GN rules, to make them
>   a little less intimidating.
> 
> + Removed |app_as_shared_lib|, since even before this CL all
>   resources were generated with package ID 0x7f anyway, or
>   fixed a compile_resources() time. Hence |shared_resources|
>   did the exact same thing.
> 
> + Improve --help output for prepare_resources.py and
>   compile_resources.py by using option groups for inputs
>   and outputs.
> 
> R=​agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org
> 
> Bug: 820459
> Change-Id: If05ac24a57c4dfa11f9ce43c30ab22e957b2765d
> Reviewed-on: https://chromium-review.googlesource.com/957095
> Commit-Queue: David Turner <digit@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543957}

TBR=digit@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,estevenson@chromium.org,trevordixon@chromium.org

Change-Id: I38d7922928cc6222750e057bc4a602a1faaec59e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820459
Reviewed-on: https://chromium-review.googlesource.com/968461Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544011}

This patch makes SignedExchangeHandler populate the minimal set of
timing info for the HTTP exchange response, so that devtools' network
timeline will show reasonable values.

Bug: 803774
Change-Id: Ida0d34f7bab86f5ff674b776fe5fca511111c87c
Reviewed-on: https://chromium-review.googlesource.com/967632Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544010}

Change-Id: I2e894379abc801ef364a9228b89e3cc23eaf408c
Reviewed-on: https://chromium-review.googlesource.com/968247
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544009}

last_auth_error_ was set from OnGetTokenFailure, but then never cleared
in onGetTokenSuccess. This meant that the error could stay around, even
if the causing token issue was resolved.

BUG=822182

Change-Id: I135baa55d8e81860313dd02f2ca432f0482c3c10
Reviewed-on: https://chromium-review.googlesource.com/964334
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544008}

As skia font cache, we need to limit the memory usage of skia resource cache
for the low-end device as well. But, as the font cache, it's hard to estimate
what is the limit value the best for each low-end device. So it would be good
if we give them the power to limit to use the resource cache. This CL introduces
a new command line switch to limit the skia resource cache size.

Bug: 823210
Change-Id: Icc55a8701fe2fa94bdc0ee09b428c19031c131a5
Reviewed-on: https://chromium-review.googlesource.com/968006
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544007}

https://webrtc.googlesource.com/src.git/+log/8a1b20a21329..9fa35e528528

$ git log 8a1b20a21..9fa35e528 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id4c6302826bb881e8b31332c5304b354457130c5
Reviewed-on: https://chromium-review.googlesource.com/967951
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544006}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6887bb98..8c5929de

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Id1149be5925c8733c6cf4be6ad75bee0ca955827
Reviewed-on: https://chromium-review.googlesource.com/967953Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544005}

By explicitly closing the keyboard before closing the search, the
keyboard will no longer overlay the visible elements in tests.
The slowly disappearing keyboard hid elements from espresso and failed
some test runs on small screen devices.

Change-Id: I45e6548395a3875e79d9cad6a7655e6d67163d2a
Reviewed-on: https://chromium-review.googlesource.com/966034
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544004}

The former is a deprecated alias.

Bug: None
Change-Id: Ib4c1132135de159a932ebc26454f5df15274e25d
Reviewed-on: https://chromium-review.googlesource.com/966602
Commit-Queue: Niels Möller <nisse@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544003}

This CL implements WorkerModuleFetchCoordinator that actually initiates module
loading on the main thread in response to requests from
WorkerOrWorkletModuleFetcher on the worker thread.

Design doc:
https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn

Bug: 680046
Change-Id: Ib845662436356b2966ed987a88be33ed5dc970f8
Reviewed-on: https://chromium-review.googlesource.com/963874
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544002}

Using wpt-import in Chromium 7b38a1f6.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14159

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
mek@chromium.org:
  external/wpt/webmessaging

TBR=qyearsley

No-Export: true
Change-Id: Ic444f5ba8ab19f1684848838d1b6f7daf7fc61e5
Reviewed-on: https://chromium-review.googlesource.com/967562
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544001}

It seems odd that he's not already in the the OWNERS and is effectively
owner for the virtual/fake stuff already.

Change-Id: I7ad37eb9406539df6a666c4e299d684405c2c3cb
Reviewed-on: https://chromium-review.googlesource.com/967064
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544000}

This CL introduces Editor::Command::CanExecute(), and move the predicate
in Editor::Command::Execute() to it, make Editor::Command::Execute()
simple and improve code health.
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Iae25f9ebd4d7554e83a9a819c562fae85c2dedc6
Reviewed-on: https://chromium-review.googlesource.com/954773Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543999}

This CL change Editor::CreateCommand to be const type for
improving code health.
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I1e17c38f346d07f06cae0e736da0d550eacf3f74
Reviewed-on: https://chromium-review.googlesource.com/965723Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543998}

Right after the target Element gets detached from the document tree,
the last size change event is dispatched to ResizeObserver.  At this
moment, the target Element is already detached from the document and
we cannot rely on the wrapper-tracing path of:
    Document --> Element --> ElementRareData --> ResizeObserver
So, we need another path to perform the wrapper-tracing for
ResizeObserver.

This patch makes ResizeObserver ActiveScriptWrappable, so that the
following path of wrapper-tracing will be available:
    V8 wrapper of ResizeObserver --> blink::ResizeObserver

I confirmed that this patch fixes the crash issue at a certain
website.

FYI: You find some discussion at https://crrev.com/c/960482 .

Bug: 815058
Change-Id: I43c4695304f7f54b819f0c2dfbc4a5a8cf9df8f7
Reviewed-on: https://chromium-review.googlesource.com/964075Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543997}

This is a preparation CL for module scripts on workers.

Before this CL, postMessage() requests during dedicated worker startup are
queued until a worker thread is created and a thread initialization task is
posted to the worker thread. This works for classic scripts because classic
script evaluation happens synchronously after thread initialization and there is
no timing to interleave the message tasks. However, this is not applicable for
module scripts because module script evaluation happens asynchronously on the
worker thread. This allows posted tasks run before script evaluation and results
in dropouts of the Message events.

This CL makes sure to post message tasks after script evaluation. ObjectProxy on
the worker thread notifies MessagingProxy on the main thread of the completion
of script evaluation, and then MessagingProxy posts queued messages.

Bug: 680046
Change-Id: I7cb32cc8911a7bbe9e5d83e5f7fceb333bb3125a
Reviewed-on: https://chromium-review.googlesource.com/967914
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543996}

Generic, platform-independent decoders - {H264,VP8,VP9}Decoder - operate on
generic Picture classes - {H264,VP8,VP9}Picture - and use them to communicate
with platform-specific Accelerators.

Accelerators augment these Picture classes with platform-specific metadata
in order to process them. This includes platform-specific representations
of buffers used as targets for decoding a given picture, such as VASurface
for VaapiVDA.

This platform-specific metadata is encapsulated in Accelerator-specific
{Vaapi,V4L2}DecodeSurface classes.

To tie {Vaapi,V4L2}DecodeSurface to each type of Picture class, a set of
classes: {Vaapi,V4L2}{H624,VP8,VP9}Picture is introduced. They are subclasses
of {H264,VP8,VP9}Picture classes and own {Vaapi,V4L2}DecodeSurface classes.

For VaapiVDA, the relationship is:

{H264,VP8,VP9}Picture
         ^    |
         |     -[owns] -> H264/VP8/VP9 specific metadata
      [is a]
         |
Vaapi{H624,VP8,VP9}Picture
              |
               -[owns]-> VaapiDecodeSurface
                           |
                            -[owns]-> common Picture metadata(visible_rect,...}
                                      platform-specific metadata(VASurface)

In case of V4L2VDA:

{H264,VP8,VP9}Picture
         ^    |
         |     -[owns] -> H264/VP8/VP9 specific metadata
      [is a]
         |
V4L2{H624,VP8,VP9}Picture
              |
               -[owns]-> V4L2DecodeSurface
                           |
                            -[owns]-> common Picture metadata(visible_rect,...)
                                      platform-specific metadata:
                                        ({input,output}_record, config_store...)

However, as {Vaapi,V4L2}{H624,VP8,VP9}Picture are platform-specific already,
we can eliminate one level of ownership indirection by removing
{Vaapi,V4L2}DecodeSurface classes, as well as avoid having the same common
Picture metadata in each of the 6 {Vaapi,V4L2}{H624,VP8,VP9}Picture classes
to further simplify the design:

   CodecPicture
         ^    |
	 |     -[owns] -> common Picture metadata
      [is a]
	 |
{H264,VP8,VP9}Picture
         ^    |
	 |     -[owns] -> H264/VP8/VP9-specific metadata
      [is a]
	 |
Vaapi{H624,VP8,VP9}Picture
              |
	       -[owns] -> platform-specific metadata(VASurface)

Moreover, this will further allow us to reuse the picture classes on all
levels of the hierarchy (including {V4L2,Vaapi}{H624,VP8,VP9}Picture
classes) for the upcoming, new AcceleratedVideoEncoder framework, without
having to create a new set of encoder-only {Vaapi,V4L2}EncodeSurface classes.

Removal of V4L2DecodeSurface is left for a follow-up CL.

BUG=703988
TEST=VDA unittests, video playback in Chrome, video playback in ARC++

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I86f30adf4b5754fffb89eb3769b11d01d8e04814
Reviewed-on: https://chromium-review.googlesource.com/947545
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543995}

Unused for over a year, since:
  https://chromium.googlesource.com/chromium/src/+/a5466f457a195abd0f03066439c0efae3b5e14b0

Change-Id: Ie04f64f9156b71aa78dc498c70997cccbc7817aa
Reviewed-on: https://chromium-review.googlesource.com/966541
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543994}

This reverts commit 827ddeb7.

Reason for revert: crbug.com/823119

Original change's description:
> cc: CHECK surface invariants in LayerTreeHost on all platforms
>
> This is an option now that aura::WindowTreeHost have been fixed
>
> Bug: 818085
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I074ade34758a5005862543549e4bbe69838301b9
> Reviewed-on: https://chromium-review.googlesource.com/959550
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543656}

TBR=ccameron@chromium.org,fsamuel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 818085, 823119
Change-Id: Ib0e66b23c1fb3420a2a6d38e17255e7b01b9e803
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/968161
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543993}

This reverts commit 6af9df3e.

Reason for revert: Caused a regression as outlined in
https://chromium-review.googlesource.com/c/chromium/src/+/957265#message-bfd66cb6916d1397f05a74dd7c1fca4645857147

Original change's description:
> Enable ClientHintsPersistent feature (Accept-CH-Lifetime header).
>
> blink-dev i2s thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/8RBFue7RMXQ/discussion
>
> Change-Id: I5595b3aed72ea0cece88948f69f480f5808fce6b
> Bug: 735518,782381,816661
> TBR: raymes@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/957265
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543786}

TBR=ddorwin@chromium.org,raymes@chromium.org,kinuko@chromium.org,tbansal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 735518, 782381, 816661
Change-Id: I47c42057e7d3158eeb515b993266ce0ff8e937e7
Reviewed-on: https://chromium-review.googlesource.com/968081
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543992}