GitLab

The operator& is dangerous as it makes code unclear what is happening.

For ScopedPropVariant there is already a get() method returning a
const& of the internal type. So doing &foo.get() will get a pointer to
the internal type.

For ScopedVariant, there is only operator&, so replace it with an
operator*() that returns a const&. This changes callsites from doing
something like V_FOO(&scoper) to V_FOO(&*scoper) which makes it clear
that it is getting the address of the thing inside scoper, not the
scoper itself.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985853005

Cr-Commit-Position: refs/heads/master@{#319795}

The purpose of this change is to ensure that if a client knows about an
attachment (i.e. has an AttachmentId or AttachmentIdProto) it will know
the attachment's size even if the attachment has never been available on
the local device.

The idea is that by storing size locally, we can simplify remote storage
management.

Move crc32c out of Attachment now that it's part of AttachmentId.

BUG=464431

Review URL: https://codereview.chromium.org/982883002

Cr-Commit-Position: refs/heads/master@{#319794}

Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.

R=Nico
BUG=464816

Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
Cr-Commit-Position: refs/heads/master@{#319722}

Review URL: https://codereview.chromium.org/985003004

Cr-Commit-Position: refs/heads/master@{#319793}

for store locally checkbox

BUG=464640

Review URL: https://codereview.chromium.org/990543002

Cr-Commit-Position: refs/heads/master@{#319792}

The earlier attempt https://codereview.chromium.org/973123003/ was incorrect. Reverted parts that patch
which changed the WebMouseEventBuilder::Build function to convert from DIP to pixels and back. The initial
conversion from DIP to pixels was not needed as the values are picked up from the Windows message which gives
us these coordinates in pixels.

Changes in this patch are as below:-
1. The WebMouseEventBuilder::Build function has been changed to convert the WebMouseEvent::globalX and globalY values
   to DIP. The other changes in the earlier patch as mentioned above have been reverted.

2. The RenderWidgetHostViewAura::UpdateMouseLockRegion function which executes on Windows was clipping the windows cursor
   to a rectangle in DIPs. We need to convert this rectangle to pixels before calling the ClipCursor API. This was the
   main reason for the lock operation not working correctly.

3. I was seeing a DCHECK in the renderer process in the WebViewImpl::pointerLockMouseEvent function as we were sending
   the mouse leave message. Added code in the CanRendererHandleEvent function in the render_widget_host_view_aura.cc file
   to not send this message if we are in the mouse locked state.

BUG=411634
TEST= The main test case in bug 411634

Review URL: https://codereview.chromium.org/981393002

Cr-Commit-Position: refs/heads/master@{#319791}

r319208 added the Low Box token to PreSpawnTarget. For some reason, this doesn't play well with Windows 10 preview builds, so this CL selectively enables the feature on Windows 8 & 8.1

BUG=464779,455496

Review URL: https://codereview.chromium.org/986933002

Cr-Commit-Position: refs/heads/master@{#319790}

We currently combine clips in the target space of the clip's transform
node. This is incorrect. We want to combine clips in the space of the
transform node's _content_ target space.

BUG=386810

Review URL: https://codereview.chromium.org/991013002

Cr-Commit-Position: refs/heads/master@{#319789}

The two formats GL_LUMINANCE and GL_RED_EXT are now been tested in addition to GL_RGBA.
GL_LUMINANCE and GL_RED_EXT are used for yuv resources that are uploaded by VideoLayerImpl.

BUG=423481

Review URL: https://codereview.chromium.org/974913003

Cr-Commit-Position: refs/heads/master@{#319788}

Note that the "Change" button for selecting the downloads path doesn't do
anything meaningful yet. We still need to figure out how to call into the
C++ layer to display the appropriate picker.

BUG=464785

Review URL: https://codereview.chromium.org/988783002

Cr-Commit-Position: refs/heads/master@{#319787}

BUG=465344
TEST=linux_chromium_clobber_rel_ng does not block new ash_unittests from landing

Review URL: https://codereview.chromium.org/985853004

Cr-Commit-Position: refs/heads/master@{#319786}

Revert of Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce (patchset #1 id:1 of https://codereview.chromium.org/989213003/)

Reason for revert:
Broke at least Win8 GN

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5379/steps/compile/logs/stdio

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/pdfium/samples/pdfium_diff.image_diff_png.obj.rsp /c ../../third_party/pdfium/samples/image_diff_png.cc /Foobj/third_party/pdfium/samples/pdfium_diff.image_diff_png.obj /Fdobj/third_party/pdfium/samples/pdfium_diff_cc.pdb
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) :error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) : warning C4702: unreachable code
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(574) : warning C4702: unreachable code
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/pdfium/samples/pdfium_test.image_diff_png.obj.rsp /c ../../third_party/pdfium/samples/image_diff_png.cc /Foobj/third_party/pdfium/samples/pdfium_test.image_diff_png.obj /Fdobj/third_party/pdfium/samples/pdfium_test_cc.pdb
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) :error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(246) : warning C4702: unreachable code
e:\b\build\slave\win8_gn\build\src\third_party\pdfium\samples\image_diff_png.cc(574) : warning C4702: unreachable code
ninja: build stopped: subcommand failed.

Original issue's description:
> Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce
>
> This brings in:
> 1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder.
> 0700106 Make conversions for CPDF_Link explicit.
> 8842c62 Fix the pdfium component build.
> 5a370d7 Make conversion between CPDF_Dest and its object explicit.
> 7348fae Add gmock to .gitignore
> 624b6c1 Make conversion between CPDF_Action and its dictionary explicit.
> 61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h
> e1671bd Kill off JS_ErrorString type.
> b720d0a Return error information from pdfium to JS.
> 944ccad Do hit tests against Annots in reverse order.
> 5b47dbf Remove unused IDS_ constants from pdfium.
> 3d25502 Pull in gmock for standalone pdfium builds.
> ec61a85 Upgrade openjpeg to revision 2997.
> 42a8ada Implement a delegate for EmbedderTests.
> 57e4c86 Kill off unused IFXJS interface methods.
> 4351ac2 Fix compilation error on Windows.
> f9cfdda Add small flate decode unit test.
> e796478 Kill multi-byte comments in fxet_list.h
> 23f9288 Convert pdfium expected test results to PNG format.
> 0fd53cf Fix GN build after PNG support backport
> ef1e85c Backport PNG output format to origin/master branch.
>
> BUG=445408,457493,PDFIUM:123
>
> Committed: https://crrev.com/608e59f9ceecd5b60ae5e50c4f0da4bc6a7f405e
> Cr-Commit-Position: refs/heads/master@{#319781}

TBR=brettw@chromium.org,thestig@chromium.org,tsepez@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445408,457493,PDFIUM:123

Review URL: https://codereview.chromium.org/996523002

Cr-Commit-Position: refs/heads/master@{#319785}

Improve SpdyHttpUtils::GetUrlFromHeaderBlock() implementation with early
returns.  Get rid of a number of temporary variables that were declared too far
from where they were first used.

Also remove SPDY2-specific code, as SPDY2 is no longer supported in Chromium.

Acknowledgements to Daniel Bratell for suggesting to use append instead of
inline operator+ that would create unnecessary temporary strings, see
https://crrev.com/965773002.

BUG=

Review URL: https://codereview.chromium.org/996483002

Cr-Commit-Position: refs/heads/master@{#319784}

This change is chromium part of
https://codereview.chromium.org/921053003/

And out-of-date TODO is removed as well.

TEST=
BUG=458409

Review URL: https://codereview.chromium.org/983143003

Cr-Commit-Position: refs/heads/master@{#319783}

BUG=none

Review URL: https://codereview.chromium.org/983413005

Cr-Commit-Position: refs/heads/master@{#319782}

This brings in:
1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder.
0700106 Make conversions for CPDF_Link explicit.
8842c62 Fix the pdfium component build.
5a370d7 Make conversion between CPDF_Dest and its object explicit.
7348fae Add gmock to .gitignore
624b6c1 Make conversion between CPDF_Action and its dictionary explicit.
61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h
e1671bd Kill off JS_ErrorString type.
b720d0a Return error information from pdfium to JS.
944ccad Do hit tests against Annots in reverse order.
5b47dbf Remove unused IDS_ constants from pdfium.
3d25502 Pull in gmock for standalone pdfium builds.
ec61a85 Upgrade openjpeg to revision 2997.
42a8ada Implement a delegate for EmbedderTests.
57e4c86 Kill off unused IFXJS interface methods.
4351ac2 Fix compilation error on Windows.
f9cfdda Add small flate decode unit test.
e796478 Kill multi-byte comments in fxet_list.h
23f9288 Convert pdfium expected test results to PNG format.
0fd53cf Fix GN build after PNG support backport
ef1e85c Backport PNG output format to origin/master branch.

BUG=445408,457493,PDFIUM:123

Review URL: https://codereview.chromium.org/989213003

Cr-Commit-Position: refs/heads/master@{#319781}

$ git log 1b7bfeca3..b61a1802f --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-03-09 maruel Ignore command from included .isolate when the current one define a command.
2015-02-26 maruel Reduce ereporter2 spam on file locking on Windows.

R=vadimsh@chromium.org
BUG=440882

Review URL: https://codereview.chromium.org/986423002

Cr-Commit-Position: refs/heads/master@{#319780}

This adds better tracking of free discardable memory in child
processes and the ability to release the memory without having
the browser process purge the memory.

BUG=460995
TEST=content_unittests --gtest_filter=DiscardableSharedMemoryHeapTest.*

Review URL: https://codereview.chromium.org/981403002

Cr-Commit-Position: refs/heads/master@{#319779}

When the render widget is hidden, the hang monitor timeout is explicitly
stopped. However, tasks executed *after* the widget hide signal may
trigger a restart of the hang monitor timeout, e.g., queued input
events. Prevent such restarts when the widget is hidden while
also ensuring the hang monitor restarts when the widget is shown again.

BUG=458594

Review URL: https://codereview.chromium.org/938123003

Cr-Commit-Position: refs/heads/master@{#319778}

Revert of [Andorid] ClipDrawable progress bar experiment. (patchset #2 id:20001 of https://codereview.chromium.org/960733002/)

Reason for revert:
Although ClipDrawableProgressBar showed some perf improvement on blink_perf.svg, it didn't show any meaningful difference on page_cycler.top_10_mobile test.

Original issue's description:
> [Andorid] ClipDrawable progress bar experiment.
>
> Recently it was discovered that ClipDrawable is much faster than our
> default ToolbarProgressBar on content shell.
>
> So we plan to experiment with ClipDrawable based progress bar
> implementation.
>
> BUG=455891
>
> Committed: https://crrev.com/b13144e2f2b4ac80f81cee8ce4d4c7f4831b625e
> Cr-Commit-Position: refs/heads/master@{#318292}

TBR=dtrainor@chromium.org,jaekyun@chromium.org
NOPRESUBMIT=false
NOTREECHECKS=false
NOTRY=false
BUG=455891

Review URL: https://codereview.chromium.org/994753002

Cr-Commit-Position: refs/heads/master@{#319777}

BUG=417532

Review URL: https://codereview.chromium.org/983963002

Cr-Commit-Position: refs/heads/master@{#319776}

Previously, the websocket was disconnected in __del__, whose timing was
non-deterministic. Now the websocket is disconnected as soon as its owner
(typically devtools_client_backend) no longer wants to keep track of it.

BUG=461153

Review URL: https://codereview.chromium.org/980043003

Cr-Commit-Position: refs/heads/master@{#319775}

Revert of Add policy_templates target for GN. (patchset #4 id:60001 of https://codereview.chromium.org/957283003/)

Reason for revert:
Possibly broke some GN builds (reverted with https://codereview.chromium.org/865573002), e.g.:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/11092/steps/compile/logs/stdio

ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got 'gen/chrome/app/policy/linux/examples/chrome.json'

Original issue's description:
> Add policy_templates target for GN.
>
> BUG=462362
>
> Committed: https://crrev.com/982eb90bf74535cbe5e21c4eacb759c42ff424d4
> Cr-Commit-Position: refs/heads/master@{#319759}

TBR=pneubeck@chromium.org,bauerb@chromium.org,knn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462362

Review URL: https://codereview.chromium.org/992863002

Cr-Commit-Position: refs/heads/master@{#319774}

Revert of Add i18n support for Android App Restrictions. (patchset #7 id:120001 of https://codereview.chromium.org/865573002/)

Reason for revert:
Broke some GN builds, e.g.:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/24483/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/11092/steps/compile/logs/stdio

ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: expected depfile 'gen/chrome/policy_templates.d' to mention 'gen/chrome/app/policy/common/html/am/chrome_policy_list.html', got 'gen/chrome/app/policy/linux/examples/chrome.json'

Original issue's description:
> Add i18n support for Android App Restrictions.
>
> GYP target policy_templates is now enabled for android as well.
> Remove code that generated Policy resources w/o translation for Android.
>
> roll grit 186:187
>
> 187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.
>
> Depends on:
> https://codereview.chromium.org/865563002
>
> BUG=450548
>
> Committed: https://crrev.com/cd9f7d3afef0d0d4054318e9999aee879eaf26e1
> Cr-Commit-Position: refs/heads/master@{#319758}

TBR=bauerb@chromium.org,bartfab@chromium.org,knn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450548

Review URL: https://codereview.chromium.org/992853002

Cr-Commit-Position: refs/heads/master@{#319773}

This is a target I converted to GN and it is known to run fine.

Tested on Linux with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn device_unittests
$ out-gn/device_unittests

BUG=None
TEST=see above
R=dpranke@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/990653002

Cr-Commit-Position: refs/heads/master@{#319772}

Those filters are generic to non-Android ARM platforms, and should be
available to all products.

BUG=

Review URL: https://codereview.chromium.org/986673003

Cr-Commit-Position: refs/heads/master@{#319771}

Removing [Reset tracking data] was approved by jar@. It was never fully implemented (only for the browser process) and is superseded by taking and comparing snapshots in chrome://profiler tab.

BUG=456354

Review URL: https://codereview.chromium.org/980333004

Cr-Commit-Position: refs/heads/master@{#319770}

Start upstreaming Layout/LayoutManager files.

BUG=428821

Review URL: https://codereview.chromium.org/987883002

Cr-Commit-Position: refs/heads/master@{#319769}

ChildProcessConnectionImpl.mAlwaysInForeground is used
for the GPU process and indicates that it does not participate
in hiding like renderers. The 'important' binding gives it the
same priority as the main application, so upon termination we
should just use the app's foreground status to determine whether
the GPU process was in the foreground or not.

BUG=462422

Review URL: https://codereview.chromium.org/987193003

Cr-Commit-Position: refs/heads/master@{#319768}

Advertise "h2" token with ALPN and accept "h2" token in NPN.  This is the final,
almost-published version of HTTP/2.

Add "h2" to relevant tests.

Also add placeholder values (in comment) for drafts 16 and 17.  They might be
used for testing, or for collecting statistics about servers in the wild (not to
be released on Stable channel though).

BUG=401166

Review URL: https://codereview.chromium.org/987123002

Cr-Commit-Position: refs/heads/master@{#319767}

Having 'using' declarations in header files polutes the global
namespace and that is not what we want.

BUG=438860
R=piman@chromium.org

Review URL: https://codereview.chromium.org/972713002

Cr-Commit-Position: refs/heads/master@{#319766}

Tested with the following command lines on Linux:

$ gn gen out-gn
$ ninja -C out-gn native
$ ninja -C out-gn gpu/gles2_conform_support/native
$ gn check out-gn //gpu/gles2_conform_support/native/*

BUG=432959
TEST=see above
R=dpranke@chromium.org,sievers@chromium.org

Review URL: https://codereview.chromium.org/992463002

Cr-Commit-Position: refs/heads/master@{#319765}

Use linked hash map for broken alternative service queue in
HttpServerPropertiesImpl.  This container has efficient lookup by key, allowing
us to use it as the definitive set of broken alternative services in an upcoming
CL.

Also rename broken_alternate_protocol_map_ to
recently_broken_alternative_services_ for consistency and because it makes more
sense.

BUG=392576

Review URL: https://codereview.chromium.org/989253005

Cr-Commit-Position: refs/heads/master@{#319764}

BUG=392576

Review URL: https://codereview.chromium.org/986413003

Cr-Commit-Position: refs/heads/master@{#319763}

Some old devices are getting lollipop update without updated drivers.

BUG=

Review URL: https://codereview.chromium.org/982153002

Cr-Commit-Position: refs/heads/master@{#319762}

Because for each overscroll session, OverscrollStarted() and
OverscrollCompleted() (in TouchEditableImplAura) are not necessarily
called the same number of times, TouchEditableImplAura could be stuck in
a state of thinking that there is always an scroll in progress which
prevents handles from appearing after a long-press.

BUG=430176

Review URL: https://codereview.chromium.org/963103003

Cr-Commit-Position: refs/heads/master@{#319761}

Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (patchset #2 id:20001 of https://codereview.chromium.org/986743004/)

Reason for revert:
I think this CL is responsible for tree closing compile failure https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26672/steps/compile/logs/stdio.

Original issue's description:
> [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.
>
> In this change:
> - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
> - Remove AttachmenService::GetStore. Now attachment store is owned by
>   model type, there is no need to get it from AttachmentService
> - Introduce AttachmentReferrer. There is no functionality behind it yet
>   and interface is not complete for it. These will come in the next change.
>
> BUG=457735
> R=maniscalco@chromium.org
> TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)
>
> Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847
> Cr-Commit-Position: refs/heads/master@{#319733}

TBR=maniscalco@chromium.org,cjhopman@chromium.org,pavely@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457735

Review URL: https://codereview.chromium.org/996473005

Cr-Commit-Position: refs/heads/master@{#319760}

BUG=462362

Review URL: https://codereview.chromium.org/957283003

Cr-Commit-Position: refs/heads/master@{#319759}

GYP target policy_templates is now enabled for android as well.
Remove code that generated Policy resources w/o translation for Android.

roll grit 186:187

187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.

Depends on:
https://codereview.chromium.org/865563002

BUG=450548

Review URL: https://codereview.chromium.org/865573002

Cr-Commit-Position: refs/heads/master@{#319758}

All clients have switched to the new method.

BUG=461148

Review URL: https://codereview.chromium.org/996493002

Cr-Commit-Position: refs/heads/master@{#319757}

The test actually didn't test anything. Calling sock1.reset() would cause the
socket to disconnect before tlslite completed the handshake. tlslite doesn't
insert the session into the session cache.

This is a preparatory CL to get the tests in shape before reworking the session
cache implementation.

BUG=454044

Review URL: https://codereview.chromium.org/988223004

Cr-Commit-Position: refs/heads/master@{#319756}