Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Aug, 2018 13 commits
  3. 12 Aug, 2018 19 commits
  5. 11 Aug, 2018 8 commits
    • Christian Biesinger's avatar
      [layoutng] Cache min/max content size in ComputeInlineSizeForFragment · 3b8c952b
      Christian Biesinger authored 
      This also required fixing the relayout when the scrollbar changes, which fixes
css3/flexbox/scrollbars-auto.html (and avoids breaking two tests in
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox)

Bug: 635619

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I790f0524b029a3c2340b6b9715c5b3529c75357f
Reviewed-on: https://chromium-review.googlesource.com/1162657
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582464}
      3b8c952b
    • David Black's avatar
      Finishes Assistant container opt in UI. · fb68785c
      David Black authored 
      AssistantOptInView visibility state is synced to the user's consent
state as known by VoiceInteractionController. Note that it is possible
for VoiceInteractionController to get out of sync (b/111882861).

This CL also:
- Animates footer entry on Assistant launch.
- Animates transition of footer views when consent is granted/revoked.

See bug for demo.

Bug: b:111315696
Change-Id: I848c1301e13795711e8e1ff5916ac8e4020f4c0b
Reviewed-on: https://chromium-review.googlesource.com/1171853Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#582463}
      fb68785c
    • Xianzhu Wang's avatar
      Remove "objectPaintInvalidations" from repaint layout test results · ef7fb7cc
      Xianzhu Wang authored 
      Object (DisplayItemClient) paint invalidation has not been very
useful in layout tests (we care more about raster invalidations),
and should be better tested with unit tests. Removing them from
repaint layout test results can reduce rebaselines.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a01f025013734f788d199adc3fed4d02859b7d2
Reviewed-on: https://chromium-review.googlesource.com/1170037
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582462}
      ef7fb7cc
    • David Black's avatar
      Remove AssistantScreenContextSubscriber. · 9718bc14
      David Black authored 
      This was previously created to send contextual HTML cards from
AssistantManagerServiceImpl to AssistantScreenContextController. Now,
thanks to changes in Libassistant, contextual cards will flow through
our existing AssistantInteractionSubscriber.OnHtmlResponse pipeline.

This interface is no longer necessary.

Bug: b:112113187
Change-Id: Iccc11fdd92ce8144650038b487e735f28a3de98b
Reviewed-on: https://chromium-review.googlesource.com/1171722
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: default avatarMuyuan Li <muyuanli@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582461}
      9718bc14
    • James Robinson's avatar
      build: Default optimize_for_size to true for Fuchsia · 7606d7c4
      James Robinson authored 
      Fuchsia cares about binary size, like iOS and Android. This configures
the default build to -Oz instead of -O2.  This reduces the size of text
segment of the service_exe webrunner executable by about 13% when
building for ARM64 release mode non-component:

O2:
   text    data     bss     dec     hex filename
83509089        3370852 1109788a 87989729        53e9de1 out/fuchsia_arm64/exe.unstripped/service_exe

   text    data     bss     dec     hex filename
73707333        3398764 1110516 78216613        4a97da5 out/fuchsia_arm64/exe.unstripped/service_exe

Oz: 
Change-Id: I09774eb71f690a483f3f6064cace265a7f7f80e6
Reviewed-on: https://chromium-review.googlesource.com/1171864Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582460}
      7606d7c4
    • David Black's avatar
      Add from_user param to screen context requests. · 8ed6a68a
      David Black authored 
      This parameter is needed to distinguish between user initiated requests
and requests that we make ourselves.

User generated requests initiate a conversation interaction that will
return contextual cards. This may result from a suggestion chip press
or Assistant stylus tool selection.

Requests that do not originate from the user will not return contextual
cards or start a conversation interaction. Instead, we will cache the
screen context to send alongside subsequent voice/text queries for
context. This portion is not yet wired up.

Bug: b:112113187
Change-Id: I12cd531745d174738988808d7637c8529ddd80d0
Reviewed-on: https://chromium-review.googlesource.com/1170428
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582459}
      8ed6a68a
    • David Bokan's avatar
      Reland "[RootScroller] Allow main document horizontal overflow" · 801a32fc
      David Bokan authored 
      This is a reland of ace3f1f7

Original change's description:
> [RootScroller] Allow main document horizontal overflow
>
> When implicitly promoting an element to be the root scroller, we first
> check if the main document has any overflow. If it does, we err on the
> side of not promoting since it is likely the main document's content is
> important and meant to be scrollable.
>
> This heuristic turns out to be too restrictive. For example, this makes
> it hard to build a root scrolling carousel. This CL loosens the
> restriction to allow horizontal overflow.
>
> Bug: 838683
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a
> Reviewed-on: https://chromium-review.googlesource.com/1165859
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581408}

Bug: 838683
Change-Id: I886908a56db7a463c619135ed08712312ccacbfc
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
TBR: bokan, dtapuska
Reviewed-on: https://chromium-review.googlesource.com/1171717
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582458}
      801a32fc
    • Kevin Marshall's avatar
      [fuchsia] Fix deletion threading for sandbox policy's ServiceDirectory. · 42b4e9ec
      Kevin Marshall authored 
      SandboxPolicyFuchsia is not thread affine but its ServiceDirectory
is not. This CL schedules the ServiceDirectory's deletion on the
same thread that was used for its construction.

Change-Id: I98e950481e49106ba64c759cef2c903b5dcf5d3b
Reviewed-on: https://chromium-review.googlesource.com/1171673Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582457}
      42b4e9ec