GitLab

These tests are command line tests which may use the same isolate and binary,
but with different permutations of command line arguments. This allows us to
run the same test suite with multiple sets of arguments. This is useful for
testing chromium-based tests that don't want to launch child processeses from
a single test, but rather run different permutations of the same test binary.

New tests added for the new functionality and for the previous "c plus plus"
isolate test functionality.

BUG=angleproject:2188

Change-Id: I97434db67ffbd9fc75edb712f6706543c7a5af54
Reviewed-on: https://chromium-review.googlesource.com/743683
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#512675}

Original CL: https://chromium-review.googlesource.com/737877

This CL avoids erroneous array bound checks in the standard algorithm
library.

This is a preparation for AVX optimization of blink::VectorMath
functions.

Bug: 778262
Change-Id: Ifc8465644a048cd0815c993dd824bdf62d04415a
Reviewed-on: https://chromium-review.googlesource.com/744005Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#512674}

By David Dorwin request.

Bug: None
Change-Id: Ie06397c5d14db8260983f71aec405c0c07f66923
Reviewed-on: https://chromium-review.googlesource.com/740687Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Cr-Commit-Position: refs/heads/master@{#512673}

https://pdfium.googlesource.com/pdfium.git/+log/d2d4df84d3c2..d6e9cfaab055

$ git log d2d4df84d..d6e9cfaab --date=short --no-merges --format='%ad %ae %s'
2017-10-30 dsinclair Convert JS resource into enum class
2017-10-30 art-snake Remove useless code.
2017-10-30 hnakashima Deduplicate md5s in fpdfannot_embeddertest.cpp for Windows and others.
2017-10-30 art-snake Use CPDF_PageDataAvail to check page availability.
2017-10-30 dsinclair Rename global data files to match contents
2017-10-30 dsinclair Move fpdfsdk/javascript to fxjs/
2017-10-30 thestig Combine common code in fpdf_transformpage.cpp.
2017-10-30 art-snake Use CPDF_PageDataAvail to check page resources availability.
2017-10-30 dsinclair Rename util to cjs_util
2017-10-30 art-snake Use CPDF_PageDataAvail to check form availability.
2017-10-30 npm More safe ints in CJBig2_TRDProc
2017-10-30 dsinclair Move resource to js_resource

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I4614921a455668308342f45894b3bffd2ed2b17c
Reviewed-on: https://chromium-review.googlesource.com/744737
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512672}

MainController's -topPresentedViewController is deprecated. It performs a walk
from the bottom of the VC hierarchy to the top most VC. But this walk is
not necessary when the presenting VC is known.

In most cases, the presenting VC is known so the VC hierarchy walk is not 
necessary. We can pass the presenting VC through the dispatcher.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I69f9dd45ae5b55c9cfe95a56d014c11a7390f8fa
Reviewed-on: https://chromium-review.googlesource.com/705635
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512671}

Enabling the checkout requires setting
    "custom_vars": {
      "checkout_libaom": True,
    },

in .gclient solutions[]

BUG=aomedia:937

Change-Id: I70e4e847a16155080016d090f8bca293e871a225
Reviewed-on: https://chromium-review.googlesource.com/726469
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512670}

When the URL defocus animation is running and the BottomSheet is open,
setting end margin on the location bar for the URL actions container
results in a blank space. Set the end margin to 0 at the beginning of
on the defocus animation rather than at the end.

BUG=752597

Change-Id: I55c6ec574966ec6b8ce3981d9afa0f7e7d2765d2
Reviewed-on: https://chromium-review.googlesource.com/744968Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512669}

I generally don't do reviews in chrome. There's a bunch of reviewers in
there already.

TBR=tedchoc

Change-Id: Id66fc37fbdf055418f22c90ddc8595bd7ef81093
Reviewed-on: https://chromium-review.googlesource.com/744596Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512668}

When handling a gesture on the compositor thread, we may checkerboard
tiles if no rasterized resource is available for them. This is currently
captured in Compositing.RenderPass.AppendQuadData UMA. This change adds
an equivalent UKM to capture this metric per site.

Since checkerboarding should only occur from input handled on the
compositor thread, the stats are accumulated only when we are actively
running an animation resulting from user input. In order to limit the
frequency with which the metric is recorded, the stats are accumulated
over the gesture duration and emitted when exiting it.

R=ajuma@chromium.org, vmpstr@chromium.org

Bug: 728273
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1c47215963966f32f3c7d0f69661c87b21558ebb
Reviewed-on: https://chromium-review.googlesource.com/734134Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512667}

See mount failure in e.g. https://ci.chromium.org/buildbot/tryserver.chromium.linux/fuchsia_arm64/13

Bug: 772031
Change-Id: Ic97e190754e1569b14c0d4643b3d6481fe539f5f
Reviewed-on: https://chromium-review.googlesource.com/744991Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512666}

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c6cae22e85a75b0f288e356b1df73f254fe3795
Reviewed-on: https://chromium-review.googlesource.com/741926
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512665}

This reverts commit 33bb6c6a.

Reason for revert: This is causing an issue with crashes, crbug/779437, and causing the #1 renderer crash in Canary. 

[Assert] ui::Gpu::EstablishGpuChannelSync

Confirmed with kenrb@ and it's okay to revert this. 

Original change's description:
> Introduce CompostingModeWatcher interface for global coordination.
> 
> Makes a CompositingModeReporter mojo API that is implemented in the viz
> process (which is the browser in this CL). The API allows registering a
> CompositingModeWatcher which hears about compositing mode fallback from
> gpu to software.
> 
> Tracks the compositing mode in GpuProcessTransportFactory and ensures
> that decisions to use software compositing are sticky and global. Gives
> the current compositing state to new renderers on the command line.
> Tracks the compositing mode in RenderThreadImpl, based on the command
> line and from being a CompositingModeWatcher, and ensures that the
> compositing mode there is also sticky and global.
> 
> Exposes the real compositing mode to blink via the Platform API instead
> of just exposing the state at startup (ie the command line flag).
> 
> No longer tries to fall back to software compositing in the renderer
> process as a local decision. Tries gpu compositing indefinitely until
> hearing otherwise from being a CompositingModeWatcher.
> 
> Bug: 772574
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I1801010d1659135e815ca24960651e0f87d70c1c
> Reviewed-on: https://chromium-review.googlesource.com/714365
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512347}

TBR=sadrul@chromium.org,danakj@chromium.org,kenrb@chromium.org,boliu@chromium.org,pdr@chromium.org,piman@chromium.org
NOTRY=true

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 772574
Change-Id: Ie43594c265a196e0e354d90c1a7eca0e1ed50870
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/744881Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512664}

video_VideoDecodeAccelerator verifies a thumnail test result by comapring md5sum.
Because of mesa update, the resulted md5sum becomes different from
an expected value.
So there is a need to update these md5sum values to fix the test failure.

cf. mesa update url: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4540d37c6974d2f31bc5e596a272c3804fe12c96

BUG=chromium:779482
TEST=video_VideoDecodeAccelerator

Change-Id: If92ec955d177d3e0899f041f8e5c6e2a75289fc5
Reviewed-on: https://chromium-review.googlesource.com/742830Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512663}

Renaming per go/local-screens-design-doc, to share the presentation manager between offscreen and wired display presentations.

Bug: 758005
Change-Id: Ia9e0f2c110aaabad65c243063fff45ff405374d1
Reviewed-on: https://chromium-review.googlesource.com/734312Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512662}

Bug: 764126
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I10e75f00e152c7ae6314e4671fca8f6c601bdf65
Reviewed-on: https://chromium-review.googlesource.com/740573
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512661}

Exposes all current window titles, message bodies and cancel-button
text.

Also fixing crash when DownloadDangerPromptViews is destructed without
triggering an action. This happens at least when browser_tests are run
without --interactive, though possibly also when a tab gets closed
without closing the dialog first.

Bug: chromium:654142
Change-Id: I7339ffec27cb41d50ddc97aece2ca4fdf403cbb5
Reviewed-on: https://chromium-review.googlesource.com/731617
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512660}

Once ag/3121293 is submitted, we can safely drop the about: support.

BUG=b:67758218
TEST=try

Change-Id: Ifc08fd3daac84ffc5923c642e3fa200c4efe9bd7
Reviewed-on: https://chromium-review.googlesource.com/736314
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512659}

A new mojo pipe is added from blink::GamepadDispatcher to
device::GamepadHapticsManager to communicate haptics commands (play
effect, reset vibration).

BUG=749295

Change-Id: I20400aaca30165133a4b892e900f171e3bd48eda
Reviewed-on: https://chromium-review.googlesource.com/723848
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512658}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6837c2a8ad051165c928ec0104d21012a725eed8
Reviewed-on: https://chromium-review.googlesource.com/740921Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512657}

Also stops propagation if the checkbox is clicked to prevent the default
click handler from unchecking the box.

Bug: 762441
Change-Id: I6a304221d1c9ae52d592645d430c61fa621741c2
Reviewed-on: https://chromium-review.googlesource.com/744340
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512656}

It is currently disabled but most of the mechanics to create this
are hooked up. This patch should have no behavior change.

Make the TabStripModelOrderController refer to the Impl and not the
abstract TabStripModel base since it's really a part of the
implementation. This allows a number of ordering-related functions
to be moved only to the Impl.

Remove comments in tab_strip_model_impl.h that duplicate those in
tab_strip_model.h. Make ConstrainInsertionIndex private since it was
not used by any external caller.

Bug: 778461
Change-Id: I63fa9dcbf62a02ff332c73234b457d33b81d9667
Reviewed-on: https://chromium-review.googlesource.com/742642Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512655}

This patch:
1. Added CU relation manipulation methods in mojo interface and public APIs;
2. Created one type of *ResourceCoordinator for each coordination unit type;
3. Removed generic CoordinationUnit mojo interface and implementation;
4. Replaced every call of SetProperty and SendEvent with new public APIs;
5. Added more tests.

BUG=775691

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I10b5c6a5ce9d8f0fbe3c2c3afef4ee4da7da0757
Reviewed-on: https://chromium-review.googlesource.com/736036
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512654}

ProfileInfoHandler::GetAccountNameAndIcon expects
chromeos::UserImageSource::GetUserImage to return a PNG
image so webui::GetPngDataUrl can be used to create a
profile icon data url from it that can be used by WebUI.

This change makes UserImageSource::GetUserImage always
return a PNG image so that the assumptions made in
GetAccountNameAndIcon are correct.

JPEG images with image/png mime type happen to work
previously as Blink will ignore the mime type and look
at the image signature to determine how to decode it.
The code that was introduced to remove animations from
PNG images is not that smart.

Bug: 779042
Test: manual
Change-Id: Ib33821f9a25d38626aa939b2540b2a77487de4dc
Reviewed-on: https://chromium-review.googlesource.com/744907Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512653}

https://skia.googlesource.com/skia.git/+log/228da62fa791..45d6303f6e84

$ git log 228da62fa..45d6303f6 --date=short --no-merges --format='%ad %ae %s'
2017-10-30 egdaniel Have mip status match surface when snapping image from wrapped object
2017-10-30 mtklein make color rotating a little less pointlessly slow
2017-10-30 egdaniel Add mip support to GrAHardwareBufferImageGenerator
2017-10-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 55bc905f0..e7c5f4f05 (2 commits)
2017-10-30 robertphillips Revert "Revert "Fix Debian9-Clang build""
2017-10-30 robertphillips Revert "Revert "Fix GrDefaultPathRender inversely wound path bug""
2017-10-30 robertphillips Suppress Gr*PathRendererTests on Vulkan NexusPlayer and Iris 540
2017-10-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 87c358839..55bc905f0 (1 commit)
2017-10-30 liyuqian Initialize mask to 0 during AntiRect optimization
2017-10-30 ethannicholas fix skslc splitting escape sequences in half
2017-10-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 65c56dd94..87c358839 (1 commit)
2017-10-30 mtklein remove SkThread, using std::thread instead
2017-10-30 caryclark generated include refresh
2017-10-30 kjlubick Update Pixel Cs to new version
2017-10-28 fmalita Remove gradient SkFixed position records
2017-10-30 angle-deps-roller Roll skia/third_party/externals/angle2/ 2a35741bd..65c56dd94 (1 commit)
2017-10-30 robertphillips Revert "Fix GrDefaultPathRender inversely wound path bug"
2017-10-30 robertphillips Revert "Fix Debian9-Clang build"
2017-10-30 liyuqian Do not TryBlitFatAntiRect if isInverse
2017-10-30 bsalomon Remove deferred upload types from GrDrawOp.h.
2017-10-27 bsalomon Add GrTextUtils::Target

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I8871ce71d2527eec149d1ab1b1f1b0897b3f4413
Reviewed-on: https://chromium-review.googlesource.com/744728Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512652}

Two notable changes:
 . Do not immediately destroy the GLContextGLX when MakeCurrent() fails.
   This follows the pattern in GLContextEGL, where MakeCurrent() does
   not immediately destroy the context on failure.
 . Notify TextureManager about lost context early during tear down. This
   is necessary because FramebufferManager is destroyed first, and
   during its destruction, some gpu::gles2::Texture objects can be
   destroyed. But TextureManager is destroyed later, and is notified of
   the lost context only during destruction. As a result, Texture
   destruction does glDeleteTextures() while there's no context, causing
   a crash.

BUG=777594

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I664e43c297cded17c223d3ee1ac4e32ca28ffd42
Reviewed-on: https://chromium-review.googlesource.com/734945
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512651}

Update chromeos::PowerManagerClient to notify its observers
about ScreenIdleStateChanged D-Bus signals. Also pass along
reasons from SuspendImminent signals.

TBR=stevenjb@chromium.org

Bug: 778449
Change-Id: Ieb19e055050416ff38d79ae46d580c35ce64db51
Reviewed-on: https://chromium-review.googlesource.com/742626
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512650}

This CL deletes some redundant text from the experimental web request page
available at https://developer.chrome.com/extensions/experimental_webRequest.

BUG=None

Change-Id: Id1dfc316f74168688cca7da2a2790b7f70fff9c6
Reviewed-on: https://chromium-review.googlesource.com/744427Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512649}

Moves setWebUsageEnabled to BrowsingDataRemovalController from
MainController. This is an intermediate step in order to remove Clear
browsing data code from MainController.


Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I06074b01635d655fb4acad8cb53795a8296b36ee
Reviewed-on: https://chromium-review.googlesource.com/679014
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512648}

Bug: 775703
Change-Id: Id56b1abd8355667d93a4d5b612af6e7a08a3577e
Reviewed-on: https://chromium-review.googlesource.com/743144Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512647}

BUG=768563

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4865db1b9b295532b53da3da1430cb59a2b4e2a0
Reviewed-on: https://chromium-review.googlesource.com/742081
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512646}

Scanout has a precise meaning and is something that we explicitly
control on ChromeOS only. Rename this method to avoid confusion.

R=reveman
BUG=NONE

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib551a7c810ffeb3e7c5bad8e974477daae3012a8
Reviewed-on: https://chromium-review.googlesource.com/737129
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512645}

Bug: 772031
Change-Id: I9aa7df5c39537b5866f3f35c4c1765f54dc2d7be
Reviewed-on: https://chromium-review.googlesource.com/744262
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512644}

Exposes GetContentsBounds() alongside GetLocalBounds() when they are
different. This visualizes inset usage inside views and can show why
some content may be clipped.

Bug: None
Change-Id: I2f1269fc2b2f93c8c4ba3fd5455fd7f070fffc5a
Reviewed-on: https://chromium-review.googlesource.com/741687Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512643}

With this CL, calls to Process::WaitForExit*() must be done
within the scope of a base::ScopedAllowBaseSyncPrimitives*.

Since calls to Process::WaitForExit*() can potentially
deadlock, it is desirable to have them reviewed by a //base
OWNER.

Bug: 766678
Change-Id: I1d5cc98984b84a412492db5f83c8db4b20396367
Reviewed-on: https://chromium-review.googlesource.com/703475
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512642}

PK11_FindKeyByAnyCert retains wincx on the resulting SECKEYPrivateKey,
which may be used on PK11_Sign. To keep the lifetimes correct, we must
retain a reference to the password delegate in SSLPlatformKeyNSS.

Bug: 779090
Change-Id: Ia769ebe967582e83fbcbcaa5bca7ef788c1345a6
Reviewed-on: https://chromium-review.googlesource.com/743847Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512641}

Bug: 684616
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If162f88f88e455a1115a72da8d9c6508fcea5d90
Reviewed-on: https://chromium-review.googlesource.com/742746
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512640}

When the settings button in a notification popup is clicked, the notification
is activated and hidden almost at the same time.
In such case, the notification is deactivated without OnWindowActivated for
the activation being called.

We have to manually ignore such case in TrayBubbleWrapper::OnWindowActivated.

TEST=manual
BUG=778973

Change-Id: I90802a99a64bd8a9d8de56e48735e0fd7abe6ed6
Reviewed-on: https://chromium-review.googlesource.com/740928Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512639}

For valid repaint text differences and invisible subpixel differences.

TBR=wangxianzhu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I86bdfbbe92ce36e2cd5705eb8211d492e7c3e6b4
Reviewed-on: https://chromium-review.googlesource.com/744970
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512638}

This requires filtering out some tests:
- Some PartitionAllocTests which fail under ARM64, and were just
  being skipped under x64.
- BuildTime.InThePast which current fails under ARM64.

Bug: 772031, 779645, 779668
Change-Id: Ic764f276d8298bf309c815af6b60eed4ea5d3c4f
Reviewed-on: https://chromium-review.googlesource.com/744315
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512637}

Currently, we populate website data metadata for sites which activate
as ENABLED. This metadata is used to trigger showing the "Ads" setting
in the settings UI, OIB, and page info.

However, we also activate as ENABLED for warning sites, and decrease
activation level downstream in the driver factory. This means that
warning sites will show up in the various settings UIs as having
intrusive ads.

This CL makes it so that warning sites do not populate the metadata. 

Bug: 779673
Change-Id: I972faf6aeda6884b584c8383918fa7a9ba966b6c
Reviewed-on: https://chromium-review.googlesource.com/744442Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512636}