- 16 Sep, 2020 40 commits
-
-
Hiroki Nakagawa authored
For code simplification, this CL replaces WebPrerenderRelType with mojom::PrerenderRelType. Before this change, WebPrerenderRelType was represented as bit-field. This is because it was allowed to specify both "prerender"[1] and "next"[2] types at the same time in the link rel attribute like <link rel="prefetch next">. However, in that case, "prerender" is just prioritized[3], so it was unnecessary to keep both the types in the bit-field. Therefore this CL introduces the mojom::PrerenderRelType as enum instead of bit-field. This would make code simpler and more readable. [1] https://html.spec.whatwg.org/C/#link-type-prerender [2] https://html.spec.whatwg.org/C/#link-type-next [3] https://source.chromium.org/chromium/chromium/src/+/master:components/prerender/browser/prerender_manager.cc;l=177;drc=ee49bcdf8e3a7764fa22b8e9d1ec1d0c9332870f Bug: n/a Change-Id: Ida2957a659c7578930bdeac136c72ebc8cacb8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409890Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#807396}
-
Joanmarie Diggs authored
AXLayoutObject::TextAlternative calls LayoutText::PlainText which has special handling for generated content which depends on TextBoxes returning a non-empty InlineTextBoxList. But if we're in a Layout NG context, an empty list is returned so AXLayoutObject::TextAlternative falls back on the LayoutObject's text which includes whitespace that is not included in the child AXInlineTextBox. Because the AXPosition which corresponds with the end of the generated content is at the end of the child kInlineTextBox, but not at the end of the kStaticText parent, we were hitting an infinite loop between AXPosition::CreateParentPosition and AXPosition::AtStartOfLine. The infinite loop was fixed in http://crrev.com/c/2369681. But we still need LayoutText::PlainText's special handling for generated content to work regardless of which layout engine is being used, and for the text exposed via accessibility APIs to not include collapsed whitespace from generated content. Because we can get the TextBoxInfo regardless of the layout engine, use that instead of the actual InlineTextBox instances in LayoutText::PlainText to fix both issues. AX-RelNotes: N/A Bug: 1122637 Change-Id: Ic5a99a92e05bcd751f8ecd2aa236350c909ebe35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395719 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807395}
-
sandromaggi authored
This removes a possible asynchronous state when an out-of-loop write to the |UserData| happens. This may be caused by a PDM update. Check Patchset 1 for a test case that shows such a failure. Bug: b/168445878 Change-Id: Iae9fb3aa823d1c6e64acd598a1b31be587c0493c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410036Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#807394}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/726af6f78f80..e8ce4355ae1c 2020-09-15 andreperezmaselco.developer@gmail.com spirv-fuzz: Add bit instruction synonym transformation (#3775) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Skip unreachable blocks (#3729) 2020-09-15 afdx@google.com Fix build errors (#3804) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Handle invalid ids in fact manager (#3742) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Support memory instructions MoveInstructionDown (#3700) 2020-09-15 stefanomil@google.com spirv-fuzz: Pass submanagers to other submanagers when necessary (#3796) 2020-09-15 stefanomil@google.com spirv-fuzz: Transformation to flatten conditional branch (#3667) 2020-09-14 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Add BaseInstance, BaseVertex, DrawIndex, and ViewIndex (#3782) 2020-09-14 dnovillo@google.com Properly mark IR changed if instruction folder creates more than one constant. (#3799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I5dfd8b4c49b7783fd25f375eacba608e766ab12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807393}
-
Boris Sazonov authored
Plumbs OnGaiaCookieDeletedByUserAction through JNI and exposes it to the Java code. Bug: 1095112 Change-Id: I0e47a48ba26f70c3e5d9706dca0904974ea2b852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410256Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807392}
-
sauski authored
Bug: 1081866 Change-Id: I8d472c78e4251c3549b24ee4eda01a20f97df75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404925Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#807391}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I95e88c9c5592c1425f2a3ded0b59d72c6a1bd0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410397 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807390}
-
Hidehiko Abe authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe26e5..d7eebbfb276a $ git log 79326efe2..d7eebbfb2 --date=short --no-merges --format='%ad %ae %s' 2020-09-16 hidehiko icu: Expand is_linux to is_linux || is_chromeos. 2020-09-11 fdegans [fuchsia] Bring more changes from the Fuchsia copy 2020-09-01 fdegans Upstream Fuchsia changes in build file 2020-06-29 adetaylor Add CPEPrefix. Created with: roll-dep src/third_party/icu Bug: 1110266 Change-Id: I41906106d93794e7d11d65571512e9bea85352e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413511Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807389}
-
Finnur Thorarinsson authored
When the user navigates to a PWA, we should show 'Install app' instead of 'Add to homescreen'. Bug: 1128364 Change-Id: Ie778478a1c0484158b4724100ad83f827d34634f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398503Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#807388}
-
François Beaufort authored
This CL makes sure a USB Webcam device on macOS properly advertises its PTZ support. When supported, the pan, tilt, and zoom controls (ranges and values) are available to websites that user has granted access to. Bug: 934063 Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#807387}
-
Christian Biesinger authored
The previous code did not do the right thing for abspos boxes. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: I0ec70519d8b4501c67718ab9baabc6bf1d11ac36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412136 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807386}
-
Alex Ilin authored
RevertReason enum used to be used for recording histograms but it's no longer the case. This CL removes this enum to simplify the code in preparation to upcoming refactoring (see the bug). Bug: 1128451 Change-Id: I497c9b53ba5b3acade5bb9a9cfeeee4445443f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412308Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807385}
-
Camillo Bruni authored
- Add better assertion failure messages - Use better content for document.write The tests assume that the ignore-destructive-writes counter is only incremented during the synchronous part of module evaluation (see https://github.com/whatwg/html/pull/4352#issuecomment-611193922). This also fixes document-write/module-delayed.html which accidentally had wrong test expectations checked in that made it pass. Bug: 1127215 Bug: 1022182 Bug: v8:9344 Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807384}
-
Joel Hockey authored
Currently, Plugin VM subpages such as shared folders or USB do not have id as a URL param. As a consequence, if app service sends any events about apps while the page is open, settings will change to show the main page since it doesn't recognize the current app page and suspects that the currently shown app has been deleted. Change-Id: I650230187e6dc80814ff5b7c5b648c990f349be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409464Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#807383}
-
Fergal Daly authored
Unload is not called on frames if they are not live. https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/render_frame_host_manager.cc;l=481;drc=420adc39b2caf85261a08935ec47c03745100e1f Bug: 1072817 Change-Id: I5e00d678cf1bd80d928b3fb3ade292741eff9a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410099 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807382}
-
Hiroki Sato authored
This change fixes focusable and clickable property computation for ARC a11y nodes, and these properties are populated when a node has corresponding action. AX-Relnotes: Fixed an issue where Search+Space didn't work for some element in Android apps. Bug: b:168461929 Bug: 1123056 Bug: 1126607 Test: manual, Search+Space on YT Music now works. Test: AccessibilityNodeInfoDataWrapperTest Change-Id: I6a9e534920fe1a2c51b70aee0ab0d8aeb00fdd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409851 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#807381}
-
Peter E Conn authored
Change-Id: Ie18a544cee4d55b95ba8bb9432dfe1c33a89a642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410493Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807380}
-
Nate Fischer authored
No change to logic. This uses the preferred parameter names (files_to_skip, files_to_check) for GetPylint() in build/android/PRESUBMIT.py. Fixed: 1128780 Test: git cl presubmit --upload Change-Id: I0f7d7dde917437c940c85835bbcebf252d111643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412975 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#807379}
-
Alex Rudenko authored
The tests has been updated in https://crrev.com/c/2172859 but TestExpectations were not updated. This CL enables passing tests. 1 test fails and will be addressed in a follow-up CL. Bug: chromium:1075869 Change-Id: Ie7f21ad9020379ff4eebc7aeb7e71be53f899e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410405 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#807378}
-
Yoshifumi Inoue authored
Because we don't have sample HTML to cause this case but we see crash logs, thiis a speculative patch to avoid crash caused by attempting to construct invalid range in |FindTaskController::FindTask:: Invoke()|. Bug: 1125953 Change-Id: I38d43bf6e66e44ba25529aa8a2dffea5523a49eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413460 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807377}
-
Yoichi Osato authored
Due to CORS error: https://chromium-swarm.appspot.com/task?id=4eabb07d02113910: .. START Page Action: NavigateAction(http://edition.cnn.com/) DevTools console [javascript]: Access to font at 'https://edition.i.cdn.cnn.com/.a/fonts/icons/2.4.10/cnn-icons.woff2' from origin 'https://edition.cnn.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. https://edition.cnn.com/ TBR=eyaich@chromium.org Bug: 1128844 Change-Id: I52eb9713d25fcb83982eb6439bc0d718c2b28788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409896Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#807376}
-
Hidehiko Abe authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/3008f9e6de12..69a0d6e8affc $ git log 3008f9e6d..69a0d6e8a --date=short --no-merges --format='%ad %ae %s' 2020-09-09 hidehiko native_client: Expand is_linux to is_linux || is_chromeos. Created with: roll-dep src/native_client Bug: 1110266 Change-Id: If32b0fc03e6e3cb46026bc79db3726bf2bef9914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409559 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1be45d6b6ab..deacaf80c273 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645 Tbr: yoichio@google.com Change-Id: I78849f3d8cc8b25c9d38ac30e46df6f05e702f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413391Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807374}
-
Yoshifumi Inoue authored
This patch gets rid of |unused function ShapeResult::MutableUnique()| for improving code health. Change-Id: I6ab5c02b8ee6d92128fd44486212c9df56fba8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412117 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d22b57cd6cee..97fd79e5180b 2020-09-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac40436e2e3692902f2ac0c0d415652d5ff3d904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413395Reviewed-by:
-
Benoit Lize authored
On some platforms, the OOM path calls free(), which deadlocks as a consequence, since we are holding the lock from this path. Release it before OOM. Bug: 998048 Change-Id: I6aec2b8aa7e4ce64f2b9754284ec8c42ee2bdc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410872Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807371}
-
Jing Wang authored
Now we can independently enable/disable each type, which is useful when we rollout personal info experiment in stable. Bug: 1042084 Change-Id: I2e355fa2fb00fddc2bb94cf66e5056153c205abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409684Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807370}
-
dpapad authored
In some cases, like the FilesApp which is served from a chrome-extension:// scheme, converting all chrome:// URLs to scheme-relative URLs is not desired. Adding a |preserve_url_scheme| to opt-out of the default behavior. Bug: 1128313 Change-Id: I48fe8fda4320d8ff3eaca35229c8c34cd55407de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411563Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807369}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4108364efc3f..2610e8261e9e 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 183a454b9d54 to 4d3a0f602852 (29 revisions) 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2c970cbe to da6c6f8f (442 revisions) 2020-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f14b7ab7a55 to b33e0b36a08c (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: Manual verificationTest: Test: Manual verification in AOSP checkoutTest: Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_* Change-Id: I027d75e4f630f25429c41c2e67ae031fec28a93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413392Reviewed-by:
-
Morten Stenshorne authored
We were setting the *position* of the column row after a spanner correctly, but the *size* was wrong, if there was a trailing spanner margin. Just update the layout position up front when entering layout of a column row, which simplifies the code and fixes bugs. Bug: 829028 Change-Id: I473ff1fe43da3b8b852a0a2f199c7537d7bfc3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410242Reviewed-by:
-
Gyuyoung Kim authored
As the second step to convert ViewMsg_UpdateWebPreferences to Mojo, this CL moves needed methods from content::RenderViewImpl to blink::WebView because they will be called by UpdatePreferences() Mojo implementation method in the following CL. - Move ApplyWebPreferences() to Blink. - Rename Get|SetWebkitPreferences() to Get|SetBlinkPreferences(). - Remove |webkit_preferences_| variable in RenderViewImpl. - Remove webkit_preferences(), then start to use GetBlinkPreferences(). - Move needed content switches to Blink. Bug: 1097943 Change-Id: Ifff24d84c3dbcd8abceaf4ece8a03f2c17b28d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409887 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807366}
-
Morten Stenshorne authored
We were resolving the block-size of column content against the columns, but that's only correct if the column happens to take up all the space in a multicol container (which typically ISN'T the case when there are column spanners, or when a lone column row is balanced to use less space than what's specified on the multicol container). So, resolve percentage block-size against the computed content-box block-size of the multicol container (not the columns). Also provide the correct percentage resolution size in the initial column balancing pass. This doesn't really do much for correctness, since the column stretching machinery will eventually give us the right column size, but this will hopefully give a better initial size guess, so that we don't have to stretch and re-lay out as many times as we would have without this change. Some work left to do (TODO added) for OOF descendants. No intended behavior changes there for now. Bug: 829028 Change-Id: Iddc5b1f53ca375a05768385bab35ce2215c2ccbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412728Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Alex Rudenko authored
The test was disabled in https://crrev.com/c/2403560 and it can be enabled now becaused DevTools has been rolled. Bug: 1125357 Change-Id: Ic09d1bc8437ad6c1a5efc80a58867fee79eb956b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413250Reviewed-by:
-
Alan Screen authored
Interactions with print drivers via operating system APIs is being moved from out of the highly privileged browser process into a sandboxed utility service process. Changes to support rolling this update out will be guarded behind a feature flag "enable-oop-print-drivers". This feature is currently only applicable for desktop operating systems. Bug: 809738 Change-Id: I938df469b6108a7b5a8dd9d5e0225d12bbe1f6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412449Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807363}
-
Eugene But authored
Chrome for iOS bots no longer run perf tests Bug: 978949 Change-Id: I3f45e349a3c9605716fb6e230bf6fa10fb67a20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411477 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807362}
-
Frédéric Wang authored
This CL disables multicol for MathML, since it has been causing issue and is not needed for math layout. This is consistent with flexbox, grid, table or custom layout for example. In particular, this fixes an assertion failure when multicol is used on MathML token elements. Bug: 6606, 1128267 Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131Reviewed-by:
-
Glen Robertson authored
This is a reland of 93d899e2 OCL incorrectly added a dep on telemetry in official build. TBR=dpranke@google.com,blundell@chromium.org,dominickn@chromium.org,ericorth@chromium.org Original change's description: > Enable `gn check` on //chrome/browser. > > Changes are: > - adding deps when missing. > - adding "nogncheck" when needed (see below explanation). > - deleting nonexistent files from sources. > - new target :net_dns_access for files that depend on > //net/dns:host_resolver (which has restricted visibility). > Alternative: could open visibility to all of //chrome/browser instead > of adding a new target that has visibility. > - moving //c/b:test_support sources to //c/b/chromeos:test_support or > //c/test:test_support when they depended on headers there (cannot > add a dependency, there is a cycle). > - moving includes to conditional sections when they are used only in > conditional sections (where it caused deps issues). > - removing unused includes of test code from non-test code. > - merging sections in //c/b/BUILD.gn that had the same if() conditions. > Alternative: revert these changes, they are cosmetic. > - adding some asserts/conditional blocks in build files that only work > under those conditions. > > "gn check" does not understand #if statements in cc/h files so it > complains about missing deps in configurations where those deps were > never actually included. "nogncheck" has been added to the include lines > to suppress these spurious errors where necessary (sometimes it is not > necessary because the include is used outside of #if statements in other > files). > > Bug: 898837, 1125897 > Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807321} Bug: 898837 Bug: 1125897 Change-Id: If1dc6009b640c0b6ae33b1455b6ccf27c1cf274b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413427Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#807360}
-
Darwin Huang authored
This allows us to avoid an unnecessary and repetitive translation layer in ClipboardAndroid, between ClipboardFormatType and std::string. Bug: 1123230 Change-Id: Idd749fba9bbe13c9e5e13aa0f4ea6d93d7f74b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383112Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807359}
-
Alan Cutter authored
This CL adds two fields to the default web app config JSON: - load_and_await_service_worker_registration: bool - service_worker_install_url: URL string These allow default apps to control their service worker registration behaviour during the install flow. Bug: 1123435 Change-Id: Id389c347066a8dbcaa2c2350b884cdb5872e5721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409057 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18cab16dfca1199c8d6d6cdbb6ca351866a511a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413390Reviewed-by:
-
