- 05 Nov, 2019 40 commits
-
-
Taylor Bergquist authored
Also updates the tooltip with the same information. Bug: 999557 Change-Id: Iee27b98e70385e23f7d517622c024d2315a8d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889945 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#712405}
-
dpapad authored
This is in preparation of turning on web_dev related PRESUBMIT checks for components/. Bug: 1019312 Change-Id: I3226df6b609bc0e16b72d041234084a5615219fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895896 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712404}
-
Jun Mukai authored
I just happened to notice that these two properties don't follow the naming convention. Right now no one is actually using them (though some Tast tests are going to use them), so changing their names should be safe right now. Bug: 1021353 Test: build passes Change-Id: I3f578f1a891fdaa68110b4656006dffe1baaed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894246 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712403}
-
Henry Jian authored
Previously, I forgot to apply masking to adaptive icon in the notification bar, making the icon in notification bar inconsistent with other icons. This CL fixes the bug. Bug: 977173 Change-Id: If42d7f59c3d126dd23f53d4547112455add9fca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898634 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712402}
-
Long Cheng authored
Bug: 1013732 Bug: b/34248841 Change-Id: Ia6cf9a39efc6880d3458b8e33af2ef4225f0290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887748 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712401}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcAnswerOptionsPlatform directly. Similar to https://crrev.com/c/1884931 . BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I24915fd592e3ebd551717cd5dd8a4faccb525596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890794Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#712400}
-
gogerald authored
Bug: 1020663 Change-Id: Ica6eff7c7bf1e04636b24068a0b966f3cd50dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894467 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#712399}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc836871cb18..4a4f34b76f3a git log cc836871cb18..4a4f34b76f3a --date=short --no-merges --format='%ad %ae %s' 2019-11-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-04 brianosman@google.com Fully embrace skcms types in SkColorSpace API Created with: gclient setdep -r src/third_party/skia@4a4f34b76f3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I44ac76ba7234893811b31d155a6a6a98702eb4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712398}
-
Xiaohan Wang authored
Instead of creating the Renderer in PipelineController before pipeline start which includes Demuxer initialization, this CL moves Renderer creation to PipelineImpl as a step in PipelineImpl::Start() so that the Renderer is only created after the Demuxer has been initialized. This makes it possible to have more flexible Renderer creation, e.g. create different Renderers based on different stream or CDM. Bug: 1018372, 827990 Test: No functionality change. Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712397}
-
Fabrice de Gans-Riberi authored
Bug: 1016036 Change-Id: I9c2125d7b2fe11c08f7fa7024155ae25f4a0360e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898713Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712396}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kmarshall@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I9d65b702148140bab94514de52e0a551f4cb9d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895647 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712395}
-
Sophie Chang authored
Bug: 969558 Change-Id: I6320efadce91869b6fe13bee8022e581102f0b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896038Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712394}
-
Matt Mueller authored
Change-Id: Ic7c38924c3c1fc441566aa85dd6c99cc75243810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898100Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712393}
-
https://crrev.com/c/1782247Fergal Daly authored
TBR=yuzus@chromium.org Bug: 1020884 Change-Id: I291230bded9a9d915935f362d60d85589ef722dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898160Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712392}
-
Klaus Weidner authored
While investigating a flaky test, one of the issues found was that a session 'end' event is triggered directly after issuing the session.end() call, without waiting for device-side session teardown to proceed. As a result, requesting a new session could fail due to the device side thinking there's already an active immersive session. According to https://immersive-web.github.io/webxr/#ended and discussions with Brandon, expected behavior is that the 'end' event and end().then promise resolution should be delayed if needed to ensure that a new session can be started at that time. This CL adds a "ended but not yet shut down" state to XRSession, and adds a new ShutdownSession call to isolated_xr_service's XRRuntime, to enable the expected delay. In case of mojo communication errors, the shutdown happens immediately. Also update WebXrTestFramework's enterSessionWithUserGesture to detect and retry clicks that aren't delivered after session end transitions, and remove sleeps that were previously added to work around flakiness in WebXR VR consent tests. It appears that this flakiness was at least in part caused by prematurely starting a new session while the previous session wasn't fully shut down yet. The test change is included in the same CL since the new shutdown logic by itself left some tests flaky due to clicks not being delivered consistently from the test framework. Change-Id: I6d48b259677c92bac323db0e10803a48718d4a33 Bug: 1014159, 998307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874824 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712391}
-
Peter Boström authored
Removes ::OnBoundsChanged overrides in AppMenuButton by making ToolbarButton::OnBoundsChanged safe to call even in the WebAppMenuButton. This is likely a prerequisite for hosting extensions in the PWA frame as the buttons are currently being sized too large to fit. Bug: chromium:1006162 Change-Id: I0aa444cd913957feb08f2e9a340269734b0cc76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866874 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#712390}
-
Eric Roman authored
Bug: 1021236 Change-Id: I18e1d63683419beb48f4bbc820946fc9162c9f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898616 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
-
Sarthak Shah authored
This CL enables ScreenWin to retrive and store Pixels Per Inch value for every connected touch monitor to the system. This value will be later utilized to configure animation curve for fling gesture. Bug: 647137 Change-Id: I4184060ff64e800e2d76111e035c7f7bf6eb53b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884752 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712388}
-
Rahul Arakeri authored
Native scrollbars on Mac do not have scrollbar arrow buttons. The math for calculating the forward and back track rects assumes that arrow rects are non empty. This leads to the scrollbar hit test missing the track rects. Bug: 1016452 Change-Id: Ie1a25211cb79022286ddf4684cc8d33e04823747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873491 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/94d6f48ba1b7..f6a2232b48c2 git log 94d6f48ba1b7..f6a2232b48c2 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ehmaldonado@chromium.org Revert "git-cl: Fix some python3 compatibility errors." 2019-11-04 ehmaldonado@chromium.org owners_finder: Fix flaky tests. Created with: gclient setdep -r src/third_party/depot_tools@f6a2232b48c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002209,chromium:1009814 Change-Id: Ifbfebdcca16dac3de97e016f1c47992d84d32b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898688Reviewed-by:
-
Sorin Jianu authored
* Removes //chrome/updater:updater_constants target * Fixes the dependencies to get a clean run for 'gn check out/default //chrome/updater/*' R=waffles CC=milagreen Bug: 1021336 Change-Id: I50febba965a5d1684ffef0c259dc9bd7e743d34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898776 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712385}
-
Chris Palmer authored
It (sometimes) measurably hurts run-time performance, but we don't have a strong case for its defensive value. The canary check in release mode hurts performance as it requires going completely out of line to compare against a global. Speedometer total Linux: 2.5% Win: 1.4% v8.browsing (metric: blink-gc-total which covers the whole phase) Linux CNN: 11% Linux FB: Noise blink_perf.bindings Linux: Noise Impact: We think the performance impact is noticeable. The canary is only present on 64bit. The canary is only present on Oilpan object and not off-heap objects that are referred to by scoped_refptr<> or regular malloced objects. The canary is not present in V8 which is the first line of attack. The canary is present on all Oilpan objects which means that it is spread across many pages. Any read gadget (e.g. high-performance Spectre gadget) is sufficient to find the value for the current renderer. Impact: The canary can guard against linear overwrites when there's no other info leak present. This mechanism is only enabled on 64-bit. Pointer compression of the Oilpan heap will make the memory overhead of the canary visible. Impact: Similar to not emitting the canary on 32-bit because of memory overhead, we should probably not emit the canary when moving into a future with pointer compression. Change-Id: I6ddb610d0e697fe9407667b72ce4efe4c3720431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879865 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712384}
-
Wez authored
FilteredServiceDirectory is used to create sandboxed directories with subsets of the services available to the caller. For use-cases like integration testing, it is useful to allow specific services to have fake test implementations added, for example, alongside the production services exposed via the directory. Change-Id: I2d751770eb04a138e45f2f019a69323a4cadd3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896535 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Eric Roman authored
Bug: 1021236 Change-Id: I19ec9a8d9618ec8b28deb95cbe46d9ea25be66e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896394 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#712382}
-
Dale Curtis authored
Per bug, test is scheduled for deletion, so just blanket disable. BUG=1004299 TBR=csharrison Change-Id: Ia055c4700340bafa8c11abb9894cc19a12e6b1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898766Reviewed-by:
-
Findit authored
This reverts commit 08aba315. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 712315 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA4YWJhMzE1MmJjMjk3ZTFlMzAwZGEyOWZkYWE2M2NjOTY3MTAzMDcM Sample Failed Build: https://ci.chromium.org/b/8897675907369267936 Sample Failed Step: compile Original change's description: > Register the updater app id in registry (Windows). > > Send both the updater and Chrome app ids in the "update apps" use case. > With this change, --install and --ua commands work as expected, meaning > the app ids and the versions are sent during update checks. > > There is a edge case, not handled currently, where the app id for > the updater is not available until the first update check has happened. > This is going to be resolved in a future CL which lands as part of > fixing this CR bug. > > R=waffles > > Bug: 1020285 > Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712315} Change-Id: I82dcc710be51b507c48a66de5dcb3b9d48a50c44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898537 Cr-Commit-Position: refs/heads/master@{#712380}
-
Dale Curtis authored
BUG=783450 TBR=poromov Change-Id: If1011b161745c67e6938f2fa71032423136d2919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898624Reviewed-by:
-
Jesse Schettler authored
Add new print preview metrics for ARC printing. Also, replace UMA macros with UMA functions in PrintRenderFrameHelper. Bug: b:143787611 Change-Id: I4cbbacd04245312ccd1237c9e0dd15989915c1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896300Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#712378}
-
Wez authored
Change-Id: I7e43ea82867177c1aeab089f8f1e35abb802d1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712377}
-
Gyuyoung Kim authored
This CL converts CompositingModeReporterPtr to mojo::Remote<viz::mojom::CompositingModeReporter> in RenderThreadImpl. Bug: 955171 Change-Id: If36579920d065b49e539c37a17a37b2782f5f6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896491Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#712376}
-
Devlin Cronin authored
Unit tests are nice - they are faster and less flaky than browser tests. Add a unit test suite for the ExtensionsMenuView class, and a super basic test that checks extensions are shown in the menu. This is mostly just a jumping-off point so we can easily add more unit tests as we move forward (and add any that are needed to have coverage parity with the old implementation). Bug: 959926, 984654 Change-Id: I04a4d9af02ef1075bb4f0180fbf90c1b615008c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880074Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712375}
-
Shimi Zhang authored
Bug: None Change-Id: I2d62164864a0386f9c524552ac73ec477e0182fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896342 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712374}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5cbb77739e8d..71b0f0b588d6 git log 5cbb77739e8d..71b0f0b588d6 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 j.vigil@samsung.com EGL: Implement EGL_KHR_surfaceless_context Created with: gclient setdep -r src/third_party/angle@71b0f0b588d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ieefe13e1fc312664482bf8cc9608c7c60920bdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898635Reviewed-by:
-
Natalie Chouinard authored
Cleaning up JavascriptPreference migration logic that was introduce >4 years ago. Bug: 1016957 Change-Id: I587e0d9722850b861bac8cc768476ae4e36ce93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895328Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#712372}
-
Kenichi Ishibashi authored
To investigate invalid states where a redundant service worker is controlling clients. DevTools' application tab shows clients nicely but it doesn't show redundant service workers. Bug: 1015692 Change-Id: I6102f5d897e8e91a49d8502d8876cac809a2c181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890516Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712371}
-
Yuchen Liu authored
This is helpful for debugging media issues on Fuchsia. Once we're confident on the media playback quality, we can revert this patch. Bug: 1021274 Test: Build, deploy and verify the DVLOG shows in the log. Change-Id: I542cc66763af0b1e5e216ec70b821f6ed8bfb123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898511 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Devlin Cronin authored
With the ExtensionsMenu feature, we're changing how extensions in the toolbar presented. However, many tests leverage conceptually simple behavior that should continue to work - such as clicking on an extension opening a popup, or an extension having a presence in the toolbar. We should find a way to apply these tests to both the current behavior and the new ExtensionsMenu behavior. BrowserActionTestUtil is a (platform-agnostic) test utility class for exercising the behavior of extensions in the toolbar. (Note that the name "BrowserAction" is legacy; it actually tests all extension actions). This provides an abstract interface for performing actions like clicking on extensions, getting icons, and determining the number of extensions in the toolbar, and is a common method used by platform- agnostic tests exercising these behaviors. We can repurpose this class with an ExtensionsMenu-specific implementation, which allows us to reuse many of the existing tests without updating them to know about the ExtensionsMenu experiment. While this won't work for all tests (since some exercise behavior specific to the presentation in the toolbar), it should allow us to leverage the same tests for basic functionality like clicking on extensions. Introduce ExtensionsMenuTestUtil, an implementation of BrowserActionTestUtil that works with the ExtensionsMenu UI, and use this iff the ExtensionsToolbarMenu feature is enabled. This reduces the number of browser tests on Linux that fail with the ExtensionsToolbarMenu feature enabled from 105 to 74. Bug: 984654 Change-Id: Ife6d663ca59db9032f5442a297f6b0ac51a2528a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877660 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Mike Wittman authored
Updates the metadata function interfaces to use only the required types, in preparation for refactoring them into separate class. Bug: 1895969 Change-Id: I8b80d091d457e7a43d8593a39a71531b1923c27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896914 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712368}
-
François Doray authored
The freezing origin trial opt-out/in is not a typical new Web feature that Web developers would like to try out. It is an explicit way to opt-in/out of an intervention. If we set the opt-in with --enable-experimental-web-platform-features: Web developers may be surprised that their site gets frozen when playing audio, using WebUSB... If we set the opt-out with --enable-experimental-web-platform-features: Web developers will not be able to observe how their site works with freezing. Therefore, this CL ensures that --enable-experimental-web-platform-features does not set the origin trial opt-out/in. Bug: 1020567 Change-Id: I7c595224fa236d554d2548476b36472f676ed2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894878Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#712367}
-
Wez authored
Bug: 1020694 Change-Id: I5f0e03328646456dbc1289a259d99b7bd9d8e79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893545 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712366}
-
