GitLab

Copy original Incognito Tab Switcher body string and remove period. Add screenshot for new string.

Change-Id: I9cf696f114e663fde5feb892074bcf2309f52424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245890Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Maxime Charland <mcharland@google.com>
Cr-Commit-Position: refs/heads/master@{#779073}

These tests were disabled on Mac ASAN for flakiness, due to
bug 496955. That bug has been fixed and these tests are no
longer flaky.

Bug: 851854, 496955
Change-Id: Idd52325c2103cb5518dc058242abeb27c1107451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238339Reviewed-by: Archana Simha <archanasimha@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779072}

Also pull WebContentsState out of TabState.

Bug: 1090048
Change-Id: I82eb800afbe7748944e8529c797f57a8ba2b6b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241863Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779071}

Now we can see the date time picker when choose download later option
in the download later dialog.

Also fix an issue that DownloadDateTimePickerDialogTest failed on
Android L when mocking WindowAndroid.

Bug: 1078454,1094925
Change-Id: If203ac4a544c90eaad885198add745b46700c083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248449Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779070}

This patch contains the CSS environment variables for the virtual
keyboard rectangle that are updated when geometry change occurs.
This was a feedback from TAG review:
(https://github.com/w3ctag/design-reviews/issues/507)

Bug: 856269

Change-Id: I1cf5bd234f388fbab0083398f46f70ed7a1482a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244196Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#779069}

Bug: 1088044
Change-Id: Ib47ad031d3d851093119ae42576da6bec6c4b82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222902
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779068}

The Android IPC INotificationManager.enqueueNotificationWithTag()
might be corrupted when we processing web notifications.

This CL only catches the exception, the root cause is still unknown.

Bug: 1077027
Change-Id: I180ff015031d38cb1ae0abbbde05a732e22cd153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247539
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779067}

Minor change to move the test-only class DispatchStub into its
own file so it may be shared between multiple unittest files.

Split out from :
https://chromium-review.googlesource.com/c/chromium/src/+/2188057

Bug: 928948
Change-Id: I8bf6338304a1ddb90c4696c98b15b58cc49e3c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244453
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#779066}

Bug: 1088592
Test: Manual Test
Change-Id: If6a3b674872e40eea57eef623d35beb47d86b4c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242753Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779065}

ones.

Rename them per the request from UX.
Pure renaming, no functional change.

Bug: 972162
Change-Id: I73c5d4b03f9424afe954f8f4afc5345477e63cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248670Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779064}

Bug: 1093528
Change-Id: I0b40ecc88a70faba6f602fa286c1e16fb09c575b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248177Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779063}

Instead of processing the data one sample at a time, we can process
a block at a time by doing large memcpy's and then some vector
operations to interpolate the samples.  As a final micro-optimization,
if the interpolation factor is 0, we can skip the interpolation phase
altogether.

Using (a slightly modified) Spotify's Web Audio Bench, we have the
following results using 500 runs of 10 sec each (the default) on a linux
machine:

Without CL:
TEST	μs	MIN	Q1	MEDIAN	Q3	MAX	MEAN	STDDEV
Baseline	594	594	740	751	761	3215	757.82	146.55
Delay-default	331	331	387	405	416	2124	406.47	81.65
Delay-0.1	344	344	401	423	440	834	425.68	41.04
DelayAutomation-a-rate	675	675	748	763	779	1262	768.23	42.97
DelayAutomation-k-rate	365	365	424	444	460	1036	446.24	38.61

With CL:
TEST	μs	MIN	Q1	MEDIAN	Q3	MAX	MEAN	STDDEV
Baseline	736	736	747	756	765	901	758.57	17.76
Delay-default	180	180	230	249	267	1467	256.75	77.1
Delay-0.1	233	233	302	317	332	2402	322.39	96.86
DelayAutomation-a-rate	612	612	683	698	713	983	701.78	33.85
DelayAutomation-k-rate	206	206	281	299	318	522	305.34	37.96

As we can see, the CL speeds up processing the default by 38%, delay-0.1
25% and k-rate by 32% (using the mean and not us results).

One layout test needed to be updated to handle numerical differences
for mac.  The implementation of Vsma on mac is different from linux and
windows. and this difference shows up in the test.  (Mac uses VDSP_vsma,
instead of our hand-written Vsma. VDSP_vsma might be using an FMA
which has different round properties.)

Bug: 1087071
Change-Id: I2b95096fef9fd1e5f7c87e4f4bdfa7d52f5b8d58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171843
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779062}

The //docs/contributing.md file talks about how all code in
Chromium must be relevant to the project, but as written it was
somewhat circular ("should be in service of other code"); this
CL updates the wording a bit to try and clarify how completely new
top-level things (like //fuchsia) get approved.

R=jochen@chromium.org, haraken@chromium.org, darin@chromium.org

Change-Id: I35246fff40d3cec0700e55d904f63973db2eaee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246830Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#779061}

animations change

https://chromium-review.googlesource.com/c/chromium/src/+/2223998 change
introduced memory regression as a result of adding HeapHashSet data
member to NodeRareData. This change replaces HeapHashSet with
Member<HeapHashSet...>, thus reducing additional memory from 24 to
16 bytes on windows per NodeRareData.

Bug: 1093776
Change-Id: Iaaecd9fc7d2221313f3949a790408a2c88a64b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241190Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#779060}

Users of Oilpan should not manually call the write barrier.

Bug: 986235
Change-Id: Iacf133c5f3f2ea10bde9041da65c9754b889a8ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246571
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779059}

Bug: 159159163
Test: build and run
Change-Id: I1217ca75f722bb1bcac019a3b0a3d4debc524925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248888
Auto-Submit: Michael Montvelishsky <mont@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779058}

This fixes some padding issues with views that use
RippleBackgroundHelper and matches what Chrome does.

Bug: 1019922
Change-Id: Icc7424715e7494529d7fb519127ea7bd6bd249ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248861
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779057}

This helper class is all but unused. Probably a remnant of another
crypto backend. Also remove a redundant EVP_CIPHER_CTX scoper since
BoringSSL already provides one.

Bug: none
Change-Id: Ie4594313fbe4ecc0b0352a92c361ca3e77665eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245889
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779056}

This CL fixes a typo-bug. We should always consider main-thread layers
as not "back face visible" because the main thread can't know the
final draw transform. This aligns TransformInterop with the
equivalent behavior for pre-TransformInterop.

Bug: 428458

Change-Id: I4e861262324eadd5b1740ac92bd19391f88061be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247151Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779055}

VideoFrame::duration did not check whether frame_ is nullptr
or not and referenced it unconditionally. Add a check.

Change-Id: I4f002e8dfb9f3f9899a7f8360c3f79aff9bfb69c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237970Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Tuukka Toivonen <tuukka.toivonen@intel.com>
Cr-Commit-Position: refs/heads/master@{#779054}

Bug: 1044687
Change-Id: I6885843022dd2d36981eb350318e55e6e32c58a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219151
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779053}

Based on the spec [1], the current implementation of
AudioWorkletProcessor needs to create a new data container
(i.e. WebIDL sequence<>) for input, output, and param arrays.

With the new spec change [2], this CL changes the overall design
of the audio processing callback:

1. Moves the processing call from AudioWorkletGlobalScope to
   AudioWorkletProcessor object.
2. AudioWorkletProcessor now keeps the data container within
   the object and allocate memory when it is needed.

The preliminary benchmark shows the sizable improvement in the
audio stream quality. The glitch score
(= buffer underrun/total callback) is improved by ~9x in the
low-tier machine. [3]

This is an API change [4], but the real world impact would be
negligible because there's no functionality change.

[1]: https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process-inputs-outputs-parameters-inputs
[2]: https://github.com/WebAudio/web-audio-api/issues/1933#issuecomment-616632754
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1086665#c2
[4]: https://chromestatus.com/feature/5647541725036544


Bug: 1071085, 1086665
Change-Id: I3e664754973d4d86649d38c1807c6b9d7830fb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218702Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779052}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4872ceba46e..38accb0f0337

2020-06-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ia626b6a96e1c3f036d34d2a8ee3e656cfb7a8084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779051}

Bug: 1044687
Change-Id: Ic8fd8f5340645243e5c8bdb2e75f2514d7c903a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227550
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779050}

Bug: b/155347422
Change-Id: Id07c7ae6bf2b7a57479f123afd37b3903ffa27a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247429Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779049}

For some reason we are hitting this CHECK so
this removes it and logs it to a histogram.

BUG=1072403

Change-Id: Icd0d0aa974a17710df2d8467f34aaf2cbad8ef93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247912
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779048}

This CL brings drag and drop to tab grid.
- By default, the DragAndDrop feature flag is disabled
and the old gesture-based reordering is used.
- When the feature flag is enabled, reordering is done
via drag and drop.
- GridViewController fulfills the drag and drop interaction
delegate protocols since it is in the UI layer.
- The TabGridMediator creates the drag items (via helper utils)
and has the model logic to perform actions for the drop.
- A new protocol GridDragAndDropHandler serves as the liaison
between the UI and model layers.

This CL is one of several to add drag and drop functionality.

Bug: 1087844
Change-Id: I5add4a9192c300077b8f881e200a0090a1fce765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245038
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779047}

Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167137

Bug: 1095733
Change-Id: I9b9709113d3ecf4ac8642b44e0aab1061242c51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248456
Commit-Queue: Jose Leal <joselea@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#779046}

chrome.platformKeys.getKeyPair(certificate, parameters, callback) passes the key
pair of the certificate to the callback so as it can be used with
platformKeys.subtleCrypto functions. For more information please refer to:
https://developer.chrome.com/extensions/platformKeys#method-getKeyPair

This CL extends this function so that it accepts a certificate for an EC key.

Bug: 1059209, 980395
Change-Id: Ic34294cbb380ac3fe5da63ccebfa4e0a6f8fcf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231046Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#779045}

This reverts commit 4a4f53a7.

Reason for revert: Cryptic failure in v8 snapshot step, details in bug:

[28088/52852] ACTION //v8:run_mksnapshot_default(//build/toolchain/win:win_clang_x64)
FAILED: gen/v8/embedded.S snapshot_blob.bin
c:\b\s\w\ir\cipd_bin_packages\cpython\bin\python.exe ../../v8/tools/run.py ./mksnapshot --turbo_instruction_scheduling --target_os=win --target_arch=x64 --embedded_src gen/v8/embedded.S --embedded_variant Default --random-seed 314159265 --startup_blob snapshot_blob.bin --no-native-code-counters

TBR=thakis@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1095767
Change-Id: I3ebb7a7e638afd8936b7d0d98c328e53bc411209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248077
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779044}

1) Add a 16dp margin between the omnibox and "continue browsing"
   section.
2) Add a 16dp margin between the recent tab card and the feed section.
   Note that for OMNIBOX_ONLY variation, the grid tab switcher uses the
   same parent view as the feed section. Thus, we only set the top
   margin for above section when we are not in OMNIBOX_ONLY.
3) Add a 12dp margin between the omnibox and MV tiles.

Bug: 1091988, 1081326
Change-Id: Iff61993f80032246b5212cab9ba8f02090605650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247142
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779043}

This is a general failsafe if the app zygote fails silently, meaning a
bindService call never ends up with a onServiceConnected callback.
Fallback to non-zygote services if onServiceConnected is not called
after a timeout.

Implement by recreating all ChildServiceConnections and making sure old
service connections are never reused. This is to avoid races where
timeout races with the real onServiceConnected call. This is only
enabled on Q+ where onServiceConnected is called on the launcher thread,
not the UI thread, so there is no race from posting to launcher thread.

The switch is static, so after the first timeout, all brand new
connections will immediately fallback to non-zygote.

Bug: 1087966
Change-Id: Iedc2f5c6ddd780c35ca266c257793dbcfdf42e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233312Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779042}

Remove Mac Builder Next, switch OS of Mac Builder to 10.15

This CL copies what was done for Mac10.14:
https://chromium-review.googlesource.com/c/chromium/src/+/2036769

Bug: 1066873
Change-Id: If227273be17c14547b16db1a68ff69f84fcc59eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242162
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779041}

This reverts commit dd25682c.

Reason for revert: Created separate pref

Original change's description:
> Revert "Restore mic gain on CrOS restart"
> 
> This reverts commit 5cafeca2.
> 
> Reason for revert: regression - causing large mic gain
> 
> Original change's description:
> > Restore mic gain on CrOS restart
> > 
> > This change reapplies the mic gain value when the device starts up.
> > 
> > Previously, the stored pref value was not applied on startup, so the UI
> > and the underlying audio service were out of sync.
> > 
> > Bug: 1083149
> > Change-Id: I422beb14f439ddd0fc36737e677125a48a0c9bd6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208092
> > Auto-Submit: Bailey Berro <baileyberro@chromium.org>
> > Commit-Queue: Jenny Zhang <jennyz@chromium.org>
> > Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#769926}
> 
> TBR=jennyz@chromium.org,baileyberro@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1083149, 158677629
> Change-Id: I8dd419d50177b68db3c751016ceba5fade7f721e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245493
> Reviewed-by: Hsinyu Chao <hychao@chromium.org>
> Commit-Queue: Hsinyu Chao <hychao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778196}

TBR=hychao@chromium.org,jennyz@chromium.org,baileyberro@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1083149, 158677629
Change-Id: I004f88d49a57df188aac8c611c7a361e98eab891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248345Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779040}

This moves the code to create the GL texture and bind it to
a GLImage into SharedImageBackingGLCommon.

After this patch, it will be possible to defer creation of
the GL texture until its use.

Bug: 1092155
Change-Id: I460d9f838f00f4492083956134bfc35466ebfde4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246994
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779039}

Added so
https://chromium-review.googlesource.com/c/chromium/src/+/2157285 can
avoid some unnecessary conversions to and from strings.

crypto::HMAC is particularly silly in its current form because Verify
takes char as input but Sign writes to unsigned char.

Bug: 559302
Change-Id: If2bb6c5bff2dfd8a1efd89088001af5c5458cb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246935Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779038}

Bug: 1069066, 1069069
Change-Id: I0dc98c814dd4f6fec72f74b40282c6f71edafe10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241189
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779037}

The getImageData operation can be slow on accelerated-gpu backend. The
willReadFrequently option is used by users to indicate that the canvas
gets directly read frequently through getImageData. Initialize
Canvas2DLayerBridge to use gpu rendering if willReadFrequently == false,
use cpu rendering otherwise. Added and modified unit tests accordingly.

In addition, AccelerationCriteria enum can be safely removed as it was
used to disable GPU for small canvas, in which the logic has been
abandoned a while back.

Bug: 1090180
Change-Id: I53670e4d71631f46c13176548171f6c05fb21434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237108
Commit-Queue: Teresa Kang <teresakang@google.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779036}

Bug: 995977
Change-Id: I2abc391e5cde840e7ecb7ecda460a264cb6eb5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247243Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779035}

In AVIFImageDecoder::Decode(), add a call to UpdateAggressivePurging()
to match GIFImageDecoder::Decode() and PNGImageDecoder::Decode(), two
other image decoders that support animated images. (WEBPImageDecoder
also supports animated images, but it calls UpdateAggressivePurging() in
a different method called by Decode().) Also remove the redundant call
to buffer.SetPixelFormat(ImageFrame::PixelFormat::kRGBA_F16), which is
already called in AVIFImageDecoder::InitializeNewFrame().

In AVIFImageDecoder::InitializeNewFrame(), move the
buffer.SetPixelFormat(ImageFrame::PixelFormat::kRGBA_F16) call to the
beginning of the method to match PNGImageDecoder::InitializeNewFrame().
Although it doesn't really matter in this case, it is good for
AVIFImageDecoder to imitate PNGImageDecoder because PNGImageDecoder is
the only other image decoder that supports HBD images.

Change-Id: Id81d13af8f8e33993211d50e23dc2aacc4e16648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247036Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#779034}