- 22 Oct, 2018 40 commits
-
-
Vladislav Kaznacheev authored
Bug: 873486 Test: Chrome builds and runs Change-Id: I507b97aa1bb0c894599037c5a8cc85286ebc9bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1292249Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#601740}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08cf46bc4eec..099769d5218b Created with: gclient setdep -r src-internal@099769d5218b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ce0632f941af9c7be3b002efe5756976b79db6f Reviewed-on: https://chromium-review.googlesource.com/c/1294789Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601739}
-
CJ DiMeglio authored
This change allows the kOnDemand option to apply for MediaStreams, meaning that we can switch over to using Surfaces when it is needed for PiP, deferring to a VideoLayer in the normal non-PiP case. Bug: 889857 Change-Id: I56019885d24e9d36f74a279d31f8259081edd1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1271591Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#601738}
-
Sadrul Habib Chowdhury authored
On android, it turns out the presentation timestamp coming from the driver can be from the future. Report how far ahead in the future these timestamps are. BUG=894440 Change-Id: Ic9bf5620721de3279e8b74277273e8db63da0842 Reviewed-on: https://chromium-review.googlesource.com/c/1294193 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#601737}
-
Mikel Astiz authored
PASSWORDS is the only remaining datatype that hasn't been wrapped in pseudo-USS and also the most difficult one, due to the encryption- related particularities (entities must be encrypted at all times). The proposal is described in a dedicated section in the Design Doc: https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot The patch includes the USS variant of the datatype controller for passwords, together with the required plumbing to enable directory-level (SyncableServiceBasedBridge) encryption of data. Cryptographer updates are posted from the sync thread directly to the model thread (password's background thread) with a newly introduced proxy observer, such that the bridge is up-to-date by the time the processor receives updates. A refcounted class (interface ModelCryptographer) is used for the plumbing to the bridge, due to the complex lifetime conditions of the involved parts. All this code is behind experimental feature toggle "SyncPseudoUSSPasswords". Because of encryption-related particularities of PASSWORDS, special care is taken with integration tests, and all tests with or without pseudo-USS enabled, including backward-compatibility tests that exercise legacy clients talking to pseudo-USS-enabled clients (and vice versa). Bug: 870624 Change-Id: I3e9ecc36d0b27c4c28e98fa709e7d13f9fb5a025 Reviewed-on: https://chromium-review.googlesource.com/c/1289889 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601736}
-
Peter Boström authored
With Refresh launched we no longer need to support pre-Refresh modes. This code is being cleaned up, so removing them from chrome://flags prevents them from being used in the wild. TBR=sky@chromium.org Bug: None Change-Id: I4924e21c91cf9ccc6b8cce174c1260c5af4887e2 Reviewed-on: https://chromium-review.googlesource.com/c/1285082 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601735}
-
Xiaohan Wang authored
- Define StringToCodecMap to avoid typing the long name multiple times. - base::NoDestructor supports emplace; no need to create a map first. - KEEP_FIRST_OF_DUPES is the default behavior; no need to specify. - Remove #if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING), because: * It's causing clang format to misbehave. * We should keep the mapping simple and should not restrict feature here, especially since MimeUtil::Codec::EAC3 is defined unconditionally. - Reformatted by "git cl format" Bug: 897767 Test: No functionality change. Change-Id: Iac8d8b8ae5a9a1acbab89105c121f1d80badd536 Reviewed-on: https://chromium-review.googlesource.com/c/1294598Reviewed-by:Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601734}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98f1e59b41c6..149834e67d30 git log 98f1e59b41c6..149834e67d30 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 ehmaldonado@chromium.org metrics: Add function to collect repeated metrics. Created with: gclient setdep -r src/third_party/depot_tools@149834e67d30 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:897394 TBR=agable@chromium.org Change-Id: I796b4e0e93af9e2319b05bf95a42a9f1f4d3d8b9 Reviewed-on: https://chromium-review.googlesource.com/c/1294226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601733}
-
Michael Spang authored
It's possible to write a fixtureless test by using TEST() instead of TEST_F(). Do this as it is slightly cleaner. Bug: none Test: events_unittests Change-Id: I67f50d73d01595de29f6346ef977891d6ea7b1c2 Reviewed-on: https://chromium-review.googlesource.com/c/1294569Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601732}
-
Yi Gu authored
This reverts commit f7da13a2. Reason for revert: As per comments by Findit Original change's description: > [MessageLoop] Lock-free ScheduleWork() scheme > > The Lock is causing hangs because of priority inversion > mixed with priority boosting (ScheduleWork() tends to > boost the destination thread which may deschedule the > posting thread; if the posting thread is a background > thread this boost-induded-desched-while-holding-lock > can cause a livelock). See https://crbug.com/890978#c10 > for example crashes catching this. > > The Lock was only necessary for startup/shutdown and is > being replaced by a lock-free atomic scheme in this CL. > > MessagePump::ScheduleWork() itself was already thread-safe > (but the Android impl did unnecessarily check a non-atomic bool) > > This adds a WaitableEvent in ~MessageLoop(); hence the requirement > for a wait-allowance in net's EmbeddedTestServer. > > TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) > > Bug: 890978, 874237 > Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 > Reviewed-on: https://chromium-review.googlesource.com/c/1278631 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601600} TBR=gab@chromium.org,fdoray@chromium.org,zhongyi@chromium.org Change-Id: I521ef6ba2758f84d13a4f98d65cb41b276cb115e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890978, 874237 Reviewed-on: https://chromium-review.googlesource.com/c/1294717Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601731}
-
Robert Liao authored
Making all combobox models owned by their respective comboboxes simplifes lifetime management for the examples app as models are essentially not referenced outside of construction. In certain exceptions, when they are referenced, they occur in response to handling a combobox event. This also allows all of the examples apps using comboboxes to use the normal views destruction codepath instead of having to explicitly destroy the combobox. BUG=897337 Change-Id: I2823517296f46a17d864936397963e1eee8bbfaa Reviewed-on: https://chromium-review.googlesource.com/c/1294205 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601730}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c320e9c7ad01..ae9bed9f4af1 git log c320e9c7ad01..ae9bed9f4af1 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 thestig@chromium.org Roll v8/ 626844157..db22e96fb (203 commits) 2018-10-22 tsepez@chromium.org Fix timezone inconsistency in document methods test. 2018-10-22 hans@chromium.org Rename CPDF_Object::Type enumerators with k prefixes Created with: gclient setdep -r src/third_party/pdfium@ae9bed9f4af1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895475 TBR=dsinclair@chromium.org Change-Id: Iaa2bfccd1c8ae1daa2d41b7c4fc59ca2776d3eac Reviewed-on: https://chromium-review.googlesource.com/c/1294631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601729}
-
Fabio Tirelo authored
Bug: 896690 Change-Id: I7d59fab94c44ae61cfada8d40396486432ba7f81 Reviewed-on: https://chromium-review.googlesource.com/c/1294302 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601728}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/623a134fbd08..b145370ba063 git log 623a134fbd08..b145370ba063 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 Max) Gu [CpuFCP] Support CPU time FCP 2018-10-22 pasko@chromium.org androidStartupMetric: ignore the 2nd run Created with: gclient setdep -r src/third_party/catapult@b145370ba063 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891797 TBR=sullivan@chromium.org Change-Id: If83ef19e92bf4dae24946252090007cdae728505 Reviewed-on: https://chromium-review.googlesource.com/c/1294709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601727}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe4fc148546b..ff1aeb953faf git log fe4fc148546b..ff1aeb953faf --date=short --no-merges --format='%ad %ae %s' 2018-10-22 jvanverth@google.com Ensure that SkYUVSizeInfo is fully initialized with old interface. 2018-10-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-22 halcanary@google.com SkPDF: maybe save some RAM by making the bitsets smaller 2018-10-22 halcanary@google.com SkQP-on-GCE: use fold to make output more legible, remove unnecessary status line Created with: gclient setdep -r src/third_party/skia@ff1aeb953faf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897245 TBR=brianosman@chromium.org Change-Id: I83e5ac477d3a09015a5dc18f2a7c277d24f6f9e6 Reviewed-on: https://chromium-review.googlesource.com/c/1294228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601726}
-
Evan Stade authored
Bug: 640365 Change-Id: I9683f06da8528cf50ce67943932bad09edac28db Reviewed-on: https://chromium-review.googlesource.com/c/1292410 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#601725}
-
Eugene But authored
This test tests implementation specific details, was a maintenance burden for chrome and never caught regressions in page state restoration code. Given that state restoration is a part of CRWWebController, the only way to test page state code is to write an EG test: crbug.com/897768 Removing this test does not really change anything, because the test has been failing consistently for very long time. Bug: 897467 Change-Id: Iaff4a9dc60b720c280c73f00b29ebcae04994e1c Reviewed-on: https://chromium-review.googlesource.com/c/1294196 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#601724}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0ba35798c393..07d0f9dff3d2 git log 0ba35798c393..07d0f9dff3d2 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@07d0f9dff3d2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7d8bfe4140a498de443c3d681ff252936663885f Reviewed-on: https://chromium-review.googlesource.com/c/1294227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601723}
-
Yi Gu authored
TBR=einbinder@chromium.org NOTRY=true Bug: 897075 Change-Id: I0d844c234e40658a58974e1ecfe0a0d933a9e663 Reviewed-on: https://chromium-review.googlesource.com/c/1294696 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601722}
-
Alexey Kozyatinskiy authored
New backend is moved out of injected script source. New custom preview contains only header and bodyGettedId if body is available. bodyGetterId represents function which returns json ML representation of body. R=dgozman@chromium.org Bug: chromium:595206 Change-Id: Ia665fb2794df80fb65c6253980392a73dfa5be84 Reviewed-on: https://chromium-review.googlesource.com/c/1292965 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601721}
-
Jared Saul authored
This is a retry/relanding of https://chromium-review.googlesource.com/c/chromium/src/+/1269524, but with the browsertest additions removed, because something is causing them to be flaky on Win7 builds. Despite making progress, the original CL has already been reverted twice, so I'd like to land this portion of it so if it's reverted in the future, only the browsertests (done as a subsequent CL) will be reverted instead of this big 18-file thing. Bug: 884817 Change-Id: I05983ff8b13c7dbac25e615bba8a5d1fa7cc0819 Reviewed-on: https://chromium-review.googlesource.com/c/1294429Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#601720}
-
Peter Kasting authored
Bug: none Change-Id: I204bd7561f4f1942a5d887e2cd82e1d05677e35d Reviewed-on: https://chromium-review.googlesource.com/c/1285327 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601719}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/ffffc5655474..8f2210a2e54a $ git log ffffc5655..8f2210a2e --date=short --no-merges --format='%ad %ae %s' 2018-10-18 yaowu Correct md5 hashes for three test files 2018-10-18 aniket.dhok Optimize highbd fwd_txfm modules 2018-10-17 satish.suman Optimize highbd fwd_txfm modules 2018-10-16 jimbankoski CONFIG_INSPECTION: fix tx_size and tx_type 2018-10-16 wenyao.liu refine memory in av1_rd_pick_inter_mode_sb() 2018-10-17 sarahparker Expose resize_plane functions 2018-10-17 yaowu Move large array from stack to heap 2018-10-17 ravi.chaudhary Fix thread sanitizer issue in hbd modules 2018-10-16 satish.suman Optimize av1_wiener_convolve_add_src_avx2 2018-10-01 jimbankoski CONFIG_INSPECTION: Enable analysis of Non-Showable Frames 2018-10-12 yunqingwang Use sharp interpolation filter in temporal filtering 2018-10-16 sarahparker Refresh LAST_FRAME with error_resilient show_existing_frame 2018-10-15 tomfinegan cmake: Organize aom.pc and install target support. 2018-10-16 shan add bitstreams with scalability to test vector set 2018-10-03 jonathan.matthews [normative] Respect obu_has_size_field with annexb 2018-10-12 debargha Adjust altref filter strength based on noise level 2018-10-15 urvang TX Raw data: Get small random sample. 2018-10-15 debargha Revert "add edge detector to rdopt" 2018-10-05 wtc Reduce the cpi->scaled_ref_idx array size by 1. 2018-10-14 jimbankoski refactor read_tx_size_vartx: (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Change-Id: I0bed5afdb82736b28cd4f7a003113627b3de2d23 Reviewed-on: https://chromium-review.googlesource.com/c/1294199Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#601718}
-
Khushal authored
Since GPU raster uses the GpuImageDecodeCache for image uploads, ensuring that the image is tracked as discardable avoids at-raster caching for them which has more ref/unref overhead. R=ericrk@chromium.org Bug: 894200 Change-Id: I9d40ab5e0d7c2c2e4a12d7ab8be318cfcba2f590 Reviewed-on: https://chromium-review.googlesource.com/c/1292813Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601717}
-
Joshua Bell authored
A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: https://github.com/WICG/web-locks/issues/51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601716}
-
Nico Weber authored
Writing v8_context_snapshot.bin is now deterministic. Bug: 870584 Change-Id: If70b304db316e4245b093ccdd31fb9aa0dae05ff Reviewed-on: https://chromium-review.googlesource.com/c/1294304Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601715}
-
Daniele Castagna authored
In BufferQueue::CopyBufferDamage DCHECK that a framebuffer is generated instead of ignoring that generation might fail and then avoid deleting it. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I75dcf48a444a613df0a653d3bc5d420afa416430 Reviewed-on: https://chromium-review.googlesource.com/c/1293796Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#601714}
-
Xing Liu authored
This CL implements a code path to make Java side known how OfflineItem should be resumed. OfflineItemState::FAILED: Cannot resume, no further user actions. OfflineItemState::INTERRUPTED: Can resume, but need to restart from beginning. Should hook to retry button. OfflineItemState::PENDING/PAUSE still uses DownloadUtils.isDownloadPending/isDownloadPause, when download can be resumed in the middle. Bug: 895018,895013 Change-Id: I36a82cf3754093bfab85a623818d9e2392a6fc73 Reviewed-on: https://chromium-review.googlesource.com/c/1289677 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601713}
-
Travis Skare authored
Putting the result of the calculation into fill_into_edit places it in the omnibox when the user focuses the suggestion, allowing them to copy the result or use it as the basis of another calculation. Whereas leaving the query as the operands allows the user to still use the suggestion to get to a SRP with a calculator on it, which is more useful than searching for the result. Bug: 896407 Change-Id: Ie42ad7d21824af6d518414b6d2bb5212bba7580c Reviewed-on: https://chromium-review.googlesource.com/c/1287181 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#601712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d19984aa7d87..08cf46bc4eec Created with: gclient setdep -r src-internal@08cf46bc4eec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3dce790dbe1841bd2058ff3e3ebf9f3bc7975d16 Reviewed-on: https://chromium-review.googlesource.com/c/1294225Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601711}
-
James Cook authored
This is needed for it to observe clicks outside the browser window (e.g. on the desktop) under SingleProcessMash on Chrome OS. Bug: 896948 Test: existing content_unittests Change-Id: I8cdfa78f934255bde7e23a3964990e418717eb54 Reviewed-on: https://chromium-review.googlesource.com/c/1292810Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601710}
-
Leonard Grey authored
Bug: 850098 Change-Id: If6de5922311ba501c5a746d9228993b42eff0b60 Reviewed-on: https://chromium-review.googlesource.com/c/1291569 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601709}
-
Michael Spang authored
This will probe I8042 devices as internal devices without having to fall back to examining the device hierarchy in sysfs. Bug: b/116723180 Test: events_unittests Change-Id: Ie1f5d9854afdd039b96655793dc7b5be2881bdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1281235Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601708}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bc77bb4..c18347a7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a3ffe190585c91bb35d3ab5b1669a20b7f08bb3 Reviewed-on: https://chromium-review.googlesource.com/c/1294391Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601707}
-
dpapad authored
Specificity of ::slotted() rules is different in Shadow DOM v0 and v1. The latter is the correct specced behavior, but the code so far relied on the former. Bug: 896674 Change-Id: I0eb2fc0925e1cb83db732e89d958acab4a8fc5fb Reviewed-on: https://chromium-review.googlesource.com/c/1290198Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601706}
-
Peter Wen authored
Including warning and mitigation for errors. Bug: 877956 Change-Id: Id0abfce282d6f3a15ee5a9d4a70751839f2946a2 Reviewed-on: https://chromium-review.googlesource.com/c/1294592Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601705}
-
Tom Anderson authored
BUG=784492 R=thakis Change-Id: I4a2d637f9fab0fb2bc4c05dc0637a73233b21ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1294449 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601704}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ab9bc6fcb3d..623a134fbd08 git log 6ab9bc6fcb3d..623a134fbd08 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 benjhayden@chromium.org Reland Migrate trace_viewer.gypi to gni 2018-10-22 perezju@chromium.org [soundwave] Post process data for data studios Created with: gclient setdep -r src/third_party/catapult@623a134fbd08 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895699,chromium:894773 TBR=sullivan@chromium.org Change-Id: I0eb0337711b8a2b45055d5b63e4b3fde7c9d3478 Reviewed-on: https://chromium-review.googlesource.com/c/1294220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601703}
-
Yi Gu authored
ExtensionApiTest.DisplayModeWindowIsInFullscreen and ChromeNavigationBrowserTest.TransientEntryPreservedOnMultipleNavigationsDuringInterstitial started to fail after patch crrev.com/c/1292513 Given that the patch was landed 4 hours ago, will disable the tests and assign the bug to the patch owner. TBR=sky@chromium.org NOTRY=true Bug: 897879 Change-Id: I559a1820293fe057eebb628b9d5aa962f1999020 Reviewed-on: https://chromium-review.googlesource.com/c/1294599 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601702}
-
Clark DuVall authored
This matches the logic in http://crrev.com/c/1045025. A couple of the most recent configs are kept around in case the config changes in the middle of a request, which will allow the headers to be correct in that case. Also adds a browsertest for basic config changes. Bug: 721403 Change-Id: I788dcf52efa9a86031fd33cbc77d1be45022b19c Reviewed-on: https://chromium-review.googlesource.com/c/1292510 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#601701}
-