- 29 May, 2018 40 commits
-
-
Sebastien Marchand authored
Follow up on this comment: https://chromium-review.googlesource.com/c/chromium/src/+/1068665/13/services/resource_coordinator/public/mojom/page_signal.mojom#18 Change-Id: Ib930db9c0326c9fae8cd7c2bf8b771d5a196c164 Reviewed-on: https://chromium-review.googlesource.com/1076897Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#562576}
-
Helen Li authored
- Add extra return values to NetworkContext::CreateTCPConnectedSocket, because //extensions depends on the ability to get local address and peer address synchronously. - Add a network::mojom::SSLConfig to UpgradeToTLS() because //extensions depends on the ability to configure max and min tls version. - Add two non-pure virtual methods (SetNoDelay and SetKeepAlive) to net/socket/transport_client_socket.h, so I can mock out those in tests using mock socket data (net::MockClientSocket is a subclass of net::TransportClientSocket). Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2019d783b29ff0d68dbea95fb7a0f2d5e81a70fd Reviewed-on: https://chromium-review.googlesource.com/1073191Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#562575}
-
Anders Hartvoll Ruud authored
This makes custom properties _almost_ normal w.r.t. style building. As long as we DCHECK that the value is not initial/inherit before applying, we can treat it as any other CSSProperty. R=futhark@chromium.org Bug: 751354 Change-Id: I2009320d95e1371df550fd2a55d7d561042d2061 Reviewed-on: https://chromium-review.googlesource.com/1076327 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562574}
-
Mohammad Refaat authored
This may have caused the crash in crbug/847026 Bug: 847026 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia3b4a4a756aec2898f8933173a61bdb097f935b5 Reviewed-on: https://chromium-review.googlesource.com/1076672Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#562573}
-
Denis Yaroshevskiy authored
decltype of a ternary operator between const ref and a temporary value is a const value. Which is copied into another temporary and then the const ref extends it's lifetime. The intention in the code seems to be to avoid copying match in a common case. This patch does it in propper way. Change-Id: Id4e41cd12b4bc76b8439b459a61603af30c1c8f3 Reviewed-on: https://chromium-review.googlesource.com/1076628Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#562572}
-
James Cook authored
Mash (out-of-process ash) doesn't have a CursorClient yet. We'll have one in a few weeks as we switch to ws2 (window server as a library built into ash), so just early exit on null. Bug: 847557, 631103 Test: chrome --enable-features=Mash can login on device Change-Id: I3190785c218b455652151acad213fef94e85beec Reviewed-on: https://chromium-review.googlesource.com/1077074Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#562571}
-
David Black authored
AssistantBubbleView should be concerned with choreography of its child views, not their specific implementations. Will also make it easier to unit test view classes in isolation. Note that this CL also creates a constants file for Assistant UI. Bug: b:80245607 Change-Id: I05be99e93383c5df61c279a54b811a03a8a3cb29 Reviewed-on: https://chromium-review.googlesource.com/1072147Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#562570}
-
Findit authored
This reverts commit b591d330. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 562448 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1OTFkMzMwMzA4NzI5ZmU3OTBmMTg5M2Y3ODk2ZGE3YzVlNTlkN2IM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10089 Sample Failed Step: net_unittests Original change's description: > Don't call GetOrCreateGroup until we need a group > > Bug: 830917 > Change-Id: I52deae4c68054b0dcef62b18e7b263830b438162 > Reviewed-on: https://chromium-review.googlesource.com/1010507 > Commit-Queue: Brad Lassey <lassey@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562448} Change-Id: I3064c71c087498a908ab9380b560290a3f38b49a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830917 Reviewed-on: https://chromium-review.googlesource.com/1077033 Cr-Commit-Position: refs/heads/master@{#562569}
-
Dmitry Gozman authored
TBR=eseckler@chromium.org Change-Id: If3d1d379e145091264f6f2110de1046c860c8cfe Reviewed-on: https://chromium-review.googlesource.com/1076973 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562568}
-
Pavel Feldman authored
Change-Id: I422b4fb9d65ab231e9736a890d292d7e2889c270 Reviewed-on: https://chromium-review.googlesource.com/1077084Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562567}
-
Xianzhu Wang authored
- Combine the original paint and raster invalidation tests in - box_paint_invalidator_test.cc - paint_invalidation_test.cc - raster_invalidation_test.cc into paint_and_raster_invalidation_test.cc. - Make the moved tests as well as CaretDisplayItemClientTest work for SPv175, BlinkGenPropertyTrees and SPv2. - Remove SPv1 paint test configuration and code path in the changed code. - Fix two small bugs to make the all the tests pass: - Make the child frame not initially throttled when it is set HTML contents. Previously the child frame will skip painting because it's always in the initial-throttled state. - Avoid invalidation on invisible scrollbar change. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1bf491c2ca17d89f967b2989829d6ba871c844c6 Reviewed-on: https://chromium-review.googlesource.com/1075807 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#562566}
-
Jungshik Shin authored
U+0E1E (พ) => w U+0E9E (ພ) => w U+0E9F (ຟ) => w U+0EA3 (ຣ) => s U+0EAE (ຮ) => s U+0E1A (บ) => u U+0E9A (ບ) => u Note that U+0E1F(ฟ) and U+0E23 (ร) were added a while ago. BUG=833143 TEST=components_unittests --gtest_filter=*IDN* Change-Id: I882e7d272cdca1d80aa23be94b4d7906ff8653c1 Reviewed-on: https://chromium-review.googlesource.com/1058710Reviewed-by:Peter Kasting <pkasting@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562565}
-
Bin Wu authored
Merge internal change: 197832805 R=rch@chromium.org Change-Id: I2f583a74507647737b330921b25488dc0053e957 Reviewed-on: https://chromium-review.googlesource.com/1070804Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#562564}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2014bc..316c606 git log c2014bc..316c606 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 jmadill@chromium.org Vulkan: Call GraphResource instead of GraphNode. 2018-05-29 geofflang@chromium.org Return a program binary size of 0 when the program is not linked. Created with: gclient setdep -r src/third_party/angle@316c606 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I8ddff0dde3fa92bfad8ce01f823d5e0368b71128 Reviewed-on: https://chromium-review.googlesource.com/1076830 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562563}
-
Kurt Horimoto authored
This CL adds an additional fullscreen viewport adjustment experiment. In this approach, the WKWebView's frame is translated up and down to account for the bottom inset created by the secondary toolbar. Meanwhile, the top safe area inset is adjusted to push the top of the rendered viewport below the toolbars. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idb3ae9fb11ca2b35ee5219a52f9e08aa14363a7b Reviewed-on: https://chromium-review.googlesource.com/1066975 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562562}
-
Mark Pearson authored
Fix table of contents indentation. Change-Id: I245c2bc0ac2fcdf3bc7e4234db809a778dd2dc5b Reviewed-on: https://chromium-review.googlesource.com/1076682Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562561}
-
Calder Kitagawa authored
Fixes a CHECK failure in Zucchini Apply found by ClusterFuzz. Scenario: A disassembler parses an image element and shrinks it to be the understood size. Apply expects that this understood size is identical to the size of the element it is trying to patch. This expectation will always hold for "good" patch data but for an arbitary patch may not. This results in a CHECK failure when getting reference writers. Solution: After parsing, check that the disassembler sizes match their respective image sizes. Fail to Apply and print an error message if this is not the case. Bug: 847278 Change-Id: I96edb738b8f9ea2d16193ea1aa2def7319ee8f70 Reviewed-on: https://chromium-review.googlesource.com/1076369 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#562560}
-
David Michael Barr authored
The include structure has changed in libaom. Bug: 783519 Change-Id: Ibea981e41e25ef5aa18c3c840b6ebfae9ceee526 Reviewed-on: https://chromium-review.googlesource.com/1074797Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#562559}
-
Xing Liu authored
When users choose not to prompt the download location dialog. We still prompt the dialog. This is caused by two reasons: 1. The pref is persisted when user click the download button. Instead, the pref should also be persisted when users click on the checkbox. 2. When exisiting file results in file name conflict, we didn't check the pref. Bug: 845311 Change-Id: I8a3bf53cbb9edcd5905003b5739400243977e55a Reviewed-on: https://chromium-review.googlesource.com/1074378 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562558}
-
Andrew Grieve authored
And fix diagnose_bloat.py regexp that extracts summary from supersize output Bug: 702625 Change-Id: Ib8941a2cb84c18d02dd980e4725f44ea6ed4fcb7 Reviewed-on: https://chromium-review.googlesource.com/1071708 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#562557}
-
Biao She authored
We only print bindings in DEBUG build. However, we generate code for printing bindings in release build for each new binding we create. This CL simply hides all printing related code behind DEBUG build. It reduces the native binary size about 20k. Bug: NONE Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ie6b6c6148369717b89c1e4f68336c0950954cc06 Reviewed-on: https://chromium-review.googlesource.com/1076308 Commit-Queue: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#562556}
-
Malay Keshav authored
We use a change observer to trigger updating the selected mode of a display. This is useful for the drop down menu we use to select the mode on external displays. However, if display zoom is disabled, we show a slider instead of a drop down. The slider triggers the same pref value change even if the user is still dragging it. This causes a usability regression on the settings resolution slider. To fix this, the patch adds a check which ensures we only listen to events fired due to releasing the slider when display zoom is disabled. Bug: 845712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9965bdf3121289ac29f38175cc9ad179cda41497 Component: Display settings, resolution slider Reviewed-on: https://chromium-review.googlesource.com/1069773 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562555}
-
Marcin Wiacek authored
Change-Id: I16161b7a07ed8291bb252f81cd568c3cf847c402 Reviewed-on: https://chromium-review.googlesource.com/1075311Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#562554}
-
Max Rebuschatis authored
This change adds the capability to request a hit-test on an XRSession. The session queries the magic window provider to get any hits based on the given ray and then resolves a promise with an array of hit results. This test is added by https://crrev.com/c/1040880, which will land immediately after this one. Bug: 833633 Test: third_party/WebKit/LayoutTests/xr/ar_hittest.html Change-Id: I225297bcf052765f156790a588eafb817ed75e08 Reviewed-on: https://chromium-review.googlesource.com/1018524 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#562553}
-
Nico Weber authored
Bug: 843511,845598 Change-Id: I17b82fb59da08c5522148d5bf57d8c8bbad9b6d6 Reviewed-on: https://chromium-review.googlesource.com/1069228 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#562552}
-
erikchen authored
There was a race condition that could cause the vm region map in a memlog trace to contain full file paths. This happened if the CoordinatorImpl callback occurred before the TracingController was able to set the TracingConfig on TraceLog. Change-Id: If3b424ed13b91a0bd644316fe1a7b30a6254b191 Reviewed-on: https://chromium-review.googlesource.com/1072312Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562551}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/66c64a74..8030067c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia8c9e477d466ca695a9b656f5e41e2ba945f0bcc Reviewed-on: https://chromium-review.googlesource.com/1076503Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#562550}
-
Scott Haseley authored
FrameScheduler already handles timer freezing, and there isn't anything (non-trivial) left on default timer queue, so this should be safe. Per-frame timer queue is controlled by FrameScheduler. This patch also moves |frozen_when_backgrounded| into the Policy. Bug: 820634 Change-Id: I95527a9919d37647a13e59ebcceede5fa36774c6 Reviewed-on: https://chromium-review.googlesource.com/1073649 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562549}
-
Robert Sesek authored
Bug: 847518 Change-Id: Icd279d0a71e9c7b617c965674ee76d37ef23b29f Reviewed-on: https://chromium-review.googlesource.com/1076354Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#562548}
-
David Michael Barr authored
linux/arm for targets without NEON support. linux/arm-neon-cpu-detect for deprecated(Bug 448055) Android config. Bug: 783519 Change-Id: Ib050ed227ddfcd759efbe08e80a781ca6f675dbe Reviewed-on: https://chromium-review.googlesource.com/1068902 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562547}
-
Ken Rockot authored
ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled forever. It was originally disabled for flakiness, but neither the flaky crashes nor the code which was crashing appear to exist anymore. This CL makes some minor updates to the test expectations and re-enables the test. Bug: 140976,841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62 Reviewed-on: https://chromium-review.googlesource.com/1076683Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#562546}
-
Ahmed Fakhry authored
In order to be able to set the Color Transform Matrix (CTM) and a default gamma/degamma Loopup Tables (LUTs) separately for Night Light on the Cathode Ray Tube Controller (CRTC), this CL splits the existing API into two separate calls. BUG=749250 TEST=Updated tests in DisplayColorManagerTest and NightLightCrtcTest. Change-Id: Ic21475e7a5d86dd8d2df9f6e3ef8eb16ee213d84 Reviewed-on: https://chromium-review.googlesource.com/1070317Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#562545}
-
Yuke Liao authored
This CL adds a builder to chromium.fyi to generate code coverage reports on linux platform. Bug: 825362 Change-Id: If3942d9a7b37da6db2d40bc0b04ad7ac89460deb Reviewed-on: https://chromium-review.googlesource.com/1073071Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#562544}
-
Brian Anderson authored
* Enable FrameMetrics to differentiate between source type, source thread, and compile target. * Report sample count for worst windows. * Move tracing logic from StreamAnalyzer to StreamAnalysis, which allows results to be stored and traced at a later point. Bug: 790759 Change-Id: I763a0f354d97119c16635675a2b9fa29a947f417 Reviewed-on: https://chromium-review.googlesource.com/1072872 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#562543}
-
Findit authored
This reverts commit 2c24de69. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 562467 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJjMjRkZTY5NTMyY2IyNmNjMTk5YmIwN2Y5ZWJmYTY3MzBiYzI2ZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/69346 Sample Failed Step: chrome_elf_unittests Original change's description: > [chrome_elf, third-party block support] full hook testing. > > Adding some full tests, including some corner cases. These tests > initialize the whole third_party_dlls project, to exercise the new hook. > > Non-test adjustments: > - pe_image_safe: |directory| == 0 is valid! (export dir) > - hook: Exposed a GetDataFromImageForTesting() function. > Also a few fixes in the hook shim: > * Use the PEImageSafe constructor that takes an HMODULE. > * Use the new GetFingerprintString() api. > * Don't hash an empty image or section name. > * Pass a name hash instead of non-hashed into LogLoadAttempt > if a DLL was allowed. > - packed_list_file: > * GetFingerprintHash() removed from this project. > * Also, gracefully handle a blacklist file that exists, but is empty. > - packed_list_format: > * Added "new" GetFingerprintString() API here. > It centralizes the format string without doing the hash. > > Test: chrome_elf_unittests.exe, ThirdPartyTest.* > Bug: 769590 > Change-Id: I592f76b884312bb267eb6747a478e271fc96e689 > Reviewed-on: https://chromium-review.googlesource.com/1069694 > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562467} Change-Id: I46cf1feddbc80a60ca92b44152d2f7ad0ef865e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769590 Reviewed-on: https://chromium-review.googlesource.com/1077029 Cr-Commit-Position: refs/heads/master@{#562542}
-
Miguel Casas authored
Removed handling of gfx::BufferFormat::BGRX_1010102 from gl_image_native_pixmap, because we support XB30 instead. Bug: 776093 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I07a54ca42af9469df10469776ff3e3f4d3b0b09c Reviewed-on: https://chromium-review.googlesource.com/1073052Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562541}
-
Georges Khalil authored
This change adds the necessary reported fields from within Chrome to remove the need for the native host. BUG=847264 Change-Id: Id7e0489749c7e878c023d698e9f56ea0b2ef4ab9 Reviewed-on: https://chromium-review.googlesource.com/1074498 Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#562540}
-
Sebastien Marchand authored
This forwards the |kNonPersistentNotificationCreated| events received in services/resource_coordinator/ to the page signal observer on the browser side (c/b/rc). Non-persistent notifications are web notifications created by a page, they require the page to be alive to be created (persistent notifications are created by service workers and don't rely on the page to be alive) These events will be recorded in the local site characteristics database in a further CL. We need to consider potential usage of non-persistent web notifications before proactively discarding a tab to make sure that we don't discard a tab that could try to communicate with the user via non-persistent web notifications. Bug: 773382 Change-Id: I0245cd4514541a2f70b547d5ce9fab0e633ddf94 Reviewed-on: https://chromium-review.googlesource.com/1068665Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#562539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 58bfcc57. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" acf0cdd6 "Clamp argument to SVGGeometryElement.getPointAtLength to [0, length]" 63ca6994 "CSS: ::part invalidation layout tests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18903 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ifccae2f41c6b5c9f5c88f64f78e8134bc6d9bdbd Reviewed-on: https://chromium-review.googlesource.com/1076322 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#562538}
-
Xiaohan Wang authored
- In CdmAdapter, do not expose a Decryptor is CdmProxy is requested. - In MojoCdm, support CDM ID based Decryptor in MojoCdm. - Implement ClearKeyCdmProxy::SetKey() to load a license in its AesDecryptor so it can perform decryption. - Update ECKEncryptedMediaTest.CdmProxy test to cover playback using ClearKeyCdmProxy to do decryption. TBR: rkuroiwa@chromium.org Bug: 806018 Test: ECKEncryptedMediaTest.CdmProxy covers the new path Change-Id: Icd1cbddb8535f9b2ef5b20c3b1535d8c41dbb19c Reviewed-on: https://chromium-review.googlesource.com/1071073 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#562537}
-