- 05 Oct, 2018 40 commits
-
-
John Z Wu authored
Bug: 770984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iad12bba9a759ba69771606144d8cec7f68b61eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1257891Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597342}
-
James Cook authored
This allows testing ChromeVox with multiple simultaneous mash apps. * Turn on a11y support in AuraInit::InitParams * Initialize ash window property transport Bug: 888147, 892743 Change-Id: I3114787aa687dd6a233b7411739fa3f938cf4399 Reviewed-on: https://chromium-review.googlesource.com/c/1265535 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597341}
-
Jun Mukai authored
This expectation fails due to the button which is showing with Mash. This is basically for developers, so it's okay to skip the checks. BUG=892730 TEST=interactive_ui_tests Change-Id: Ibebe65891bdbb1d9539e89f42114c39435ff2737 Reviewed-on: https://chromium-review.googlesource.com/c/1265895Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597340}
-
Matt Menke authored
This matches behavior of all other browsers. WPT tests were recently updated to check for the more common behavior, instead of Chrome's divergent behavior, so this CL also updates the expectations of a number of layout tests. Bug: 891251 Change-Id: I3b0b091fe52000d1adb597c7fe6491dd3d2371c4 Reviewed-on: https://chromium-review.googlesource.com/c/1256284 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597339}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef8a3eb5221c..4d6f60512341 git log ef8a3eb5221c..4d6f60512341 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d62b62d8..7099444b (597059:597172) Created with: gclient setdep -r src/third_party/webrtc@4d6f60512341 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I699f5ddfb91ba80f43580c16f7eb1544c64c0a45 Reviewed-on: https://chromium-review.googlesource.com/c/1265050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597338}
-
Becca Hughes authored
Add UMA metrics for tracking audio focus events. There are three histograms added in total; the first records RequestAudioFocus calls, the second records AbandonAudioFocus calls and the third records requested AudioFocusTypes. In the future we will probably switch these with UKM but UKM is not available for ARC++ yet. BUG=883958 Change-Id: I1092b9d1c638a13526687ac77b87d66490e4b89c Reviewed-on: https://chromium-review.googlesource.com/c/1238871 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#597337}
-
David Trainor authored
If we've failed to grab a thumbnail for a particular content id, don't try again to avoid lots of wasted file access and computation. BUG=892320 Change-Id: I9d980c0cce1644f2c0da3d8699c5e25e220af8f0 Reviewed-on: https://chromium-review.googlesource.com/c/1263416 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597336}
-
Tommy C. Li authored
After this CL, when the user opens the page info bubble (for instance by clicking the lock icon), Chrome shows the full URL in the search bar. This is a way for users to show the full underlying URL for both the Steady State Elisions and Query in Omnibox features. We are currently gating this behavior on the Query in Omnibox flag, since it's still under active experimentation. Bug: 874592 Change-Id: Icdb1b8ac79f6f8f3a90b9f82dcd838c5af6b767f Reviewed-on: https://chromium-review.googlesource.com/c/1265497 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#597335}
-
Ryan Hansberry authored
Bug: 892477 Change-Id: If64554bc2e0a779c896520bcee25d7948b873200 Reviewed-on: https://chromium-review.googlesource.com/c/1265899 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597334}
-
Xianzhu Wang authored
Such objects are not actual stacking contexts. For now we know LayoutTableCol is one of such objects for now, though it should support effects (crbug.com/892734). Bug: 890615 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7fe4b09e5b95731b0ce3805583b6391677419216 Reviewed-on: https://chromium-review.googlesource.com/c/1262927 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597333}
-
Marijn Kruisselbrink authored
The test is still flaky on Linux TSan builder. Tbr: mpearson@chromium.org Bug: 891959 Change-Id: I1233fb7a8fb60465064e5e4bd80fcc5a57e41858 Reviewed-on: https://chromium-review.googlesource.com/c/1265823Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597332}
-
Matt Menke authored
The latest spec can be found at https://mimesniff.spec.whatwg.org/ In particular, this CL makes the parser: * Trim whitespace within quotes. * Not ignore first "(" in a charset or anything after it. * Allow quoted empty strings. * Prefer values closed to the beginning of the string. This makes a number of previously failing WPT layout tests pass, though there still remain some deviations from the spec: * When there are multiple Content-Type lines, we use the last. * We don't restrict the characters we allow in Content-Type fields. * We trim whitespace before the first quote characters (The spec indicates that if there's a space after the "=", it's treated as a non-quoted string). Bug: 788491, 772343 Change-Id: Ieeb11eb76d824a9df5130d8c5dc0be3b442ca366 Reviewed-on: https://chromium-review.googlesource.com/c/1257443 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597331}
-
Nektarios Paisios authored
Some widgets in Views, such as table and tree view controls, make use of lightweight objects to display their contents. These lightweight objects are not View classes and hence have no native accessibility support. To make them accessible, we introduce a virtual accessibility view that will be used to provide the accessibility support for those objects. In addition, we could make use of virtual accessibility views to override the children of a real view and create a completely new accessibility tree hanging off that real view. This creates more flexibility as it allows us to construct a virtual accessibility tree that is not always a mirror image of the hierarchy of the real views. R=dmazzoni@chromium.org Bug: 101762 Tested: unit tests Change-Id: Iab8fea36ef44373e06d9408c407a27caa7c4219c Reviewed-on: https://chromium-review.googlesource.com/c/1229234 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#597330}
-
Gabriel Marin authored
Original CL: - https://chromium-review.googlesource.com/c/chromium/src/+/777963 Make some tcmalloc constants truly const. Change-Id: I84e036d5c71373ce3572d4b67b06fcadb25bb347 Reviewed-on: https://chromium-review.googlesource.com/777963 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517642} BUG=724399,b:70905156 Change-Id: I21e732e8001eeea57b7fea95cc9ec6df21f12dea Reviewed-on: https://chromium-review.googlesource.com/c/1130809Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597329}
-
mrefaat authored
Detect download failure when a corrupted PDF was downloaded and log the OpenIn download result in all cases. Bug: 888545 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19eefd9c1b6da0c9d6b18bfcc0f3953fb33ef391 Reviewed-on: https://chromium-review.googlesource.com/c/1259295Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#597328}
-
Henrique Nakashima authored
Change-Id: Icd771944352b9c161933c477fe714492aa38bbe7 Reviewed-on: https://chromium-review.googlesource.com/c/1265637Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#597327}
-
Xiaohui Chen authored
Disable screen reader reading voice query result because Assistant is going to respond with voice anyway. Bug: b:113734839 Test: locally build and test Change-Id: Ifa1079a6c551e8682857b8ab8e8afe0dd05218a7 Reviewed-on: https://chromium-review.googlesource.com/c/1232883Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#597326}
-
Marijn Kruisselbrink authored
Bug: 892772 Change-Id: Id0359aeda04a4d4fbe41d3b7b6fb6df8897da60f Tbr: schenney@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1265816Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597325}
-
Ken Rockot authored
Adds a new ServiceBinding helper to the Service Manager's client library. This is intended as a replacement for ServiceContext, because ServiceContext is cumbersome in its insistence to own the corresponding Service object. ServiceBinding, like ServiceContext, deals with the IPC interface between a local Service instance and the Service Manager, exposing interesting events to the Service implementation while also providing it access to its Connector and assigned Identity. Some particularly gnarly tests have been updated to use ServiceBinding in lieu of ServiceContext. Furthermore, without ServiceContext and with a lot of its legacy motivations gone, ServiceRunner isn't terribly useful either. The tests have also been trivially updated to manage their own MessageLoop instead of using ServiceRunner. This is the first in a series of patches which aim to completely eliminate ServiceContext, ForwardingService (in service.h), and ServiceRunner, requiring Service implementations to write a little more boilerplate in exchange for flexibility with ownership semantics. Bug: 891780 Change-Id: Ib0c1d3263f34a5e33a167a8187edad1d52413f73 Reviewed-on: https://chromium-review.googlesource.com/c/1259485Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#597324}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc81511e. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25886 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ie11269620d31a49ab9ae1640a6e6edf4fb96c4af Reviewed-on: https://chromium-review.googlesource.com/c/1265027 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597323}
-
Raymond Toy authored
The Media nodes should be on the AudioContext, not BaseAudioContext. Make it so. This also implies that the constructors for these nodes should take an AudioContext, not BaseAudioContext. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913, 842225, 697123 Change-Id: Ic2a82a2343fa4a169a26733375c646fec61769ed Reviewed-on: https://chromium-review.googlesource.com/c/1069692 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597322}
-
Gabriel Marin authored
Small code refactoring to reduce indentation. This change was originally part of https://codereview.chromium.org/9963095. BUG=724399,b:70905156 Change-Id: Id9d13559380f7c62653b03723cb13de3aeb96074 Reviewed-on: https://chromium-review.googlesource.com/c/1130804Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597321}
-
Marijn Kruisselbrink authored
Tbr: robertma@chromium.org Bug: 856601 Change-Id: Ib6b0b9c13c89de9637222601d0830cef7bcaea8f Reviewed-on: https://chromium-review.googlesource.com/c/1265561Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597320}
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/7200028 Decrease the kHashbits to 12 effectively restoring the pre-r89459 size of the page heap. TBR=antonm TEST=VM usage drops on the perf bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89670 BUG=724399,b:70905156 Change-Id: Id0eedab1c33b53e47970561547f75c440f5d9ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1130808Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597319}
-
Jao-ke Chin-Lee authored
Mark the original master as chromium.webkit and add testing/buildbot changes. BUG=790343 Change-Id: I11f61b9100f0879c9cb6d63119d7d508a9d779c7 Reviewed-on: https://chromium-review.googlesource.com/c/1262677Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597318}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89a5e559a7c9..37377c3e485a Created with: gclient setdep -r src-internal@37377c3e485a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:731383 TBR=mmoss@chromium.org Change-Id: I679d4bf4d3c61b3d949444d25098d30f18934436 Reviewed-on: https://chromium-review.googlesource.com/c/1265053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597317}
-
Henrique Nakashima authored
As per the style guide. Change-Id: Ie8519eba699a66c224fb669b782627af276d1872 Reviewed-on: https://chromium-review.googlesource.com/c/1265507Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#597316}
-
Marijn Kruisselbrink authored
This reverts commit ad61fb27. Reason for revert: New PDFPluginDisabledTest.IframePdfPlaceholderWithCSP test is failing in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5617 Original change's description: > Click to Open PDF: Put placeholder HTML in IFRAMEs directly > > Previously, when the user has a disabled PDF plugin (or no PDF plugin) > and the website has an IFRAMEed PDF, when Click to Open PDF was enabled, > we would inject a fake <object> tag into the IFRAME to force a PDF > plugin placeholder to appear. > > This approach is problematic with CSP, as CSP may forbid OBJECT tags > from loading in IFRAMEs. > > This CL instead injects the placeholder HTML directly into the IFRAME. > > In the IFRAME case, the button is now a plain link, which should allow > the user to click it and download the PDF even if CSP forbids <object> > tags or JavaScript. > > It still may trigger a CSP warning if IFRAME is prohibited from running > JavaScript, but that only hurts keyboard-accessibility, and doesn't > prevent the mainstream use case from working. > > This CL also prevents the <object> tag from auto-opening the PDF after > download, which was probably a mistake, since that overrides the user > configurable "Always open with system viewer" option. > > Bug: 887752, 879149, 878871 > Change-Id: I900c08331d2cfc96ea7cd1cd46ea594445b0920b > Reviewed-on: https://chromium-review.googlesource.com/c/1246956 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597192} TBR=thestig@chromium.org,tommycli@chromium.org,jochen@chromium.org,mkwst@chromium.org Change-Id: I8a5554c0489ec76a4adb35ca93afef9c4354316e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887752, 879149, 878871 Reviewed-on: https://chromium-review.googlesource.com/c/1265826Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597315}
-
Lily Chen authored
This change adds a histogram that tracks the number of cache entries examined when no matching entry is found (which is most of the time). This will allow us to have a better proxy for HTTP auth cache size. Bug: 757116 Change-Id: I8a4b7348a473d2802ac12dda2589569e523b3e5e Reviewed-on: https://chromium-review.googlesource.com/c/1265435Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#597314}
-
Egor Pasko authored
These histograms are recorded only in suffixed forms: appending "Tabbed" or "WebApk". This tiny change would avoid suggesting the base name in the UMA dashboard. Bug: None Change-Id: I4e9f3e235f1691b886df87b5008e6364da4aa999 Reviewed-on: https://chromium-review.googlesource.com/c/1261636Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#597313}
-
Victor Vasiliev authored
It's not used anywhere else in the code. R=bnc@chromium.org Change-Id: I0c6a71b161c7cd3823700b522be3a09e33369685 Reviewed-on: https://chromium-review.googlesource.com/c/1262896Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#597312}
-
John Delaney authored
Currently the was_fetched_via_cache flag is not set correctly when url loader clients are notified that a resource response was received when the network service is not enabled. This flag should be set if the underlying UrlRequest was cached. Change-Id: I7f9cf92723879836e40a29b109b60baf782b32eb Reviewed-on: https://chromium-review.googlesource.com/c/1259545Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597311}
-
Philip Jägenstedt authored
These have been removed in wpt's testharness.js: https://github.com/web-platform-tests/wpt/pull/12976 This is blocking updating LayoutTests/resources/testharness.js. `assert_exists` was blindly replaced with `assert_own_property` in all files (s/assert_own_property/assert_exists/g) and `assert_not_exists` was changed on a case-by-case basis. Bug: 892613 Change-Id: Ied0d7952c5737b5afe50088cdd8be2c9629d40b7 Reviewed-on: https://chromium-review.googlesource.com/c/1264641Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#597310}
-
John Williams authored
Bug: 883887 Change-Id: I9ce93c85e7fcfb2ad4625fe35abb3b8ee9fa2fd5 Reviewed-on: https://chromium-review.googlesource.com/c/1260103Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597309}
-
Kevin McNee authored
Loading this page is timing out due to a catapult roll. TBR=yuzus@chromium.org Bug: 892352 Change-Id: I0493da4014439537ede38679db2e6ba702d01247 Reviewed-on: https://chromium-review.googlesource.com/c/1265128Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597308}
-
Filip Gorski authored
* Enabling the feature by default * Removing old experiment groups. Bug: 714709 Change-Id: I7962bcba392d67402a58f89510298be034b47d11 Reviewed-on: https://chromium-review.googlesource.com/c/1259606Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#597307}
-
Ben Kelly authored
When SimpleCache starts up it runs a consistency check and performs any necessary version upgrades. The cache_storage code is seeing SimpleCache initialization fail on some devices. This histogram will record why the SimpleCache check and upgrade process is failing to help track down any underlying problems. R=morlovich@chromium.org Bug: 889976 Change-Id: I6072d7d11294d360d3ff48b44ae0531fce03e004 Reviewed-on: https://chromium-review.googlesource.com/c/1249961 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597306}
-
David Black authored
AssistantContainerViewAnimator is the class responsible for rebounding AssistantContainerView smoothly in response to size/state changes. This CL moves the existing animation logic into AssistantContainerViewAnimatorLegacyImpl with the hopes that we will be able to deprecate it in favor of a more performant implementation. Bug: b:116657110, b:113348616 Change-Id: Ic81beb977c176f445d3ce8ef1c075ef0e75cd64c Reviewed-on: https://chromium-review.googlesource.com/c/1244540 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#597305}
-
Charlie Reis authored
The formatting logic may rewrite such URLs into an unsafe state. This is a first step before preventing navigations to invalid URLs entirely. Bug: 850824 Change-Id: I71743bfb4b610d55ce901ee8902125f934a2bb23 Reviewed-on: https://chromium-review.googlesource.com/c/1252942Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#597304}
-
Becca Hughes authored
Add a source name in AudioFocusDelegateDefault for "web". BUG=875004 Change-Id: Id80b828ee7b717d8f9c0b624974bc3758db1c858 Reviewed-on: https://chromium-review.googlesource.com/c/1239540 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597303}
-