- 20 Jul, 2017 40 commits
-
-
Alexander Alekseev authored
This CL updates Gaia containers size after its state has been updated, not before. Bug: 745933 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1517fe77e1148f6af27e816782767f9b5ee22d77 Reviewed-on: https://chromium-review.googlesource.com/578869Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488387}
-
Stephen McGruer authored
Bug: 699244 Change-Id: I5187cfa7e0e170a50bc270fd7f852ecdb239dfa7 Reviewed-on: https://chromium-review.googlesource.com/559789Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#488386}
-
Alexander Alekseev authored
This CL fixes the problem with Gaia screen error overlay visibility. Bug: 738806 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I741951a0d1d8ba511b37783cb5651fdc50a05378 Reviewed-on: https://chromium-review.googlesource.com/579287Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488385}
-
Vaclav Brozek authored
As logs from trybots suggest (see the associated bug), the state of the UI during this test sometimes lags behind the test's expectations. This CL attempts to prevent it by draining the UI thread at the moment where the test frequently fails. This was impossible to verify on available trybots, but should at least be verifiable on https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS, where the flake is rather reliable (the test never passes on the very first attempt). TBR=sdefresne@chromium.org Bug: 747058 Change-Id: Ib9cd3c2669357f22bc8d19474c82dabe66801740 Reviewed-on: https://chromium-review.googlesource.com/579972 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488384}
-
Kyle Milka authored
This is part 4 of 6 for FieldTrial refactoring for WebView Part 1: https://chromium-review.googlesource.com/c/562098/ Part 2: https://chromium-review.googlesource.com/c/561920/ Part 3: https://chromium-review.googlesource.com/c/561922/ Part 4: https://chromium-review.googlesource.com/c/561980/ Part 5: https://chromium-review.googlesource.com/c/562417/ Part 6: https://chromium-review.googlesource.com/c/562021/ This CL adds a new class, PlatformFieldTrials, that the Chrome specific ChromeBrowserFieldTrials is now derived from. Its implementation is currently just stubs as they shouldn't be necessary for WebView. BUG=678288 Change-Id: I5d7b1b77f5af39594977a5bd7ed66bf51cb63628 Reviewed-on: https://chromium-review.googlesource.com/561980 Commit-Queue: Kyle Milka <kmilka@google.com> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488383}
-
Alexander Alekseev authored
Bug: 736903 Change-Id: Ic71d4c4d52f4ad17be6b8e9f251d79b534dea341 Reviewed-on: https://chromium-review.googlesource.com/579168Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488382}
-
ranj authored
and modifies the bytecode of classes. Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler that throws Exception. Output is written to a new JAR file. BUG=672945 Review-Url: https://codereview.chromium.org/2971063003 Cr-Original-Commit-Position: refs/heads/master@{#487903} Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589 Review-Url: https://codereview.chromium.org/2971063003 Cr-Commit-Position: refs/heads/master@{#488381}
-
Peter Wen authored
Original CL: http://crrev.com/c/578488 Fixes: Cronet builders TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Bug: 731159 Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34 Reviewed-on: https://chromium-review.googlesource.com/580267 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488380}
-
Alex Zhang authored
RendererSettings is consumed by DirectRenderer and its subclasses. Renderers are part of viz so RenderSettings should also be in viz. It is moved to common because browser is going to send RendererSettings initialized via command line flags to Viz. The rest of the CL updates includes, forward declarations and namespaces as appropriate. Bug: 722935, 732825 Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271 TBR=boliu@chromium.org, piman@chromium.org, sadrul@chromium.org Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271 Reviewed-on: https://chromium-review.googlesource.com/579592 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#488379}
-
Ilya Sherman authored
The InitTaskGetHardwareClassOnBackgroundThread() code calls into StatisticsProvider::GetMachineStatistic(), which calls WaitForStatisticsLoaded(), which uses a WaitableEvent. Bug: 743056 Change-Id: I3da6e975b1d774f963ca4cdb9242878357bd2b78 Reviewed-on: https://chromium-review.googlesource.com/572740Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488378}
-
Alexander Alekseev authored
Bug: 736904 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I179d50c4dd3e2c835f06145e2c453c0012f1e001 Reviewed-on: https://chromium-review.googlesource.com/578952Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488377}
-
sebsg authored
Change-Id: I6094dd41a321a93333bee8c8d26b16db7cff1191 Reviewed-on: https://chromium-review.googlesource.com/580348 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#488376}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd9a923e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/348 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I09e8c412330f06dfbd412689ea9b03f5c49f08b3 Reviewed-on: https://chromium-review.googlesource.com/579953 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488375}
-
Dongseong Hwang authored
BGRX_8888 Gpu Memory Buffer is not always supported. Before using it, check it available first. BUG=746069 TEST=run WebGL Aquarium on eve Change-Id: Ib49784a7706cfebd8edd572011c874b18f805f86 Reviewed-on: https://chromium-review.googlesource.com/576616Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#488374}
-
lethalantidote authored
BUG=730519 Review-Url: https://codereview.chromium.org/2938913002 Cr-Commit-Position: refs/heads/master@{#488373}
-
lukasza authored
FrameIsAd heuristics ==================== After this CL, TopDocumentIsolation will by default only isolate cross-site frames that also match FrameIsAd heuristics. This behavior is controllable via Finch, via chrome://flags and via command line (see below for details). Impact on browser tests ======================= Browser tests should not depend on the FrameIsAd heuristics. This is taken care of by EnableTopDocumentIsolationForTesting, which enables the mode that isolates all frames that are cross-site from the main frame. chrome://flags changes ====================== This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the following variations are present (3. and 4. are introduced by this CL): 1. Default 2. Enabled 3. Enabled (CrossSite - isolate all frames from sites other than the top-level frame) 4. Enabled (Ads - isolate only cross-site ads detected by heuristics) 5. Disabled Today variations 1 and 5 turn off TDI mode (because the default for kTopDocumentIsolation base::Feature is to be disabled). Variation 3 enables TDI and isolates all cross-site frames (this is what browser tests use when enabling TDI via EnableTopDocumentIsolationForTesting). Variations 2 and 4 enable TDI and use FrameIsAd heuristics. Probably a better name for variation 2 would be "Enabled (unspecified isolation mode)", but the "Enabled" string is hardcoded in the chrome://flags code. I've manually tested that if a user enabled TDI in chrome://flags before this CL, then it will stay enabled after this CL (variation 2). Command line ============ After this CL, the user can control TDI with the following command line switches: - When no extra cmdline switches are present, then TDI is controlled via chrome://flags and/or Finch experiments. - Cmdline flags to disable TDI: --disable-features=top-document-isolation - Cmdline flags to enable TDI using unspecified / default isolation mode: --enable-features=top-document-isolation - Cmdline flags to enable TDI using specific isolation mode (1 for cross-site, 2 for ads; see the TopDocumentIsolationMode enum for all possible values): --enable-features="top-document-isolation<TopDocumentIsolation" \ --force-fieldtrials=TopDocumentIsolation/Cmdline \ --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1 BUG=733303 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2946113002 Cr-Commit-Position: refs/heads/master@{#488372}
-
chrome://net-exportEric Roman authored
There is an option to configure the maximum size of the NetLog. The default is 100MiB. This is a re-land that was originally reviewed at https://chromium-review.googlesource.com/c/571514/ TBR=xunjieli@chromium.org Bug: 679030 Change-Id: Ibf4fd80bca9ecd2d7899bc7039a930bbfc70ffa0 Reviewed-on: https://chromium-review.googlesource.com/580030Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488371}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/dc11ec85ebf6..77417ec9e131 $ git log dc11ec85e..77417ec9e --date=short --no-merges --format='%ad %ae %s' 2017-07-19 tsepez Make CPWL_Wnd classes be observable. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iffe7f8d656cd04ddc17b622d819f3d3499691c66 Reviewed-on: https://chromium-review.googlesource.com/579664 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488370}
-
Becca Hughes authored
Rename the media-engagement feature flag to RecordMediaEngagementScores in order to better describe what it is doing. BUG=None Change-Id: I3d3ac469f6c32418396ca95884d18374ce8db1e1 Reviewed-on: https://chromium-review.googlesource.com/579196Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488369}
-
Abhishek Bhardwaj authored
This change deprecates the current GetNetworks function and removes the old GetNetworksDeprecated function altogether. The new GetNetworks function uses the NetworkConfiguration type used in other APIs instead of the old WifiConfiguration type. BUG=b:63738960 TEST=Compile and boot. Change-Id: I4c00cf19b55fd90a322422ca91cd787084013d86 Reviewed-on: https://chromium-review.googlesource.com/573111 Commit-Queue: Abhishek Bhardwaj <abhishekbh@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#488368}
-
Ian Vollick authored
With this CL, we add a LinearLayout element whose responsibility is the positioning of its child elements. Bug: None Change-Id: Ied896a84a1f5615b3a22e1857469766a21883cad Reviewed-on: https://chromium-review.googlesource.com/577193 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488367}
-
Changwan Ryu authored
BUG=414219 Change-Id: I5fda048452466a5bbbc164a9f0924a3b886b74d5 Reviewed-on: https://chromium-review.googlesource.com/580153 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#488366}
-
Albert J. Wong authored
Leverages mojo EDK utils to remove one platform divergence in pipe creation, and then another within the Posix world for handling sendmsg vs write which differs signficantly between SysV-ish Linux and BSDish OsX. Bug: Change-Id: I27391043a05e0c917bed1f99acd3811ef92b2d19 Reviewed-on: https://chromium-review.googlesource.com/578381Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488365}
-
Michael Wasserman authored
Add the placeholder in ShelfModel's ctor, like the app list item. Only call OnShelfItemDelegateChanged for items with delegates. Rename CLC::InitBrowserShortcutItem, update expectations/behavior. Bail early in CLC::OnShelfItemAdded for the browser shortcut too. This should make mash_browser_tests run more reliably. (avoids a race between ChromeLauncherController adding the shortcut and ShelfWindowWatcher observing the first chrome window) Bug: 743050 Test: No ChromeOS shelf behavior changes; more mash_browser_tests pass. Change-Id: I96b3adb4fc3eff35f720d8b22048523dc6f1a6a3 Reviewed-on: https://chromium-review.googlesource.com/578547 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#488364}
-
Wenzhao Zang authored
(1) Remove extra focus on the disabled dropdown menu button. (2) Make password field focused only once instead of three times. (3) Assign the user name as ARIA label for the entire pod. (4) Skip image until more descriptive texts are available. Bug: 746568 Change-Id: I4ed9918947a3a7f03fe84ebbf64ab94be7e88475 Reviewed-on: https://chromium-review.googlesource.com/578459Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488363}
-
jdonnelly authored
Revert of Don't reset the omnibox state on command-return. (patchset #1 id:1 of https://codereview.chromium.org/2904243002/ ) Reason for revert: This change caused a new issue: https://crbug.com/743288. While we decide how to proceed, it would be better to revert to the previous behavior. Original issue's description: > Don't reset the omnibox state on command-return. > > This was originally added in https://codereview.chromium.org/260008/, > motivated it appears by a desire to match Safari's behavior. Safari no > longer does this (the address field state is preserved on command-return > as the new tab is openeed in the background). > > This change makes Chrome's behavior consistent with Safari, simplifies > the code, fixes a bug, and is more useful IMO. If you want to open > several tabs with variations on some search, for example, you can press > command-return after each, then keep typing to produce the next. > > See discussion in the bug for more info. > > BUG=513966 > > Review-Url: https://codereview.chromium.org/2904243002 > Cr-Commit-Position: refs/heads/master@{#475542} > Committed: https://chromium.googlesource.com/chromium/src/+/1f35c3ffdebd60917647555ac6ec572098967035 TBR=rohitrao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=513966 Review-Url: https://codereview.chromium.org/2983193002 Cr-Commit-Position: refs/heads/master@{#488362}
-
Jun Cai authored
This is a follow-up CL from the comment at: https://codereview.chromium.org/2929603003/diff/180001/device/generic_sensor/relative_orientation_fusion_algorithm.h This CL does the following to update sensor data documentation at sensor_readings.h: 1. Add units information for ACCELEROMETER and LINEAR_ACCELERATION. 2. Add units information for GYROSCOPE. 3. Add more comments about the correspoinding values in the W3C DeviceOrientation Event Specification for ABSOLUTE_ORIENTATION_EULER_ANGLES and RELATIVE_ORIENTATION_EULER_ANGLES. Bug: None Change-Id: Ie7820d84f6a21cc55a50f1f98d1b7f4630c222d4 Reviewed-on: https://chromium-review.googlesource.com/580089 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488361}
-
Hayley Ferr authored
Report how often the effective touch action computed by blink is or is not equivalent to the whitelisted touch action computed by the compositor. Bug: 745718 Change-Id: Ieb080bbd6791d8bfaafafd134c2406537000287a Reviewed-on: https://chromium-review.googlesource.com/575585 Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488360}
-
Victor Costan authored
Bug: 746653 Change-Id: Idda88c827b237b0bde4517ad9532537dc4977313 Reviewed-on: https://chromium-review.googlesource.com/578736 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#488359}
-
Evan Stade authored
Bug: none Change-Id: I8a7313d1007b2cb8e6a9fe5cd584c5286afd818d Reviewed-on: https://chromium-review.googlesource.com/575348Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#488358}
-
sebsg authored
Bug: 746990 Change-Id: Ib5aff32726225192d07c1a55b895d4f959110253 Reviewed-on: https://chromium-review.googlesource.com/579576 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488357}
-
Nate Fischer authored
This changes our logic to fetch Safe Browsing user opt-out very early in WebView initialization. This treats user-opt out as a tri-state (opted-in, opted-out, unknown). The hope is that: 1. isVerifyAppsEnabled responds before the network request completes 2. Failing that, isVerifyAppsEnabled responds before lookupUri responds. If neither of the above is the case, and we still have not received a response from isVerifyAppsEnabled, then we will mark the URL as safe in downstream code and not show an interstitial. Bug: 731927 Test: manual - custom app Change-Id: Ie6c647828710d7e49e2e962bf3b334c4c8fcec15 Reviewed-on: https://chromium-review.googlesource.com/578947Reviewed-by:Selim Gurun <sgurun@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488356}
-
Toni Barzic authored
The entry point for note taking on lock screen has been added to the lock screen UI for webui lock screen implementation - this means that the item in the system tray is not longer needed in this case. Keep the tray item around for views based lock screen (i.e. when show-md-login flag is set) - in this case the lock screen UI has yet to be updated, so there is still a need for an entry point in the tray. BUG=737067 Change-Id: I53c53c7154c1dfec165c6a9898359b29b366db3f Reviewed-on: https://chromium-review.googlesource.com/578647 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Terry Anderson <tdanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#488355}
-
jbauman authored
Create a new type of GLImage representing an NV12 DXGI share handle (and array level) and support displaying it in an overlay. BUG=729238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2968503003 Cr-Original-Commit-Position: refs/heads/master@{#485701} Committed: https://chromium.googlesource.com/chromium/src/+/fc666dc7bc9d5141a6457ee08b0004c705463140 Review-Url: https://codereview.chromium.org/2968503003 Cr-Commit-Position: refs/heads/master@{#488354}
-
Sean O'Brien authored
Scroll events from the touchpad may arrive in the |GestureEventQueue| out of order, such that a GestureFlingStart arrives before a GestureScrollUpdate. Currently, the debounce filter removes the GestureFlingStart. This CL will forward the GestureFlingStart after emptying the debounce queue. BUG=717205 Change-Id: I42bd147195b9a2be8e34391c534c625cc785e2e0 Reviewed-on: https://chromium-review.googlesource.com/553424 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#488353}
-
Matthew Halpern authored
Currently GRC's process CPU measurement mechanisms are tightly integrated with the process coordination unit implementation. This CL moves the CPU usage measurement from the resource_coordinator service to the content_browser service. Decoupling process CPU measurement from the CU model allows the coordination units to focus on representing browser state within GRC, rather than updating it. In GRC terms, the migrated render process CPU measurement infrastructure is a "probe" that externally triggers updates to the CU graph. A new feature flag has been added for enabling render process CPU usage profiling. To do so, run: out/Default/chrome --enable-features=GlobalResourceCoordinator,GRCRenderProcessCPUProfiling \ http://example.com BUG=691886,741768 Change-Id: I2fc7609c6963776a167c5f76abe078dedb0e2efe Reviewed-on: https://chromium-review.googlesource.com/565906 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#488352}
-
Yipeng Wang authored
Generated jni headers should not be included by multiple .cc files. This double-include is breaking upcoming changes to the JNI generator. BUG=683256 Change-Id: I92318e46de45841557544bf04503bee27fc52e9a Reviewed-on: https://chromium-review.googlesource.com/578743Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yipeng Wang <yipengw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488351}
-
Brett Wilson authored
Fixes linking in Windows non-component builds since the profiling process is now a child process. Move AllocationTracker::Alloc into a separate class AllocationEvent so it can be used in the exporter. Hooks up a simple test for the exporter. The exporter is not currently hooked up to any triggering. Change-Id: Ic9dda085032694ff1a5872e357ca2e03c0d42ad3 Reviewed-on: https://chromium-review.googlesource.com/575395 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488350}
-
Peter Kasting authored
Ensure that the KeyValueImport test actually checks that GetFormValuesForElementName() overwrites the existing consumer value. This test would have failed in the initial version we wrote to convert the WebDataService off the DB thread, and was noticed by eye. This also refactors some common caller code into the callee in a couple places. Bug: none Change-Id: I3fc17a97b95e28c019f98e6692eedceb3fee260a Reviewed-on: https://chromium-review.googlesource.com/578586Reviewed-by:
mahmadi <mahmadi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#488349}
-
Alexei Filippov authored
Change-Id: I9f6597ba0c296a478e5501c7f13a536210c4ceff Reviewed-on: https://chromium-review.googlesource.com/578740Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#488348}
-