GitLab

BUG=429756

Review URL: https://codereview.chromium.org/1133203003

Cr-Commit-Position: refs/heads/master@{#330354}

Logs test cases which will be run, which helps to catch cases when you
misspell config parameter name and run all test cases instead of
specified once.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1142803002

Cr-Commit-Position: refs/heads/master@{#330353}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4657068..5b5ddd7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1147683002

Cr-Commit-Position: refs/heads/master@{#330352}

Revert of Reland: Lazily initialize MessageLoop for faster thread startup (patchset #5 id:160001 of https://codereview.chromium.org/1129953004/)

Reason for revert:
Massive data race reports, see https://crbug.com/489263

Original issue's description:
> Reland: Lazily initialize MessageLoop for faster thread startup
>
> Original review: https://codereview.chromium.org/1011683002/
>
> Reverted because it's suspected for following flakiness issues:
> http://crbug.com/485157 - Windows race
> http://crbug.com/485091 - Android ThreadWatcher
> http://crbug.com/485178 - interactive_ui_tests Menu* tests
>
> PS1 is the original patch set that gets reverted.
>
> BUG=465458, 485157, 485091, 485178
> TBR=jam
>
> Committed: https://crrev.com/8b6133a69f16702a32a3c3104630c4d9ac393b7a
> Cr-Commit-Position: refs/heads/master@{#330329}

TBR=thakis@chromium.org,toyoshim@chromium.org,jam@chromium.org,kinuko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465458, 485157, 485091, 485178

Review URL: https://codereview.chromium.org/1140363002

Cr-Commit-Position: refs/heads/master@{#330351}

Improved logging in chrome code in case of error in policy fetching.

BUG=489230

Review URL: https://codereview.chromium.org/1140333002

Cr-Commit-Position: refs/heads/master@{#330350}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/36757d61..b19d3aa

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1139093003

Cr-Commit-Position: refs/heads/master@{#330349}

Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (patchset #1 id:1 of https://codereview.chromium.org/1132913004/)

Reason for revert:
See crbug.com/489135

Original issue's description:
> [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost
>
> BUG=483693
>
> Committed: https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1
> Cr-Commit-Position: refs/heads/master@{#330286}

TBR=dgozman@chromium.org,pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483693

Review URL: https://codereview.chromium.org/1140603004

Cr-Commit-Position: refs/heads/master@{#330348}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8e110e4..36757d61

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1144793002

Cr-Commit-Position: refs/heads/master@{#330347}

This test has been flaky in the last 2 weeks on Mac bots.
(Adding NOTRY as everything is currently red on the perf waterfall)

BUG=489214
NOTRY=true
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1129833005

Cr-Commit-Position: refs/heads/master@{#330346}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6137460..8e110e4

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1139233003

Cr-Commit-Position: refs/heads/master@{#330345}

BUG=263527

Review URL: https://codereview.chromium.org/1127143003

Cr-Commit-Position: refs/heads/master@{#330344}

Move GetHumanReadableOrigin method to affliation utils in order
to make it available in ios. This CL requires  GetHumanReadableOrigin
on ios: https://chromereviews.googleplex.com/191547013/

BUG=486736

Review URL: https://codereview.chromium.org/1130213004

Cr-Commit-Position: refs/heads/master@{#330343}

This patch fixes the regression by https://codereview.chromium.org/1134603002/diff/1/ui/file_manager/video_player/css/video_player.css

BUG=488213
TEST=none

Review URL: https://codereview.chromium.org/1141183004

Cr-Commit-Position: refs/heads/master@{#330342}

Make sure jinja2 from third_party is used.

Review URL: https://codereview.chromium.org/1138383003

Cr-Commit-Position: refs/heads/master@{#330341}

This is to ensure that threading is not the cause of http handler crashes.

BUG=none
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1138323003

Cr-Commit-Position: refs/heads/master@{#330340}

The change complements Breakpad's crrev.com/1125153008 and introduces
the ability of attaching production information and build id to
microdumps.

The DEPS roll pulls in the following change:
r1456 d7e4030  [microdump] Add build fingerprint and product info metadata.

Summary of all changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/9fcbe25..d7e4030

BUG=456494,410294

Review URL: https://codereview.chromium.org/1019663003

Cr-Commit-Position: refs/heads/master@{#330339}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/739db8a..6137460

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1145673002

Cr-Commit-Position: refs/heads/master@{#330338}

With "--log_time" optional arg, we can see each logged event's
timestamp to know how long does a task spend.

BUG=None
TEST=manual ./run_benchmark with "-v --log_time" args added.

Review URL: https://codereview.chromium.org/1079443002

Cr-Commit-Position: refs/heads/master@{#330337}

glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will force the
texture format in the level info to GL_RGBA regardless of the internal
format used by the GLImage.

This CL address this by adding a GetFormat function to GLImage that
glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will use when
updating the level info.

BUG=

Review URL: https://codereview.chromium.org/1140683002

Cr-Commit-Position: refs/heads/master@{#330336}

Rules for invariant varying (or in/out variable) matching are different
for ESSL 3 and ESSL 1. Use a recently added ANGLE API to choose which
rules to use based on shader version.

Tested by WebGL 2 test deqp/data/gles3/shaders/qualification_order.html

BUG=488372
TEST=WebGL 2 conformance tests

Review URL: https://codereview.chromium.org/1135733006

Cr-Commit-Position: refs/heads/master@{#330335}

The only thing we need to know per QuerySync block is its
index in the block sequence. Everything else can be
calculated from that if we just store a few numbers in
the Bucket objects.

Total memory reduction is 92%.

This is alt #2 in bug 485536.

BUG=485536

Review URL: https://codereview.chromium.org/1131913004

Cr-Commit-Position: refs/heads/master@{#330334}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4472bfd..739db8a

TBR=

Review URL: https://codereview.chromium.org/1146613002

Cr-Commit-Position: refs/heads/master@{#330333}

Cr-Commit-Position: refs/heads/master@{#330332}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2dd4f36..4472bfd

TBR=

Review URL: https://codereview.chromium.org/1127123011

Cr-Commit-Position: refs/heads/master@{#330331}

Currently, socket pairs for the IPC channels (mainly for PPAPI IPC channels) are created in nacl_helper (and nacl_helper_nonsfi).
However, to make more secure, socketpair() will be prohibited in Non-SFI mode. So, this is its preparation.

TEST=Ran bots.
BUG=358417

Review URL: https://codereview.chromium.org/1051243002

Cr-Commit-Position: refs/heads/master@{#330330}

Original review: https://codereview.chromium.org/1011683002/

Reverted because it's suspected for following flakiness issues:
http://crbug.com/485157 - Windows race
http://crbug.com/485091 - Android ThreadWatcher
http://crbug.com/485178 - interactive_ui_tests Menu* tests

PS1 is the original patch set that gets reverted.

BUG=465458, 485157, 485091, 485178
TBR=jam

Review URL: https://codereview.chromium.org/1129953004

Cr-Commit-Position: refs/heads/master@{#330329}

This completes the check-in of hunspell code into the Chromium tree.

BUG=472897
R=brettw@chromium.org
TBR=phajdan.jr@chromium.org # for checklicenses

Review URL: https://codereview.chromium.org/1135173004

Cr-Commit-Position: refs/heads/master@{#330328}

BUG=489119
TEST=manually

Review URL: https://codereview.chromium.org/1129013005

Cr-Commit-Position: refs/heads/master@{#330327}

It is possible that when
ChromeWebViewGuestDelegate::HandleContextMenu() attempts to build a
menu to display that it will receive a null pointer (if the associated
web_contents' frame tree does not have a focussed frame). In the
current code this can lead to a crash. In the short term, while we
determine if this lack of a focussed frame is an error or not, early-out
if we receive a null menu.

BUG=487419

Review URL: https://codereview.chromium.org/1139193003

Cr-Commit-Position: refs/heads/master@{#330326}

The design doc pointed to is public on chromium.org, but the
Googler-only shortener is not.  Use a public one instead so
anyone can follow it.

BUG=

Review URL: https://codereview.chromium.org/899413002

Cr-Commit-Position: refs/heads/master@{#330325}

Cr-Commit-Position: refs/heads/master@{#330324}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33ccde6..2dd4f36

TBR=

Review URL: https://codereview.chromium.org/1126393007

Cr-Commit-Position: refs/heads/master@{#330323}

BUG=488357

Review URL: https://codereview.chromium.org/1130763005

Cr-Commit-Position: refs/heads/master@{#330322}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0698cc2..33ccde6

TBR=

Review URL: https://codereview.chromium.org/1129353008

Cr-Commit-Position: refs/heads/master@{#330321}

Presumably during destruction, the RenderView can be destroyed before
the RenderFrame (since it only holds a weak pointer to it). We need
to check whether it is alive before clearing the plugin find handler.

BUG=487146

Review URL: https://codereview.chromium.org/1123393004

Cr-Commit-Position: refs/heads/master@{#330320}

FakeProfileStore now returns the real kProfileLastUsed (from the pref
store), instead of a dummy value. This means that tests for code that
sets or manipulates the kProfileLastUsed pref will behave correctly.

AppListServceUnitTest.RemovedProfileResetsToInitialProfile now properly
tests the behaviour of RemoveProfile (that it clears kAppListProfile,
and that GetProfilePath returns the initial profile when kAppListProfile
is missing). Previously, it did not distinguish between the initial and
last used profiles.

AppListServiceUnitTest.RemovedProfileResetsToLastUsedProfileIfExists
also tests that the kAppListProfile has been set correctly.

BUG=487951

Review URL: https://codereview.chromium.org/1134533007

Cr-Commit-Position: refs/heads/master@{#330319}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3340c79a..0698cc2

TBR=

Review URL: https://codereview.chromium.org/1130343004

Cr-Commit-Position: refs/heads/master@{#330318}

DynamicSocketDataProvider only has one consumer, FtpSocketDataProvider. This CL moves the functionality of DynamicSocketDataProvider directly into FtpSocketDataProvider.

Review URL: https://codereview.chromium.org/1137183005

Cr-Commit-Position: refs/heads/master@{#330317}

All the ARM linux builders already specify this, and
armhf is the now the default for both Ubuntu and Debian.

Followup cleanup cl for the bots:
https://codereview.chromium.org/1141643004/

BUG=308256

Review URL: https://codereview.chromium.org/1140503004

Cr-Commit-Position: refs/heads/master@{#330316}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e3dad87..3340c79a

TBR=

Review URL: https://codereview.chromium.org/1135763005

Cr-Commit-Position: refs/heads/master@{#330315}