Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 May, 2018 3 commits
    • David Tseng's avatar
      Explicitly compute precision of floating point numbers · 81ef19c2
      David Tseng authored 
      In Blink, we parse floating point numbers such as those from ARIA value now from strings to doubles.

In the midst of conversions, we incur some amount of errors (trailing garbage) when converting from doubles to floats.

To see this, within Blink,

LOG(ERROR) << "Float valueNow=" << base::NumberToString(float_value);

for the snippet:
<div role="progressbar" aria-valuenow=0.05>

You will see:
0.05000000074505806

V8 uses doubles in its underlying number type.

For the purposes of automation, default to a precision of 2 decimal places.

Since the underlying data is always available, we can consider exposing a more full featured api like GetFloatAttribute(int precision) to the wrapping js and on up to chrome.automation.AutomationNode, if needed.

Bug: 841972
Change-Id: Ideb979d43d7ed28bae8a5293f0f40fb2a7c79199
Reviewed-on: https://chromium-review.googlesource.com/1058448Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559347}
      81ef19c2
    • Bill Orr's avatar
      Fix crash when entering WebVR presentation · 46304c60
      Bill Orr authored 
      The issue here is that viewports_need_updating_ is uninitialized until
OnResume, and that leaves viewports uninitialized until the first
DrawFrame after OnResume.

However, some incoming calls from mojo, such as UpdateLayerBounds may
be processed before that first DrawFrame.

The fix is to initialize viewports_need_updating_ to true, so viewports
are created in InitializeRenderer, before mojo calls are processed.

This then creates a new bug, where we lose the UVs set by a call to
UpdateLayerBounds before the first OnResume/DrawFrame. We need to cache
the bounds and can reapply them when creating new viewports.

BUG=839108

Change-Id: Ieef7f98d9606fe033095e8b8a8e9cde92afdcccc
Reviewed-on: https://chromium-review.googlesource.com/1062930Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559346}
      46304c60
    • Sergey Berezin's avatar
      [luci-milo] Delete buildbot versions of migrated ios-* builders · cb2ace9a
      Sergey Berezin authored 
      R=hinoka@chromium.org

Bug: 843638
Change-Id: I80fc3f991b697298c8866d6e81ea64e7c1aed256
Reviewed-on: https://chromium-review.googlesource.com/1062944Reviewed-by: default avatarRyan Tseng <hinoka@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559345}
      cb2ace9a
  3. 16 May, 2018 37 commits