- 29 May, 2020 40 commits
-
-
Piotr Bialecki authored
Change-Id: I2f05f6eaa5ea7bcbaa27e0a8f4472affb42afa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168768 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773348}
-
Alex Moshchuk authored
If a history navigation targets a subframe, but the subframe has been removed by its parent, we currently fall back to reload the whole page. This CL tries to modify this behavior to instead do a no-op same-document navigation (to the same item sequence number) to the main frame. This approach will update the current history entry to the target one, but it avoids a reload and allows the main frame and other frames to continue to function. The CL tries to preserve the main frame reload behavior in the cases where that's still needed, including various kinds of reloads, session restore, and crash recovery, by refactoring FindFramesToNavigate() to explicitly queue a different-document load in those cases. We've also attempted ignoring the navigation completely, rather than doing a no-op same-document navigation. This had the problem of not notifying observers about the updated history entry, meaning that things like greying out of back/forward buttons didn't work properly, and history length/offset information wasn't updated properly in the renderer processes. Doing a redundant same-document navigation avoids these problems, as it goes through a complete navigation flow. There was one unwanted side effect of this approach, which is that the main frame would redundantly fire popstate events when the ISNs aren't changing. The spec [1] argues that popstate events should be fired whenever the "entry" changes, but "entry" in that context probably means the FrameNavigationEntry and not NavigationEntry. Although the NavigationEntry changes here, the spec probably expects FrameNavigationEntry to not change (due to how joint session history entries are supposed to work), even though it does change in our current implementation (see https://crbug.com/373041). Other browsers also don't trigger a redundant popstate in this case. So this CL also modifies DocumentLoader to avoid triggering redundant popstate events when the ISN doesn't change. This is a less risky option to solve this problem. It has some drawbacks -- if there are multiple history entries targeting a removed subframe, the user might have to keep clicking back/forward until finding an entry that still works. In the future, we could consider improving this to automatically walk past all history entries corresponding to the affected subframe. [1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#history-traversal Bug: 705550 Change-Id: I11fca7a8f1062af347442922f49b2dfe50970d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181973Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773347}
-
Tommy Li authored
This CL creates a whole new flag for the On-Content variant of Contextual Web ZeroSuggest. Bug: 1087700 Change-Id: I4ccb748421470e2ccd3508d69fc317e12c27ff9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219597Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#773346}
-
Matt Menke authored
It then passes the NetworkIsolationKey on to the ExpectCTReporter. Also plumb NIK through the other TransportSecurityState methods that call it. Only one caller of TransportSecurityState is updated to pass in a non-empty NIK. The other 3 callers will be addressed in followup CLs. Bug: 969893, 1082280 Change-Id: I2982c06288e6ff9ec2dd863b0ecbcf01f46b2791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217871Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773345}
-
OlivierLi authored
This avoid having to type 1 << (numbits_ - 1) in several places which can make code harder to read and can be typo prone. This function can also be used within another template. Change-Id: I46af3ab832bb58a6565702a391db028b2a69807f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222526 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#773344}
-
Tibor Goldschwendt authored
This ensures the most visited tiles as up-to-date. It's also what the local NTP does. Bug: 1087564 Change-Id: I724b99763952894617400d2733ce55992e3933dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222635 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773343}
-
Samuel Huang authored
SuperSize-archive calls _AddUnattributedSectionSymbols() to create symbols (in .other section) to account for sections that are not covered by symbols. However, previously this was done only ELF files inside APK and not for stand-alone ELF files. Also, the accounting was off, resulting in Supersize-console Print(size_info) producing file sizes that are off. This CL fixes the above problems. Details: * Add models.ClassifySections() to classify sections into one of three groups: (1) Unsummed sections: These don't add to binary size. E.g., .bss. (2) Explicitly summed sections: These add to binary size, and have symbols that are extracted by the "usual method" via .map file parsing, nm, etc. E.g., .text. (3) Implicitly summed sections: These add to binary size, but needs to be extracted via _AddUnattributedSectionSymbols(), and counted as part of the .other section. E.g., .dynsym. * The function is used by archive.py and describe.py, to eliminate previous size mismatches. * Add BaseSizeInfo.ClassifySection() to wrap this. * archive.py: Change main flow so that _AddUnattributedSectionSymbols() get called when an ELF file is the main input (even without APK). * describe.py: When describing section sizes, add note to make it clear that a section is counted in the .other section. This CL leads to extensive .golden file changes. Bug: 1084580 Change-Id: If663eb9acce89b32f857a0056b6f5ec39db35d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217861Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#773342}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df546db4d8f7..cc7ec24ca824 2020-05-29 egdaniel@google.com Move backend surface vk getters and setters back out from behind compile flag. 2020-05-29 bungeman@google.com Revert "Hide ICU C++ API from Skia users." 2020-05-29 bungeman@google.com Create CTTypesetter without Options. 2020-05-29 herb@google.com tease apart GrTextBlob and SubRun 2020-05-29 bungeman@google.com Hide ICU C++ API from Skia users. 2020-05-29 herb@google.com Rename fUniqueID -> fMessageBoxID 2020-05-29 csmartdalton@google.com Wire up mouse and keyboard events in CanvasKit viewer 2020-05-29 egdaniel@google.com Add GrBackendMutableState object to handle shared texture state. 2020-05-29 michaelludwig@google.com Rename fIH variable to fInvH 2020-05-29 csmartdalton@google.com Merge PathText samples into one, with different modes 2020-05-29 nigeltao@google.com Fix markdown typo in the style guide 2020-05-29 senorblanco@chromium.org Modify SurfaceTest to only test readbacks from supported surfaces. 2020-05-29 brianosman@google.com Minor cleanup in the sample_matrix GMs 2020-05-29 robertphillips@google.com Update DDL test harness to better match OOP-R 2020-05-29 nifong@google.com Record code coverage in canvaskit tests, increase coverage 2020-05-29 herb@google.com Move hasW to SubRun If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I5ced804b0b88c5c04788f5e10a879779ef17990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773341}
-
Chih-Yu Huang authored
CL:2035212 was reverted because we encountered some issue with the guest user, and VP8 on Intel device. Now those issues are solved. It's time to enable ChromeosVideoDecoder by default again. Bug: 984482 Test: ninja media/base Change-Id: I7ad037186fa4f62a0f7d14025e5f4590c7caad53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214764 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773340}
-
Arnaud Mandy authored
This CL enables possibility to isolate blink implementation of screen enumeration from the rest of the stack. It provides the possibility to create mock displays at test conveniences by rerouting the GetDisplay call to the JS implementation in the test. Existing test has been modified to use this test framework. Bug: 1075656 Change-Id: I1a38426deaccff14036f00806ef7dfc878bcd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214538 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773339}
-
Sergey Ulanov authored
Previously there were tests that play audio and tests that play video, but no tests were playing a file with both audio and video. Also video was not played to the end. Added PlayVideo test that plays bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests to share play_video.html and reduce amount of duplicated code. Bug: b/153914562 Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773338}
-
Matt Jones authored
This patch removes logic that would prevent the bottom sheet from showing when contextual search was visible. The code in question was relevant when the bottom sheet could trigger without a user action. Since this is no longer the case, the code is unneeded. This block of code should have been removed with https://crrev.com/c/1808180, which contained the rest of this logic. Bug: 100227 Change-Id: I6c1896c9c8907ec01542568162291e85aa2892cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204298Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#773337}
-
Behnood Momenzadeh authored
This CL provides an extra layer of protection to top domains with top 3 most visited TLDs. If a potential target embedding domain embeds a hostname with another valid TLD instead of the domain's actual TLD, the heuristic will flag it. For example, the heuristic will trigger on google.info-foo.com. This CL also flags domains that embed a target without the target's separators (e.g. googlecom-evil.com). Bug: 1087636 Change-Id: I14205e5b9830146d8aecfd216082d1213e5622bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215377 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#773336}
-
Alexander Cooper authored
Starting in M83, WebXr uses the permissions api. As such, the custom consent flow that it initially shipped with is no longer needed and can now be removed. Since the change to permissions is launched via finch for M83 (and not enabled by default in code until 84), the feature itself (and the finch configuration) will be left until M86; though it will not change any behavior. The feature is not exposed in about_flags. Bug: 1064384 Change-Id: I7fda1e70bc57feb9977bef7bcd07b47cb93f38ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219161 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773335}
-
Wan-Teh Chang authored
Add variants of the gfx::ColorSpace::GetRangeAdjustMatrix() and gfx::ColorTransform::NewColorTransform() methods that take bit depths as input parameters, so that the range adjustment for high bit depths can be performed accurately. Use the new gfx::ColorTransform::NewColorTransform() method in AVIFImageDecoder. Tested: gfx_unittests --gtest_filter=*ColorSpace* blink_platform_unittests --gtest_filter=*AVIF* Change-Id: Ib36ba6c05d5d7da3a4d0715ad5880336c0b1693c Bug: 1087192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213127 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773334}
-
danakj authored
This is a reland of d18bad64 This changes evaluateInPagePromise() to be evaluateInPageAsync() instead as the latter waits on the promise returned from eval()'ing the code before resolving the promise from the TestRunner. It also puts back the promise returned at the end of the eval()'d code in order for evaluateInPageAsync() to wait on it. Original change's description: > Fix the http/tests/devtools/console-cross-origin-iframe-logging.js test > > This test wants to verify that an error is seen when using a frame in > another origin. It was using a different site, where the frame's > contents is not visible at all when site-isolated. Instead, put the > frame in another origin in the same site so that the main frame can see > the contents of the iframe. > > R=caseq@chromium.org > > Bug: 623268 > Change-Id: Ib4ab03229f1033fc01717e561eb35b3c6d047e2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218373 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772769} Bug: 623268 Change-Id: I48bdb6ed1b24665c1b2f03a84454d7d4fe2c0360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220468 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#773333}
-
danakj authored
The failure is not site-isolation related. So moving to the correct part of TestExpectations and changing the bug number. TBR=yangguo@chromium.org NOTRY=true Bug: 1046784, 901502 Change-Id: I93f8f1250c00a43889ae3112fa89759884e7766c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221429Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773332}
-
Yue Zhang authored
This CL modifies the content description of the buttons in tab strip based on different features so that the difference can be reflected in TalkBack. Bug: 1085574 Change-Id: I26f7360f5900c1446b63a0edfeab1d7faa4595c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216364 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773331}
-
Siyu An authored
This flag will control whether the nickname can be uploaded to Payments or not, in case the pay.google.com change needs to launch separately. Bug: 1082013 Change-Id: Icd9905fc4b211c16b7280d4cdb02f20ea9aef38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219600 Commit-Queue: Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Auto-Submit: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#773330}
-
Nina Satragno authored
Disable MediaHistoryStoreFeedsTest.* on TSAN builders. These tests are flaky on TSAN, likely due to a race condition with ScopedFeatureList. TBR=beccahughes@chromium.org Bug: 1087974 Change-Id: Id215412e6918a91b390f8fbd099adc1e4a0cc043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222554Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773329}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98496cab72c7..3e1e10875278 2020-05-29 lehoangq@gmail.com Metal: Use 2d array for caching index conversion's pipeline state. 2020-05-29 amaiorano@google.com Fix CopyTextureTestES3.ES3FloatFormats for VK 2020-05-29 msisov@igalia.com Rename DisplayOzone to DisplayGbm. 2020-05-29 ianelliott@google.com Create a pre-rotation test for dFdx() & dFdy() 2020-05-29 cnorthrop@google.com Capture/Replay: Update MEC for Subway Surfer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458 Tbr: ynovikov@google.com Change-Id: Ifddbf2b2eb511d8b3a913269b1bf636f5e9ad314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773328}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I97194ae462156597638309e4b3160e3e9fc5e9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773327}
-
Toni Barzic authored
WindowState handles the kImmersiveIsActive property updates by updating the shelf visibility state, which also hides the shelf if the shelf has auto-hidden visibility state. The kImmersiveIsActive property has started to be set repeatedly, even when the property value does not change. The constant shelf visibility updates were thus preventing users from dragging the shelf up in the immersive fullscreen, as the shelf auto-hide visibility (i.e. the actual shelf visibility when it's in auto-hidden state) set by dragging the shelf up was constantly getting invalidated. This CL updates WindowState logic to only update the shelf visibility if the kImmersiveIsActive property actually changes, so the shelf auto-hide visibility gets invalidated only if the property changes. The same logic is applied for kHideShelfWhenFullscreenKey property updates. BUG=1084854 TEST=Play a video in the Youtube Android app, and set the video to play in fullscreen (to start immersive fullscreen). Drag the shelf up from the hidden state. Verify the shelf stays visible. Tapping on the app window should hide the shelf again. Change-Id: Ica96b896e33d0c2dc876d87f302a8b68a8624409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212968 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#773326}
-
Kenneth Russell authored
Bug: 1084591 Tbr: geofflang@chromium.org Change-Id: I159e7f85df1feb654a45de6a91252ec767f07f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222549Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773325}
-
danakj authored
This is a reland of 002510a0 This changes evaluateInPagePromise() to be evaluateInPageAsync() instead as the latter waits on the promise returned from eval()'ing the code before resolving the promise from the TestRunner. Original change's description: > Fix the http/tests/devtools/inspect-iframe-from-different-domain.js test > > This test wants to verify devtools inspect works with an iframe in > another domain. It was putting the iframe in another site, which causes > it to become detached from the local root in site isolation. Instead, > put both the main frame and iframe into the example.test domain, with > the iframe in a subdomain. > > This test was originally added for webkit bug 31587 which is found at > https://bugs.webkit.org/show_bug.cgi?id=31587. > > It said: > > If you try to inspect elements located inside an IFRAME that was > > loaded from a different domain, not satisfying the same origin > > policy, Web Inpector in recent WebKit nightly builds cannot show > > style information. Works in Safari 4.0.4. > > R=yangguo@chromium.org > > Bug: 623268 > Change-Id: I842bf835e49ee79e60e423fd36a5d3cedb8a8cfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218765 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772743} Bug: 623268 Change-Id: I05b8d89d51ec29d536677f9894937531592a249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220748Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773324}
-
danakj authored
If a local frame gets a user activation, we set a bit on FrameTreeNode, indicating that it has once received a user gesture. That bit is then used to set an /active/ user gesture in RemoteFrames created for the FrameTreeNode thereafter. This manifests as flaky web tests that see a user gesture in OOP iframes that they were not expecting - because they see an active user gesture in the remote main frame that was created and consumed in the previous test. This would manifest in the wild as an OOPIF gaining a user gesture that it can use to autoplay or whatnot when there is no active user gesture. R=avi@chromium.org, beccahughes@chromium.org, dcheng@chromium.org Bug: 872952 Change-Id: Ia6f76ab33f4906e5ed60c553a5e9ea07ad75b439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220475 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#773323}
-
Nick Harper authored
There are some entries that should probably be public-suffix-requested instead of bulk entries. This change temporarily makes them public-suffix-requested so they don't get removed while awaiting confirmation that they should be public-suffix-requested. (gsaadvantage.gov was removed in crrev.com/c/2207497.) Change-Id: I25694c9c93e7435aaf5eb83f8580b439769a520f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220813Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#773322}
-
Ken Rockot authored
Several mojom types are required to be stable over time by virtue of their use in Content's page state serialization code. Now that we have the [Stable] attribute with strict presubmit enforcement, these types can all be marked [Stable] to ensure that they aren't unwittingly broken by future changes. Bug: 1070663 Change-Id: I7de41133eb8244f7dd8562fa713b6ad702c04ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220251 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#773321}
-
Ken Rockot authored
This adds support for launching the browser (for any Content embedder) with a Mojo invitation on the command line, allowing external clients to include the browser process in a pre-existing Mojo process network and access a generic primordial Binder interface akin to InterfaceProvider. A simple browser test is added to verify that Content Shell can be launched in this mode and the primordial Binder can be used by the external launcher (in this case, content_browsertests) to bind a new testing control interface (content.mojom.ShellController) exposed by Content Shell. See crbug.com/1082454 for motivating use cases. Bug: 1082444, 1082454 Change-Id: I2cfc66d94aa9bdb5072e8ca63d95ae562b63b5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200004 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773320}
-
Sylvain Defresne authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/c25055244f3c..b2ae9cdce12f $ git log c25055244..b2ae9cdce --date=short --no-merges --format='%ad %ae %s' 2020-05-29 bryanoltman [FeatureHighlight] Delete unused accessibility hint string and unused localization support. Created with: roll-dep src/ios/third_party/material_components_ios/src Additional changes: Fixed references to files removed from the MDC repository. Bug: none Change-Id: Ib89f6b982025a11e1f414bcece11a92e7877e72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218077 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#773319}
-
Yuly Novikov authored
Turns out isolated_script and it's derivative, gpu_integration_test, accept --xvfb argument to run xvfb.py, so new isolate type isn't needed. This manually reverts the changes added in https://chromium-review.googlesource.com/c/chromium/src/+/2156073 https://chromium-review.googlesource.com/c/chromium/src/+/2162088 https://chromium-review.googlesource.com/c/chromium/src/+/2163657 Keeping https://chromium-review.googlesource.com/c/chromium/src/+/2176316 since it applies to windowed_test_launcher as well. TBR=dpranke Bug: 1064477 Change-Id: I2536f15ac6c05e1a3c46fe670db6eff684ff098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222144Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#773318}
-
Alexander Cooper authored
The WebXr Permissions API has shipped with M83, as such the legacy consent flow may also be removed. This change removes all tests that were specific to the consent flow in preparation for removing the code for the consent flow. Bug: 1064384 Change-Id: I263a6f6acbac0abbd29436c4d1cfdf4502509628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219351 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773317}
-
Alex Gough authored
Uses mojom and sandbox trace events to show which interfaces were seen in which processes and sandboxes during a tracing session. Example output: { "None(Browser)": [ "(Impl)IPC::mojom::Channel::GetAssociatedInterface", "(Impl)IPC::mojom::Channel::Receive", "(Impl)IPC::mojom::Channel::SetPeerPid", "(Impl)apps::mojom::AppService::RegisterPublisher", ... "data_decoder::mojom::DataDecoderService::BindJsonParser", "data_decoder::mojom::JsonParser::Parse", "data_decoder::mojom::JsonParser::ParseCallback", ... ], "Utility": [ ... "(Impl)data_decoder::mojom::DataDecoderService::BindImageDecoder", "(Impl)data_decoder::mojom::DataDecoderService::BindJsonParser", "(Impl)data_decoder::mojom::ImageDecoder::DecodeImage", ... ], ... } Bug: 1085213 Change-Id: I210aa51108b9f2b98ffa1dcc819810acfc3cbf32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219398Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773316}
-
Peng Huang authored
Right now, SkiaOutputSurfaceImplOnGpu::CopyOutput() will do some cleanup, however for avoiding extra queue submissions. CopyOutput() will not call gr_context()->submit() anymore, so it is better to cleanup resources until SwapBuffers() or SwapBuffersSkipped() is called. Remove cleanup code from CopyOutput(), and always call SwapBuffersSkipped() for tests. Bug: 1087063 Change-Id: Ia8532f1cf5ae1df05136ca4203673f4e0509e1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222545 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773315}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/399b81d2743f..721a721d0875 2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie67210b376c05f15dfd0d180058c904018bceadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773314}
-
Jonah Ryan-Davis authored
gl_tests crash for a known reason when run on ANGLE via the passthrough command decoder. To unblock the passthrough, this CL sets the gl_tests to run on the validating command decoder. This should only be temporary until a fix is landed in ANGLE. Bug: chromium:1087084 Change-Id: If80911d172fbf867f0be486f8feec269ae39a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218761 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e69660b3e62..998524a08e08 2020-05-29 sprang@webrtc.org Fixes issue with excessive stats updating in TaskQueuePacedSender. 2020-05-29 peter@signal.org Disable remote ICE candidate DNS lookups when the IceTransportPolicy is Relay or None If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id96d91e2e42cec10651594dcfe76dea7d71fb4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222707Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773312}
-
Gabriel Charette authored
This will help identify intentional nested loops in traces. R=fdoray@chromium.org Bug: 899897, 1074019 Change-Id: Ie8d7522c66b00a7b7f2e94e8143a980afd48f47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220631Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773311}
-
Richard Townsend authored
To rebaseline: copied x64 => arm64, ninja, executed suggested copy command. Change-Id: Ibf2e9f9d93d10c3f2946d5890c66e2956c576baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222349 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773310}
-
Matt Jones authored
The setIsObscuringAllTabs API on BottomSheetController was originally necessary because the TabObscuringHandler needed access to the view being obscured. The handler has changed such that is is now token based and therefore no longer needs to be an API on the controller. Bug: 100227 Change-Id: Iff028b627833ceaa4cdd424c6e5305dde7b4dfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212512 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#773309}
-