- 05 Aug, 2020 33 commits
-
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ide399f10072868afe3e27bdec1af0077a856cb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333581Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#794804}
-
Yuchen Liu authored
Now we have CastAudioManagerAndroid. Move android specific logics into the new class. Bug: internel b/160753974 Test: Build Change-Id: I9a3a177f938da525e8f18df3ee0be5588bdd6eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337539Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794803}
-
Jia Li authored
This CL adds the async code path to PredictionManager using the ML Service. For more convenient unit testing, a FakeServiceConnection for the ML Service is added. Bug: 1099371 Change-Id: I008180d173b7a1d0ee0f192662de43ad940ff856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324447 Commit-Queue: Jia Li <jiakl@google.com> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794802}
-
Robin Lewis authored
Bug: 1112604 Change-Id: I35017174be59a5e0191ef3a7f4e4791646af3d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336184 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#794801}
-
Charlene Yan authored
Bug: 1111874 Change-Id: I379fcb8461a7bf958ebf31714544a5c7ec0faf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332068 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#794800}
-
Nate Chapin authored
Currently, DocumentLoader sets FrameLoader::frame_owner_sandbox_flags_ only to immediately read that state back. Give FrameLoader a GetForcedSandboxFlags() helper to access its permanent flags, then have DocumentLoader assemble the state it needs rather than using FrameLoader::EffectiveSandboxFlags(). The only other use of FrameLoader::EffectiveSandboxFlags() is a test-only case. Switch it to use PendingEffectiveSandboxFlags(), since all the tests seem to be happy with it. Change-Id: Id58eda10c18843b3e2ddc4b962513507e2e66aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333335 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794799}
-
Chris Hamilton authored
This will be used to determine the attribution context for the performance.measureMemory API. BUG=1085129 Change-Id: Ia901dcc73e689984c3714c94f624dfb90b85c5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332331Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#794798}
-
Etienne Bergeron authored
This CL is removing incorrect usage of Range::Round(...). The plan is to deprecate and remove that API since it's leading to rounding errors. The appropriate usage will be to find the Enclosed/Enclosing range. R=msw@chromium.org Bug: 1111044 Change-Id: Ic81b79dc681b9453f34148e7ac33912c3cbba98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332839 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#794797}
-
Noah Rose Ledesma authored
Implementations of the WebMediaPlayer should report to their delegates when the audio output sink has changed. This CL adds the delegate method and has the player impls invoke it. Bug: 1110124 Change-Id: I72a9d9b9855333f2d0015c1279e474a199d456e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321066 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#794796}
-
Wenyu Fu authored
These render tests are failing on different building bots. TBR=dullweber@chromium.org Bug: 1112985 Change-Id: I1590c2bad3c0042ecfd73ac46c6edbffb2f683fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337290Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794795}
-
Haiyang Pan authored
It is: * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest.testGridToTabToCurrentLiveDetached Example build: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1521 Bug: 1092987 Change-Id: Ia169115d5b57046ebc4b23af16cb8ed0f5ddbc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336308 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794794}
-
Moe Ahmadi authored
Intercepts middle-slot promo link clicks when the link has an href with the following format: command:<ID>. Extracts the command ID and sends it to the NTP via postMessage to be sent to and executed by the browser. For more information see go/promos-deeplinking-settings Bug: 1106421 Change-Id: Idf84b93d5e15eb2555fd1e1857d372aef2e4f2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335324Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794793}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596560172-90d73787e73e756b1319ad7ac9a0bacd58cfb767.profdata to chrome-win32-master-1596562698-726e910d88cf0fdaea1d96e4c3f332f3c327590e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ied0b542f94b9d2aa443bf9cb576e8681295db1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794792}
-
Minoru Chikamune authored
We are going to remove ipc_task_queue and ipc_task_runner. The scheduling policy of ipc_task_queue is the same as the default task queue. Nowadays, we are using per-frame task queues as much as possible. And if there are no relevant per-frame task queues, then we can use the (per-isolate) default task queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: Ie9c760ee47151c32d094e43168e8e94e561344ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332088 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#794791}
-
Koji Ishii authored
This patch: * Adds tests for enumerating fragments for a |LayoutObject|. These tests were created for crrev.com/c/2332083 but missed to include in the CL. * Added |LayoutObjectToDebugStringList| helper function. * Move some helper functions out of the test class so that they can be used in other than member functions. crrev.com/c/2313736 needs to create a separate class to use different runtime flag. Bug: 982194 Change-Id: I4236c4251242b5790ba62388177a14d46958aa61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337196 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794790}
-
Tsuyoshi Horo authored
Bug: 1111536, 1111337 Change-Id: I0c48340d8ab2d78056e640f7a3e6f9263578dadb TBR: dbertoni@chromium.org, lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337199Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794789}
-
Haiyang Pan authored
They are: * org.chromium.chrome.browser.autofill_assistant.AutofillAssistantAutostartTest.testAutostart * org.chromium.chrome.browser.autofill.AutofillUpstreamTests.testSaveCardInfoBarWithEmptyYear Example build: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1489 Bug: 1112812 Change-Id: I65142339cb9f1ebc34fb7c43cb82cde48bbf7cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336307 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e84a1b13760d..0a4342793e0e 2020-08-04 enga@chromium.org Implement depth-only/stencil-only copies on Vulkan and Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1e196712ad859e1afe2814c1239b60254bd8357d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337333Reviewed-by:
-
Ben Joyce authored
We want test_runner.py to mimic the options available for base/test/launcher/unit_test_launcher.cc which includes the option "--test-launcher-batch-limit". Bug: 1090055 Change-Id: Id6710b0078068f03a0f163985fdadad4d14dea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333585 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#794786}
-
Noah Rose Ledesma authored
The renderer will now properly handle IPCs to change audio sink ID. Bug: 1096248 Change-Id: I26113128c0016df9c2a126a8d6bf7ce965f74e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295830 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
-
Chih-Hsuan Kuo authored
The original code has unnecessary DCHECKs that will cause crashes when audio/video config got changed more than once. This CL removed them and also refactor the config changes flow. Bug: 1111702 Change-Id: Id3a7ba39cc5a5d433f4a0a791f10c75baa43ed79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332082Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#794784}
-
Ken MacKay authored
* Avoid allocating memory during logging. * Post logs to a lower-priority thread for actual output. Bug: internal b/162244426 Change-Id: Iae080bcfebc96a151fed6f108cbfb12ff70a44ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324819Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#794783}
-
Minoru Chikamune authored
We are going to remove cleanup_task_queue and cleanup_task_runner. The scheduling policy of cleanup_task_queue is the same as the default task queue. We can simply use the (per-isolate) default task queue instead of cleanup_task_queue. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.i19urefmv8te Bug: 1105403 Change-Id: I3cd4ddac6f4b44fcb3d9105fd826777246c70131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335847Reviewed-by:
-
James Hawkins authored
Added a unit test to help confirm success of the migration and removed an unused dependency on date_time_types. R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsTimezoneSelector* Change-Id: I89bba050a66202c2d21e312bee42972c7bcd91b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337112Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#794781}
-
Zhuoyu Qian authored
Rename SignallingSender to SignalingSender to use the same naming as the spec. Bug: 1044584 Change-Id: Ieef65c03931f159f05019ee0799c789320bc164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331762Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#794780}
-
chrome://safe-browsing/#tab-deep-scanFabio Tirelo authored
Screenshots: - File downloaded: - https://screenshot.googleplex.com/Zqbk3EFo1aL - https://screenshot.googleplex.com/dDEcotFktcw - File attached: https://screenshot.googleplex.com/Jci3Y84CmFE Bug: 1096902 Change-Id: I5b786e3baeae600fe51ff04d9e6ffeb0ad0265b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329671Reviewed-by:Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794779}
-
Steven Bennetts authored
Bug: 1105137 Change-Id: I84440d73d5cb14601e1a559c261c4b17e25d637e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316127Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#794778}
-
Xiaocheng Hu authored
Design doc: https://bit.ly/39qATQ4 This patch applies the letter-spacing-override value in @font-face, and uses it to change the spacing between characters. Note that the spacing is considered part of the font face, and hence, it's applied at the character level instead of element. See the new test case letter-spacing-override.html for an example. Though we don't have a stable spec at the moment, we land it behind a flag to make testing and discussion easier. Bug: 1098355 Change-Id: I182d89aa9226ac92a0af50af06c0c56b021fb394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318510 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794777}
-
Klaus Weidner authored
This is intended as a convenience for debugging synchronization issues related to sync tokens. The output is in the format "a:b:c:d", i.e. "0:1:4:16", where a is the namespace_id, b/c are the upper and lower half of the 64bit command buffer ID (corresponding to channel and route ID for gpu/ipc/ usage), and d is the release count. Change-Id: I2cbc1ce9cff56d8b83bfa582ce4702f7459005c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324869 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#794776}
-
K. Moon authored
Now that we're allowed to use absl::variant, reimplement Image to use an absl::variant<pp::ImageData, SkBitmap> internally. Behavior should remain largely the same, with slightly less memory overhead. Bug: 1099020 Change-Id: Ia4b2398ceae6156997be8904562778d47af97e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333538Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#794775}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97713d6f163e..d6df76fdb45c 2020-08-04 brgoddar@microsoft.com CSS Grid: add background to row/column gaps for default highlighting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109213 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I872dda7b9dc4b6d036b232ec1e200b4b417c286f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335759Reviewed-by:
-
Noah Rose Ledesma authored
Added media player delegate messages to allow the |MediaSessionController| to send set audio sink id messages to the renderer. Bug: 1105169 Change-Id: Idb382bcf6c0457aeeb870cb9475483045acaaf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295808 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794773}
-
Noah Rose Ledesma authored
Changing audio sinks on pepper players is not supported. The mock media session player observer needs to have OnSetSinkId implemented. Bug: 1096246 Change-Id: Ie08b36cff98f4beb2a4148e0bd05e27e993308f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295748 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
-
- 04 Aug, 2020 7 commits
-
-
Yusuke Sato authored
ARCVM boards will have {system_ext,odm,product}_build.prop files in /usr/share/arcvm/properties. This CL let Chrome process these files in addition to the existing ones (default.prop, build.prop, and vendor_build.prop). When processing the files, this files also let Chrome replace ro.<partition>.product.cpu.abilist* so that all abilist properties have a single consistent value regardless of the <partition>. BUG=b:162555733,b:162024174 TEST=components_unittests Change-Id: I98e1a5118657b91171b63c6bcbe9f71d9d1fe6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333580 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: -
Varun Khaneja authored
With larger (or smaller font) the absolute pixel sizes for the spinner change the relative center of the animation which leads to an uneven rotation. To prevent this, the spinner now has a size relative to the font size which is identical for the current size on normal scaling but scales with larger/smaller sizes to keep the animation intact. This fix is inspired by crrev.com/c/2250203 Fixed: 1111300 Change-Id: I6626f107096cb0465efd109179c88cb88a54b7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337438 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794770}
-
Jason Lin authored
Bug: 1109773 Change-Id: I34f25aa26b61cb98564ebf62cd3d44ab2da2a2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334826 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#794769}
-
Daniel Clark authored
Add 'max' attribute to month-picker-appearance-step.html to prevent 'This month' button from toggling The month picker's 'This month' button is grayed out if the current month (the actual month it is right now, not the 'value' attribute of the control) is a valid choice as determined by the value, min, max, and step attributes. August 2020 is the first month since this test was introduced that is valid per the combination of value and step of the control in this test, so it started failing at the beginning of the month as the button was no longer grayed out. This change re-enables the test, adding a 'max' attribute with a value in the past, so that the button will always be grayed out going forward. The baselines still need to be regenerated because it turns out that adding a max changes the width of the control's text field. See blink::DateTimeNumericFieldElement::MaximumWidth and the reference to it in blink::DateTimeEditElement::CustomStyleForLayoutObject. Bug: 1112111 Change-Id: I70cce1b98114c888a701e067d0543b7d12e2f457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337099Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794768}
-
Kai Ninomiya authored
Bug: None Change-Id: I6a9f7a2bda46e786a3137a6a8e9a84948a301678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337102 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#794767}
-
Sammie Quon authored
This does not add a usage, but we will add two shortly (by two separate engineers) which is why this is done first. Test: manually replaced a current icon Bug: 1105227 Change-Id: I453d219d57fd54f5e8a43e518a0ca648e82c6125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337494Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#794766}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a3e03e1086d5..be7c55a2a8ce 2020-08-04 swiftshader.regress@gmail.com Regres: Update test lists @ 74cc8ea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia1fc7ee4c661cbf812ca10f483c5eaeff380a7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337373Reviewed-by:
-
